quality 17.2.0 → 18.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 912b09b15ecd97352a9f9661be47a75b7e779f8d
-  data.tar.gz: 3e3ac5f309c4b33dde65f8b5bf1d3840a256bdfe
+  metadata.gz: 13356954d2864a210c04f07acebd158ca6898072
+  data.tar.gz: 6e08804b23726babd514f31ee29b9db4bdcd4327
 SHA512:
-  metadata.gz: 44aa11ce25807e7fd53939e8708b1d220a10ddcf7b4d0c9f6f5d114fe25106efaf357b279933a14028e53ce1d974fc7155f439f886728e88ca58692b71cee0a9
-  data.tar.gz: 0aec4b8d60baa7015562bddd8d994d38fdc434708fda00f4c601fa557882f64ac8c58c56b097926c8c359a95c7e4acc825bdb21aaae458a3e7731ce2c7e8349d
+  metadata.gz: f66de80a8ded9313495c449909c2839277a1931547c75dc14db3e51629e193e036719c7fef0070a453f3ffedf7b14cb27d62b5ebb40fd70adfa352591c806941
+  data.tar.gz: 46956de8a0f4880b344d905d23c2b9e05f50ebc31e8e12a0cb060a116631b3ac5b0749e6056b6bdf617b833112acd4ee1942ade161c94a47ff00710ea2917147

data/lib/quality/config.rb

@@ -14,34 +14,49 @@ module Quality
 
     def_delegators(:source_file_globber,
                    :ruby_dirs_arr=, :ruby_dirs_arr,
-                   :source_dirs_arr=, :source_dirs_arr,
-                   :extra_source_files_arr=, :extra_source_files_arr,
-                   :exclude_files_arr=, :exclude_files_arr,
                    :extra_ruby_files_arr=, :extra_ruby_files_arr,
                    :ruby_file_extensions_arr=, :ruby_file_extensions_arr,
                    :ruby_file_extensions_glob=, :ruby_file_extensions_glob,
+                   :ruby_files_glob, :ruby_files_arr)
+
+    def_delegators(:source_file_globber,
+                   :js_dirs_arr=, :js_dirs_arr,
+                   :extra_js_files_arr=, :extra_js_files_arr,
+                   :js_file_extensions_arr=, :js_file_extensions_arr,
+                   :js_file_extensions_glob=, :js_file_extensions_glob,
+                   :js_files_glob, :js_files_arr)
+
+    def_delegators(:source_file_globber,
+                   :python_files_glob, :python_files_arr)
+
+    def_delegators(:source_file_globber,
+                   :source_dirs_arr=, :source_dirs_arr,
+                   :extra_source_files_arr=, :extra_source_files_arr,
+                   :exclude_files_arr=, :exclude_files_arr,
                    :source_file_extensions_arr=, :source_file_extensions_arr,
                    :source_file_extensions_glob=, :source_file_extensions_glob,
                    :source_and_doc_files_glob,
                    :source_files_glob,
                    :source_files_exclude_glob,
-                   :source_files_exclude_glob=,
-                   :ruby_files_glob,
-                   :ruby_files_arr)
+                   :source_files_exclude_glob=)
 
-    alias_method(:extra_files, :extra_source_files_arr)
-    alias_method(:extra_files=, :extra_source_files_arr=)
     alias_method(:extra_ruby_files, :extra_ruby_files_arr)
     alias_method(:extra_ruby_files=, :extra_ruby_files_arr=)
     alias_method(:ruby_files, :ruby_files_arr)
+    alias_method(:python_files, :python_files_arr)
     alias_method(:ruby_dirs, :ruby_dirs_arr)
     alias_method(:ruby_dirs=, :ruby_dirs_arr=)
+    alias_method(:ruby_file_extensions, :ruby_file_extensions_glob)
+    alias_method(:ruby_file_extensions=, :ruby_file_extensions_glob=)
+
+    alias_method(:extra_files, :extra_source_files_arr)
+    alias_method(:extra_files=, :extra_source_files_arr=)
+    alias_method(:extra_source_files, :extra_source_files_arr)
+    alias_method(:extra_source_files=, :extra_source_files_arr=)
     alias_method(:source_dirs, :source_dirs_arr)
     alias_method(:source_dirs=, :source_dirs_arr=)
     alias_method(:exclude_files, :exclude_files_arr)
     alias_method(:exclude_files=, :exclude_files_arr=)
-    alias_method(:ruby_file_extensions, :ruby_file_extensions_glob)
-    alias_method(:ruby_file_extensions=, :ruby_file_extensions_glob=)
 
     # This was named and documented poorly early on
     alias_method(:source_file_extensions, :source_file_extensions_glob)

data/lib/quality/rake/task.rb

@@ -16,6 +16,7 @@ end
 require 'rake'
 require 'rake/tasklib'
 require 'rbconfig'
+require_relative '../which'
 require_relative '../runner'
 require_relative '../quality_checker'
 require_relative '../config'
@@ -47,7 +48,8 @@ module Quality
                      globber: Dir,
                      gem_spec: Gem::Specification,
                      quality_checker_class:
-                       Quality::QualityChecker)
+                       Quality::QualityChecker,
+                     which: Which.new)
         @dsl = dsl
         @cmd_runner = cmd_runner
         @globber = globber
@@ -59,7 +61,8 @@ module Quality
                                         quality_checker_class,
                                       count_io: count_io,
                                       count_file: count_file,
-                                      globber: globber)
+                                      globber: globber,
+                                      which: which)
         define
       end
 

data/lib/quality/runner.rb

@@ -1,14 +1,17 @@
 require 'active_support/inflector'
 require 'forwardable'
+require_relative 'which'
 require_relative 'tools/cane'
 require_relative 'tools/flay'
 require_relative 'tools/flog'
 require_relative 'tools/reek'
 require_relative 'tools/rubocop'
 require_relative 'tools/bigfiles'
+require_relative 'tools/pep8'
 require_relative 'tools/punchlist'
 require_relative 'tools/brakeman'
 require_relative 'tools/rails_best_practices'
+require_relative 'tools/eslint'
 
 module Quality
   # Knows how to run different quality tools based on a configuration
@@ -20,9 +23,11 @@ module Quality
     include Tools::Reek
     include Tools::Rubocop
     include Tools::Bigfiles
+    include Tools::Pep8
     include Tools::Punchlist
     include Tools::Brakeman
     include Tools::RailsBestPractices
+    include Tools::Eslint
 
     extend ::Forwardable
 
@@ -31,13 +36,15 @@ module Quality
                    quality_checker_class: Quality::QualityChecker,
                    count_io: IO,
                    count_file: File,
-                   globber: Dir)
+                   globber: Dir,
+                   which: Which.new)
       @config = config
       @gem_spec = gem_spec
       @quality_checker_class = quality_checker_class
       @count_io = count_io
       @count_file = count_file
       @globber = globber
+      @which = which
     end
 
     def run_quality
@@ -45,8 +52,9 @@ module Quality
     end
 
     def run_quality_with_tool(tool)
-      installed = @gem_spec.find_all_by_name(tool).any?
       suppressed = @config.skip_tools.include? tool
+      installed = @gem_spec.find_all_by_name(tool).any? ||
+                  !@which.which(tool).nil?
 
       if installed && !suppressed
         method("quality_#{tool}".to_sym).call
@@ -97,8 +105,9 @@ module Quality
     end
 
     def_delegators :@config, :ruby_files, :ruby_files_glob,
+                   :python_files, :python_files_glob,
                    :source_files_glob, :punchlist_regexp,
                    :source_files_exclude_glob, :exclude_files,
-                   :source_and_doc_files_glob
+                   :source_and_doc_files_glob, :js_files_arr
   end
 end

data/lib/quality/tools/eslint.rb

@@ -0,0 +1,24 @@
+module Quality
+  module Tools
+    # Adds 'bigfiles' tool support to quality gem
+    module Eslint
+      private
+
+      def eslint_args
+        '-f unix ' + js_files_arr.join(' ')
+      end
+
+      def quality_eslint
+        ratchet_quality_cmd('eslint',
+                            args: eslint_args,
+                            gives_error_code_on_violations: true) do |line|
+          if line =~ /^.*:\d+:\d+: /
+            1
+          else
+            0
+          end
+        end
+      end
+    end
+  end
+end

data/lib/quality/tools/pep8.rb

@@ -0,0 +1,19 @@
+module Quality
+  module Tools
+    # Adds 'pep8' tool support to quality gem
+    module Pep8
+      private
+
+      def pep8_args
+        python_files.join(' ')
+      end
+
+      def quality_pep8
+        ratchet_quality_cmd('pep8',
+                            args: pep8_args) do |line|
+          line.split(':')[0].to_i
+        end
+      end
+    end
+  end
+end

data/lib/quality/version.rb

@@ -2,5 +2,5 @@
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '17.2.0'
+  VERSION = '18.0.0'
 end

data/lib/quality/which.rb

@@ -0,0 +1,14 @@
+class Which
+  # http://stackoverflow.com/questions/2108727/
+  #   which-in-ruby-checking-if-program-exists-in-path-from-ruby
+  def which(cmd)
+    exts = ENV['PATHEXT'] ? ENV['PATHEXT'].split(';') : ['']
+    ENV['PATH'].split(File::PATH_SEPARATOR).each do |path|
+      exts.each { |ext|
+        exe = File.join(path, "#{cmd}#{ext}")
+        return exe if File.executable?(exe) && !File.directory?(exe)
+      }
+    end
+    return nil
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 17.2.0
+  version: 18.0.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-29 00:00:00.000000000 Z
+date: 2015-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -309,13 +309,16 @@ files:
 - lib/quality/tools/bigfiles.rb
 - lib/quality/tools/brakeman.rb
 - lib/quality/tools/cane.rb
+- lib/quality/tools/eslint.rb
 - lib/quality/tools/flay.rb
 - lib/quality/tools/flog.rb
+- lib/quality/tools/pep8.rb
 - lib/quality/tools/punchlist.rb
 - lib/quality/tools/rails_best_practices.rb
 - lib/quality/tools/reek.rb
 - lib/quality/tools/rubocop.rb
 - lib/quality/version.rb
+- lib/quality/which.rb
 - quality.gemspec
 homepage: http://github.com/apiology/quality
 licenses: