quality 14.1.0 → 15.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ff756ce9314546a2c59c80a36050ce9c66b4e6fc
-  data.tar.gz: bd98a9ea95e2e15e5e9ada6f7f88d3f33e7bb7ea
+  metadata.gz: 995802b4ed3cd4dc1a74e479ceaef9ae9268bced
+  data.tar.gz: 122f1155c0b703f40d1edd9be73494d79c142778
 SHA512:
-  metadata.gz: fbcd9d84b68a47dabffa94adf2f2f1ef9e303d2e0c9b4f7c50d6d95881dac53b11fb8c86d1dd09a397b6fc655d4e560d99470c1f936324f23aeaab76a5a3b8eb
-  data.tar.gz: ac1efb5bb1eca658ee7c6f648a977d2a822b37a13de59ae88d2e39598be1a1490596d495b917e0ceda436d030bd5069bd365d26552fa9a252fe416198cbd8c3b
+  metadata.gz: d29111841b9960995b55f0c9778afc1bfb4351377bd5e2224631d2d75a8913b7a866a617383b84f762b432dbc73d8e71da69177fefc5deafa82d10d546f72e1f
+  data.tar.gz: bfdb7160449283acd80159a8177a848324bae0e42445f3f821c976da534d1a5a48bda5fdc665b1f029602df0c31eecc64bcebf4cbafaa8ce22cc3be122e61146

data/lib/quality/quality_checker.rb

@@ -55,7 +55,6 @@ module Quality
     def check_exit_status(exit_status)
       return if @command_options[:gives_error_code_on_violations] ||
                 @command_options[:gives_error_code_on_no_relevant_code]
-
       fail("Error detected running #{full_cmd}.  " \
            "Exit status is #{exit_status}") if exit_status != 0
     end
@@ -89,9 +88,7 @@ module Quality
     private
 
     def full_cmd
-      args = @command_options[:args]
-      args ||= ''
-
+      args = @command_options[:args] || ''
       @found_output = false
       RubySpawn.new(@cmd, args).invocation
     end

data/lib/quality/runner.rb

@@ -1,3 +1,4 @@
+require 'active_support/inflector'
 require 'forwardable'
 require_relative 'tools/cane'
 require_relative 'tools/flay'
@@ -7,6 +8,7 @@ require_relative 'tools/rubocop'
 require_relative 'tools/bigfiles'
 require_relative 'tools/punchlist'
 require_relative 'tools/brakeman'
+require_relative 'tools/rails_best_practices'
 
 module Quality
   # Knows how to run different quality tools based on a configuration
@@ -17,9 +19,10 @@ module Quality
     include Tools::Flog
     include Tools::Reek
     include Tools::Rubocop
-    include Tools::BigFiles
+    include Tools::Bigfiles
     include Tools::Punchlist
     include Tools::Brakeman
+    include Tools::RailsBestPractices
 
     extend ::Forwardable
 
@@ -53,9 +56,7 @@ module Quality
     end
 
     def run_ratchet
-      @config.all_output_files.each do |filename|
-        run_ratchet_on_file(filename)
-      end
+      @config.all_output_files.each { |filename| run_ratchet_on_file(filename) }
     end
 
     def run_ratchet_on_file(filename)
@@ -81,7 +82,7 @@ module Quality
       self.class.ancestors.map do |ancestor|
         ancestor_name = ancestor.to_s
         next unless ancestor_name.start_with?('Quality::Tools::')
-        ancestor_name.split('::').last.downcase
+        ancestor_name.split('::').last.underscore
       end.compact
     end
 

data/lib/quality/tools/bigfiles.rb

@@ -1,7 +1,7 @@
 module Quality
   module Tools
     # Adds 'bigfiles' tool support to quality gem
-    module BigFiles
+    module Bigfiles
       private
 
       def bigfiles_args

data/lib/quality/tools/rails_best_practices.rb

@@ -0,0 +1,30 @@
+module Quality
+  module Tools
+    # Adds 'rubocop' tool support to quality gem
+    module RailsBestPractices
+      private
+
+      def quality_rails_best_practices
+        ratchet_quality_cmd('rails_best_practices',
+                            gives_error_code_on_violations: true) do |line|
+          self.class.count_rails_best_practices_violations(line)
+        end
+      end
+
+      def self.included(base)
+        base.extend ClassMethods
+      end
+
+      # See Rubocop.included
+      module ClassMethods
+        def count_rails_best_practices_violations(line)
+          if line =~ /.*:[0-9]* - /
+            1
+          else
+            0
+          end
+        end
+      end
+    end
+  end
+end

data/lib/quality/version.rb

@@ -2,5 +2,5 @@
 # reek, flog, flay and rubocop and makes sure your numbers don't get
 # any worse over time.
 module Quality
-  VERSION = '14.1.0'
+  VERSION = '15.0.0'
 end

data/quality.gemspec

@@ -30,6 +30,7 @@ Gem::Specification.new do |s|
   s.rubygems_version = '1.3.6'
   s.summary = 'Code quality tools for Ruby'
 
+  s.add_runtime_dependency('activesupport')
   s.add_runtime_dependency('source_finder')
   s.add_runtime_dependency('cane', ['>= 2.6'])
   s.add_runtime_dependency('reek', ['>= 1.3.4'])
@@ -40,6 +41,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency('bigfiles', ['>= 0.1'])
   s.add_runtime_dependency('punchlist', ['>= 1.1'])
   s.add_runtime_dependency('brakeman')
+  s.add_runtime_dependency('rails_best_practices')
 
   # need above 3.2.2 to support Ruby 2.0 syntax
   #

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: quality
 version: !ruby/object:Gem::Version
-  version: 14.1.0
+  version: 15.0.0
 platform: ruby
 authors:
 - Vince Broz
@@ -10,6 +10,20 @@ bindir: bin
 cert_chain: []
 date: 2015-09-12 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: source_finder
   requirement: !ruby/object:Gem::Requirement
@@ -142,6 +156,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails_best_practices
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: ruby_parser
   requirement: !ruby/object:Gem::Requirement
@@ -271,6 +299,7 @@ files:
 - lib/quality/tools/flay.rb
 - lib/quality/tools/flog.rb
 - lib/quality/tools/punchlist.rb
+- lib/quality/tools/rails_best_practices.rb
 - lib/quality/tools/reek.rb
 - lib/quality/tools/rubocop.rb
 - lib/quality/version.rb