quack 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1830bde6d8a56a3e4c301d835fd92e1256d5eb17
-  data.tar.gz: 38b60b97814429883b911d500c8ece47ff3f0876
+  metadata.gz: 7a304d056868937d1ee1826e161f6c98f0a3689b
+  data.tar.gz: 4b3d887a9fd30f017e476d3255d304bc68b65787
 SHA512:
-  metadata.gz: a0fcc64f9e0d8bc09b9e9a34e35e09619b22f96b98678fd3b1a1faa2c031585c290c87b02969235db2506c90f5b55e8c32c7077912b9dd41068639c9d29dc9f6
-  data.tar.gz: 2964091d32eb62b21096c2b8a9791e7b4144bd6232187483b3fcbf91fae44950aeef2dedc7c5348b887068036068c8d9c6a42c0298c36d7804452693b072ec2f
+  metadata.gz: 985c6eb97f59ade57f907f62bb34db075496e4d9ada71d228727a7d5b90c77b7379da7a837e961466689fa6bd457fed7d3a2916d7fbbf647630ba0dd77f9e3a2
+  data.tar.gz: 46c3e096e6196e130b8d2287ca5fa9efee3f1bec692a86619de0657fdd2e5acb2ea94e315479ce402b5a1c7f7a0fe488a72e3dd9624c6b9fdaaf2919a7b8af69

data/CHANGELOG.md

@@ -1,8 +1,11 @@
 # CHANGELOG
 
+## 1.1.0
+
+- Support for negative values (#3)
+
 ## 0.0.4
 
 Breaking change:  Times are now only coereced if there is no surrounding text.  
 
 I.e. "It was 04-05-2016" is now considered a String rather than a Time
-

data/lib/quack/types/float.rb

@@ -3,7 +3,7 @@ require "quack/type"
 module Quack
   module Types
     class Float < Quack::Type
-      PATTERN = /\A\d+\.\d*\z/
+      PATTERN = /\A-?\d+\.\d*\z/
 
       class << self
         def built_in_types
@@ -20,4 +20,4 @@ module Quack
       end
     end
   end
-end
+end

data/lib/quack/types/integer.rb

@@ -3,7 +3,7 @@ require "quack/type"
 module Quack
   module Types
     class Integer < Quack::Type
-      PATTERN = /\A\d+\z/
+      PATTERN = /\A-?\d+\z/
 
       class << self
         def built_in_types
@@ -21,4 +21,4 @@ module Quack
       end
     end
   end
-end
+end

data/lib/quack/version.rb

@@ -1,3 +1,3 @@
 module Quack
-  VERSION = "1.0.0"
+  VERSION = '1.1.0'.freeze
 end

data/spec/quack/guesser_spec.rb

@@ -2,8 +2,8 @@ require "test_helper"
 
 describe Quack::Guesser do
   describe "given a string integer" do
-    let(:value) { "123" }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { "123" }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have Integer type" do
       subject.guess.class.must_equal(Quack::Types::Integer)
@@ -11,8 +11,8 @@ describe Quack::Guesser do
   end
 
   describe "given a Fixnum integer" do
-    let(:value) { 123 }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { 123 }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have Integer type" do
       subject.guess.class.must_equal(Quack::Types::Integer)
@@ -20,8 +20,8 @@ describe Quack::Guesser do
   end
 
   describe "given a string float" do
-    let(:value) { "123.4" }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { "123.4" }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have Float type" do
       subject.guess.class.must_equal(Quack::Types::Float)
@@ -29,8 +29,8 @@ describe Quack::Guesser do
   end
 
   describe "given a Float" do
-    let(:value) { 123.4 }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { 123.4 }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have Float type" do
       subject.guess.class.must_equal(Quack::Types::Float)
@@ -38,8 +38,8 @@ describe Quack::Guesser do
   end
 
   describe "given a 'true' string" do
-    let(:value) { "true" }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { "true" }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have Boolean type" do
       subject.guess.class.must_equal(Quack::Types::Boolean)
@@ -47,8 +47,8 @@ describe Quack::Guesser do
   end
 
   describe "given a 'false' string" do
-    let(:value) { "false" }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { "false" }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have Boolean type" do
       subject.guess.class.must_equal(Quack::Types::Boolean)
@@ -56,8 +56,8 @@ describe Quack::Guesser do
   end
 
   describe "given true" do
-    let(:value) { true }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { true }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have Boolean type" do
       subject.guess.class.must_equal(Quack::Types::Boolean)
@@ -65,8 +65,8 @@ describe Quack::Guesser do
   end
 
   describe "given false" do
-    let(:value) { false }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { false }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have Boolean type" do
       subject.guess.class.must_equal(Quack::Types::Boolean)
@@ -74,8 +74,8 @@ describe Quack::Guesser do
   end
 
   describe "given an ISO 8061 UTC date" do
-    let(:value) { "2014-03-22T03:00:00Z" }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { "2014-03-22T03:00:00Z" }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have Time type" do
       subject.guess.class.must_equal(Quack::Types::Time)
@@ -83,8 +83,8 @@ describe Quack::Guesser do
   end
 
   describe "given a padded ISO 8061 UTC date" do
-    let(:value) { "     2014-03-22T03:00:00Z " }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { "     2014-03-22T03:00:00Z " }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have Time type" do
       subject.guess.class.must_equal(Quack::Types::Time)
@@ -92,8 +92,8 @@ describe Quack::Guesser do
   end
 
   describe "given an embedded ISO 8061 UTC date" do
-    let(:value) { "something awesome will happen 2014-03-22T03:00:00Z or thereabouts" }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { "something awesome will happen 2014-03-22T03:00:00Z or thereabouts" }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have String type" do
       subject.guess.class.must_equal(Quack::Types::String)
@@ -101,8 +101,8 @@ describe Quack::Guesser do
   end
 
   describe "given an embedded simple date" do
-    let(:value) { "something awesome will happen 2014-03-22 or thereabouts" }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { "something awesome will happen 2014-03-22 or thereabouts" }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have String type" do
       subject.guess.class.must_equal(Quack::Types::String)
@@ -110,8 +110,8 @@ describe Quack::Guesser do
   end
 
   describe "given an ISO 8061 non-UTC date" do
-    let(:value) { "2014-03-22T03:00:00-07:00" }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { "2014-03-22T03:00:00-07:00" }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have Time type" do
       subject.guess.class.must_equal(Quack::Types::Time)
@@ -119,11 +119,11 @@ describe Quack::Guesser do
   end
 
   describe "given an random string" do
-    let(:value) { "foo123" }
-    let(:subject) { Quack::Guesser.new(value) }
+    let(:raw_value) { "foo123" }
+    let(:subject) { Quack::Guesser.new(raw_value) }
 
     it "should have String type" do
       subject.guess.class.must_equal(Quack::Types::String)
     end
   end
-end
+end

data/spec/quack/types/float_spec.rb

@@ -10,6 +10,14 @@ describe Quack::Types::Float do
       Quack::Types::Float.matches?(123.4).must_equal(true)
     end
 
+    it "should be true for negative float strings" do
+      Quack::Types::Float.matches?("-123.4").must_equal(true)
+    end
+
+    it "should be true for negative floats" do
+      Quack::Types::Float.matches?(-123.4).must_equal(true)
+    end
+
     it "should be false for integer strings" do
       Quack::Types::Float.matches?("123").must_equal(false)
     end
@@ -17,6 +25,14 @@ describe Quack::Types::Float do
     it "should be false for integers" do
       Quack::Types::Float.matches?(123).must_equal(false)
     end
+
+    it "should be false for negative integer strings" do
+      Quack::Types::Float.matches?("-123").must_equal(false)
+    end
+
+    it "should be false for negative integers" do
+      Quack::Types::Float.matches?(-123).must_equal(false)
+    end
   end
 
   describe "#to_coerced" do
@@ -31,4 +47,4 @@ describe Quack::Types::Float do
       type.to_coerced.class.must_equal(Float)
     end
   end
-end
+end

data/spec/quack/types/integer_spec.rb

@@ -10,6 +10,14 @@ describe Quack::Types::Integer do
       Quack::Types::Integer.matches?(123).must_equal(true)
     end
 
+    it "should be true for negative integer stings" do
+      Quack::Types::Integer.matches?("-123").must_equal(true)
+    end
+
+    it "should be true for negative Integers" do
+      Quack::Types::Integer.matches?(-123).must_equal(true)
+    end
+
     it "should be true for large Integer" do
       num = 232305722798259244150093798251441
       Quack::Types::Integer.matches?(num).must_equal(true)
@@ -22,6 +30,14 @@ describe Quack::Types::Integer do
     it "should be false for floats" do
       Quack::Types::Integer.matches?(123.4).must_equal(false)
     end
+
+    it "should be false for negative float strings" do
+      Quack::Types::Integer.matches?("-123.4").must_equal(false)
+    end
+
+    it "should be false for negative floats" do
+      Quack::Types::Integer.matches?(-123.4).must_equal(false)
+    end
   end
 
   describe "#to_coerced" do
@@ -42,4 +58,4 @@ describe Quack::Types::Integer do
       type.to_coerced.class.must_equal(1.class)
     end
   end
-end
+end

data/spec/quack/types/null_spec.rb

@@ -14,7 +14,7 @@ describe Quack::Types::Null do
   describe "#to_coerced" do
     it "should return nil" do
       type = Quack::Types::Null.new(nil)
-      type.to_coerced.must_equal(nil)
+      type.to_coerced.must_be_nil
     end
   end
-end
+end

data/spec/quack/types/time_spec.rb

@@ -46,6 +46,11 @@ describe Quack::Types::Time do
       type.to_coerced.must_equal(expected)
     end
 
+    it "should raise a ParseError for dates out of range" do
+      type = Quack::Types::Time.new("0000-00-00")
+      proc { type.to_coerced }.must_raise(Quack::ParseError)
+    end
+
     it "should raise a ParseError for invalid dates" do
       type = Quack::Types::Time.new("foo")
       proc { type.to_coerced }.must_raise(Quack::ParseError)
@@ -65,4 +70,4 @@ describe Quack::Types::Time do
       type.to_s.must_equal("2014-03-22T03:10:12-07:00")
     end
   end
-end
+end

data/spec/quack_spec.rb

@@ -1,10 +1,10 @@
 require "test_helper"
 
 describe Quack do
-  let(:value) { "123" }
+  let(:raw_value) { "123" }
   it "should proxy to the guesser" do
-    type = Quack(value)
+    type = Quack(raw_value)
     type.class.must_equal(Quack::Types::Integer)
     type.to_coerced.must_equal(123)
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: quack
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Derrick Reimer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-20 00:00:00.000000000 Z
+date: 2017-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler