qti 2.22.6 → 2.23.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a72b532cd51607d749d519695eedd195baa829425689fb89651a240fe2ce6f74
-  data.tar.gz: f4ca8d029a779c5f5b4b80c782238271647cee5d7cb15a4c221ffe5f5d53b1f7
+  metadata.gz: bd8303859118b11ead1859869efcadb1345b74da5c0d03099d961ed8ed33439d
+  data.tar.gz: 5f7e10b30898792b696d61cb14bc9a117c027462df0da9b5c35a347f98df62b6
 SHA512:
-  metadata.gz: 97053ee0f769f90b7148271a7ecf0fe309adb72e48adb6feea2c823225c0a7c27a9bc4adae09b7f2fd812b063a7197a77fe316598e5539aff74c7d66471d207e
-  data.tar.gz: 3ca0b4a412a6573fc530693e301bafca22e636742d069713b0be51e3ff923d302bfaee84792bbc72812553b8fb59eefe7e1eaaea67803634445ced172157d04f
+  metadata.gz: faf84243d53822d2bb64712f5ea2215377199e956bec31e11d55a6d361b8f4c5509a2c7516c04b33141509877b2ad7f2c17b116b8bfbb9377f896212190ff298
+  data.tar.gz: 854b534ca6c5b4d30f6bca3287144fdfc884e7a977ea2d875d226da0ddeb41d0da5b5294c0371444da630f049209259ff222cf986b998b45cebec5279938edf3

data/lib/qti/v1/models/assessment.rb

@@ -14,6 +14,10 @@ module Qti
           @title ||= xpath_with_single_check('.//xmlns:assessment/@title')&.content || File.basename(@path, '.xml')
         end
 
+        def external_assignment_id
+          @external_assignment_id ||= xpath_with_single_check('.//xmlns:assessment/@external_assignment_id')&.content
+        end
+
         def assessment_items
           @doc.xpath("//*[self::#{GROUP_ID} or self::xmlns:item[not(ancestor::#{GROUP_ID})]" \
             ' or self::xmlns:bankentry_item]')

data/lib/qti/v1/models/interactions/choice_interaction.rb

@@ -83,7 +83,7 @@ module Qti
           # rubocop:enable Metrics/AbcSize
           def setvar_nodes(choice_nodes)
             choice_nodes.select do |choice_node|
-              choice_node.at_xpath('.//xmlns:setvar')&.content&.to_f&.positive?
+              choice_node.at_xpath('.//xmlns:setvar')&.content&.present?
             end
           end
         end

data/lib/qti/v1/models/object_bank.rb

@@ -13,6 +13,10 @@ module Qti
           @identifier ||= xpath_with_single_check('.//xmlns:objectbank/@ident')&.content
         end
 
+        def canvas_item_bank
+          @canvas_item_bank ||= xpath_with_single_check('.//xmlns:objectbank/@canvas_item_bank')&.content
+        end
+
         # tells us whether the bank was an account or course bank
         def bank_type
           @bank_type ||= xpath_with_single_check(

data/lib/qti/v2/models/assessment_test.rb

@@ -13,6 +13,10 @@ module Qti
           @title ||= xpath_with_single_check('//xmlns:assessmentTest/@title')&.content || File.basename(@path, '.xml')
         end
 
+        def external_assignment_id
+          nil
+        end
+
         def assessment_items
           # Return the xml files we should be parsing
           @assessment_items ||= begin

data/lib/qti/version.rb

@@ -1,3 +1,3 @@
 module Qti
-  VERSION = '2.22.6'.freeze
+  VERSION = '2.23.1'.freeze
 end

data/spec/fixtures/items_1.2/choice_vary_points_by_answer_zero_points.xml

@@ -0,0 +1,69 @@
+<?xml version="1.0"encoding="UTF-8"?>
+<questestinterop xmlns="http://www.imsglobal.org/xsd/ims_qtiasiv1p2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.imsglobal.org/xsd/ims_qtiasiv1p2 http://www.imsglobal.org/xsd/ims_qtiasiv1p2p1.xsd">
+  <assessment title="1.2 Import Quiz" ident="A1001">
+    <section title="Main" ident="S1002">
+      <item ident="d74b47a4abeeed159e030bfecbcecea2" title="My question title">
+        <itemmetadata>
+          <qtimetadata>
+            <qtimetadatafield>
+              <fieldlabel>question_type</fieldlabel>
+              <fieldentry>multiple_choice_question</fieldentry>
+            </qtimetadatafield>
+            <qtimetadatafield>
+              <fieldlabel>points_possible</fieldlabel>
+              <fieldentry>10.0</fieldentry>
+            </qtimetadatafield>
+            <qtimetadatafield>
+              <fieldlabel>original_answer_ids</fieldlabel>
+              <fieldentry>93bbcb84-3281-4d99-b243-79ba4051e654,3cd6d311-07cd-4ec0-b2db-3048e6cf1128</fieldentry>
+            </qtimetadatafield>
+            <qtimetadatafield>
+              <fieldlabel>assessment_question_identifierref</fieldlabel>
+              <fieldentry>9f47365e112840d80a79a960b1b0b6a7</fieldentry>
+            </qtimetadatafield>
+            <qtimetadatafield>
+              <fieldlabel>calculator_type</fieldlabel>
+              <fieldentry>none</fieldentry>
+            </qtimetadatafield>
+          </qtimetadata>
+        </itemmetadata>
+        <presentation>
+          <material>
+            <mattext texttype="text/html">&lt;p&gt;the correct answer is letter A&lt;/p&gt;</mattext>
+          </material>
+          <response_lid ident="response1" rcardinality="Single">
+            <render_choice>
+              <response_label ident="93bbcb84-3281-4d99-b243-79ba4051e654">
+                <material>
+                  <mattext texttype="text/html">A</mattext>
+                </material>
+              </response_label>
+              <response_label ident="3cd6d311-07cd-4ec0-b2db-3048e6cf1128">
+                <material>
+                  <mattext texttype="text/html">B</mattext>
+                </material>
+              </response_label>
+            </render_choice>
+          </response_lid>
+        </presentation>
+        <resprocessing>
+          <outcomes>
+            <decvar maxvalue="100" minvalue="0" varname="SCORE" vartype="Decimal"/>
+          </outcomes>
+          <respcondition>
+            <conditionvar>
+              <varequal respident="response1">93bbcb84-3281-4d99-b243-79ba4051e654</varequal>
+            </conditionvar>
+            <setvar action="Set" varname="SCORE">0.0</setvar>
+          </respcondition>
+          <respcondition correctanswer="Yes">
+            <conditionvar>
+              <varequal respident="response1">3cd6d311-07cd-4ec0-b2db-3048e6cf1128</varequal>
+            </conditionvar>
+            <setvar action="Set" varname="SCORE">0.0</setvar>
+          </respcondition>
+        </resprocessing>
+      </item>
+    </section>
+  </assessment>
+</questestinterop>

data/spec/fixtures/test_qti_1.2/quiz.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="ISO-8859-1"?>
 <questestinterop xmlns="http://www.imsglobal.org/xsd/ims_qtiasiv1p2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.imsglobal.org/xsd/ims_qtiasiv1p2 http://www.imsglobal.org/xsd/ims_qtiasiv1p2p1.xsd">
-  <assessment title="1.2 Import Quiz" ident="A1001">
+  <assessment title="1.2 Import Quiz" ident="A1001" external_assignment_id="801785">
     <section title="Main" ident="S1002">
       <item title="Grading - specific - 3 pt score" ident="QUE_1003">
         <presentation>

data/spec/lib/qti/v1/models/assessment_item_spec.rb

@@ -138,7 +138,7 @@ describe Qti::V1::Models::AssessmentItem do
     describe '#scoring_data_structs' do
       it 'grabs the rcardinality and scoring data value' do
         struct = loaded_class.send(:scoring_data_structs)
-        expect(struct.first.values).to eq 'QUE_1006_A2'
+        expect(struct.first.values).to eq 'QUE_1005_A1'
         expect(struct.first.rcardinality).to eq 'Single'
       end
     end
@@ -266,4 +266,26 @@ describe Qti::V1::Models::AssessmentItem do
       end
     end
   end
+
+  context 'multiple choice with "vary points by answer" and answers with zero points' do
+    let(:file_path) { File.join('spec', 'fixtures', 'items_1.2', 'choice_vary_points_by_answer_zero_points.xml') }
+    let(:test_object) { Qti::V1::Models::Assessment.from_path!(file_path) }
+    let(:assessment_item_refs) { test_object.assessment_items }
+    let(:loaded_class) { described_class.new(assessment_item_refs.first) }
+
+    describe '#scoring_data_structs' do
+      it 'collects all the correct answers' do
+        struct = loaded_class.scoring_data_structs
+        expect(struct.size).to eq 2
+        expect(struct.map(&:values)).to eq %w[93bbcb84-3281-4d99-b243-79ba4051e654 3cd6d311-07cd-4ec0-b2db-3048e6cf1128]
+      end
+
+      it 'collect all the points answer points' do
+        struct = loaded_class.scoring_data_structs
+        expect(struct.size).to eq 2
+        expect(struct.map(&:scoring_options)).to eq([{ 'points' => 0.0 },
+                                                     { 'points' => 0.0, 'correct_answer' => true }])
+      end
+    end
+  end
 end

data/spec/lib/qti/v1/models/assessment_spec.rb

@@ -25,6 +25,12 @@ describe Qti::V1::Models::Assessment do
           expect(loaded_class.identifier).to eq(expected_identifier)
         end
       end
+
+      describe '#external_assignment_id' do
+        it 'retruns the external_assignment_id' do
+          expect(loaded_class.external_assignment_id).to eq(expected_external_assignment_id)
+        end
+      end
     end
 
     shared_examples_for 'verify quiz items' do
@@ -43,6 +49,7 @@ describe Qti::V1::Models::Assessment do
       let(:loaded_class) { described_class.from_path!(path) }
       let(:expected_title) { '1.2 Import Quiz' }
       let(:expected_identifier) { 'A1001' }
+      let(:expected_external_assignment_id) { '801785' }
       let(:expected_item_count) { 5 }
 
       include_examples('basic quiz fields')
@@ -52,6 +59,7 @@ describe Qti::V1::Models::Assessment do
       let(:path) { File.join(fixtures_path, 'feedback_quiz_1.2.xml') }
       let(:loaded_class) { described_class.from_path!(path) }
       let(:expected_title) { 'I Can Haz Feedback' }
+      let(:expected_external_assignment_id) { nil }
       let(:expected_identifier) { 'i618e88580f76f70a1ed28804f497df9c' }
       let(:expected_item_count) { 3 }
       let(:expected_item_data) do
@@ -82,6 +90,7 @@ describe Qti::V1::Models::Assessment do
       let(:path) { File.join(fixtures_path, 'all_canvas_simple_1.2.xml') }
       let(:loaded_class) { described_class.from_path!(path) }
       let(:expected_title) { 'Every Canvas Interaction' }
+      let(:expected_external_assignment_id) { nil }
       let(:expected_identifier) { 'ie09bc528e6ecd1cb9ebfafd940c20215' }
       let(:expected_item_count) { 10 }
       let(:expected_item_data) do

data/spec/lib/qti/v1/models/object_bank_spec.rb

@@ -3,7 +3,7 @@ describe Qti::V1::Models::ObjectBank do
     <<~XML
       <?xml version="1.0" encoding="UTF-8"?>
       <questestinterop xmlns="http://www.imsglobal.org/xsd/ims_qtiasiv1p2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.imsglobal.org/xsd/ims_qtiasiv1p2 http://www.imsglobal.org/xsd/ims_qtiasiv1p2p1.xsd">
-        <objectbank ident="gooblegobble12345">
+        <objectbank ident="gooblegobble12345" canvas_item_bank="true">
           <qtimetadata>
             <qtimetadatafield>
               <fieldlabel>not_a_bank_title</fieldlabel>
@@ -57,6 +57,14 @@ describe Qti::V1::Models::ObjectBank do
     end
   end
 
+  describe '#canvas_item_bank' do
+    it 'returns the canvas_item_bank' do
+      allow(File).to receive(:read).and_return(doc)
+      objectbank = described_class.new path: '/etc/FakeBank008.xml'
+      expect(objectbank.canvas_item_bank).to eq 'true'
+    end
+  end
+
   describe '#bank_type' do
     it 'has the bank_type attribute' do
       allow(File).to receive(:read).and_return(doc)

data/spec/lib/qti/v2/models/assessment_test_spec.rb

@@ -19,6 +19,10 @@ describe Qti::V2::Models::AssessmentTest do
       expect(loaded_class.identifier).to eq 'SPECTATUS-GENERATED-TEST'
     end
 
+    it 'has a nil external_assignment_id' do
+      expect(loaded_class.external_assignment_id).to be_nil
+    end
+
     it 'gets dependency file refs' do
       refs = loaded_class.assessment_items
       expect(refs.all? { |ref| File.extname(ref[:path]) == '.xml' })

data/spec/lib/qti_spec.rb

@@ -35,7 +35,7 @@ describe Qti::Importer do
         assessment_items = importer.assessment_item_refs.map { |item| importer.create_assessment_item(item) }
         expect(assessment_items.count).to eq 5
         answer_arity = assessment_items.map { |item| item.scoring_data_structs.count }
-        expect(answer_arity).to eq [1, 1, 4, 1, 1]
+        expect(answer_arity).to eq [2, 5, 7, 1, 1]
       end
 
       it 'sets the path and package root properly' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: qti
 version: !ruby/object:Gem::Version
-  version: 2.22.6
+  version: 2.23.1
 platform: ruby
 authors:
 - Adrian Diaz
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-01-18 00:00:00.000000000 Z
+date: 2024-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -403,6 +403,7 @@ files:
 - spec/fixtures/items_1.2/categorization.xml
 - spec/fixtures/items_1.2/choice.xml
 - spec/fixtures/items_1.2/choice_vary_points_by_answer.xml
+- spec/fixtures/items_1.2/choice_vary_points_by_answer_zero_points.xml
 - spec/fixtures/items_1.2/essay.xml
 - spec/fixtures/items_1.2/essay_custom_settings.xml
 - spec/fixtures/items_1.2/fib.xml
@@ -783,6 +784,7 @@ test_files:
 - spec/fixtures/items_1.2/categorization.xml
 - spec/fixtures/items_1.2/choice.xml
 - spec/fixtures/items_1.2/choice_vary_points_by_answer.xml
+- spec/fixtures/items_1.2/choice_vary_points_by_answer_zero_points.xml
 - spec/fixtures/items_1.2/essay.xml
 - spec/fixtures/items_1.2/essay_custom_settings.xml
 - spec/fixtures/items_1.2/fib.xml