qr4r 0.4.1 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: cff0eada33f50b75d934b1f9f45e0b3675c97530
-  data.tar.gz: ba17372851d5d9f26728d884baaea00f2d471f3b
+SHA256:
+  metadata.gz: f4c24865c756bda423d52946750d9b685b08594946b007df49dc691cdf7812b0
+  data.tar.gz: 9243051860e97857a2672803af5c4aff439dc2a62bf46899700f3e921018f1ba
 SHA512:
-  metadata.gz: 705375dedabcab27760ce69ecc0f992e668acb417d435ab3c06db189af7a8dbd9e5d6d427cdf8a863406def499e337117a36f419450d88fa9fdc58627fa0f250
-  data.tar.gz: 2cd32bbe096b894110d9d68ec1fed83ed5289f05a6ec284ed4b25dc4d1958a1130f232a9651aa2b369e4abbbec7373520717826cbe8609e4ccf236c85eade2b3
+  metadata.gz: f8934e5af05802cd3cde1de57633e3066ea3ba782f6f94ad7c081f9a20ed08516d62ef669bf70136887a7eca6bafbf4f7effd40173711d83337bb62cd77c510e
+  data.tar.gz: 6406b4d106db3f9c1d6c8a928a2aeedf8a424f9181fa72d24e612c8f42082c4e6cd43dff601dcfa790dcfe25986fc2e18eb402166017a2ce5cb83eb51a223344

data/.rubocop-common.yml

@@ -0,0 +1,102 @@
+AllCops:
+  NewCops: enable
+  DisplayCopNames: true
+  DisplayStyleGuide: true
+  Exclude:
+    - "bin/*"
+    - "db/schema.rb"
+    - "lib/templates/**/*"
+    - "**/node_modules/**/*"
+    - "tmp/**/*"
+    - "vendor/**/*"
+    - "log/**/*"
+
+Layout/CaseIndentation:
+  Enabled: false
+
+Layout/FirstArrayElementIndentation:
+  EnforcedStyle: consistent
+
+Layout/HashAlignment:
+  Enabled: false
+
+Layout/LineLength:
+  Max: 120
+
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+Lint/AmbiguousBlockAssociation:
+  Enabled: false
+
+Lint/ScriptPermission:
+  Exclude:
+    - "Rakefile"
+
+Metrics/AbcSize:
+  Max: 35
+  Exclude:
+    - "spec/**/*"
+
+Metrics/BlockLength:
+  CountComments: false
+  Max: 50
+  Exclude:
+    - "config/**/*"
+    - "spec/**/*"
+
+Metrics/ClassLength:
+  Max: 250
+  Exclude:
+    - "spec/**/*"
+
+Metrics/MethodLength:
+  Max: 25
+  Exclude:
+    - "db/migrate/*"
+    - "spec/**/*"
+
+Naming/PredicateName:
+  Enabled: false
+
+Security/YAMLLoad:
+  Enabled: false
+
+Style/BarePercentLiterals:
+  EnforcedStyle: percent_q
+
+Style/BlockDelimiters:
+  EnforcedStyle: braces_for_chaining
+
+Style/Documentation:
+  Enabled: false
+
+Style/EmptyMethod:
+  EnforcedStyle: expanded
+
+Style/FormatStringToken:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  EnforcedStyle: never
+
+Style/Lambda:
+  EnforcedStyle: literal
+
+Style/ModuleFunction:
+  EnforcedStyle: extend_self
+
+Style/MutableConstant:
+  Enabled: false
+
+Style/PreferredHashMethods:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/StringLiteralsInInterpolation:
+  EnforcedStyle: double_quotes
+
+Style/TernaryParentheses:
+  EnforcedStyle: require_parentheses_when_complex

data/.rubocop-performance.yml

@@ -0,0 +1,2 @@
+Performance/Casecmp:
+  Enabled: false

data/.rubocop.yml

@@ -0,0 +1,9 @@
+require:
+  - rubocop-performance
+
+inherit_from:
+  - ./.rubocop-common.yml      # copied from c5-conventions
+  - ./.rubocop-performance.yml # copied from c5-conventions
+
+AllCops:
+  TargetRubyVersion: 2.5

data/.ruby-version

@@ -0,0 +1 @@
+2.6.6

data/Gemfile

@@ -1,2 +1,2 @@
-source 'https://rubygems.org'
-gemspec 
+source "https://rubygems.org"
+gemspec

data/Gemfile.lock

@@ -1,22 +1,50 @@
 PATH
   remote: .
   specs:
-    qr4r (0.4.0)
-      mojo_magick
-      rqrcode
+    qr4r (0.6.0)
+      mojo_magick (~> 0.5)
+      rqrcode_core (~> 0.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    chunky_png (1.3.5)
-    mojo_magick (0.5.6)
-    rake (11.1.2)
-    rqrcode (0.10.1)
-      chunky_png (~> 1.0)
+    ast (2.4.1)
+    minitest (5.14.1)
+    mojo_magick (0.5.7)
+    parallel (1.19.2)
+    parser (2.7.2.0)
+      ast (~> 2.4.1)
+    rainbow (3.0.0)
+    rake (13.0.1)
+    regexp_parser (1.8.2)
+    rexml (3.2.4)
+    rqrcode_core (0.1.2)
+    rubocop (0.93.1)
+      parallel (~> 1.10)
+      parser (>= 2.7.1.5)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8)
+      rexml
+      rubocop-ast (>= 0.6.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-ast (0.8.0)
+      parser (>= 2.7.1.5)
+    rubocop-performance (1.8.1)
+      rubocop (>= 0.87.0)
+      rubocop-ast (>= 0.4.0)
+    ruby-progressbar (1.10.1)
+    unicode-display_width (1.7.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
+  minitest (~> 5.14)
   qr4r!
-  rake
+  rake (~> 13.0)
+  rubocop (~> 0.93)
+  rubocop-performance (~> 1.8)
+
+BUNDLED WITH
+   2.1.4

data/LICENSE.txt

@@ -0,0 +1,14 @@
+            DO WHAT THE FUCK YOU WANT TO PUBLIC LICENSE
+                    Version 2, December 2004
+
+ Copyright (C) 2020 Jon Rogers <jon@rcode5.com>
+ Copyright (C) 2004 Sam Hocevar <sam@hocevar.net>
+
+ Everyone is permitted to copy and distribute verbatim or modified
+ copies of this license document, and changing it is allowed as long
+ as the name is changed.
+
+            DO WHAT THE FUCK YOU WANT TO PUBLIC LICENSE
+   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+
+  0. You just DO WHAT THE FUCK YOU WANT TO.

data/Rakefile

@@ -1,18 +1,16 @@
-require 'rubygems'
-task :default => :test
+require "rubygems"
+require "rake/testtask"
+task default: :test
 
-task 'default' => :test
-
-desc "Default: run tests"
-task :test do
-  require 'rake/runtest'
-  files = Dir.glob(File.join(File.dirname(__FILE__), 'test/*_test.rb'))
-  files.each do |f|
-    Rake.run_tests f
-  end
+Rake::TestTask.new do |task|
+  task.pattern = "test/*_test.rb"
 end
 
 task :build do
   `rm qr4r-*.gem`
-  puts `gem build qr4r.gemspec`  
+  puts `gem build qr4r.gemspec`
+end
+
+task release: :build do
+  puts `gem push qr4r-*.gem`
 end

data/examples/generate_qr4r.rb

@@ -1,14 +1,13 @@
 #!/usr/bin/env ruby
 
-require 'qr4r'
-require 'optparse'
-require 'ostruct'
+require "qr4r"
+require "optparse"
+require "ostruct"
 
 class CmdlineOpts
-
   @opts = nil
 
-  ALLOWED_FORMATS = %w(jpg jpeg gif tif tiff png)
+  ALLOWED_FORMATS = %w[jpg jpeg gif tif tiff png].freeze
 
   attr_reader :options
 
@@ -19,13 +18,24 @@ class CmdlineOpts
     @options.pixel_size = 10
     @options.verbose = false
 
-    @opts = OptionParser.new do |opts|
+    @opts = setup_options
+
+    @opts.parse!(args)
+  end
+
+  # rubocop:disable Metrics/MethodLength
+  def setup_options
+    OptionParser.new do |opts|
       opts.banner = "Usage: $0 [options] outfile the stuff to encode"
 
       opts.separator ""
 
       # Mandatory argument.
-      opts.on("-f", "--format FILE_FORMAT", ALLOWED_FORMATS, "Output qrcode image format (default: gif)", " (#{ALLOWED_FORMATS.join ', '})") do |fmt|
+      opts.on("-f",
+              "--format FILE_FORMAT",
+              ALLOWED_FORMATS,
+              "Output qrcode image format (default: gif)",
+              " (#{ALLOWED_FORMATS.join ", "})") do |fmt|
         @options.format = fmt
       end
       opts.on("-b", "--border N",
@@ -36,7 +46,7 @@ class CmdlineOpts
               "Size for each qrcode pixel") do |px|
         @options.pixel_size = px.to_i
       end
-      opts.on("-v", "--[no-]verbose", "Be verbose") do |v|
+      opts.on("-v", "--[no-]verbose", "Be verbose") do |_v|
         @options.verbose = V
       end
 
@@ -46,17 +56,15 @@ class CmdlineOpts
         puts opts
         exit
       end
+      opts
     end
+    # rubocop:enable Metrics/MethodLength
+  end
 
-    @opts.parse!(args)
-
-  end  # parse()
-  
   def help
     puts @opts
   end
-
-end 
+end
 
 cmd_options = CmdlineOpts.new(ARGV)
 
@@ -64,15 +72,15 @@ if ARGV.length < 2
   cmd_options.help
 else
   outfile = ARGV.shift
-  to_encode = ARGV.join ' '
+  to_encode = ARGV.join " "
   options = cmd_options.options
 
   if options.verbose
     print "Encoding \"#{to_encode}\" to file #{outfile}"
-    print " with border #{options.border}"  if options.border > 0
+    print " with border #{options.border}"  if options.border.positive?
     print " and pixel_size #{options.pixel_size}"
     puts " and format #{options.format}"
   end
 
-  Qr4r::encode(to_encode, outfile, cmd_options.options.marshal_dump)
+  Qr4r.encode(to_encode, outfile, cmd_options.options.marshal_dump)
 end

data/init.rb

@@ -1 +1 @@
-require File::expand_path(File::join(File::dirname(__FILE__), 'lib', 'qr4r'))
+require File.expand_path(File.join(File.dirname(__FILE__), "lib", "qr4r"))

data/lib/qr4r.rb

@@ -1,52 +1,31 @@
-require 'rqrcode'
-require 'mojo_magick'
+require "rqrcode_core"
+require "mojo_magick"
 module Qr4r
-
-  # params we use
-  #   pixel_size  - size of each dot, default = 3
-  # params we pass to QRCode include :size and :level
-  #   size   - the size of the qrcode (default 4)
-  #   level  - the error correction level, can be:
-  #      * Level :l 7%  of code can be restored
-  #      * Level :m 15% of code can be restored
-  #      * Level :q 25% of code can be restored
-  #      * Level :h 30% of code can be restored
-  # note: if size is not included and 4 appears to be too small for the included string, we'll make it bigger
-  #       if you include size, we'll use it, which may lead to an error if the string is too long
-  # Limitations are as follows:
-  #   size = 1, max string length = 7
-  #   size = 2, max string length = 14
-  #   size = 3, max string length = 24
-  #   size = 4, max string length = 34
-  #   size = 5, max string length = 44
-  #   size = 6, max string length = 58
-  #   size = 7, max string length = 64
-  #   size = 8, max string length = 84
-  #   size = 9, max string length = 98
-  #   size = 10, max string length = 119
-
-  SIZE_RESTRICTIONS = [0, 7, 14, 24, 34, 44, 58, 64, 84, 98, 119] 
+  # These come from rqrcode_core - read https://github.com/whomwah/rqrcode_core
+  # for more information
+  SIZE_RESTRICTIONS = [0, 7, 14, 24, 34, 44, 58, 64, 84, 98, 119]
 
   def self.encode(str, outfile, *rest)
-    opts = rest[0] if rest && rest.length > 0
-    opts ||= {} 
-    opts.merge!({:size => compute_size(str)}) unless opts[:size]
-    opts.merge!({:pixel_size => 3}) unless opts[:pixel_size]
-    qr, data = build_qr_code(str, opts)
-    create_image(qr,data,outfile,opts)
+    opts = rest[0] unless rest.empty?
+    opts ||= {}
+    opts[:size] = compute_size(str) unless opts[:size]
+    opts[:pixel_size] = 3 unless opts[:pixel_size]
+    qr_code, data = build_qr_code(str, opts)
+    create_image(qr_code, data, outfile, opts)
   end
 
   class << self
     private
-    def build_qr_code(str,opts)
-      qr = RQRCode::QRCode.new(str, opts)
-      data = [].tap do |data|
+
+    def build_qr_code(str, opts)
+      qr = RQRCodeCore::QRCode.new(str, opts)
+      data = [].tap do |px|
         qr.modules.each_index do |x|
           qr.modules.each_index do |y|
-            if qr.dark?(x,y)
-              3.times { data << 0 }
+            if qr.checked?(x, y)
+              3.times { px << 0 }
             else
-              3.times { data << 255 }
+              3.times { px << 255 }
             end
           end
         end
@@ -54,37 +33,36 @@ module Qr4r
       [qr, data]
     end
 
-    def create_image(qr, data, outfile, opts) 
-      MojoMagick::convert do |c|
-        d = data.pack 'C'*data.size
-        c.blob(d, :format => :rgb, :depth => 8, :size => ("%dx%d" % [qr.modules.size, qr.modules.size]))
+    def create_image(qr_code, data, outfile, opts)
+      MojoMagick.convert do |c|
+        d = data.pack "C" * data.size
+        c.blob(d, format: :rgb, depth: 8, size: format("%dx%d", qr_code.modules.size, qr_code.modules.size))
         if opts[:pixel_size]
-          wd = qr.modules.size * opts[:pixel_size].to_i
-          c.scale "%dx%d" % [ wd, wd ]
+          wd = qr_code.modules.size * opts[:pixel_size].to_i
+          c.scale format("%dx%d", wd, wd)
         end
         if opts[:border]
           border = opts[:border].to_i
-          c.bordercolor 'white'
-          c.border '%dx%d' % [ border, border ]
+          c.bordercolor "white"
+          c.border format("%dx%d", border, border)
         end
         c.file outfile
       end
     end
 
-
     def compute_size(str)
       slen = str.size
       ii = 0
-      while ii < SIZE_RESTRICTIONS.length do
-        if slen < SIZE_RESTRICTIONS[ii]
-          break
-        end
-        ii+=1
+      while ii < SIZE_RESTRICTIONS.length
+        break if slen < SIZE_RESTRICTIONS[ii]
+
+        ii += 1
       end
       if ii > 10
         raise "Your string is too big for this encoder.  It should be less than #{SIZE_RESTRICTIONS.last} characters"
       end
-      return ii
+
+      ii
     end
   end
 end

data/lib/qr4r/version.rb

@@ -1,3 +1,3 @@
 module Qr4r
-  VERSION = '0.4.1'
+  VERSION = "0.6.0".freeze
 end

data/qr4r.gemspec

@@ -1,23 +1,28 @@
-$:.push File.expand_path("../lib", __FILE__)
+$LOAD_PATH.push File.expand_path("lib", __dir__)
 require "qr4r/version"
 
 Gem::Specification.new do |s|
+  s.required_ruby_version = ">= 2.5.0"
   s.name        = "qr4r"
+  s.licenses    = ['WTFPL']
   s.version     = Qr4r::VERSION
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Jon Rogers"]
   s.email       = ["jon@rcode5.com"]
   s.homepage    = "http://github.com/rcode5/qr4r"
   s.summary     = "qr4r-#{Qr4r::VERSION}"
-  s.description = %q{QR PNG Generator for Ruby. Leveraging RQRCode and MojoMagick modules}
+  s.description = "QR PNG Generator for Ruby. Leveraging RQRCode and MojoMagick modules"
 
   s.rubyforge_project = "qr4r"
-  
+
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   s.require_paths = ["lib"]
-  s.add_dependency('rqrcode')
-  s.add_dependency('mojo_magick')
-  s.add_development_dependency('rake')
+  s.add_dependency("mojo_magick", '~> 0.5')
+  s.add_dependency("rqrcode_core", '~> 0.1')
+  s.add_development_dependency("minitest", "~> 5.14")
+  s.add_development_dependency("rake", "~> 13.0")
+  s.add_development_dependency("rubocop", "~> 0.93")
+  s.add_development_dependency("rubocop-performance", "~> 1.8")
 end

data/test/qr4r_test.rb

@@ -1,124 +1,120 @@
-require 'test/unit'
-require File::expand_path(File::join(File::dirname(__FILE__), '..', 'init'))
-require 'tempfile'
-class Qr4rTest < Test::Unit::TestCase
-
-  def test_encode
-    # do something
-    f = Tempfile.new(['qr4r','.png'])
-    Qr4r::encode('whatever yo', f.path)
-    # assert that it worked
-    assert File.exists?(f.path)
-    r = MojoMagick::get_image_size(f.path)
-    assert r[:height] == 25 * 3
-    assert r[:width] == 25 * 3
-  end
-
-  def test_encode_with_size
-    # do something
-    f = Tempfile.new(['qr4r','.png'])
-    Qr4r::encode('whatever yo', f.path, :size => 4)
-    # assert that it worked
-    assert File.exists?(f)
-    r = MojoMagick::get_image_size(f.path)
-    assert r[:height] == 33 * 3
-    assert r[:width] == 33 * 3
-  end
-
-  def test_encode_with_size_and_border
-    # do something
-    f = Tempfile.new(['qr4r','.png'])
-    Qr4r::encode('whatever yo', f.path, :size => 4, :border => 10)
-    # assert that it worked
-    assert File.exists?(f)
-    r = MojoMagick::get_image_size(f.path)
-    assert r[:height] == 33 * 3 + 20
-    assert r[:width] == 33 * 3 + 20
-  end
-
-  def test_encode_with_pixel_size
-    # do something
-    f = Tempfile.new(['qr4r','.png'])
-    Qr4r::encode('whatever yo', f.path, :pixel_size => 5)
-    # assert that it worked
-    assert File.exists?(f)
-    r = MojoMagick::get_image_size(f.path)
-    assert r[:height] == 25 * 5
-    assert r[:width] == 25 * 5
-  end
-
-  def test_encode_with_pixel_size_as_string
-    # do something
-    f = Tempfile.new(['qr4r','.png'])
-    Qr4r::encode('whatever yo', f.path, :pixel_size => '5')
-    # assert that it worked
-    assert File.exists?(f)
-    r = MojoMagick::get_image_size(f.path)
-    assert r[:height] == 25 * 5
-    assert r[:width] == 25 * 5
-  end
-
-  def test_encode_with_size_and_level
-    # do something
-    f = Tempfile.new(['qr4r','.png'])
-    Qr4r::encode('whatever yo', f.path, :size => 4, :level => :m)
-    # assert that it worked
-    assert File.exists?(f)
-    r = MojoMagick::get_image_size(f.path)
-    assert r[:height] == 33 * 3
-    assert r[:width] == 33 * 3
-  end
-
-  def test_a_long_string_with_size_thats_too_small
-    caught = false
-    begin
-      f = Tempfile.new(['qr4r','.png'])
-      Qr4r::encode('this string should also be encodable. don\'t ya think', f.path, :size => 4)
-    rescue
-      caught = true
-    end
-    assert caught, 'Expected an error'
-  end
-
-  def test_a_long_string_with_size_thats_right
-    f = Tempfile.new(['qr4r','.png'])
-    Qr4r::encode('this string should also be encodable. don\'t ya think', f.path, :size => 10)
-    assert File.exists?(f)
-    r = MojoMagick::get_image_size(f.path)
-    assert r[:height] == 57 * 3
-    assert r[:width] == 57 * 3
-  end
-
-  def test_a_long_string_without_size
-    f = Tempfile.new(['qr4r','.png'])
-    Qr4r::encode('this string should also be encodable. don\'t ya think', f.path)
-    assert File.exists?(f)
-    r = MojoMagick::get_image_size(f.path)
-    assert r[:height] = 41 * 3
-    assert r[:width] = 41 * 3
-
-  end
-
-  def test_compute_size
-    test_sizes = [ 7, 14, 24, 34, 44, 58, 64, 84, 98]
-    test_sizes.each_with_index do |sz, idx|
-      str = 'a'*(sz-1)
-      assert Qr4r.send(:compute_size, str) == idx+1
-      str = 'a'*(sz)
-      assert Qr4r.send(:compute_size, str) == idx+2
-    end
-  end
-
-  def test_compute_size_too_big
-    str = 'a'*120
-    caught = false
-    begin
-      Qr4r.send(:compute_size, str)
-    rescue Exception => ex
-      caught = true
-    end
-    assert caught, "Expected exception"
-    
-  end
-    
-end
+require "minitest/autorun"
+require File.expand_path(File.join(File.dirname(__FILE__), "..", "init"))
+require "tempfile"
+class Qr4rTest < MiniTest::Test
+  def test_encode
+    # do something
+    f = Tempfile.new(["qr4r", ".png"])
+    Qr4r.encode("whatever yo", f.path)
+    # assert that it worked
+    assert File.exist?(f.path)
+    r = MojoMagick.get_image_size(f.path)
+    assert r[:height] == 25 * 3
+    assert r[:width] == 25 * 3
+  end
+
+  def test_encode_with_size
+    # do something
+    f = Tempfile.new(["qr4r", ".png"])
+    Qr4r.encode("whatever yo", f.path, size: 4)
+    # assert that it worked
+    assert File.exist?(f)
+    r = MojoMagick.get_image_size(f.path)
+    assert r[:height] == 33 * 3
+    assert r[:width] == 33 * 3
+  end
+
+  def test_encode_with_size_and_border
+    # do something
+    f = Tempfile.new(["qr4r", ".png"])
+    Qr4r.encode("whatever yo", f.path, size: 4, border: 10)
+    # assert that it worked
+    assert File.exist?(f)
+    r = MojoMagick.get_image_size(f.path)
+    assert r[:height] == 33 * 3 + 20
+    assert r[:width] == 33 * 3 + 20
+  end
+
+  def test_encode_with_pixel_size
+    # do something
+    f = Tempfile.new(["qr4r", ".png"])
+    Qr4r.encode("whatever yo", f.path, pixel_size: 5)
+    # assert that it worked
+    assert File.exist?(f)
+    r = MojoMagick.get_image_size(f.path)
+    assert r[:height] == 25 * 5
+    assert r[:width] == 25 * 5
+  end
+
+  def test_encode_with_pixel_size_as_string
+    # do something
+    f = Tempfile.new(["qr4r", ".png"])
+    Qr4r.encode("whatever yo", f.path, pixel_size: "5")
+    # assert that it worked
+    assert File.exist?(f)
+    r = MojoMagick.get_image_size(f.path)
+    assert r[:height] == 25 * 5
+    assert r[:width] == 25 * 5
+  end
+
+  def test_encode_with_size_and_level
+    # do something
+    f = Tempfile.new(["qr4r", ".png"])
+    Qr4r.encode("whatever yo", f.path, size: 4, level: :m)
+    # assert that it worked
+    assert File.exist?(f)
+    r = MojoMagick.get_image_size(f.path)
+    assert r[:height] == 33 * 3
+    assert r[:width] == 33 * 3
+  end
+
+  def test_a_long_string_with_size_thats_too_small
+    caught = false
+    begin
+      f = Tempfile.new(["qr4r", ".png"])
+      Qr4r.encode("this string should also be encodable. don't ya think", f.path, size: 4)
+    rescue StandardError
+      caught = true
+    end
+    assert caught, "Expected an error"
+  end
+
+  def test_a_long_string_with_size_thats_right
+    f = Tempfile.new(["qr4r", ".png"])
+    Qr4r.encode("this string should also be encodable. don't ya think", f.path, size: 10)
+    assert File.exist?(f)
+    r = MojoMagick.get_image_size(f.path)
+    assert r[:height] == 57 * 3
+    assert r[:width] == 57 * 3
+  end
+
+  def test_a_long_string_without_size
+    f = Tempfile.new(["qr4r", ".png"])
+    Qr4r.encode("this string should also be encodable. don't ya think", f.path)
+    assert File.exist?(f)
+    r = MojoMagick.get_image_size(f.path)
+    assert r[:height] = 41 * 3
+    assert r[:width] = 41 * 3
+  end
+
+  def test_compute_size
+    test_sizes = [7, 14, 24, 34, 44, 58, 64, 84, 98]
+    test_sizes.each_with_index do |sz, idx|
+      str = "a" * (sz - 1)
+      assert Qr4r.send(:compute_size, str) == idx + 1
+      str = "a" * sz
+      assert Qr4r.send(:compute_size, str) == idx + 2
+    end
+  end
+
+  def test_compute_size_too_big
+    str = "a" * 120
+    caught = false
+    begin
+      Qr4r.send(:compute_size, str)
+    rescue StandardError => _e
+      caught = true
+    end
+    assert caught, "Expected exception"
+  end
+end

metadata

@@ -1,57 +1,99 @@
 --- !ruby/object:Gem::Specification
 name: qr4r
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.6.0
 platform: ruby
 authors:
 - Jon Rogers
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-04-11 00:00:00.000000000 Z
+date: 2020-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rqrcode
+  name: mojo_magick
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.5'
 - !ruby/object:Gem::Dependency
-  name: mojo_magick
+  name: rqrcode_core
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.1'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.14'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.14'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '13.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '13.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.93'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.93'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
 description: QR PNG Generator for Ruby. Leveraging RQRCode and MojoMagick modules
 email:
 - jon@rcode5.com
@@ -60,9 +102,14 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop-common.yml"
+- ".rubocop-performance.yml"
+- ".rubocop.yml"
+- ".ruby-version"
 - ".rvmrc"
 - Gemfile
 - Gemfile.lock
+- LICENSE.txt
 - README.md
 - Rakefile
 - examples/generate_qr4r.rb
@@ -74,9 +121,10 @@ files:
 - qr4r.gemspec
 - test/qr4r_test.rb
 homepage: http://github.com/rcode5/qr4r
-licenses: []
+licenses:
+- WTFPL
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -84,18 +132,16 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: qr4r
-rubygems_version: 2.2.2
-signing_key: 
+rubygems_version: 3.0.3
+signing_key:
 specification_version: 4
-summary: qr4r-0.4.1
+summary: qr4r-0.6.0
 test_files:
 - test/qr4r_test.rb
-has_rdoc: