qr-bills 0.1.2 → 1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e156aa65cb4788eff6c5450aee6dd63f69090432e4f4182d304a31aac808ebe6
-  data.tar.gz: 3f928ff3b0213a3509f161e4ba2a56e480830e78181740835d294fd087d6e943
+  metadata.gz: 5b13afc587aab384d5e9a030f42108e2b9110fcc7990e6f1ae0b7ce94069d04c
+  data.tar.gz: 8052cd236374ecf1bc14ba7f41b7cd42295fc983a3034e3dec39b23af794c862
 SHA512:
-  metadata.gz: d61b9da6f1620aa1c8f8d05a9d460105087076c96568e061fa3f16d09cfb697c16ffd34084513b4ba397a73b61ba104cf2b5562f380f4d71bf4a3604c3c984a7
-  data.tar.gz: 88d1f1c246014a9f6f2837d9d6c20760d0fb759fc0c3484e0c5f561a6e4f31622935ddda9a55dcdb25a9888b159b4a2d9918f76fced28118541396174a88b0ef
+  metadata.gz: f513cd9212d3469f6be2b9b254b7fd39fb3b61d712896d90f70250c5e05426d8bf87800940288c699649b19d3ae3cc71d6e17726e9a9ddbc15f49614402291a2
+  data.tar.gz: 455577fd45fcc3fe7be24f14ee32275e2d5e6e8d5257f4c7eeaee184616596f6a5f42c09e72d2fe01fe42d3ccf774a0711e0e60516e46438216fefad453d1967

data/config/locales/qrbills.de.yml

@@ -0,0 +1,17 @@
+de:
+  qrbills:
+    payment_part: Zahlteil
+    account: Konto
+    payable_to: Zahlbar an
+    reference: Referenz
+    additional_information: zusätzliche Informationen
+    further_information: weitere Informationen
+    currency: Währung
+    amount: Betrag
+    receipt: Empfangsschein
+    acceptance_point: Annahmestelle
+    separate_before_paying_in: Vor der Einzahlung abzutrennen
+    payable_by: Zahlbar durch
+    payable_by_name_addr: Zahlbar durch (Name/Adresse)
+    in_favour_of: Zugunsten
+    name: Name

data/config/locales/qrbills.en.yml

@@ -0,0 +1,17 @@
+en:
+  qrbills:
+    payment_part: payment part
+    account: account
+    payable_to: payable to
+    reference: reference
+    additional_information: additional information
+    further_information: further information
+    currency: currency
+    amount: amount
+    receipt: receipt
+    acceptance_point: acceptance point
+    separate_before_paying_in: separate before paying in
+    payable_by: payable by
+    payable_by_name_addr: payable by (name/address)
+    in_favour_of: in favour of
+    name: nom

data/config/locales/qrbills.fr.yml

@@ -0,0 +1,17 @@
+fr:
+  qrbills:
+    payment_part: section paiement
+    account: compte
+    payable_to: payable à
+    reference: référence
+    additional_information: informations additionnelles
+    further_information: informations supplémentaires
+    currency: monnaie
+    amount: montant
+    receipt: récépissé
+    acceptance_point: èpomt de dépôt
+    separate_before_paying_in: à détacher avant le versement
+    payable_by: payable par
+    payable_by_name_addr: payable par (nom/adresse)
+    in_favour_of: en faveur de
+    name: name

data/config/locales/qrbills.it.yml

@@ -0,0 +1,17 @@
+it:
+  qrbills:
+    payment_part: "sezione pagamento"
+    account: conto
+    payable_to: "pagabile a"
+    reference: riferimento
+    additional_information: "informazioni aggiuntive"
+    further_information: "informazioni supplementari"
+    currency: valuta
+    amount: importo
+    receipt: ricevuta
+    acceptance_point: "punto di accettazione"
+    separate_before_paying_in: "da staccare prima del versamento"
+    payable_by: pagabile da
+    payable_by_name_addr: pagabile da (nome/indirizzo)
+    in_favour_of: a favore di
+    name: nome

data/lib/qr-bills.rb

@@ -2,38 +2,34 @@ require 'i18n'
 require 'qr-bills/qr-exceptions'
 require 'qr-bills/qr-params'
 require 'qr-bills/qr-html-layout'
+require 'qr-bills/qr-creditor-reference'
 
-class QRBills
+module QRBills
   def self.generate(qr_params)
-    # init translator sets
-    I18n.load_path << "#{File.expand_path("#{File.dirname(__FILE__)}/../config/locales/it.yml")}"
-    I18n.load_path << "#{File.expand_path("#{File.dirname(__FILE__)}/../config/locales/en.yml")}"
-    I18n.load_path << "#{File.expand_path("#{File.dirname(__FILE__)}/../config/locales/de.yml")}"
-    I18n.load_path << "#{File.expand_path("#{File.dirname(__FILE__)}/../config/locales/fr.yml")}"
-    I18n.default_locale = :it
-
-    bill = { 
-      params: qr_params,
-      output: nil 
-    }
+    raise ArgumentError, "#{QRExceptions::INVALID_PARAMETERS}: bill type param not set" unless qr_params.has_key?(:bill_type)
+    raise ArgumentError, "#{QRExceptions::INVALID_PARAMETERS}: validation failed" unless QRParams.valid?(qr_params)
 
-    if qr_params.has_key?(:bill_type)
-
-      if !QRParams.valid?(qr_params)
-        raise QRExceptions::INVALID_PARAMETERS + ": params validation check failed"
-      end
+    # init translator sets
+    %i[it en de fr].each do |locale|
+      locale_file = File.join(qr_params[:locales][:path], "qrbills.#{locale}.yml")
 
-      if qr_params[:output_params][:format] == "html"
-        bill[:output] = QRHTMLLayout.create(qr_params)
-      else
-        raise QRExceptions::NOT_SUPPORTED + ": html is the only output format supported so far"
-      end
+      I18n.load_path << locale_file
+    end
 
+    output = case qr_params[:output_params][:format]
+    when 'html'
+      QRHTMLLayout.create(qr_params)
+    when 'qrcode_png'
+      QRGenerator.create(qr_params, qr_params[:qrcode_filepath])
     else
-      raise QRExceptions::INVALID_PARAMETERS + ": bill type param not set"
+      raise ArgumentError, "#{QRExceptions::NOT_SUPPORTED}: #{qr_params[:output_params][:format]} is not yet supported"
     end
 
-    return bill
+    { params: qr_params, output: output }
+  end
+
+  def self.create_creditor_reference(reference)
+    QRCreditorReference.create(reference)
   end
 
   def self.get_qr_params

data/lib/qr-bills/qr-creditor-reference.rb

@@ -0,0 +1,78 @@
+require 'qr-bills/qr-exceptions'
+
+# implement Creditor Reference ISO 11649 generator
+module QRCreditorReference
+  PREFIX = "RF"
+
+  # chars values to calculate the check code
+  @char_values = {
+    "A": 10,
+    "B": 11,
+    "C": 12,
+    "D": 13,
+    "E": 14,
+    "F": 15,
+    "G": 16,
+    "H": 17,
+    "I": 18,
+    "J": 19,
+    "K": 20,
+    "L": 21,
+    "M": 22,
+    "N": 23,
+    "O": 24,
+    "P": 25,
+    "Q": 26,
+    "R": 27,
+    "S": 28,
+    "T": 29,
+    "U": 30,
+    "V": 31,
+    "W": 32,
+    "X": 33,
+    "Y": 34,
+    "Z": 35
+  }
+  
+  def self.create(reference)
+    reference = reference.delete(' ')
+    chars = reference.split('')
+
+    if chars.size == 0 
+      raise QRExceptions::INVALID_PARAMETERS + ": provided reference too short: must be at least one char"
+    end
+
+    # max 25 chars: 2 chars (RF) + 2 chars (check code) + 21 chars (reference)
+    if chars.size > 21 
+      raise QRExceptions::INVALID_PARAMETERS + ": provided reference too long: must be less than 21 chars"
+    end
+
+    reference_val = ""
+
+    chars.each do |c|
+      reference_val += get_char_value(c).to_s
+    end
+
+    # put RF+00 at the end to resolve check code
+    reference_val += @char_values["R".to_sym].to_s + @char_values["F".to_sym].to_s + "00"
+
+    # get check code
+    # when performing the validation of the check code (n % 97) 
+    # the remainder must be equal to 1, thus the 98
+    check_code = 98 - (reference_val.to_i % 97)
+
+    if check_code < 10
+      check_code = "0" + check_code.to_s
+    end
+
+    return PREFIX + check_code.to_s + reference
+  end
+
+  def self.get_char_value(char)
+    if char =~ /[0-9]/
+      return char.to_i
+    end
+
+    return @char_values[char.upcase.to_sym]
+  end
+end

data/lib/qr-bills/qr-exceptions.rb

@@ -1,4 +1,4 @@
-class QRExceptions
+module QRExceptions
   EXCEPTION_PREFIX = "QR-bill"
 
   INVALID_PARAMETERS = EXCEPTION_PREFIX + " invalid parameters"

data/lib/qr-bills/qr-generator.rb

@@ -1,8 +1,6 @@
 require 'rqrcode'
-require 'RMagick'
-include Magick
 
-class QRGenerator
+module QRGenerator
   # payload:
   #  "SPC\r\n" +    # indicator for swiss qr code: SPC (swiss payments code)
   #  "0200\r\n" +   # version of the specifications, 0200 = v2.0
@@ -39,11 +37,6 @@ class QRGenerator
   #  "eBill/B/41010560425610173";                 # alternative scheme paramaters, max 100 chars
  
   def self.create(params, qrcode_path)
-    create_qr(params, qrcode_path)
-    add_swiss_cross(qrcode_path, qrcode_path)
-  end
-
-  def self.create_qr(params, qrcode_path)
     payload = "SPC\r\n"
     payload += "0200\r\n"
     payload += "1\r\n"
@@ -76,7 +69,7 @@ class QRGenerator
     payload += "#{params[:bill_params][:additionally_information]}\r\n"
     payload += "EPD\r\n"
     payload += "#{params[:bill_params][:bill_information_coded]}\r\n"
-    payload += "#{params[:bill_params][:alternative_scheme_paramters]}\r\n"
+    payload += "#{params[:bill_params][:alternative_scheme_parameters]}\r\n"
 
     qrcode = RQRCode::QRCode.new(payload)
 
@@ -93,13 +86,8 @@ class QRGenerator
       size: 1024,
     )
 
-    IO.binwrite(qrcode_path, png.to_s)
-  end
-
-  def self.add_swiss_cross(qrcode_path, final_path)
-    qr_image    = Image.read(qrcode_path)[0]
-    swiss_cross = Image.read(File.expand_path("#{File.dirname(__FILE__)}/../../web/assets/images/swiss_cross.png"))[0]
-    final_qr    = qr_image.composite(swiss_cross, CenterGravity, OverCompositeOp)
-    final_qr.write(final_path)
+    swiss_cross = ChunkyPNG::Image.from_file(File.expand_path("#{File.dirname(__FILE__)}/../../web/assets/images/swiss_cross.png"))
+    final_qr    = png.compose!(swiss_cross, (png.width - swiss_cross.width) / 2,  (png.height - swiss_cross.height) / 2)
+    final_qr.save(qrcode_path)
   end
 end

data/lib/qr-bills/qr-html-layout.rb

@@ -1,6 +1,6 @@
 require 'qr-bills/qr-generator'
 
-class QRHTMLLayout
+module QRHTMLLayout
 
   def self.create(params)
     QRGenerator.create(params, params[:qrcode_filepath])
@@ -10,25 +10,25 @@ class QRHTMLLayout
   def self.html_layout(params)
     layout  = "<div class=\"bill_container\">\n"
     layout += "  <div class=\"receipt_section\">\n"
-    layout += "    <div class=\"title\">#{I18n.t(:receipt).capitalize}</div>\n"
-    layout += "    <div class=\"subtitle payable_to\">#{I18n.t(:account).capitalize} / #{I18n.t(:payable_to).capitalize}</div>\n"
+    layout += "    <div class=\"title\">#{I18n.t("qrbills.receipt").capitalize}</div>\n"
+    layout += "    <div class=\"subtitle payable_to\">#{I18n.t("qrbills.account").capitalize} / #{I18n.t("qrbills.payable_to").capitalize}</div>\n"
     layout += "    <div class=\"qrcontent\">\n"
     layout += "      #{params[:bill_params][:creditor][:iban]}<br/>\n"
     layout += "      #{params[:bill_params][:creditor][:address][:name]}<br/>\n"
     layout += "      #{params[:bill_params][:creditor][:address][:line1]} #{params[:bill_params][:creditor][:address][:line2]}<br/>\n"
     layout += "      #{params[:bill_params][:creditor][:address][:postal_code]} #{params[:bill_params][:creditor][:address][:town]}<br/>\n"
-    layout += "    </div>"
-    layout += "    <div><br/></div>"
+    layout += "    </div>\n"
+    layout += "    <div><br/></div>\n"
 
     if !params[:bill_params][:reference].nil? && !params[:bill_params][:reference].empty?
-    layout += "    <div class=\"subtitle reference\">#{I18n.t(:reference).capitalize}</div>\n"
+    layout += "    <div class=\"subtitle reference\">#{I18n.t("qrbills.reference").capitalize}</div>\n"
     layout += "    <div class=\"reference\">\n"
     layout += "      #{params[:bill_params][:reference]}<br/>\n"
     layout += "    </div>\n"
     layout += "    <div><br/></div>\n"
     end
 
-    layout += "    <div class=\"subtitle payable_by\">#{I18n.t(:payable_by).capitalize}</div>\n"
+    layout += "    <div class=\"subtitle payable_by\">#{I18n.t("qrbills.payable_by").capitalize}</div>\n"
     layout += "    <div class=\"payable_by\">\n"
     layout += "      #{params[:bill_params][:debtor][:address][:name]}<br/>\n"
     layout += "      #{params[:bill_params][:debtor][:address][:line1]} #{params[:bill_params][:debtor][:address][:line2]}<br/>\n"
@@ -37,33 +37,33 @@ class QRHTMLLayout
 
     layout += "    <div class=\"amount\">\n"
     layout += "      <div class=\"currency\">\n"
-    layout += "        <span class=\"amount_header subtitle\">#{I18n.t(:currency).capitalize}</span><br/>\n"
+    layout += "        <span class=\"amount_header subtitle\">#{I18n.t("qrbills.currency").capitalize}</span><br/>\n"
     layout += "        #{params[:bill_params][:currency]}<br/>\n"
     layout += "      </div>\n"
 
     layout += "      <div class=\"amount_value\">\n"
-    layout += "        <span class=\"amount_header subtitle\">#{I18n.t(:amount).capitalize}</span><br/>\n"
+    layout += "        <span class=\"amount_header subtitle\">#{I18n.t("qrbills.amount").capitalize}</span><br/>\n"
     layout += "        #{params[:bill_params][:amount]}<br/>\n"
     layout += "      </div>\n"
     layout += "    </div>\n"
     
     layout += "    <div class=\"acceptance_point\">\n"
-    layout += "      #{I18n.t(:acceptance_point).capitalize}<br/>\n"
+    layout += "      #{I18n.t("qrbills.acceptance_point").capitalize}<br/>\n"
     layout += "    </div>\n"
     
     layout += "  </div>\n"
     layout += "  <div class=\"payment_section\">\n"
     layout += "    <div class=\"left_column\">\n"
-    layout += "      <div class=\"title\">#{I18n.t(:payment_part).capitalize}</div>\n"
+    layout += "      <div class=\"title\">#{I18n.t("qrbills.payment_part").capitalize}</div>\n"
     layout += "      <div class=\"qr_code\"><img src=\"#{params[:qrcode_filepath]}\" /></div>\n"
     layout += "      <div class=\"amount\">\n"
     layout += "        <div class=\"currency\">\n"
-    layout += "          <span class=\"amount_header subtitle\">#{I18n.t(:currency).capitalize}</span><br/>\n"
+    layout += "          <span class=\"amount_header subtitle\">#{I18n.t("qrbills.currency").capitalize}</span><br/>\n"
     layout += "          #{params[:bill_params][:currency]}<br/>\n"
     layout += "        </div>\n"
     
     layout += "        <div class=\"amount_value\">\n"
-    layout += "          <span class=\"amount_header subtitle\">#{I18n.t(:amount).capitalize}</span><br/>\n"
+    layout += "          <span class=\"amount_header subtitle\">#{I18n.t("qrbills.amount").capitalize}</span><br/>\n"
     layout += "          #{params[:bill_params][:amount]}<br/>\n"
     layout += "        </div>\n"
     layout += "      </div>\n"
@@ -71,17 +71,17 @@ class QRHTMLLayout
     layout += "      <div class=\"further_information\">\n"
 
     if !params[:bill_params][:bill_information_coded].nil? && !params[:bill_params][:bill_information_coded].empty?
-    layout += "        <span class=\"finfo_header\">Name AV1:</span> #{params[:bill_params][:bill_information_coded]}\n"
+    layout += "        <span class=\"finfo_header\">#{I18n.t("qrbills.name").capitalize} AV1:</span> #{params[:bill_params][:bill_information_coded]}\n"
     end
   
-    if !params[:bill_params][:alternative_scheme_paramters].nil? && !params[:bill_params][:alternative_scheme_paramters].empty?
-    layout += "        <span class=\"finfo_header\">Name AV2:</span> #{params[:bill_params][:alternative_scheme_paramters]}\n"
+    if !params[:bill_params][:alternative_scheme_parameters].nil? && !params[:bill_params][:alternative_scheme_parameters].empty?
+    layout += "        <span class=\"finfo_header\">#{I18n.t("qrbills.name").capitalize} AV2:</span> #{params[:bill_params][:alternative_scheme_parameters]}\n"
     end
 
     layout += "      </div>\n"
     layout += "    </div>\n"
     layout += "    <div class=\"right_column\">\n"
-    layout += "      <div class=\"subtitle payable_to\">#{I18n.t(:account).capitalize} / #{I18n.t(:payable_to).capitalize}</div>\n"
+    layout += "      <div class=\"subtitle payable_to\">#{I18n.t("qrbills.account").capitalize} / #{I18n.t("qrbills.payable_to").capitalize}</div>\n"
     layout += "      <div class=\"qrcontent\">\n"
     layout += "        #{params[:bill_params][:creditor][:iban]}<br/>\n"
     layout += "        #{params[:bill_params][:creditor][:address][:name]}<br/>\n"
@@ -91,7 +91,7 @@ class QRHTMLLayout
     layout += "    <div><br/></div>\n"
 
     if !params[:bill_params][:reference].nil? && !params[:bill_params][:reference].empty?
-    layout += "    <div class=\"subtitle reference\">#{I18n.t(:reference).capitalize}</div>\n"
+    layout += "    <div class=\"subtitle reference\">#{I18n.t("qrbills.reference").capitalize}</div>\n"
     layout += "      <div class=\"reference\">\n"
     layout += "        #{params[:bill_params][:reference]}<br/>\n"
     layout += "      </div>\n"
@@ -99,14 +99,14 @@ class QRHTMLLayout
     end
 
     if !params[:bill_params][:additionally_information].nil? && !params[:bill_params][:additionally_information].empty?
-    layout += "    <div class=\"subtitle additional_information\">#{I18n.t(:additional_information).capitalize}</div>\n"
+    layout += "    <div class=\"subtitle additional_information\">#{I18n.t("qrbills.additional_information").capitalize}</div>\n"
     layout += "      <div class=\"additional_information\">\n"
     layout += "        #{params[:bill_params][:additionally_information]}<br/>\n"
     layout += "      </div>\n"
     layout += "    <div><br/></div>\n"
     end
 
-    layout += "    <div class=\"subtitle payable_by\">#{I18n.t(:payable_by).capitalize}</div>\n"
+    layout += "    <div class=\"subtitle payable_by\">#{I18n.t("qrbills.payable_by").capitalize}</div>\n"
     layout += "      <div class=\"payable_by\">\n"
     layout += "        #{params[:bill_params][:debtor][:address][:name]}<br/>\n"
     layout += "        #{params[:bill_params][:debtor][:address][:line1]} #{params[:bill_params][:debtor][:address][:line2]}<br/>\n"

data/lib/qr-bills/qr-params.rb

@@ -1,7 +1,7 @@
-class QRParams
+module QRParams
   QR_BILL_WITH_QR_REFERENCE       = "orange_with_reference"
   QR_BILL_WITH_CREDITOR_REFERENCE = "red_with_reference"
-  QR_BILL_WITOUTH_REFERENCE       = "red_without_reference"
+  QR_BILL_WITHOUT_REFERENCE       = "red_without_reference"
 
   def self.get_qr_params
     {
@@ -13,6 +13,9 @@ class QRParams
         ttf: File.expand_path("#{File.dirname(__FILE__)}/../../web/assets/fonts/LiberationSans-Regular.ttf"),
         svg: File.expand_path("#{File.dirname(__FILE__)}/../../web/assets/fonts/LiberationSans-Regular.svg")
       },
+      locales: {
+        path: File.expand_path("#{File.dirname(__FILE__)}/../../config/locales")
+      },
       bill_params: {
         language: "it",
         amount: 0.0,
@@ -21,7 +24,7 @@ class QRParams
         reference: "", # qr reference or creditor reference (iso-11649)
         additionally_information: "",
         bill_information_coded: "",
-        alternative_scheme_paramters: "",
+        alternative_scheme_parameters: "",
         creditor: {
           address: {
             type: "S",
@@ -53,43 +56,70 @@ class QRParams
   end
 
   def self.valid?(params)
-    if params.has_key?(:bill_type)
-
-      if !QRParams.base_params_valid?(params)
-        return false
-      end
+    return false unless params.key?(:bill_type)
+    return false unless QRParams.base_params_valid?(params)
 
-      if params[:bill_type] == QR_BILL_WITH_QR_REFERENCE
-        return QRParams.qr_bill_with_qr_reference_valid?(params)
-      elsif params[:bill_type] == QR_BILL_WITH_CREDITOR_REFERENCE
-        return QRParams.qr_bill_with_creditor_reference_valid?(params)
-      elsif params[:bill_type] == QR_BILL_WITOUTH_REFERENCE
-        return QRParams.qr_bill_without_reference_valid?(params)
-      else
-        return false
-      end
+    case params[:bill_type]
+    when QRParams::QR_BILL_WITH_QR_REFERENCE
+      QRParams.qr_bill_with_qr_reference_valid?(params)
+    when QRParams::QR_BILL_WITH_CREDITOR_REFERENCE
+      QRParams.qr_bill_with_creditor_reference_valid?(params)
+    when QRParams::QR_BILL_WITHOUT_REFERENCE
+      QRParams.qr_bill_without_reference_valid?(params)
     else
-      return false
+      false
     end
   end
-
+  
   def self.base_params_valid?(params)
-    # todo
-    return true
+    if params[:bill_type] == "" || params[:bill_type] == nil
+      raise ArgumentError, "#{QRExceptions::INVALID_PARAMETERS}: bill type cannot be blank"
+    end
+
+    if params[:qrcode_filepath] == "" || params[:qrcode_filepath] == nil
+      raise ArgumentError, "#{QRExceptions::INVALID_PARAMETERS}: qrcode_filepath cannot be blank"
+    end
+
+    if params[:bill_params][:currency] == "" || params[:bill_params][:currency] == nil
+      raise ArgumentError, "#{QRExceptions::INVALID_PARAMETERS}: currency cannot be blank"
+    end
+
+    true
   end
 
   def self.qr_bill_with_qr_reference_valid?(params)
-    # todo
-    return true
+    if params[:bill_params][:reference_type] != "QRR"
+      raise ArgumentError, "#{QRExceptions::INVALID_PARAMETERS}: reference type must be 'QRR' for QR bill with standard reference"
+    end
+    
+    if params[:bill_params][:reference] == "" || params[:bill_params][:reference] == nil
+      raise ArgumentError, "#{QRExceptions::INVALID_PARAMETERS}: reference cannot be blank for QR bill with standard reference"
+    end
+
+    true
   end
 
   def self.qr_bill_with_creditor_reference_valid?(params)
-    # todo
-    return true
+    if params[:bill_params][:reference_type] != "SCOR"
+      raise ArgumentError, "#{QRExceptions::INVALID_PARAMETERS}: reference type must be 'SCOR' for QR bill with (new) creditor reference"
+    end
+    
+    if params[:bill_params][:reference] == "" || params[:bill_params][:reference] == nil
+      raise ArgumentError, "#{QRExceptions::INVALID_PARAMETERS}: reference cannot be blank for QR bill with (new) creditor reference"
+    end
+
+    true
   end
 
   def self.qr_bill_without_reference_valid?(params)
-    # todo
-    return true
+    if params[:bill_params][:reference_type] != "NON"
+      raise ArgumentError, "#{QRExceptions::INVALID_PARAMETERS}: reference type must be 'NON' for QR bill without reference"
+    end
+    
+    if params[:bill_params][:reference] != ""
+      raise ArgumentError, "#{QRExceptions::INVALID_PARAMETERS}: reference must be blank for QR bill without reference"
+    end
+  
+    true
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: qr-bills
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: '1.0'
 platform: ruby
 authors:
 - Damiano Radice
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-05 00:00:00.000000000 Z
+date: 2021-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -50,26 +50,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '2'
-- !ruby/object:Gem::Dependency
-  name: rmagick
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.1.2
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.1.2
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -100,16 +80,17 @@ dependencies:
         version: '13.0'
 description: 'QR-bills support for swiss payments, for full documentation please refer
   to github repo: https://github.com/damoiser/qr-bills'
-email: damoiser+qrbill@gmail.com
+email: dam.radice@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- config/locales/de.yml
-- config/locales/en.yml
-- config/locales/fr.yml
-- config/locales/it.yml
+- config/locales/qrbills.de.yml
+- config/locales/qrbills.en.yml
+- config/locales/qrbills.fr.yml
+- config/locales/qrbills.it.yml
 - lib/qr-bills.rb
+- lib/qr-bills/qr-creditor-reference.rb
 - lib/qr-bills/qr-exceptions.rb
 - lib/qr-bills/qr-generator.rb
 - lib/qr-bills/qr-html-layout.rb
@@ -132,7 +113,7 @@ metadata:
   homepage_uri: https://github.com/damoiser/qr-bills
   source_code_uri: https://github.com/damoiser/qr-bills
   wiki_uri: https://github.com/damoiser/qr-bills
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -148,7 +129,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: QR-bills support for swiss payments
 test_files: []

data/config/locales/de.yml

@@ -1,15 +0,0 @@
-de:
-  payment_part: Zahlteil
-  account: Konto
-  payable_to: Zahlbar an
-  reference: Referenz
-  additional_information: zusätzliche Informationen
-  further_information: weitere Informationen
-  currency: Währung
-  amount: Betrag
-  receipt: Empfangsschein
-  acceptance_point: Annahmestelle
-  separate_before_paying_in: Vor der Einzahlung abzutrennen
-  payable_by: Zahlbar durch
-  payable_by_name_addr: Zahlbar durch (Name/Adresse)
-  in_favour_of: Zugunsten

data/config/locales/en.yml

@@ -1,15 +0,0 @@
-en:
-  payment_part: payment part
-  account: account
-  payable_to: payable to
-  reference: reference
-  additional_information: additional information
-  further_information: further information
-  currency: currency
-  amount: amount
-  receipt: receipt
-  acceptance_point: acceptance point
-  separate_before_paying_in: separate before paying in
-  payable_by: payable by
-  payable_by_name_addr: payable by (name/address)
-  in_favour_of: in favour of

data/config/locales/fr.yml

@@ -1,15 +0,0 @@
-fr:
-  payment_part: section paiement
-  account: compte
-  payable_to: payable à
-  reference: référence
-  additional_information: informations additionnelles
-  further_information: informations supplémentaires
-  currency: monnaie
-  amount: montant
-  receipt: récépissé
-  acceptance_point: èpomt de dépôt
-  separate_before_paying_in: à détacher avant le versement
-  payable_by: payable par
-  payable_by_name_addr: payable par (nom/adresse)
-  in_favour_of: en faveur de

data/config/locales/it.yml

@@ -1,15 +0,0 @@
-it:
-  payment_part: "sezione pagamento"
-  account: conto
-  payable_to: "pagabile a"
-  reference: riferimento
-  additional_information: "informazioni aggiuntive"
-  further_information: "informazioni supplementari"
-  currency: valuta
-  amount: importo
-  receipt: ricevuta
-  acceptance_point: "punto di accettazione"
-  separate_before_paying_in: "da staccare prima del versamento"
-  payable_by: pagabile da
-  payable_by_name_addr: pagabile da (nome/indirizzo)
-  in_favour_of: a favore di