qmin 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e969b8719fe5f2db6ad1fef920177bc35d048ace
-  data.tar.gz: 19f78471b5de8855854afba3d8d49896a6a096d6
+  metadata.gz: 8bdf979e1a4ccffc039a44895e321ace747931dc
+  data.tar.gz: 7cc149608162bcd7dcdad2b0cf5149372fcfb6c2
 SHA512:
-  metadata.gz: f0c2225a4754b8b3d5a6b3c4e6951dd98c4394b227144edeaa77f5335a06b9082794cff6672c045e7aebfc0b3cf52a64371dad59f49364c065cbdb3a87ce24ea
-  data.tar.gz: b574a6d930f82e523dd3eef0fa081a560e4a6be439649dd1826dad10738bc56ba3d522fbcef595c0b8b8c9f3d2085a0b57d3188d31d8c04884a1e96ac0e6ad31
+  metadata.gz: e3b490eb195f7a82b500cca30d12af8f58cbbe71f978638c53102e2de194f2e915a12171a8e74ad5ff2d7c41e2ec65f3fe862418bf2173f670225170f88972c6
+  data.tar.gz: 2367ffe1008775f40db4e9973df7edafa231a0eedb3007a7acd769c13081dbc88fc38ae339f28f7b4d19cb8669eeaf3d65648a6662fdc5bd866a0751789e0f9c

data/lib/qmin/core_ext/class.rb

@@ -1,24 +1,23 @@
-# Extends class with #background_method(method_name)
+# Extends class with #background(method_name)
 # The annotated method will be handled by Qmin and it's current strategy
 class Class
-  # @param method_name
-  # Decorates a method to be handled by Qmin's #background_call method
-  # Calls to the method will then be handled by the configured Qmin::Strategy#background_call method
-  # The original method is still available through "<method_name>_without_qmin"
-  def background_method(method_name)
-    return if respond_to?("#{method_name}_without_qmin") || !!method_name.to_s.match(/_without_qmin$/)
+  # @param *method_names
+  # Define one or many methods that you want to be handled by Qmin's #background_call method.
+  # Calls to these methods will be handled by the configured Qmin::Strategy#background_call method
+  # The original methods are still available through "<method_name>_without_qmin"
+  def background(*method_names)
+    method_names.each do |method_name|
+      define_qmin_background_method method_name.to_s
+    end
+  end
+
+  def define_qmin_background_method(method_name)
+    return if respond_to?("#{method_name}_without_qmin") || !!method_name.match(/_without_qmin$/)
 
-    alias_method "#{method_name}_without_qmin", method_name
+    alias_method "#{method_name}_without_qmin", method_name.to_sym
 
     define_method method_name do
-      ::Qmin::Qmin.background_call(self, method_name)
+      ::Qmin::Qmin.background_call(self, method_name.to_sym)
     end
   end
-
-  # @param *method_names
-  # annotates all methods as background_methods
-  # see #background_method for more information
-  def background_methods(*method_names)
-    method_names.map(&:to_s).each{|method_name| background_method method_name }
-  end
 end

data/lib/qmin/core_ext/string.rb

@@ -1,33 +1,20 @@
-unless String.instance_methods.include?(:snake_case)
+unless !!defined?(ActiveSupport::Inflector)
 
   class String
-    def snake_case
+    def underscore
       self.to_s.gsub(/::/, '/').
         gsub(/([A-Z]+)([A-Z][a-z])/,'\1_\2').
         gsub(/([a-z\d])([A-Z])/,'\1_\2').
         tr('-', '_').
         downcase
     end
-  end
-
-end
-
-unless String.instance_methods.include?(:constantize)
 
-  class String
     def constantize
       Kernel.const_get(self)
     end
-  end
 
-end
-
-
-unless String.instance_methods.include?(:to_queue_name)
-
-  class String
     def to_queue_name
-      gsub('::','').snake_case
+      gsub('::','').underscore
     end
   end
 

data/lib/qmin/strategy/inline.rb

@@ -7,8 +7,8 @@ module Qmin
       end
 
       # call method directly
-      def background_call(instance, method_name)
-        instance.send(::Qmin.method_name_for_instance(instance, method_name))
+      def background_call(instance, method_name, *args)
+        instance.send(::Qmin.method_name_for_instance(instance, method_name), *args)
       end
     end
   end

data/lib/qmin/version.rb

@@ -1,3 +1,3 @@
 module Qmin
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/spec/qmin/core_ext/class_spec.rb

@@ -2,69 +2,72 @@ require File.expand_path '../../spec_helper', File.dirname(__FILE__)
 
 describe Class do
   it 'responds to background_method' do
-    Class.new.should respond_to(:background_method)
+    Class.new.should respond_to(:background)
   end
 
-  it 'annotates methods' do
-    klass = Class.new do
-      def foo; end
-      background_method :foo
+  describe 'instance methods' do
+    it 'annotates methods' do
+      klass = Class.new do
+        def foo; end
+        background :foo
+      end
+      subject = klass.new
 
-      def bar; end
-      background_method :bar
+      subject.should respond_to(:foo)
+      subject.should respond_to(:foo_without_qmin)
     end
 
-    subject = klass.new
-
-    subject.should.respond_to? :foo
-    subject.should.respond_to? :foo_without_qmin
-
-    subject.should.respond_to? :bar
-    subject.should.respond_to? :bar_without_qmin
-  end
-
-
-  it 'annotates many methods' do
-    klass = Class.new do
-      def foo; end
-      def bar; end
-
-      background_methods :foo, :bar
+    it 'annotates many methods' do
+      klass = Class.new do
+        def foo; end
+        def bar; end
+        background :foo, :bar
+      end
+      subject = klass.new
+
+      subject.should respond_to(:foo)
+      subject.should respond_to(:foo_without_qmin)
+      subject.should respond_to(:bar)
+      subject.should respond_to(:bar_without_qmin)
     end
 
-    subject = klass.new
-
-    subject.should.respond_to? :foo
-    subject.should.respond_to? :foo_without_qmin
-
-    subject.should.respond_to? :bar
-    subject.should.respond_to? :bar_without_qmin
-  end
-
-  it 'does not annotate method twice' do
-    klass = Class.new do
-      def foo; end
-      background_method :foo
-      background_method :foo
+    it 'does not annotate original method' do
+      klass = Class.new do
+        def foo; end
+        background :foo
+        background :foo_without_qmin
+      end
+      subject = klass.new
+
+      subject.should respond_to(:foo)
+      subject.should respond_to(:foo_without_qmin)
+      subject.should_not respond_to(:foo_without_qmin_without_qmin)
     end
-
-    subject = klass.new
-
-    subject.should.respond_to? :foo
-    subject.should.respond_to? :foo_without_qmin
   end
 
-  it 'does not annotate original method' do
-    klass = Class.new do
-      def foo; end
-      background_method :foo
-      background_method :foo_without_qmin
+  describe 'class methods' do
+    it 'decorates eigenclass' do
+      klass = Class.new do
+        class << self
+          def foo; end
+          background :foo
+        end
+      end
+      klass.should respond_to(:foo)
+      klass.should respond_to(:foo_without_qmin)
     end
 
-    subject = klass.new
+    it 'decorates class method in eigenclass' do
+      klass = Class.new do
+        def self.foo; end
 
-    subject.should.respond_to? :foo
-    subject.should.respond_to? :foo_without_qmin
-    subject.should_not.respond_to? :foo_without_qmin_without_qmin
+        class << self
+          background :foo
+        end
+      end
+      klass.should respond_to(:foo)
+      klass.should respond_to(:foo_without_qmin)
+    end
   end
+
 end

data/spec/qmin/core_ext/string_spec.rb

@@ -2,8 +2,8 @@ require File.expand_path '../../spec_helper', File.dirname(__FILE__)
 
 describe String do
   it '.snake_case' do
-    'MyClassName'.snake_case.should eql 'my_class_name'
-    'Module::MyClassName'.snake_case.should eql 'module/my_class_name'
+    'MyClassName'.underscore.should eql 'my_class_name'
+    'Module::MyClassName'.underscore.should eql 'module/my_class_name'
   end
 
   it '.constantize' do

data/spec/spec_helper.rb

@@ -86,7 +86,7 @@ class BackgroundTestClass < TestClass
     'BackgroundTestClass'
   end
 
-  background_method :action
+  background :action
 end
 
 class TestJob < Qmin::Resque::BaseJob

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: qmin
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - the-architect