qless 0.9.3 → 0.10.0

data/lib/qless/worker/serial.rb

@@ -0,0 +1,41 @@
+# Encoding: utf-8
+
+# Qless requires
+require 'qless'
+require 'qless/worker/base'
+
+module Qless
+  module Workers
+    # A worker that keeps popping off jobs and processing them
+    class SerialWorker < BaseWorker
+      def initialize(reserver, options = {})
+        super(reserver, options)
+      end
+
+      def run
+        log(:info, "Starting #{reserver.description} in #{Process.pid}")
+        procline "Starting #{reserver.description}"
+        register_signal_handlers
+
+        reserver.prep_for_work!
+
+        listen_for_lost_lock do
+          procline "Running #{reserver.description}"
+
+          jobs.each do |job|
+            # Run the job we're working on
+            log(:debug, "Starting job #{job.klass_name} (#{job.jid} from #{job.queue_name})")
+            perform(job)
+            log(:debug, "Finished job #{job.klass_name} (#{job.jid} from #{job.queue_name})")
+
+            # So long as we're paused, we should wait
+            while paused
+              log(:debug, 'Paused...')
+              sleep interval
+            end
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: qless
 version: !ruby/object:Gem::Version
-  version: 0.9.3
+  version: 0.10.0
   prerelease: 
 platform: ruby
 authors:
 - Dan Lecocq
+- Myron Marston
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2013-05-20 00:00:00.000000000 Z
+date: 2016-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -28,37 +29,37 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.2'
 - !ruby/object:Gem::Dependency
-  name: vegas
+  name: sinatra
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.1.11
-  type: :runtime
+        version: 1.3.2
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.1.11
+        version: 1.3.2
 - !ruby/object:Gem::Dependency
-  name: sinatra
+  name: vegas
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.3.2
-  type: :runtime
+        version: 0.1.11
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.3.2
+        version: 0.1.11
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -130,7 +131,23 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: faye-websocket
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -138,7 +155,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 0.4.0
 - !ruby/object:Gem::Dependency
   name: launchy
   requirement: !ruby/object:Gem::Requirement
@@ -162,7 +179,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: 0.7.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -170,7 +187,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: 0.7.1
 - !ruby/object:Gem::Dependency
   name: sentry-raven
   requirement: !ruby/object:Gem::Requirement
@@ -187,16 +204,96 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.4'
-description: ! "\n    `qless` is meant to be a performant alternative to other queueing\n
-  \   systems, with statistics collection, a browser interface, and \n    strong guarantees
-  about job losses.\n    \n    It's written as a collection of Lua scipts that are
-  loaded into the\n    Redis instance to be used, and then executed by the client
-  library.\n    As such, it's intended to be extremely easy to port to other languages,\n
-  \   without sacrificing performance and not requiring a lot of logic\n    replication
-  between clients. Keep the Lua scripts updated, and your\n    language-specific extension
-  will also remain up to date.\n  "
+- !ruby/object:Gem::Dependency
+  name: metriks
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.9'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.9'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.13.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.13.1
+- !ruby/object:Gem::Dependency
+  name: rusage
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.2.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.2.0
+- !ruby/object:Gem::Dependency
+  name: timecop
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.7.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.7.1
+- !ruby/object:Gem::Dependency
+  name: thin
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.6.4
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.6.4
+description: ! "\n`qless` is meant to be a performant alternative to other queueing\nsystems,
+  with statistics collection, a browser interface, and\nstrong guarantees about job
+  losses.\n\nIt's written as a collection of Lua scipts that are loaded into the\nRedis
+  instance to be used, and then executed by the client library.\nAs such, it's intended
+  to be extremely easy to port to other languages,\nwithout sacrificing performance
+  and not requiring a lot of logic\nreplication between clients. Keep the Lua scripts
+  updated, and your\nlanguage-specific extension will also remain up to date.\n  "
 email:
-- dan@seomoz.org
+- dan@moz.com
+- myron@moz.com
 executables:
 - qless-web
 extensions: []
@@ -207,48 +304,34 @@ files:
 - Rakefile
 - HISTORY.md
 - lib/qless/config.rb
+- lib/qless/failure_formatter.rb
 - lib/qless/job.rb
 - lib/qless/job_reservers/ordered.rb
 - lib/qless/job_reservers/round_robin.rb
 - lib/qless/job_reservers/shuffled_round_robin.rb
 - lib/qless/lua_script.rb
+- lib/qless/middleware/memory_usage_monitor.rb
+- lib/qless/middleware/metriks.rb
 - lib/qless/middleware/redis_reconnect.rb
+- lib/qless/middleware/requeue_exceptions.rb
 - lib/qless/middleware/retry_exceptions.rb
 - lib/qless/middleware/sentry.rb
+- lib/qless/middleware/timeout.rb
 - lib/qless/queue.rb
 - lib/qless/server.rb
 - lib/qless/subscriber.rb
 - lib/qless/tasks.rb
+- lib/qless/test_helpers/worker_helpers.rb
 - lib/qless/version.rb
-- lib/qless/wait_until.rb
+- lib/qless/worker/base.rb
+- lib/qless/worker/forking.rb
+- lib/qless/worker/serial.rb
 - lib/qless/worker.rb
 - lib/qless.rb
-- lib/qless/qless-core/cancel.lua
-- lib/qless/qless-core/complete.lua
-- lib/qless/qless-core/config.lua
-- lib/qless/qless-core/depends.lua
-- lib/qless/qless-core/deregister_workers.lua
-- lib/qless/qless-core/fail.lua
-- lib/qless/qless-core/failed.lua
-- lib/qless/qless-core/get.lua
-- lib/qless/qless-core/heartbeat.lua
-- lib/qless/qless-core/jobs.lua
-- lib/qless/qless-core/pause.lua
-- lib/qless/qless-core/peek.lua
-- lib/qless/qless-core/pop.lua
-- lib/qless/qless-core/priority.lua
-- lib/qless/qless-core/put.lua
-- lib/qless/qless-core/qless-lib.lua
-- lib/qless/qless-core/qless.lua
-- lib/qless/qless-core/queues.lua
-- lib/qless/qless-core/recur.lua
-- lib/qless/qless-core/retry.lua
-- lib/qless/qless-core/stats.lua
-- lib/qless/qless-core/tag.lua
-- lib/qless/qless-core/track.lua
-- lib/qless/qless-core/unfail.lua
-- lib/qless/qless-core/unpause.lua
-- lib/qless/qless-core/workers.lua
+- lib/qless/lua/qless-lib.lua
+- lib/qless/lua/qless.lua
+- exe/install_phantomjs
+- exe/qless-web
 - lib/qless/server/static/css/bootstrap-responsive.css
 - lib/qless/server/static/css/bootstrap-responsive.min.css
 - lib/qless/server/static/css/bootstrap.css
@@ -284,6 +367,7 @@ files:
 - lib/qless/server/views/_job_list.erb
 - lib/qless/server/views/_pagination.erb
 - lib/qless/server/views/about.erb
+- lib/qless/server/views/completed.erb
 - lib/qless/server/views/config.erb
 - lib/qless/server/views/failed.erb
 - lib/qless/server/views/failed_type.erb
@@ -296,7 +380,6 @@ files:
 - lib/qless/server/views/track.erb
 - lib/qless/server/views/worker.erb
 - lib/qless/server/views/workers.erb
-- exe/qless-web
 homepage: http://github.com/seomoz/qless
 licenses: []
 post_install_message: 
@@ -317,7 +400,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: qless
-rubygems_version: 1.8.24
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: A Redis-Based Queueing System

data/lib/qless/qless-core/cancel.lua

@@ -1,101 +0,0 @@
--- Cancel(0, jid)
--- --------------
--- Cancel a job from taking place. It will be deleted from the system, and any
--- attempts to renew a heartbeat will fail, and any attempts to complete it
--- will fail. If you try to get the data on the object, you will get nothing.
---
--- Args:
---    1) jid
-
-if #KEYS > 0 then error('Cancel(): No Keys should be provided') end
-
-local function cancel(jid, jid_set)
-  if not jid_set[jid] then
-    error('Cancel(): ' .. jid .. ' is a dependency of one of the jobs but is not in the provided jid set')
-  end
-
-  -- Find any stage it's associated with and remove its from that stage
-  local state, queue, failure, worker = unpack(redis.call('hmget', 'ql:j:' .. jid, 'state', 'queue', 'failure', 'worker'))
-
-  if state == 'complete' then
-    return false
-  else
-    -- If this job has dependents, then we should probably fail
-    local dependents = redis.call('smembers', 'ql:j:' .. jid .. '-dependents')
-    for _, dependent_jid in ipairs(dependents) do
-      cancel(dependent_jid, jid_set)
-    end
-
-    -- Send a message out on the appropriate channels
-    local encoded = cjson.encode({
-      jid    = jid,
-      worker = worker,
-      event  = 'canceled',
-      queue  = queue
-    })
-    redis.call('publish', 'ql:log', encoded)
-
-    -- Remove this job from whatever worker has it, if any
-    if worker then
-      redis.call('zrem', 'ql:w:' .. worker .. ':jobs', jid)
-      -- If necessary, send a message to the appropriate worker, too
-      redis.call('publish', 'ql:w:' .. worker, encoded)
-    end
-
-    -- Remove it from that queue
-    if queue then
-      redis.call('zrem', 'ql:q:' .. queue .. '-work', jid)
-      redis.call('zrem', 'ql:q:' .. queue .. '-locks', jid)
-      redis.call('zrem', 'ql:q:' .. queue .. '-scheduled', jid)
-      redis.call('zrem', 'ql:q:' .. queue .. '-depends', jid)
-    end
-
-    -- We should probably go through all our dependencies and remove ourselves
-    -- from the list of dependents
-    for i, j in ipairs(redis.call('smembers', 'ql:j:' .. jid .. '-dependencies')) do
-      redis.call('srem', 'ql:j:' .. j .. '-dependents', jid)
-    end
-
-    -- Delete any notion of dependencies it has
-    redis.call('del', 'ql:j:' .. jid .. '-dependencies')
-
-    -- If we're in the failed state, remove all of our data
-    if state == 'failed' then
-      failure = cjson.decode(failure)
-      -- We need to make this remove it from the failed queues
-      redis.call('lrem', 'ql:f:' .. failure.group, 0, jid)
-      if redis.call('llen', 'ql:f:' .. failure.group) == 0 then
-        redis.call('srem', 'ql:failures', failure.group)
-      end
-    end
-
-    -- Remove it as a job that's tagged with this particular tag
-    local tags = cjson.decode(redis.call('hget', 'ql:j:' .. jid, 'tags') or '{}')
-    for i, tag in ipairs(tags) do
-      redis.call('zrem', 'ql:t:' .. tag, jid)
-      redis.call('zincrby', 'ql:tags', -1, tag)
-    end
-
-    -- If the job was being tracked, we should notify
-    if redis.call('zscore', 'ql:tracked', jid) ~= false then
-      redis.call('publish', 'canceled', jid)
-    end
-
-    -- Just go ahead and delete our data
-    redis.call('del', 'ql:j:' .. jid)
-  end
-end
-
--- Taken from: http://www.lua.org/pil/11.5.html
-local function to_set(list)
-  local set = {}
-  for _, l in ipairs(list) do set[l] = true end
-  return set
-end
-
-local jids    = assert(ARGV, 'Cancel(): Arg "jid" missing.')
-local jid_set = to_set(jids)
-
-for _, jid in ipairs(jids) do
-  cancel(jid, jid_set)
-end

data/lib/qless/qless-core/complete.lua

@@ -1,233 +0,0 @@
--- Complete(0, jid, worker, queue, now, data, [next, q, [(delay, d) | (depends, '["jid1","jid2",...]')])
--- -----------------------------------------------------------------------------------------------------
--- Complete a job and optionally put it in another queue, either scheduled or to
--- be considered waiting immediately. It can also optionally accept other jids
--- on which this job will be considered dependent before it's considered valid.
---
--- Args:
---    1) jid
---    2) worker
---    3) queue
---    4) now
---    5) data
---    *) [next, q, [delay, d]], [depends, '...']
-
-if #KEYS > 0 then error('Complete(): No Keys should be provided') end
-
-local jid    = assert(ARGV[1]               , 'Complete(): Arg "jid" missing.')
-local worker = assert(ARGV[2]               , 'Complete(): Arg "worker" missing.')
-local queue  = assert(ARGV[3]               , 'Complete(): Arg "queue" missing.')
-local now    = assert(tonumber(ARGV[4])     , 'Complete(): Arg "now" not a number or missing: ' .. tostring(ARGV[4]))
-local data   = assert(cjson.decode(ARGV[5]) , 'Complete(): Arg "data" missing or not JSON: '    .. tostring(ARGV[5]))
-
--- Read in all the optional parameters
-local options = {}
-for i = 6, #ARGV, 2 do options[ARGV[i]] = ARGV[i + 1] end
-
--- Sanity check on optional args
-local nextq   = options['next']
-local delay   = assert(tonumber(options['delay'] or 0))
-local depends = assert(cjson.decode(options['depends'] or '[]'), 'Complete(): Arg "depends" not JSON: ' .. tostring(options['depends']))
-
--- Delay and depends are not allowed together
-if delay > 0 and #depends > 0 then
-	error('Complete(): "delay" and "depends" are not allowed to be used together')
-end
-
--- Depends doesn't make sense without nextq
-if options['delay'] and nextq == nil then
-	error('Complete(): "delay" cannot be used without a "next".')
-end
-
--- Depends doesn't make sense without nextq
-if options['depends'] and nextq == nil then
-	error('Complete(): "depends" cannot be used without a "next".')
-end
-
--- The bin is midnight of the provided day
--- 24 * 60 * 60 = 86400
-local bin = now - (now % 86400)
-
--- First things first, we should see if the worker still owns this job
-local lastworker, history, state, priority, retries = unpack(redis.call('hmget', 'ql:j:' .. jid, 'worker', 'history', 'state', 'priority', 'retries', 'dependents'))
-
-if (lastworker ~= worker) or (state ~= 'running') then
-	return false
-end
-
--- Now we can assume that the worker does own the job. We need to
---    1) Remove the job from the 'locks' from the old queue
---    2) Enqueue it in the next stage if necessary
---    3) Update the data
---    4) Mark the job as completed, remove the worker, remove expires, and update history
-
--- Unpack the history, and update it
-history = cjson.decode(history)
-history[#history]['done'] = math.floor(now)
-
-if data then
-	redis.call('hset', 'ql:j:' .. jid, 'data', cjson.encode(data))
-end
-
--- Remove the job from the previous queue
-redis.call('zrem', 'ql:q:' .. queue .. '-work', jid)
-redis.call('zrem', 'ql:q:' .. queue .. '-locks', jid)
-redis.call('zrem', 'ql:q:' .. queue .. '-scheduled', jid)
-
-----------------------------------------------------------
--- This is the massive stats update that we have to do
-----------------------------------------------------------
--- This is how long we've been waiting to get popped
-local waiting = math.floor(now) - history[#history]['popped']
--- Now we'll go through the apparently long and arduous process of update
-local count, mean, vk = unpack(redis.call('hmget', 'ql:s:run:' .. bin .. ':' .. queue, 'total', 'mean', 'vk'))
-count = count or 0
-if count == 0 then
-	mean  = waiting
-	vk    = 0
-	count = 1
-else
-	count = count + 1
-	local oldmean = mean
-	mean  = mean + (waiting - mean) / count
-	vk    = vk + (waiting - mean) * (waiting - oldmean)
-end
--- Now, update the histogram
--- - `s1`, `s2`, ..., -- second-resolution histogram counts
--- - `m1`, `m2`, ..., -- minute-resolution
--- - `h1`, `h2`, ..., -- hour-resolution
--- - `d1`, `d2`, ..., -- day-resolution
-waiting = math.floor(waiting)
-if waiting < 60 then -- seconds
-	redis.call('hincrby', 'ql:s:run:' .. bin .. ':' .. queue, 's' .. waiting, 1)
-elseif waiting < 3600 then -- minutes
-	redis.call('hincrby', 'ql:s:run:' .. bin .. ':' .. queue, 'm' .. math.floor(waiting / 60), 1)
-elseif waiting < 86400 then -- hours
-	redis.call('hincrby', 'ql:s:run:' .. bin .. ':' .. queue, 'h' .. math.floor(waiting / 3600), 1)
-else -- days
-	redis.call('hincrby', 'ql:s:run:' .. bin .. ':' .. queue, 'd' .. math.floor(waiting / 86400), 1)
-end		
-redis.call('hmset', 'ql:s:run:' .. bin .. ':' .. queue, 'total', count, 'mean', mean, 'vk', vk)
-----------------------------------------------------------
-
--- Remove this job from the jobs that the worker that was running it has
-redis.call('zrem', 'ql:w:' .. worker .. ':jobs', jid)
-
-if redis.call('zscore', 'ql:tracked', jid) ~= false then
-	redis.call('publish', 'completed', jid)
-end
-
-if nextq then
-	-- Send a message out to log
-	redis.call('publish', 'ql:log', cjson.encode({
-		jid   = jid,
-		event = 'advanced',
-		queue = queue,
-		to    = nextq
-	}))
-
-	-- Enqueue the job
-	table.insert(history, {
-		q     = nextq,
-		put   = math.floor(now)
-	})
-
-	-- We're going to make sure that this queue is in the
-	-- set of known queues
-	if redis.call('zscore', 'ql:queues', nextq) == false then
-		redis.call('zadd', 'ql:queues', now, nextq)
-	end
-	
-	redis.call('hmset', 'ql:j:' .. jid, 'state', 'waiting', 'worker', '', 'failure', '{}',
-		'queue', nextq, 'expires', 0, 'history', cjson.encode(history), 'remaining', tonumber(retries))
-	
-	if delay > 0 then
-	    redis.call('zadd', 'ql:q:' .. nextq .. '-scheduled', now + delay, jid)
-		return 'scheduled'
-	else
-		-- These are the jids we legitimately have to wait on
-		local count = 0
-		for i, j in ipairs(depends) do
-			-- Make sure it's something other than 'nil' or complete.
-			local state = redis.call('hget', 'ql:j:' .. j, 'state')
-			if (state and state ~= 'complete') then
-				count = count + 1
-				redis.call('sadd', 'ql:j:' .. j .. '-dependents'  , jid)
-				redis.call('sadd', 'ql:j:' .. jid .. '-dependencies', j)
-			end
-		end
-		if count > 0 then
-			redis.call('zadd', 'ql:q:' .. nextq .. '-depends', now, jid)
-			redis.call('hset', 'ql:j:' .. jid, 'state', 'depends')
-			return 'depends'
-		else
-			redis.call('zadd', 'ql:q:' .. nextq .. '-work', priority - (now / 10000000000), jid)
-			return 'waiting'
-		end
-	end
-else
-	-- Send a message out to log
-	redis.call('publish', 'ql:log', cjson.encode({
-		jid   = jid,
-		event = 'completed',
-		queue = queue
-	}))
-
-	redis.call('hmset', 'ql:j:' .. jid, 'state', 'complete', 'worker', '', 'failure', '{}',
-		'queue', '', 'expires', 0, 'history', cjson.encode(history), 'remaining', tonumber(retries))
-	
-	-- Do the completion dance
-	local count, time = unpack(redis.call('hmget', 'ql:config', 'jobs-history-count', 'jobs-history'))
-	
-	-- These are the default values
-	count = tonumber(count or 50000)
-	time  = tonumber(time  or 7 * 24 * 60 * 60)
-	
-	-- Schedule this job for destructination eventually
-	redis.call('zadd', 'ql:completed', now, jid)
-	
-	-- Now look at the expired job data. First, based on the current time
-	local jids = redis.call('zrangebyscore', 'ql:completed', 0, now - time)
-	-- Any jobs that need to be expired... delete
-	for index, jid in ipairs(jids) do
-		local tags = cjson.decode(redis.call('hget', 'ql:j:' .. jid, 'tags') or '{}')
-		for i, tag in ipairs(tags) do
-			redis.call('zrem', 'ql:t:' .. tag, jid)
-			redis.call('zincrby', 'ql:tags', -1, tag)
-		end
-		redis.call('del', 'ql:j:' .. jid)
-	end
-	-- And now remove those from the queued-for-cleanup queue
-	redis.call('zremrangebyscore', 'ql:completed', 0, now - time)
-	
-	-- Now take the all by the most recent 'count' ids
-	jids = redis.call('zrange', 'ql:completed', 0, (-1-count))
-	for index, jid in ipairs(jids) do
-		local tags = cjson.decode(redis.call('hget', 'ql:j:' .. jid, 'tags') or '{}')
-		for i, tag in ipairs(tags) do
-			redis.call('zrem', 'ql:t:' .. tag, jid)
-			redis.call('zincrby', 'ql:tags', -1, tag)
-		end
-		redis.call('del', 'ql:j:' .. jid)
-	end
-	redis.call('zremrangebyrank', 'ql:completed', 0, (-1-count))
-	
-	-- Alright, if this has any dependents, then we should go ahead
-	-- and unstick those guys.
-	for i, j in ipairs(redis.call('smembers', 'ql:j:' .. jid .. '-dependents')) do
-		redis.call('srem', 'ql:j:' .. j .. '-dependencies', jid)
-		if redis.call('scard', 'ql:j:' .. j .. '-dependencies') == 0 then
-			local q, p = unpack(redis.call('hmget', 'ql:j:' .. j, 'queue', 'priority'))
-			if q then
-				redis.call('zrem', 'ql:q:' .. q .. '-depends', j)
-				redis.call('zadd', 'ql:q:' .. q .. '-work', p, j)
-				redis.call('hset', 'ql:j:' .. j, 'state', 'waiting')
-			end
-		end
-	end
-	
-	-- Delete our dependents key
-	redis.call('del', 'ql:j:' .. jid .. '-dependents')
-	
-	return 'complete'
-end