qiita-markdown 0.44.0 → 1.0.0

data/spec/qiita/markdown/processor_spec.rb

@@ -69,16 +69,12 @@ describe Qiita::Markdown::Processor do
 
         it "adds ID for ToC" do
           should eq <<-HTML.strip_heredoc
-
             <h1>
             <span id="a" class="fragment"></span><a href="#a"><i class="fa fa-link"></i></a>a</h1>
-
             <h2>
             <span id="a-1" class="fragment"></span><a href="#a-1"><i class="fa fa-link"></i></a>a</h2>
-
             <h3>
             <span id="a-2" class="fragment"></span><a href="#a-2"><i class="fa fa-link"></i></a>a</h3>
-
             <h3>
             <span id="a-3" class="fragment"></span><a href="#a-3"><i class="fa fa-link"></i></a>a</h3>
           HTML
@@ -94,7 +90,6 @@ describe Qiita::Markdown::Processor do
 
         it "generates fragment identifier by sanitizing the special characters in the title" do
           should eq <<-HTML.strip_heredoc
-
             <h1>
             <span id="rb" class="fragment"></span><a href="#rb"><i class="fa fa-link"></i></a><b>R&amp;B</b>
             </h1>
@@ -109,9 +104,10 @@ describe Qiita::Markdown::Processor do
           MARKDOWN
         end
 
-        it "does nothing" do
+        it "adds ID for ToC" do
           should eq <<-HTML.strip_heredoc
-            <h1>foo</h1>
+            <h1>
+            <span id="foo" class="fragment"></span><a href="#foo"><i class="fa fa-link"></i></a>foo</h1>
           HTML
         end
       end
@@ -250,7 +246,7 @@ describe Qiita::Markdown::Processor do
             foo
 
             </code></pre></div></div>
-           HTML
+          HTML
         end
       end
 
@@ -383,7 +379,7 @@ describe Qiita::Markdown::Processor do
 
       context "with @all and allowed_usernames context" do
         before do
-          context[:allowed_usernames] = ["alice", "bob"]
+          context[:allowed_usernames] = %w[alice bob]
         end
 
         let(:markdown) do
@@ -400,7 +396,7 @@ describe Qiita::Markdown::Processor do
 
       context "with @all and @alice" do
         before do
-          context[:allowed_usernames] = ["alice", "bob"]
+          context[:allowed_usernames] = %w[alice bob]
         end
 
         let(:markdown) do
@@ -517,7 +513,7 @@ describe Qiita::Markdown::Processor do
         it "creates link for that with .autolink class" do
           should eq(
             '<p><a href="http://example.com/search?q=%E6%97%A5%E6%9C%AC%E8%AA%9E" class="autolink">' \
-            "http://example.com/search?q=日本語</a></p>\n"
+            "http://example.com/search?q=日本語</a></p>\n",
           )
         end
       end
@@ -586,8 +582,8 @@ describe Qiita::Markdown::Processor do
         end
 
         it "wraps it in a element while keeping the width attribute" do
-          should eq %(<p><a href="http://example.com/b.png" target="_blank">) +
-                    %(<img width="80" height="48" alt="a" src="http://example.com/b.png"></a></p>\n)
+          should eq %(<a href="http://example.com/b.png" target="_blank">) +
+                    %(<img width="80" height="48" alt="a" src="http://example.com/b.png"></a>\n)
         end
       end
 
@@ -613,7 +609,7 @@ describe Qiita::Markdown::Processor do
 
       context "with font element with color attribute" do
         let(:markdown) do
-          %[<font color="red">test</font>]
+          %(<font color="red">test</font>)
         end
 
         it "allows font element with color attribute" do
@@ -647,7 +643,7 @@ describe Qiita::Markdown::Processor do
         let(:markdown) do
           <<-MARKDOWN.strip_heredoc
             - [ ] a
-             - [ ] b
+              - [ ] b
           MARKDOWN
         end
 
@@ -656,7 +652,6 @@ describe Qiita::Markdown::Processor do
             <ul>
             <li class="task-list-item">
             <input type="checkbox" class="task-list-item-checkbox" disabled>a
-
             <ul>
             <li class="task-list-item">
             <input type="checkbox" class="task-list-item-checkbox" disabled>b</li>
@@ -698,8 +693,12 @@ describe Qiita::Markdown::Processor do
         it "inserts checkbox" do
           should eq <<-HTML.strip_heredoc
             <ul>
-            <li class="task-list-item"><p><input type="checkbox" class="task-list-item-checkbox" disabled>a</p></li>
-            <li class="task-list-item"><p><input type="checkbox" class="task-list-item-checkbox" checked disabled>b</p></li>
+            <li class="task-list-item">
+            <p><input type="checkbox" class="task-list-item-checkbox" disabled>a</p>
+            </li>
+            <li class="task-list-item">
+            <p><input type="checkbox" class="task-list-item-checkbox" checked disabled>b</p>
+            </li>
             </ul>
           HTML
         end
@@ -759,20 +758,7 @@ describe Qiita::Markdown::Processor do
         end
 
         it "generates footnotes elements" do
-          should eq <<-HTML.strip_heredoc
-            <p><sup id="fnref1"><a href="#fn1" title="test">1</a></sup></p>
-
-            <div class="footnotes">
-            <hr>
-            <ol>
-
-            <li id="fn1">
-            <p>test <a href="#fnref1">↩</a></p>
-            </li>
-
-            </ol>
-            </div>
-          HTML
+          should include('class="footnotes"')
         end
       end
 
@@ -837,14 +823,15 @@ describe Qiita::Markdown::Processor do
 
         it "does not generate footnote elements" do
           should eq <<-HTML.strip_heredoc
-            <p><a href="test">^1</a></p>
+            <p>[^1]<br>
+            [^1]: test</p>
           HTML
         end
       end
 
       context "with emoji_names and emoji_url_generator context" do
         before do
-          context[:emoji_names] = %w(foo o)
+          context[:emoji_names] = %w[foo o]
 
           context[:emoji_url_generator] = proc do |emoji_name|
             "https://example.com/foo.png" if emoji_name == "foo"
@@ -860,11 +847,11 @@ describe Qiita::Markdown::Processor do
         it "replaces only the specified emoji names with img elements with custom URL" do
           should include(
             '<img class="emoji" title=":foo:" alt=":foo:" src="https://example.com/foo.png"',
-            '<img class="emoji" title=":o:" alt=":o:" src="/images/emoji/unicode/2b55.png"'
+            '<img class="emoji" title=":o:" alt=":o:" src="/images/emoji/unicode/2b55.png"',
           )
 
           should_not include(
-            '<img class="emoji" title=":x:" alt=":x:"'
+            '<img class="emoji" title=":x:" alt=":x:"',
           )
         end
       end
@@ -881,7 +868,7 @@ describe Qiita::Markdown::Processor do
         it "creates link which does not have rel='nofollow noopener' and target='_blank'" do
           should eq(
             '<p><a href="http://qiita.com/?a=b" class="autolink">' \
-            "http://qiita.com/?a=b</a></p>\n"
+            "http://qiita.com/?a=b</a></p>\n",
           )
         end
       end
@@ -898,7 +885,7 @@ describe Qiita::Markdown::Processor do
         it "creates link which has rel='nofollow noopener' and target='_blank'" do
           should eq(
             '<p><a href="http://external.com/?a=b" class="autolink" rel="nofollow noopener" target="_blank">' \
-            "http://external.com/?a=b</a></p>\n"
+            "http://external.com/?a=b</a></p>\n",
           )
         end
       end
@@ -914,7 +901,7 @@ describe Qiita::Markdown::Processor do
 
         it "creates link which does not have rel='nofollow noopener' and target='_blank'" do
           should eq(
-            "<p><a href=\"http://qiita.com/?a=b\">foobar</a></p>\n"
+            "<p><a href=\"http://qiita.com/?a=b\">foobar</a></p>\n",
           )
         end
       end
@@ -930,7 +917,7 @@ describe Qiita::Markdown::Processor do
 
         it "creates link which has rel='nofollow noopener' and target='_blank'" do
           should eq(
-            "<p><a href=\"http://external.com/?a=b\" rel=\"nofollow noopener\" target=\"_blank\">foobar</a></p>\n"
+            "<p><a href=\"http://external.com/?a=b\" rel=\"nofollow noopener\" target=\"_blank\">foobar</a></p>\n",
           )
         end
       end
@@ -947,7 +934,7 @@ describe Qiita::Markdown::Processor do
         it "creates link which has rel='nofollow noopener' and target='_blank'" do
           should eq(
             '<p><a href="http://qqqqqqiita.com/?a=b" class="autolink" rel="nofollow noopener" target="_blank">' \
-            "http://qqqqqqiita.com/?a=b</a></p>\n"
+            "http://qqqqqqiita.com/?a=b</a></p>\n",
           )
         end
       end
@@ -963,7 +950,7 @@ describe Qiita::Markdown::Processor do
 
         it "creates link which has rel='nofollow noopener' and target='_blank'" do
           should eq(
-            "<p><a href=\"http://qqqqqqiita.com/?a=b\" rel=\"nofollow noopener\" target=\"_blank\">foobar</a></p>\n"
+            "<p><a href=\"http://qqqqqqiita.com/?a=b\" rel=\"nofollow noopener\" target=\"_blank\">foobar</a></p>\n",
           )
         end
       end
@@ -980,7 +967,7 @@ describe Qiita::Markdown::Processor do
         it "creates link which has rel='nofollow noopener' and target='_blank'" do
           should eq(
             '<p><a href="http://sub.qiita.com/?a=b" class="autolink" rel="nofollow noopener" target="_blank">' \
-            "http://sub.qiita.com/?a=b</a></p>\n"
+            "http://sub.qiita.com/?a=b</a></p>\n",
           )
         end
       end
@@ -996,7 +983,7 @@ describe Qiita::Markdown::Processor do
 
         it "creates link which has rel='nofollow noopener' and target='_blank', and rel value is overwritten" do
           should eq(
-            "<p><a href=\"http://external.com/?a=b\" rel=\"nofollow noopener\" target=\"_blank\">foobar</a></p>\n"
+            "<p><a href=\"http://external.com/?a=b\" rel=\"nofollow noopener\" target=\"_blank\">foobar</a></p>\n",
           )
         end
       end
@@ -1085,13 +1072,10 @@ describe Qiita::Markdown::Processor do
 
         it "returns HTML output parsed as markdown" do
           expect(subject).to eq <<-HTML.strip_heredoc
-            <p><details><summary>Folding sample</summary><div>
-
+            <details><summary>Folding sample</summary><div>
             <div class="code-frame" data-lang="rb"><div class="highlight"><pre class="codehilite"><code><span class="nb">puts</span> <span class="s2">"Hello, World"</span>
             </code></pre></div></div>
-
-            <p></p>
-            </div></details></p>
+            </div></details>
           HTML
         end
       end
@@ -1425,14 +1409,14 @@ describe Qiita::Markdown::Processor do
         if allowed
           it "does not sanitize embed code" do
             should eq <<-HTML.strip_heredoc
-              <p data-height="1" data-theme-id="0" data-slug-hash="foo" data-default-tab="bar" data-user="baz" data-embed-version="2" data-pen-title="qux" class="codepen"></p>\n
+              <p data-height="1" data-theme-id="0" data-slug-hash="foo" data-default-tab="bar" data-user="baz" data-embed-version="2" data-pen-title="qux" class="codepen"></p>
               <script src="https://production-assets.codepen.io/assets/embed/ei.js"></script>
             HTML
           end
         else
           it "forces async attribute on script" do
             should eq <<-HTML.strip_heredoc
-              <p data-height="1" data-theme-id="0" data-slug-hash="foo" data-default-tab="bar" data-user="baz" data-embed-version="2" data-pen-title="qux" class="codepen"></p>\n
+              <p data-height="1" data-theme-id="0" data-slug-hash="foo" data-default-tab="bar" data-user="baz" data-embed-version="2" data-pen-title="qux" class="codepen"></p>
               <script src="https://production-assets.codepen.io/assets/embed/ei.js" async="async"></script>
             HTML
           end
@@ -1450,14 +1434,14 @@ describe Qiita::Markdown::Processor do
         if allowed
           it "does not sanitize embed code" do
             should eq <<-HTML.strip_heredoc
-              <p data-height="1" data-theme-id="0" data-slug-hash="foo" data-default-tab="bar" data-user="baz" data-embed-version="2" data-pen-title="qux" class="codepen"></p>\n
+              <p data-height="1" data-theme-id="0" data-slug-hash="foo" data-default-tab="bar" data-user="baz" data-embed-version="2" data-pen-title="qux" class="codepen"></p>
               <script src="https://static.codepen.io/assets/embed/ei.js"></script>
             HTML
           end
         else
           it "forces async attribute on script" do
             should eq <<-HTML.strip_heredoc
-              <p data-height="1" data-theme-id="0" data-slug-hash="foo" data-default-tab="bar" data-user="baz" data-embed-version="2" data-pen-title="qux" class="codepen"></p>\n
+              <p data-height="1" data-theme-id="0" data-slug-hash="foo" data-default-tab="bar" data-user="baz" data-embed-version="2" data-pen-title="qux" class="codepen"></p>
               <script src="https://static.codepen.io/assets/embed/ei.js" async="async"></script>
             HTML
           end
@@ -1747,7 +1731,7 @@ describe Qiita::Markdown::Processor do
 
         it "does not sanitize embed code" do
           should eq <<-HTML.strip_heredoc
-            <blockquote class="twitter-tweet" data-lang="es" data-cards="hidden" data-conversation="none">foo</blockquote>\n
+            <blockquote class="twitter-tweet" data-lang="es" data-cards="hidden" data-conversation="none">foo</blockquote>
             <script async src="https://platform.twitter.com/widgets.js"></script>
           HTML
         end
@@ -1809,14 +1793,16 @@ describe Qiita::Markdown::Processor do
           if allowed
             it "returns simple div element" do
               should eq <<-HTML.strip_heredoc
-                <div data-type="customblock">Some kind of text is here.
+                <div data-type="customblock" data-metadata="">
+                <p>Some kind of text is here.</p>
                 </div>
               HTML
             end
           else
             it "returns simple div element" do
               should eq <<-HTML.strip_heredoc
-                <div>Some kind of text is here.
+                <div>
+                <p>Some kind of text is here.</p>
                 </div>
               HTML
             end
@@ -1829,14 +1815,16 @@ describe Qiita::Markdown::Processor do
           if allowed
             it "returns simple div element" do
               should eq <<-HTML.strip_heredoc
-                <div data-type="customblock" data-metadata="anytype">Some kind of text is here.
+                <div data-type="customblock" data-metadata="anytype">
+                <p>Some kind of text is here.</p>
                 </div>
               HTML
             end
           else
             it "returns simple div element" do
               should eq <<-HTML.strip_heredoc
-                <div>Some kind of text is here.
+                <div>
+                <p>Some kind of text is here.</p>
                 </div>
               HTML
             end
@@ -1851,8 +1839,9 @@ describe Qiita::Markdown::Processor do
               it "returns info note block with class including icon as default type" do
                 should eq <<-HTML.strip_heredoc
                   <div data-type="customblock" data-metadata="note" class="note info">
-                  <span class="fa fa-fw fa-check-circle"></span><p>Some kind of text is here.
-                  </p>
+                  <span class="fa fa-fw fa-check-circle"></span><div>
+                  <p>Some kind of text is here.</p>
+                  </div>
                   </div>
                 HTML
               end
@@ -1860,8 +1849,9 @@ describe Qiita::Markdown::Processor do
               it "returns note block with class including icon" do
                 should eq <<-HTML.strip_heredoc
                   <div class="note info">
-                  <span class="fa fa-fw fa-check-circle"></span><p>Some kind of text is here.
-                  </p>
+                  <span class="fa fa-fw fa-check-circle"></span><div>
+                  <p>Some kind of text is here.</p>
+                  </div>
                   </div>
                 HTML
               end
@@ -1875,8 +1865,9 @@ describe Qiita::Markdown::Processor do
               it "returns warning note block with class including icon" do
                 should eq <<-HTML.strip_heredoc
                   <div data-type="customblock" data-metadata="note warn" class="note warn">
-                  <span class="fa fa-fw fa-exclamation-circle"></span><p>Some kind of text is here.
-                  </p>
+                  <span class="fa fa-fw fa-exclamation-circle"></span><div>
+                  <p>Some kind of text is here.</p>
+                  </div>
                   </div>
                 HTML
               end
@@ -1884,8 +1875,9 @@ describe Qiita::Markdown::Processor do
               it "returns note block with class including icon" do
                 should eq <<-HTML.strip_heredoc
                   <div class="note warn">
-                  <span class="fa fa-fw fa-exclamation-circle"></span><p>Some kind of text is here.
-                  </p>
+                  <span class="fa fa-fw fa-exclamation-circle"></span><div>
+                  <p>Some kind of text is here.</p>
+                  </div>
                   </div>
                 HTML
               end
@@ -1899,8 +1891,9 @@ describe Qiita::Markdown::Processor do
               it "returns alerting note block with class including icon" do
                 should eq <<-HTML.strip_heredoc
                   <div data-type="customblock" data-metadata="note alert" class="note alert">
-                  <span class="fa fa-fw fa-times-circle"></span><p>Some kind of text is here.
-                  </p>
+                  <span class="fa fa-fw fa-times-circle"></span><div>
+                  <p>Some kind of text is here.</p>
+                  </div>
                   </div>
                 HTML
               end
@@ -1908,8 +1901,9 @@ describe Qiita::Markdown::Processor do
               it "returns note block with class including icon" do
                 should eq <<-HTML.strip_heredoc
                   <div class="note alert">
-                  <span class="fa fa-fw fa-times-circle"></span><p>Some kind of text is here.
-                  </p>
+                  <span class="fa fa-fw fa-times-circle"></span><div>
+                  <p>Some kind of text is here.</p>
+                  </div>
                   </div>
                 HTML
               end

data/spec/qiita/markdown/summary_processor_spec.rb

@@ -11,7 +11,7 @@ describe Qiita::Markdown::SummaryProcessor do
     end
 
     let(:markdown) do
-      fail NotImplementedError
+      raise NotImplementedError
     end
 
     let(:result) do
@@ -111,7 +111,6 @@ describe Qiita::Markdown::SummaryProcessor do
       it "flattens them" do
         should eq <<-EOS.strip_heredoc
           Lorem ipsum dolor sit amet.
-
           Consectetur adipisicing elit.
         EOS
       end
@@ -240,7 +239,7 @@ describe Qiita::Markdown::SummaryProcessor do
       end
 
       it "replaces mention with link" do
-        should eq %{<a href="/alice" class="user-mention js-hovercard" title="alice" data-hovercard-target-type="user" data-hovercard-target-name="alice">@alice</a>\n}
+        should eq %(<a href="/alice" class="user-mention js-hovercard" title="alice" data-hovercard-target-type="user" data-hovercard-target-name="alice">@alice</a>\n)
       end
     end
 
@@ -254,7 +253,8 @@ describe Qiita::Markdown::SummaryProcessor do
 
       it "does not generate footnote elements by default" do
         should eq <<-EOS.strip_heredoc
-          <a href="test">^1</a>
+          [^1]
+          [^1]: test
         EOS
       end
     end