qiita-markdown 0.43.0 → 0.44.1

data/qiita-markdown.gemspec

@@ -1,4 +1,4 @@
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "qiita/markdown/version"
 
@@ -13,26 +13,26 @@ Gem::Specification.new do |spec|
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
   spec.required_ruby_version = ">= 2.6.0"
 
+  spec.add_dependency "addressable"
   spec.add_dependency "gemoji"
   spec.add_dependency "github-linguist", "~> 4.0"
+  spec.add_dependency "greenmat", "3.5.1.4"
   spec.add_dependency "html-pipeline", "~> 2.0"
   spec.add_dependency "mem"
   spec.add_dependency "rouge", "3.26.0"
-  spec.add_dependency "greenmat", "3.5.1.4"
   spec.add_dependency "sanitize"
-  spec.add_dependency "addressable"
   spec.add_development_dependency "activesupport", "~> 5.2.7"
   spec.add_development_dependency "benchmark-ips", "~> 1.2"
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "codeclimate-test-reporter", "0.4.4"
-  spec.add_development_dependency "simplecov", "!= 0.18.0", "!= 0.18.1", "!= 0.18.2", "!= 0.18.3", "!= 0.18.4", "!= 0.18.5", "!= 0.19.0", "!= 0.19.1"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.1"
-  spec.add_development_dependency "rubocop", "~> 1.27.0"
+  spec.add_development_dependency "rubocop", "~> 1.39.0"
+  spec.add_development_dependency "simplecov", "!= 0.18.0", "!= 0.18.1", "!= 0.18.2", "!= 0.18.3", "!= 0.18.4", "!= 0.18.5", "!= 0.19.0", "!= 0.19.1"
+  spec.metadata["rubygems_mfa_required"] = "true"
 end

data/spec/qiita/markdown/filters/checkbox_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+describe Qiita::Markdown::Filters::Checkbox do
+  subject(:filter) do
+    described_class.new(input_html)
+  end
+
+  context "with checkbox" do
+    let(:input_html) do
+      <<~HTML
+        <li>[ ] a</li>
+        <li>[x] a</li>
+      HTML
+    end
+
+    let(:output_html) do
+      <<~HTML
+        <li class="task-list-item">
+        <input type="checkbox" class="task-list-item-checkbox" disabled>a</li>
+        <li class="task-list-item">
+        <input type="checkbox" class="task-list-item-checkbox" checked disabled>a</li>
+      HTML
+    end
+
+    it "replaces checkboxes" do
+      expect(filter.call.to_s).to eq(output_html)
+    end
+
+    context "when input html has many spaces after checkbox mark" do
+      let(:input_html) do
+        <<~HTML
+          <li>[ ]    a</li>
+          <li>[x]    a</li>
+        HTML
+      end
+
+      it "replaces checkboxes and remove spaces" do
+        expect(filter.call.to_s).to eq(output_html)
+      end
+    end
+  end
+end

data/spec/qiita/markdown/processor_spec.rb

@@ -250,7 +250,7 @@ describe Qiita::Markdown::Processor do
             foo
 
             </code></pre></div></div>
-           HTML
+          HTML
         end
       end
 
@@ -383,7 +383,7 @@ describe Qiita::Markdown::Processor do
 
       context "with @all and allowed_usernames context" do
         before do
-          context[:allowed_usernames] = ["alice", "bob"]
+          context[:allowed_usernames] = %w[alice bob]
         end
 
         let(:markdown) do
@@ -400,7 +400,7 @@ describe Qiita::Markdown::Processor do
 
       context "with @all and @alice" do
         before do
-          context[:allowed_usernames] = ["alice", "bob"]
+          context[:allowed_usernames] = %w[alice bob]
         end
 
         let(:markdown) do
@@ -517,7 +517,7 @@ describe Qiita::Markdown::Processor do
         it "creates link for that with .autolink class" do
           should eq(
             '<p><a href="http://example.com/search?q=%E6%97%A5%E6%9C%AC%E8%AA%9E" class="autolink">' \
-            "http://example.com/search?q=日本語</a></p>\n"
+            "http://example.com/search?q=日本語</a></p>\n",
           )
         end
       end
@@ -613,7 +613,7 @@ describe Qiita::Markdown::Processor do
 
       context "with font element with color attribute" do
         let(:markdown) do
-          %[<font color="red">test</font>]
+          %(<font color="red">test</font>)
         end
 
         it "allows font element with color attribute" do
@@ -844,7 +844,7 @@ describe Qiita::Markdown::Processor do
 
       context "with emoji_names and emoji_url_generator context" do
         before do
-          context[:emoji_names] = %w(foo o)
+          context[:emoji_names] = %w[foo o]
 
           context[:emoji_url_generator] = proc do |emoji_name|
             "https://example.com/foo.png" if emoji_name == "foo"
@@ -860,11 +860,11 @@ describe Qiita::Markdown::Processor do
         it "replaces only the specified emoji names with img elements with custom URL" do
           should include(
             '<img class="emoji" title=":foo:" alt=":foo:" src="https://example.com/foo.png"',
-            '<img class="emoji" title=":o:" alt=":o:" src="/images/emoji/unicode/2b55.png"'
+            '<img class="emoji" title=":o:" alt=":o:" src="/images/emoji/unicode/2b55.png"',
           )
 
           should_not include(
-            '<img class="emoji" title=":x:" alt=":x:"'
+            '<img class="emoji" title=":x:" alt=":x:"',
           )
         end
       end
@@ -881,7 +881,7 @@ describe Qiita::Markdown::Processor do
         it "creates link which does not have rel='nofollow noopener' and target='_blank'" do
           should eq(
             '<p><a href="http://qiita.com/?a=b" class="autolink">' \
-            "http://qiita.com/?a=b</a></p>\n"
+            "http://qiita.com/?a=b</a></p>\n",
           )
         end
       end
@@ -898,7 +898,7 @@ describe Qiita::Markdown::Processor do
         it "creates link which has rel='nofollow noopener' and target='_blank'" do
           should eq(
             '<p><a href="http://external.com/?a=b" class="autolink" rel="nofollow noopener" target="_blank">' \
-            "http://external.com/?a=b</a></p>\n"
+            "http://external.com/?a=b</a></p>\n",
           )
         end
       end
@@ -914,7 +914,7 @@ describe Qiita::Markdown::Processor do
 
         it "creates link which does not have rel='nofollow noopener' and target='_blank'" do
           should eq(
-            "<p><a href=\"http://qiita.com/?a=b\">foobar</a></p>\n"
+            "<p><a href=\"http://qiita.com/?a=b\">foobar</a></p>\n",
           )
         end
       end
@@ -930,7 +930,7 @@ describe Qiita::Markdown::Processor do
 
         it "creates link which has rel='nofollow noopener' and target='_blank'" do
           should eq(
-            "<p><a href=\"http://external.com/?a=b\" rel=\"nofollow noopener\" target=\"_blank\">foobar</a></p>\n"
+            "<p><a href=\"http://external.com/?a=b\" rel=\"nofollow noopener\" target=\"_blank\">foobar</a></p>\n",
           )
         end
       end
@@ -947,7 +947,7 @@ describe Qiita::Markdown::Processor do
         it "creates link which has rel='nofollow noopener' and target='_blank'" do
           should eq(
             '<p><a href="http://qqqqqqiita.com/?a=b" class="autolink" rel="nofollow noopener" target="_blank">' \
-            "http://qqqqqqiita.com/?a=b</a></p>\n"
+            "http://qqqqqqiita.com/?a=b</a></p>\n",
           )
         end
       end
@@ -963,7 +963,7 @@ describe Qiita::Markdown::Processor do
 
         it "creates link which has rel='nofollow noopener' and target='_blank'" do
           should eq(
-            "<p><a href=\"http://qqqqqqiita.com/?a=b\" rel=\"nofollow noopener\" target=\"_blank\">foobar</a></p>\n"
+            "<p><a href=\"http://qqqqqqiita.com/?a=b\" rel=\"nofollow noopener\" target=\"_blank\">foobar</a></p>\n",
           )
         end
       end
@@ -980,7 +980,7 @@ describe Qiita::Markdown::Processor do
         it "creates link which has rel='nofollow noopener' and target='_blank'" do
           should eq(
             '<p><a href="http://sub.qiita.com/?a=b" class="autolink" rel="nofollow noopener" target="_blank">' \
-            "http://sub.qiita.com/?a=b</a></p>\n"
+            "http://sub.qiita.com/?a=b</a></p>\n",
           )
         end
       end
@@ -996,7 +996,7 @@ describe Qiita::Markdown::Processor do
 
         it "creates link which has rel='nofollow noopener' and target='_blank', and rel value is overwritten" do
           should eq(
-            "<p><a href=\"http://external.com/?a=b\" rel=\"nofollow noopener\" target=\"_blank\">foobar</a></p>\n"
+            "<p><a href=\"http://external.com/?a=b\" rel=\"nofollow noopener\" target=\"_blank\">foobar</a></p>\n",
           )
         end
       end
@@ -1620,6 +1620,44 @@ describe Qiita::Markdown::Processor do
         end
       end
 
+      context "with HTML embed code for Figma" do
+        shared_examples "embed code figma example" do
+          let(:markdown) do
+            <<-MARKDOWN.strip_heredoc
+              <iframe style="border: 1px solid rgba(0, 0, 0, 0.1);" width="100" height="100" src="#{url}"></iframe>
+            MARKDOWN
+          end
+          let(:url) { "#{scheme}//www.figma.com/embed?embed_host=share&url=https%3A%2F%2Fwww.figma.com" }
+          let(:encoded_url) { CGI.escapeHTML(url) }
+
+          if allowed
+            it "does not sanitize embed code" do
+              should eq <<-HTML.strip_heredoc
+                <iframe style="border: 1px solid rgba(0, 0, 0, 0.1);" width="100" height="100" src="#{encoded_url}"></iframe>
+              HTML
+            end
+          else
+            it "forces width attribute on iframe" do
+              should eq <<-HTML.strip_heredoc
+                <iframe style="border: 1px solid rgba(0, 0, 0, 0.1);" width="100%" height="100" src="#{encoded_url}"></iframe>
+              HTML
+            end
+          end
+        end
+
+        context "with scheme" do
+          let(:scheme) { "https:" }
+
+          include_examples "embed code figma example"
+        end
+
+        context "without scheme" do
+          let(:scheme) { "" }
+
+          include_examples "embed code figma example"
+        end
+      end
+
       context "with HTML embed code for SpeekerDeck" do
         let(:markdown) do
           <<-MARKDOWN.strip_heredoc

data/spec/qiita/markdown/summary_processor_spec.rb

@@ -11,7 +11,7 @@ describe Qiita::Markdown::SummaryProcessor do
     end
 
     let(:markdown) do
-      fail NotImplementedError
+      raise NotImplementedError
     end
 
     let(:result) do
@@ -240,7 +240,7 @@ describe Qiita::Markdown::SummaryProcessor do
       end
 
       it "replaces mention with link" do
-        should eq %{<a href="/alice" class="user-mention js-hovercard" title="alice" data-hovercard-target-type="user" data-hovercard-target-name="alice">@alice</a>\n}
+        should eq %(<a href="/alice" class="user-mention js-hovercard" title="alice" data-hovercard-target-type="user" data-hovercard-target-name="alice">@alice</a>\n)
       end
     end
 

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: qiita-markdown
 version: !ruby/object:Gem::Version
-  version: 0.43.0
+  version: 0.44.1
 platform: ruby
 authors:
 - Ryo Nakamura
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-10-14 00:00:00.000000000 Z
+date: 2022-11-16 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: addressable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: gemoji
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: greenmat
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.5.1.4
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.5.1.4
 - !ruby/object:Gem::Dependency
   name: html-pipeline
   requirement: !ruby/object:Gem::Requirement
@@ -80,20 +108,6 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 3.26.0
-- !ruby/object:Gem::Dependency
-  name: greenmat
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 3.5.1.4
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 3.5.1.4
 - !ruby/object:Gem::Dependency
   name: sanitize
   requirement: !ruby/object:Gem::Requirement
@@ -108,20 +122,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: addressable
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -178,6 +178,62 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 0.4.4
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.1'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.39.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.39.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -234,63 +290,7 @@ dependencies:
     - - "!="
       - !ruby/object:Gem::Version
         version: 0.19.1
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.1'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.27.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.27.0
-description:
+description: 
 email:
 - r7kamura@gmail.com
 executables: []
@@ -315,6 +315,7 @@ files:
 - lib/qiita/markdown/embed/asciinema.rb
 - lib/qiita/markdown/embed/code_pen.rb
 - lib/qiita/markdown/embed/docswell.rb
+- lib/qiita/markdown/embed/figma.rb
 - lib/qiita/markdown/embed/google_slide.rb
 - lib/qiita/markdown/embed/slide_share.rb
 - lib/qiita/markdown/embed/speeker_deck.rb
@@ -348,6 +349,7 @@ files:
 - lib/qiita/markdown/transformers/strip_invalid_node.rb
 - lib/qiita/markdown/version.rb
 - qiita-markdown.gemspec
+- spec/qiita/markdown/filters/checkbox_spec.rb
 - spec/qiita/markdown/filters/greenmat_spec.rb
 - spec/qiita/markdown/filters/inline_code_color_spec.rb
 - spec/qiita/markdown/greenmat/html_toc_renderer_spec.rb
@@ -357,8 +359,9 @@ files:
 homepage: https://github.com/increments/qiita-markdown
 licenses:
 - MIT
-metadata: {}
-post_install_message:
+metadata:
+  rubygems_mfa_required: 'true'
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -373,14 +376,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key:
+rubygems_version: 3.1.6
+signing_key: 
 specification_version: 4
 summary: Qiita-specified markdown processor.
-test_files:
-- spec/qiita/markdown/filters/greenmat_spec.rb
-- spec/qiita/markdown/filters/inline_code_color_spec.rb
-- spec/qiita/markdown/greenmat/html_toc_renderer_spec.rb
-- spec/qiita/markdown/processor_spec.rb
-- spec/qiita/markdown/summary_processor_spec.rb
-- spec/spec_helper.rb
+test_files: []