qiita-markdown 0.43.0 → 0.44.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 925ca9666fc91e263d0b8fb4d704900d52b92964d6d53d63730d84403304df3b
-  data.tar.gz: 47a27d59b58ced30484eadfc1dd59bfb94f96673a6e5e20fafc76f19c10065ea
+  metadata.gz: bb18cd9f37329069980cc0322cff454cb1dcbd57ad3fe6836f40b3d8e968e304
+  data.tar.gz: ad7d5e7d89eeb283616d04e2fbdc8a1bb2b090897bf1538f6033d061cbe8d958
 SHA512:
-  metadata.gz: d0613208602c957acd488a6050095a5ba79cc085fa08a8c18aa6ea98711e3ca61313cd68a9d166308b4d1cdd6efabe98e8a364c92635c82084374d765b069759
-  data.tar.gz: 9ac8835a36b9871c02981d64ee335fd8e7a1a390825e81f5536e57af0b4d5be5d5004236d40f45409294a73a739aa01d0a814d9a30d5e20643b3c6a725682faf
+  metadata.gz: 4f38820e6f6eafd5135f7d6788e9b0f31ff45b42e85afc0ffb14213e263bb951250f734b1473cf1ffbcc21a5b22d823aed16235ab06bf2f218c39ff9aa59a42f
+  data.tar.gz: 0f4b493d2cb3c06de1c2a7d68455f39a9e496d2ae95ed6ff845b8caf3367128ae0ca863a937b44ddb87147573b261178bd6573c4c6042de14a19c7c56d3e5ca1

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## Unreleased
 
+## 0.44.0
+
+- Support Figma embedding scripts
+- Fix bug of checkbox filter
+
 ## 0.43.0
 
 - Fix GitHub Actions can't be executed when public fork

data/lib/qiita/markdown/embed/figma.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module Qiita
+  module Markdown
+    module Embed
+      module Figma
+        SCRIPT_HOST = "www.figma.com"
+      end
+    end
+  end
+end

data/lib/qiita/markdown/filters/checkbox.rb

@@ -31,7 +31,7 @@ module Qiita
           end
 
           def convert
-            first_text_node.content = first_text_node.content.sub(checkbox_mark, "")
+            first_text_node.content = first_text_node.content.sub(checkbox_mark, "").lstrip
             first_text_node.add_previous_sibling(checkbox_node)
             @node["class"] = "task-list-item"
           end

data/lib/qiita/markdown/filters/final_sanitizer.rb

@@ -97,8 +97,9 @@ module Qiita
           },
           css: {
             properties: [
-              "text-align",
               "background-color",
+              "border",
+              "text-align",
             ],
           },
           elements: [

data/lib/qiita/markdown/filters/user_input_sanitizer.rb

@@ -48,7 +48,10 @@ module Qiita
             "q"          => { "cite" => ["http", "https", :relative] },
           },
           css: {
-            properties: %w[text-align],
+            properties: %w[
+              text-align
+              border
+            ],
           },
           transformers: [
             Transformers::FilterAttributes,

data/lib/qiita/markdown/transformers/filter_iframe.rb

@@ -10,6 +10,7 @@ module Qiita
           Embed::SlideShare::SCRIPT_HOST,
           Embed::GoogleSlide::SCRIPT_HOST,
           Embed::Docswell::SCRIPT_HOSTS,
+          Embed::Figma::SCRIPT_HOST,
         ].flatten.freeze
 
         def self.call(**args)

data/lib/qiita/markdown/version.rb

@@ -1,5 +1,5 @@
 module Qiita
   module Markdown
-    VERSION = "0.43.0"
+    VERSION = "0.44.0"
   end
 end

data/lib/qiita/markdown.rb

@@ -15,6 +15,7 @@ require "qiita/markdown/embed/slide_share"
 require "qiita/markdown/embed/google_slide"
 require "qiita/markdown/embed/speeker_deck"
 require "qiita/markdown/embed/docswell"
+require "qiita/markdown/embed/figma"
 require "qiita/markdown/transformers/filter_attributes"
 require "qiita/markdown/transformers/filter_script"
 require "qiita/markdown/transformers/filter_iframe"

data/spec/qiita/markdown/filters/checkbox_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+describe Qiita::Markdown::Filters::Checkbox do
+  subject(:filter) do
+    described_class.new(input_html)
+  end
+
+  context "with checkbox" do
+    let(:input_html) do
+      <<~HTML
+        <li>[ ] a</li>
+        <li>[x] a</li>
+      HTML
+    end
+
+    let(:output_html) do
+      <<~HTML
+        <li class="task-list-item">
+        <input type="checkbox" class="task-list-item-checkbox" disabled>a</li>
+        <li class="task-list-item">
+        <input type="checkbox" class="task-list-item-checkbox" checked disabled>a</li>
+      HTML
+    end
+
+    it "replaces checkboxes" do
+      expect(filter.call.to_s).to eq(output_html)
+    end
+
+    context "when input html has many spaces after checkbox mark" do
+      let(:input_html) do
+        <<~HTML
+          <li>[ ]    a</li>
+          <li>[x]    a</li>
+        HTML
+      end
+
+      it "replaces checkboxes and remove spaces" do
+        expect(filter.call.to_s).to eq(output_html)
+      end
+    end
+  end
+end

data/spec/qiita/markdown/processor_spec.rb

@@ -1620,6 +1620,44 @@ describe Qiita::Markdown::Processor do
         end
       end
 
+      context "with HTML embed code for Figma" do
+        shared_examples "embed code figma example" do
+          let(:markdown) do
+            <<-MARKDOWN.strip_heredoc
+              <iframe style="border: 1px solid rgba(0, 0, 0, 0.1);" width="100" height="100" src="#{url}"></iframe>
+            MARKDOWN
+          end
+          let(:url) { "#{scheme}//www.figma.com/embed?embed_host=share&url=https%3A%2F%2Fwww.figma.com" }
+          let(:encoded_url) { CGI.escapeHTML(url) }
+
+          if allowed
+            it "does not sanitize embed code" do
+              should eq <<-HTML.strip_heredoc
+                <iframe style="border: 1px solid rgba(0, 0, 0, 0.1);" width="100" height="100" src="#{encoded_url}"></iframe>
+              HTML
+            end
+          else
+            it "forces width attribute on iframe" do
+              should eq <<-HTML.strip_heredoc
+                <iframe style="border: 1px solid rgba(0, 0, 0, 0.1);" width="100%" height="100" src="#{encoded_url}"></iframe>
+              HTML
+            end
+          end
+        end
+
+        context "with scheme" do
+          let(:scheme) { "https:" }
+
+          include_examples "embed code figma example"
+        end
+
+        context "without scheme" do
+          let(:scheme) { "" }
+
+          include_examples "embed code figma example"
+        end
+      end
+
       context "with HTML embed code for SpeekerDeck" do
         let(:markdown) do
           <<-MARKDOWN.strip_heredoc

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: qiita-markdown
 version: !ruby/object:Gem::Version
-  version: 0.43.0
+  version: 0.44.0
 platform: ruby
 authors:
 - Ryo Nakamura
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-10-14 00:00:00.000000000 Z
+date: 2022-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gemoji
@@ -290,7 +290,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.27.0
-description:
+description: 
 email:
 - r7kamura@gmail.com
 executables: []
@@ -315,6 +315,7 @@ files:
 - lib/qiita/markdown/embed/asciinema.rb
 - lib/qiita/markdown/embed/code_pen.rb
 - lib/qiita/markdown/embed/docswell.rb
+- lib/qiita/markdown/embed/figma.rb
 - lib/qiita/markdown/embed/google_slide.rb
 - lib/qiita/markdown/embed/slide_share.rb
 - lib/qiita/markdown/embed/speeker_deck.rb
@@ -348,6 +349,7 @@ files:
 - lib/qiita/markdown/transformers/strip_invalid_node.rb
 - lib/qiita/markdown/version.rb
 - qiita-markdown.gemspec
+- spec/qiita/markdown/filters/checkbox_spec.rb
 - spec/qiita/markdown/filters/greenmat_spec.rb
 - spec/qiita/markdown/filters/inline_code_color_spec.rb
 - spec/qiita/markdown/greenmat/html_toc_renderer_spec.rb
@@ -358,7 +360,7 @@ homepage: https://github.com/increments/qiita-markdown
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -374,10 +376,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.4
-signing_key:
+signing_key: 
 specification_version: 4
 summary: Qiita-specified markdown processor.
 test_files:
+- spec/qiita/markdown/filters/checkbox_spec.rb
 - spec/qiita/markdown/filters/greenmat_spec.rb
 - spec/qiita/markdown/filters/inline_code_color_spec.rb
 - spec/qiita/markdown/greenmat/html_toc_renderer_spec.rb