qiita-markdown 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 248dab83e19fd3e32b11fa78625b51a24f36479b
-  data.tar.gz: 8e564e30dfca3ed14cbcfc5377d493150baad7a0
+  metadata.gz: a2246b9c7de465987d8096f8f06dff05874c31b1
+  data.tar.gz: 7f980024c9522ba903c7ffaa6da2964b4b78d907
 SHA512:
-  metadata.gz: 9f80abb21c9f17a44eb8a9727cac09d61699f247d6119bde8e82bf686fcf35c3efb64152a623962b312ac2cc7a0d7128088912d86a660e02c2ba3aaa57fd4b2a
-  data.tar.gz: 3c39f211272a8302879811ef3866d1c5f4a42df751109fa664a470da4db842f25a50d26bb0f9bf8b028ec8159ff19608f76d8cdf491a9bc6ef557317ad84f47c
+  metadata.gz: c83fa85dced0ec7c9dc7f4962073b5576b9dc6ef6b6c2616cb3fd6bcb033ae56e1f85a77553b9f8d350c030f5f711b57fd0d0a337bfa0eaf6671cd142675b2e3
+  data.tar.gz: ae5a0ccaf8a142815d3fefc1030f24bda3cfab000abc75af67c698df4771b7cae64348908e0e53a419e637bbdba153a952aae34a42b7bdbdf2a1e43cb4b1e467

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.2.2
+- Fix a bug that raised error on rendering `<a>` tag with href for unknown fragment inside of `<sup>` tag (e.g. `<sup><a href="#foo.1">Link</a></sup>`)
+
 ## 0.2.1
 - Strengthen sanitization (thx xrekkusu)
 

data/lib/qiita/markdown/filters/footnote.rb

@@ -4,13 +4,20 @@ module Qiita
       class Footnote < HTML::Pipeline::Filter
         def call
           doc.search("sup > a").each do |a|
-            href = a["href"]
-            if href.start_with?("#") && (li = doc.search(href).first)
-              a[:title] = li.text.gsub(/\A\n/, "").gsub(/ ↩\n\z/, "")
-            end
+            footnote = find_footnote(a)
+            next unless footnote
+            a[:title] = footnote.text.gsub(/\A\n/, "").gsub(/ ↩\n\z/, "")
           end
           doc
         end
+
+        private
+
+        def find_footnote(a)
+          href = a["href"]
+          return nil if !href || href.match(/\A#fn\d+\z/).nil?
+          doc.search(href).first
+        end
       end
     end
   end

data/lib/qiita/markdown/version.rb

@@ -1,5 +1,5 @@
 module Qiita
   module Markdown
-    VERSION = "0.2.1"
+    VERSION = "0.2.2"
   end
 end

data/spec/qiita/markdown/processor_spec.rb

@@ -561,5 +561,19 @@ describe Qiita::Markdown::Processor do
         EOS
       end
     end
+
+    context 'with manually written <a> tag with strange href inside of <sup> tag' do
+      let(:markdown) do
+        <<-EOS.strip_heredoc
+          <sup><a href="#foo.1">Link</a></sup>
+        EOS
+      end
+
+      it "does not confuse the structure with automatically generated footnote reference" do
+        should eq <<-EOS.strip_heredoc
+          <p><sup><a href="#foo.1">Link</a></sup></p>
+        EOS
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: qiita-markdown
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-23 00:00:00.000000000 Z
+date: 2015-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport