qiita-markdown 0.16.0 → 0.16.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 739494b992f30301e63c329ca71f822ef80bd67a
-  data.tar.gz: 6f925bef2e51205cec9f663e71ddae50ef6d2097
+  metadata.gz: 01b805ffe8201bb8805e335ef00b5a2b08164115
+  data.tar.gz: 15a749e779263c51422f416cd4f03927131628dd
 SHA512:
-  metadata.gz: f002a9b803ff192b9139c8060dde2116e945aec2aec1fd9f02e3a09d45ad85c5654a7fdf8f2f7b31bd44a9f48293c693506d4b0cbeca15c9d41a2d4ae66cadf9
-  data.tar.gz: b718ef753796afa29aaed9dc72122a0bc88daa33db71cceea242ffe8192ff4f6238766e54ebe0f91821ebff7680b231457ce200ff7f6a0f3c38bb2936192d4af
+  metadata.gz: 53275947310ee3fc879b5ed2934ec68f30d9f2a7b3a0cac3cf83358337bf490902168454d4d70979aacce9993ce16ebb9ed835dc5cbf22420a84d726afde9c11
+  data.tar.gz: eaf5964c573eb43bd0b9ec008a67df6d5a9c29edb0b8a959f2c54372a6f8243f6e097785de040c43ba1a4cef18e7ccccf037239b2766e5054f70eb38d85ddf27

data/CHANGELOG.md

@@ -1,139 +1,188 @@
+## 0.16.1
+
+- Fix a group mention bug that unexpectedly removes preceding space
+
 ## 0.16.0
+
 - Add rel=noopener to all external a tags
 - Support HTML5 `<details>` and `<summary>` elements
 - Enable to change settings for footnotes
 
 ## 0.15.0
+
 - Append `rel=nofollow` and `target=_blank` to `a` tags for external link
 
 ## 0.14.0
+
 - Add some attributes to mentions for rendering hovercard
 
 ## 0.13.0
+
 - Support group mention
 
 ## 0.12.0
+
 - Add custom emoji support via `:emoji_names` and `:emoji_url_generator` contexts
 
 ## 0.11.5
+
 - Add a leading newline to `<pre>` elements so that leading newlines inputted by user are properly rendered on browsers
 
 ## 0.11.4
+
 - Avoid stripping leading and trailing newlines in code snippets
 
 ## 0.11.3
+
 - Ignore menton in blockquote element
 
 ## 0.11.2
+
 - Support video element on `SCRIPTABLE_RULE`
 
 ## 0.11.1
+
 - Support email address link
 
 ## 0.11.0
+
 - Add `autolink` class to autolink element
 - Remove activesupport runtime dependency
 
 ## 0.10.0
+
 - Add ImageLink filter
 
 ## 0.9.0
+
 - Support html-pipeline v2
 
 ## 0.8.1
+
 - Fix filters configurations (thx @imishinist)
 
 ## 0.8.0
+
 - Sanitize data-attributes
 
 ## 0.7.1
+
 - Support mentions to 2-character usernames
 
 ## 0.7.0
+
 - Support `@all`
 
 ## 0.6.0
+
 - Add `:escape_html` extension to Qiita::Markdown::Greenmat::HTMLToCRenderer.
 - Fix backward incompatibility of fragment identifier of heading that includes special HTML characters in v0.5.0.
 
 ## 0.5.0
+
 - Add renderers Qiita::Markdown::Greenmat::HTMLRenderer and Qiita::Markdown::Greenmat::HTMLToCRenderer which can be passed to `Redcarpet::Markdown.new` and generate consistent heading fragment identifiers.
 
 ## 0.4.2
+
 - Fix bug on SummaryProcessor with mention
 
 ## 0.4.1
+
 - Ignore mention in filename label
 
 ## 0.4.0
+
 - Replace the core renderer redcarpet with greenmat, which is a fork of redcarpet.
 - Fix a bug where mentions with username including underscores (e.g. `@_username_`) was wrongly emphasized.
 
 ## 0.3.0
+
 - Introduce another processor Qiita::Markdown::SummaryProcessor, which is for rendering a summary of markdown document.
 
 ## 0.2.2
+
 - Fix a bug that raised error on rendering `<a>` tag with href for unknown fragment inside of `<sup>` tag (e.g. `<sup><a href="#foo.1">Link</a></sup>`)
 
 ## 0.2.1
+
 - Strengthen sanitization (thx xrekkusu)
 
 ## 0.2.0
+
 - Support text-align style on table syntax (thx @uribou)
 
 ## 0.1.9
+
 - Fix a bug that raised error while rendering links with absolute URI inside of `<sup>` tag (e.g. `<sup>[Qiita](http://qiita.com/)</sup>`)
 
 ## 0.1.8
+
 - Add title attribute into footnote link element
 
 ## 0.1.7
+
 - Enable footnotes markdown syntax
 
 ## 0.1.6
+
 - Add missing dependency on pygments.rb (thx @kwappa)
 
 ## 0.1.5
+
 - Memoize Redcarpet::Markdown object
 
 ## 0.1.4
+
 - Support type attribute of script element
 
 ## 0.1.3
+
 - Support text-align syntax on table
 
 ## 0.1.2
+
 - Support rowspan attribute
 
 ## 0.1.1
+
 - Support empty list
 
 ## 0.1.0
+
 - Default to add disabled attribute to checkbox
 
 ## 0.0.9
+
 - Make it Ruby 2.0.0-compatible
 
 ## 0.0.8
+
 - Support gapped task list
 
 ## 0.0.7
+
 - Change dependent gem version
 
 ## 0.0.6
+
 - Remove target="_blank" from a element of mention
 
 ## 0.0.5
+
 - Allow font element with color attribute
 
 ## 0.0.4
+
 - Add iframe and data-attributes support
 
 ## 0.0.3
+
 - Fix bug of code block that has colon-only label
 
 ## 0.0.2
+
 - Remove version dependency on gemoji
 
 ## 0.0.1
+
 - 1st Release

data/lib/qiita/markdown/filters/group_mention.rb

@@ -59,13 +59,16 @@ module Qiita
 
           # @return [String]
           def replaced_html
-            @replaced_html ||= html.gsub(GROUP_IDENTIFIER_PATTERN) do |_match|
+            @replaced_html ||= html.gsub(GROUP_IDENTIFIER_PATTERN) do |string|
               team_url_name = ::Regexp.last_match(1)
               group_url_name = ::Regexp.last_match(2)
               group = { group_url_name: group_url_name, team_url_name: team_url_name }
               groups << group
-              %(<a href="#{@group_mention_url_generator.call(group)}">) +
-                %(@#{team_url_name}/#{group_url_name}</a>)
+              string.sub(
+                "@#{team_url_name}/#{group_url_name}",
+                %(<a href="#{@group_mention_url_generator.call(group)}">) +
+                  %(@#{team_url_name}/#{group_url_name}</a>),
+              )
             end
           end
 

data/lib/qiita/markdown/version.rb

@@ -1,5 +1,5 @@
 module Qiita
   module Markdown
-    VERSION = "0.16.0"
+    VERSION = "0.16.1"
   end
 end

data/spec/qiita/markdown/processor_spec.rb

@@ -457,7 +457,7 @@ describe Qiita::Markdown::Processor do
       end
     end
 
-    context "with group mention" do
+    context "with group mention without group_memberion_url_generator" do
       let(:markdown) do
         "@alice/bob"
       end
@@ -491,6 +491,22 @@ describe Qiita::Markdown::Processor do
       end
     end
 
+    context "with group mention following another text" do
+      let(:context) do
+        super().merge(group_mention_url_generator: lambda do |group|
+          "https://#{group[:team_url_name]}.example.com/groups/#{group[:group_url_name]}"
+        end)
+      end
+
+      let(:markdown) do
+        "FYI @alice/bob"
+      end
+
+      it "preserves space after preceding text" do
+        is_expected.to start_with("<p>FYI <a ")
+      end
+    end
+
     context "with normal link" do
       let(:markdown) do
         "[](/example)"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: qiita-markdown
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.16.1
 platform: ruby
 authors:
 - Ryo Nakamura
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-15 00:00:00.000000000 Z
+date: 2016-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gemoji
@@ -307,7 +307,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Qiita-specified markdown processor.