qif 1.1.2 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 05d7562d52dc8df636d290de9e2cce5f412a6013
-  data.tar.gz: f47615d7c5077148c7c508bab6f14839730e49ad
+  metadata.gz: 08266f25e1ffcdf187a4ebb8b1962c966174cccf
+  data.tar.gz: f6e324f5d4ad6dd5779998a106999d7a622c124f
 SHA512:
-  metadata.gz: 4514f7c2a458fb6989ca943a5f8050f905f81e449ced6adfd79daab2ab97bbb033cb2125f42f8e576bdec73a1a0fa08657e23b77bf91f2d9c5759f8717664973
-  data.tar.gz: 87fe80e1d2b395d875121fdea2a3679e53269fa4b632cafcaca467c02bc89ddb43630c5fe113c34d0a694976386ccbc8ed2d89898f6006d99f167f03a4bee146
+  metadata.gz: 2ee86e8d5aa5128e25fe50d65ded8ea804290d8b40f7013a4d83825acbf9c4ab3ace060dc2dd4c251b0033e0cecb160bca7cf32ed1bd6ce81c2e04663663592b
+  data.tar.gz: 856b067eaa0618b390c903cb236eeff28790afe131abc5bf570643ef86ddda93f494e09250046cd9a55529fffcff8e25518ebd12a5ea62de8525ffc6b480f8b7

data/README.rdoc

@@ -6,23 +6,23 @@
 
 === INSTALL:
 
-* sudo gem install qif
+* gem install qif
 
 === DOCUMENTATION:
 
-* http://rdoc.info/github/jemmyw/Qif/master/frames
+* http://www.rubydoc.info/github/jemmyw/Qif
 
 === EXAMPLE:
 
   require 'qif'
   qif = Qif::Reader.new(open('/path/to/file.qif'))
   qif.each do |transaction|
-    puts [transaction.name, transaction.description, transaction.amount].join(", ")
+    puts [transaction.payee, transaction.amount].join(", ")
   end
 
 === CSV conversion example
 
-  # Ruby 1.9.2
+  # Ruby 2.1.0
   require 'csv'
   require 'qif'
 
@@ -33,10 +33,10 @@
   #   [3] debit amount,
   #   [4] credit amount
   #   Ignore other fields
-  basefile = 'file'
-  bank_input = CSV.read("#{file}.csv")
+  basefile = 'filename'
+  bank_input = CSV.read("#{basefile}.csv")
 
-  Qif::Writer.open("#{file}.qif", type = 'Bank', format = 'dd/mm/yyyy') do |qif|
+  Qif::Writer.open("#{basefile}.qif", type = 'Bank', format = 'dd/mm/yyyy') do |qif|
     bank_input.each do |row|
       # Fix the values depending on what state your CSV data is in
       row.each { |value| value.to_s.gsub!(/^\s+|\s+$/,'') }
@@ -51,7 +51,7 @@
 
 === LICENSE:
 
-Copyright (c) 2011 Jeremy Wells
+Copyright (c) 2014 Jeremy Wells
 
 Permission is hereby granted, free of charge, to any person
 obtaining a copy of this software and associated documentation

data/Rakefile

@@ -1,6 +1,12 @@
 require 'rspec/core/rake_task'
+require 'rdoc/task'
 
 desc "Run specs"
 RSpec::Core::RakeTask.new :spec
 
+RDoc::Task.new do |rdoc|
+  rdoc.main = "README.rdoc"
+  rdoc.rdoc_files.include("README.rdoc", "lib/**/*.rb")
+end
+
 task :default => :spec

data/lib/qif.rb

@@ -1,5 +1,11 @@
 $: << File.dirname(__FILE__)
 
+#
+# See Qif::Reader for reading qif files and Qif::Writer for writing them.
+#
+module Qif
+end
+
 require 'qif/reader'
 require 'qif/writer'
-require 'qif/transaction'
+require 'qif/transaction'

data/lib/qif/amount_parser.rb

@@ -0,0 +1,6 @@
+module AmountParser
+  def self.parse(amount)
+    warn "= amounts are unsupported" if amount =~ /^=/
+    amount.gsub(/,/, '').gsub(/^=/, '').to_f
+  end
+end

data/lib/qif/reader.rb

@@ -1,6 +1,7 @@
 require 'stringio'
 require 'qif/date_format'
 require 'qif/transaction'
+require 'qif/transaction/builder'
 
 module Qif
   # The Qif::Reader class reads a qif file and provides access to
@@ -152,9 +153,8 @@ module Qif
     end
   
     def read_transaction
-      if record = read_record
-        transaction = Transaction.read(record)
-        cache_transaction(transaction) if transaction
+      if transaction = read_record
+        cache_transaction(transaction)
       end
     end
   
@@ -163,17 +163,27 @@ module Qif
     end
 
     def read_record
-      record = {}
+      builder = Qif::Transaction::Builder.new(->(dt){@format.parse(dt)})
       begin
-        line = @data.readline
-        key = line[0,1]
-        record[key] = record.key?(key) ? record[key] + "\n" + line[1..-1].strip : line[1..-1].strip
-
-        record[key].sub!(',','') if %w(T U $).include? key
-        record[key] = @format.parse(record[key]) if %w(D).include? key
-
-      end until line =~ /^\^/
-      record
+        line = @data.readline.strip
+        key = line.slice!(0, 1)
+        builder =
+          case key
+            when 'D' then builder.set_date(line)
+            when 'T' then builder.set_amount(line)
+            when 'A' then builder.set_address(line)
+            when 'C' then builder.set_status(line)
+            when 'N' then builder.set_number(line)
+            when 'P' then builder.set_payee(line)
+            when 'M' then builder.set_memo(line)
+            when 'L' then builder.set_category(line)
+            when 'S' then builder.add_split(line)
+            when 'E' then builder.set_split_memo(line)
+            when '$' then builder.set_split_amount(line)
+            else builder
+          end
+      end until key == "^"
+      builder.build
       rescue EOFError => e
         @data.close
         nil

data/lib/qif/transaction.rb

@@ -12,9 +12,6 @@ module Qif
       :memo           => {"M" => "Memo"                                                              },
       :adress         => {"A" => "Address (up to five lines; the sixth line is an optional message)" },
       :category       => {"L" => "Category (Category/Subcategory/Transfer/Class)"                    },
-      :split_category => {"S" => "Category in split (Category/Transfer/Class)"                       },
-      :split_memo     => {"E" => "Memo in split"                                                     },
-      :split_amount   => {"$" => "Dollar amount of split"                                            },
       :end            => {"^" => "End of entry"                                                      }
     }
     DEPRECATION_FIELDS = {
@@ -24,18 +21,20 @@ module Qif
     }
     SUPPORTED_FIELDS.keys.each{|s| attr_accessor s}
 
-    def self.read(record) #::nodoc
-      return nil unless record['D'].respond_to?(:strftime)
-      SUPPORTED_FIELDS.each{|k,v| record[k] = record.delete(v.keys.first)}
-      record.reject{|k,v| v.nil?}.each{|k,v| record[k] = record[k].to_f if k.to_s.include? "amount"}
-      Transaction.new record
-    end
+    attr_reader :splits
+    alias :address :adress
+    alias :address= :adress=
 
     def initialize(attributes = {})
+      @splits = []
       deprecate_attributes!(attributes)
       SUPPORTED_FIELDS.keys.each{|s| instance_variable_set("@#{s.to_s}", attributes[s])}
     end
 
+    def add_split(split)
+      @splits << split
+    end
+
     # Returns a representation of the transaction as it
     # would appear in a qif file.
     def to_s(format = 'dd/mm/yyyy')
@@ -52,7 +51,7 @@ module Qif
         else
           "#{field}#{current}"
         end
-      end.flatten.compact.join("\n")
+      end.concat(@splits.collect{|s| s.to_s}).flatten.compact.join("\n")
     end
 
     private

data/lib/qif/transaction/builder.rb

@@ -0,0 +1,61 @@
+require_relative "split/builder"
+require_relative "builderable"
+require_relative "../amount_parser"
+
+#
+# Factory class for building transactions.
+#
+# @usage
+# txn = Qif::Transaction::Builder.new
+#   .set_date('10/06/1983')
+#   .set_amount('-10.0')
+#   .set_memo('debit $10')
+#   .add_split('jules')
+#   .set_split_memo('half to jules')
+#   .add_split_amount('-5.0')
+#   .build
+#
+class Qif::Transaction::Builder
+  include Builderable
+
+  def initialize(date_parser = ->(date) { Time.parse(date) })
+    @date_parser = date_parser
+    @splits = []
+  end
+
+  set_builder_method :date, :parse_date
+  set_builder_method :amount, ->(amt) { AmountParser.parse(amt) }
+  set_builder_method :status
+  set_builder_method :number
+  set_builder_method :payee
+  set_builder_method :memo
+  set_builder_method :category
+
+  def set_address(address)
+    @address = [@address, address].compact.join("\n")
+    self
+  end
+  alias :set_adress :set_address
+
+  def add_split(split)
+    Qif::Transaction::Split::Builder.new(self).set_split_category(split).tap do |builder|
+      @splits << builder
+    end
+  end
+
+  def build
+    _build(Qif::Transaction.new).tap do |txn|
+      txn.address = @address
+
+      @splits.each do |split_builder|
+        txn.add_split(split_builder.build_split)
+      end
+    end
+  end
+
+  private
+
+  def parse_date(date)
+    @date_parser.call(date)
+  end
+end

data/lib/qif/transaction/builderable.rb

@@ -0,0 +1,39 @@
+module Builderable
+  def self.included(base)
+    base.extend ClassMethods
+  end
+
+  module ClassMethods
+    def builder_options(options)
+      @options = options
+    end
+
+    def set_builder_method(attribute, massager = nil)
+      options = @options || {}
+      method_name = ["set", options[:prefix], attribute].compact.join("_")
+
+      define_method(method_name) do |new_value|
+        @_builder_values ||= {}
+
+        unless massager.nil?
+          if massager.kind_of?(Symbol)
+            new_value = self.send(massager, new_value)
+          else
+            new_value = massager.call(new_value)
+          end
+        end
+
+        @_builder_values[attribute] = new_value
+        self
+      end
+    end
+  end
+
+  def _build(object)
+    (@_builder_values||{}).each do |attribute, value|
+      object.public_send("#{attribute}=", value)
+    end
+
+    object
+  end
+end

data/lib/qif/transaction/split.rb

@@ -0,0 +1,26 @@
+class Qif::Transaction::Split
+  SUPPORTED_FIELDS = {
+    :category => {"S" => "Category in split (Category/Transfer/Class)" },
+    :memo     => {"E" => "Memo in split"                               },
+    :amount   => {"$" => "Dollar amount of split"                      },
+  }
+
+  attr_accessor :memo, :amount, :category
+
+  # Returns a representation of the split as it
+  # would appear in a qif file.
+  def to_s()
+    SUPPORTED_FIELDS.collect do |k,v|
+      next unless current = instance_variable_get("@#{k}")
+      field = v.keys.first
+      case current.class.to_s
+      when "Float"
+        "#{field}#{'%.2f'%current}"
+      when "String"
+        current.split("\n").collect {|x| "#{field}#{x}" }
+      else
+        "#{field}#{current}"
+      end
+    end.flatten.compact.join("\n")
+  end
+end

data/lib/qif/transaction/split/builder.rb

@@ -0,0 +1,32 @@
+require_relative '../builderable'
+require_relative '../split'
+
+#
+# Factory class for buliding splits. Do not construct this directly, rather use
+# Qif::Transaction::Builder#add_split
+#
+class Qif::Transaction::Split::Builder
+  include Builderable
+
+  def initialize(transaction_builder)
+    @transaction_builder = transaction_builder
+    yield self if block_given?
+  end
+
+  def add_split(split_memo)
+    @transaction_builder.add_split(split_memo)
+  end
+
+  builder_options prefix: 'split'
+  set_builder_method :memo
+  set_builder_method :amount, ->(amt) { AmountParser.parse(amt) }
+  set_builder_method :category
+
+  def build_split
+    _build(Qif::Transaction::Split.new)
+  end
+
+  def method_missing(name, *args, &block)
+    @transaction_builder.send(name, *args, &block)
+  end
+end

data/spec/fixtures/splits.qif

@@ -0,0 +1,20 @@
+!Type:Bank
+D6/1/94
+T-1,000.00
+CX
+N1005
+PBank Of Mortgage
+MMemo
+L[linda]
+S[steve]
+ECash
+$-253.64
+SMort Int
+$=746.36
+^
+D6/2/94
+Scategory 1
+$23
+T75.00
+PDeposit
+^

data/spec/lib/reader_spec.rb

@@ -107,4 +107,42 @@ describe Qif::Reader do
     @instance = Qif::Reader.new(open('spec/fixtures/3_records_ddmmyyyy.qif'), 'mm/dd/yyyy')
     @instance.size.should == 2
   end
+
+  context 'when reading splits' do
+    let(:reader) { Qif::Reader.new(open('spec/fixtures/splits.qif'), 'd/m/yyyy') }
+
+    context 'the first transaction' do
+      let (:transaction) { reader.transactions[0] }
+
+      it 'should have the correct number of splits' do
+        expect(transaction.splits.size).to eq(2)
+      end
+
+      context 'the first split' do
+        let (:split) { transaction.splits.first }
+
+        it { expect(split.category).to eq("[steve]") }
+        it { expect(split.memo).to eq("Cash") }
+        it { expect(split.amount).to eq(-253.64)}
+      end
+
+      context 'the second split' do
+        let (:split) { transaction.splits[1] }
+
+        it { expect(split.category).to eq("Mort Int") }
+        it { expect(split.amount).to eq(746.36) }
+      end
+
+    end
+
+    context "when the transaction has splits first" do
+      let(:transaction) { reader.transactions[1] }
+
+      it 'should correctly add the amount to the transaction' do
+        expect(transaction.amount).to eq(75)
+      end
+
+      it { expect(transaction.splits.first.amount).to eq(23) }
+    end
+  end
 end

data/spec/lib/transaction_builder_spec.rb

@@ -0,0 +1,122 @@
+require 'spec_helper'
+require 'qif/transaction/builder'
+require 'qif/transaction/split/builder'
+
+describe Qif::Transaction::Builder do
+  let(:builder) { Qif::Transaction::Builder.new }
+  def split_builder
+    double(Qif::Transaction::Split::Builder).tap do |b|
+      allow(b).to receive(:set_split_category).and_return(b)
+    end
+  end
+  def do_build
+    builder.build
+  end
+
+  context '#build' do
+    it 'should return a transaction object' do
+      expect(builder.build).to be_kind_of(Qif::Transaction)
+    end
+
+    context 'with splits' do
+      it 'should call build_split on each of the splits' do
+        sb1 = split_builder
+        sb2 = split_builder
+        allow(Qif::Transaction::Split::Builder).to receive(:new).and_return(sb1, sb2)
+        expect(sb1).to receive(:build_split).ordered
+        expect(sb2).to receive(:build_split).ordered
+        builder.add_split("a")
+        builder.add_split("b")
+        builder.build
+      end
+
+      it 'should add the splits to the transaction' do
+        builder.add_split("a")
+        builder.add_split("b")
+        expect(builder.build.splits.count).to eq(2)
+      end
+    end
+  end
+
+ context '#set_date' do
+    it_should_behave_like 'builder method', :date, '1994-06-01', :set_date, Time.mktime(1994, 6, 1)
+    it 'should use a given date parser' do
+      b = Qif::Transaction::Builder.new(->(date) { date })
+      b.set_date('1994')
+      expect(b.build.date).to eq('1994')
+    end
+  end
+
+  context '#set_amount' do
+    it_should_behave_like 'builder method', :amount, '-1000.00', :set_amount, -1000.0
+    it 'should parse commas out of the amount' do
+      builder.set_amount('1,000,000')
+      expect(builder.build.amount).to eq(1_000_000)
+    end
+  end
+
+  context '#set_status' do
+    it_should_behave_like 'builder method', :status, 'X', :set_status, 'X'
+  end
+
+  context '#set_number' do
+    it_should_behave_like 'builder method', :number, '1005', :set_number, '1005'
+  end
+
+  context '#set_payee' do
+    it_should_behave_like 'builder method', :payee, 'Bank of Mortgage', :set_payee, 'Bank of Mortgage'
+  end
+
+  context '#set_memo' do
+    it_should_behave_like 'builder method', :memo, 'Some stuff that happened', :set_memo, 'Some stuff that happened'
+  end
+
+  context '#set_category' do
+    it_should_behave_like 'builder method', :category, 'Fishing', :set_category, 'Fishing'
+  end
+
+  context '#set_address' do
+    address = <<-EOA
+      P.O. Box 1234
+      Somewhereton
+      12345
+    EOA
+    
+    it_should_behave_like 'builder method', :adress, address, :set_adress, address
+
+    context 'when called consecutively' do
+      it "should append to the address" do
+        builder
+          .set_address("Line 1")
+          .set_address("Line 2")
+        expect(do_build.address).to eq("Line 1\nLine 2")
+      end
+    end
+  end
+
+  context "#add_split" do
+    it 'should create a new split builder' do
+      expect(Qif::Transaction::Split::Builder).to receive(:new).with(builder).and_return(split_builder)
+      builder.add_split("aaa")
+    end
+
+    it 'should set the category on the split builder' do
+      sb = split_builder
+      allow(Qif::Transaction::Split::Builder).to receive(:new).and_return(sb)
+      expect(sb).to receive(:set_split_category).with('aaaa')
+      builder.add_split('aaaa')
+    end
+
+    it "should return a split builder" do
+      expect(builder.add_split('aaaa')).to be_kind_of(Qif::Transaction::Split::Builder)
+    end
+
+    context "when called multiple times" do
+      it "should return multiple different builders" do
+        sb1 = builder.add_split("aaaa")
+        expect(builder.add_split("bbbb")).to_not eq(sb1)
+      end
+    end
+  end
+
+end

data/spec/lib/transaction_spec.rb

@@ -1,76 +1,59 @@
 require 'spec_helper'
 
 describe Qif::Transaction do
-  describe '::read' do
-    it 'should return a new transaction with all attributes set' do
-      t = Qif::Transaction.read(
-        'D' => Time.parse('1994-06-01'),
-        'T' => '-1000.00'.to_f,
-        'C' => 'X',
-        'N' => '1005',
-        'P' => 'Bank Of Mortgage',
-        'M' => 'aMemo',
-        'L' => 'aCategory',
-# TODO Support correctly splits with an array of hash
-#        'S' => '[linda]
-#Mort Int',
-#        'E' => 'Cash',
-#        '$' => '-253.64
-#=746.36',
-        'A' => 'P.O. Box 27027
-Tucson, AZ
-85726',
-        '^' => nil
-      )
-
-      t.should be_a(Qif::Transaction)
-      t.date.should == Time.mktime(1994,6,1)
-      t.amount.should == -1000.00
-      t.status.should == 'X'
-      t.number.should == '1005'
-      t.payee.should == 'Bank Of Mortgage'
-      t.memo.should == 'aMemo'
-      t.category.should == 'aCategory'
-      t.adress.should == 'P.O. Box 27027
-Tucson, AZ
-85726'
-    end
-    
-    it 'should return nil if the date does not respond to strftime' do
-      Qif::Transaction.read('D' => 'hello').should be_nil
-    end
-  end
-  
   describe '#to_s' do
-    before do
-      @instance = Qif::Transaction.new(
-        :date => Time.mktime(2010, 1, 2),
-        :amount => -10.0,
-        :category => 'Debit',
-        :memo => 'Supermarket',
-        :payee => 'abcde'
-      )
+    let(:builder) do
+      Qif::Transaction::Builder.new
+        .set_date(Time.mktime(2010, 1, 2).to_s)
+        .set_amount('-10.0')
+        .set_category('Debit')
+        .set_memo('Supermarket')
+        .set_payee('abcde')
     end
-    
+
+    let(:txn) do
+      builder.build
+    end
+
+    subject { txn.to_s }
+
     it 'should format the date in the format specified as D' do
-      @instance.to_s('dd/mm/yyyy').should include('D02/01/2010')
-      @instance.to_s('mm/dd/yyyy').should include('D01/02/2010')
+      expect(txn.to_s('dd/mm/yyyy')).to include('D02/01/2010')
+      expect(txn.to_s('mm/dd/yyyy')).to include('D01/02/2010')
     end
     
     it 'should put the amount in T' do
-      @instance.to_s.should include('T-10.00')
+      expect(subject).to include('T-10.00')
     end
     
     it 'should put the category in L' do
-      @instance.to_s.should include('LDebit')
+      expect(subject).to include('LDebit')
     end
     
     it 'should put the description in M' do
-      @instance.to_s.should include('MSupermarket')
+      expect(subject).to include('MSupermarket')
     end
     
     it 'should put the reference in P' do
-      @instance.to_s.should include('Pabcde')
+      expect(subject).to include('Pabcde')
+    end
+
+    it 'adds splits to the output' do
+      builder.add_split('split_1')
+        .set_split_memo('test split 1')
+        .set_split_amount('-5.0')
+        .add_split('split_2')
+        .set_split_memo('test split 2')
+        .set_split_amount('-5.0')
+
+      expect(subject).to include(<<SPLIT.strip)
+Ssplit_1
+Etest split 1
+$-5.00
+Ssplit_2
+Etest split 2
+$-5.0
+SPLIT
     end
   end
 end

data/spec/lib/transaction_split_builder_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+require 'qif/transaction/split/builder'
+
+describe Qif::Transaction::Split::Builder do
+  let(:parent) { double(Qif::Transaction::Builder) }
+  let(:builder) { Qif::Transaction::Split::Builder.new(parent) }
+  def do_build
+    builder.build_split
+  end
+
+  context '#add_split' do
+    it 'should call add_split on the parent' do
+      expect(parent).to receive(:add_split).with("12345")
+      described_class.new(parent).add_split("12345")
+    end
+
+    it 'should return the new split builder' do
+      new_builder = double("split-builder")
+      allow(parent).to receive(:add_split).and_return(new_builder)
+      expect(described_class.new(parent).add_split(anything)).to eq(new_builder)
+    end
+  end
+
+  context '#set_memo' do
+    it_should_behave_like "builder method", :memo, 'Split', :set_split_memo
+  end
+
+  context '#set_amount' do
+    it_should_behave_like "builder method", :amount, '-10,000', :set_split_amount, -10000
+  end
+
+  context '#set_category' do
+    it_should_behave_like 'builder method', :category, '[Cash]', :set_split_category
+  end
+
+  context "when receiving an unknown message" do
+    it "should pass the message to the parent" do
+      expect(parent).to receive(:set_date).with('2012-12-31')
+      builder.set_date('2012-12-31')
+    end
+
+    it 'should return the result of the message' do
+      allow(parent).to receive(:set_date).and_return(parent)
+      expect(builder.set_date(anything)).to eq(parent)
+    end
+  end
+end

data/spec/lib/writer_spec.rb

@@ -2,98 +2,94 @@ require 'spec_helper'
 require 'stringio'
 
 describe Qif::Writer do
-  before do
-    @buffer = ''
-    @io = StringIO.new(@buffer)
-    @instance = Qif::Writer.new(@io)
-  end
+  let(:buffer) { "" }
+  let(:io) { StringIO.new(buffer) }
+  let(:instance) { Qif::Writer.new(io) }
+  let(:path) { "/tmp/test" }
   
   describe '::open' do
     before do
-      @path = '/tmp/test'
-      File.stub(:open).and_yield @io
+      File.stub(:open).and_yield io
     end
     
     it 'should yield a Qif::Writer' do
       ran = false
-      Qif::Writer.open(@path) do |writer|
+      Qif::Writer.open(path) do |writer|
         ran = true
         writer.should be_a(Qif::Writer)
       end
-      ran.should be_true
+      ran.should eq true
     end
     
     it 'should write the transactions' do
       date = Time.now
       
-      Qif::Writer.open(@path) do |writer|
+      Qif::Writer.open(path) do |writer|
         writer << Qif::Transaction.new(:date => date, :amount => 10.0, :category => 'Credit')
       end
       
-      @buffer.should include('D%s' % date.strftime('%d/%m/%Y'))
-      @buffer.should include('T10.0')
-      @buffer.should include('LCredit')
+      buffer.should include('D%s' % date.strftime('%d/%m/%Y'))
+      buffer.should include('T10.0')
+      buffer.should include('LCredit')
     end
     
     it 'should perform a File.open on the given path' do
-      File.should_receive(:open).with(@path, 'w')
-      Qif::Writer.open(@path) do |writer|
+      File.should_receive(:open).with(path, 'w')
+      Qif::Writer.open(path) do |writer|
       end
     end
   end
+
   describe '::new' do
     it 'should yield a Qif::Writer' do
       ran = false
-      Qif::Writer.new(@io) do |writer|
+      Qif::Writer.new(io) do |writer|
         ran = true
         writer.should be_a(Qif::Writer)
       end
-      ran.should be_true
+      expect(ran).to eq true
     end
     
     it 'should write the transactions' do
       date = Time.now
       
-      Qif::Writer.new(@io) do |writer|
+      Qif::Writer.new(io) do |writer|
         writer << Qif::Transaction.new(:date => date, :amount => 10.0, :category => 'Credit')
       end
       
-      @buffer.should include('D%s' % date.strftime('%d/%m/%Y'))
-      @buffer.should include('T10.0')
-      @buffer.should include('LCredit')
+      buffer.should include('D%s' % date.strftime('%d/%m/%Y'))
+      buffer.should include('T10.0')
+      buffer.should include('LCredit')
     end
     
     it 'should perform a File.open on the given path' do
-      File.should_receive(:open).with(@path, 'w')
-      Qif::Writer.open(@path) do |writer|
+      File.should_receive(:open).with(path, 'w')
+      Qif::Writer.open(path) do |writer|
       end
     end
   end
 
-
-
-
-  
   describe '#write' do
+    let(:date) { Time.now }
+
     it 'should write the header' do
-      @instance.write
-      @buffer.should include("!Type:Bank\n")
+      instance.write
+      buffer.should include("!Type:Bank\n")
     end
     
     it 'should write any pending transactions' do
-      date = Time.now
-      @instance << Qif::Transaction.new(:date => date, :amount => 10.0, :category => 'Credit')
+      instance << Qif::Transaction.new(:date => date, :amount => 10.0, :category => 'Credit')
       
-      @buffer.should_not include('D%s' % date.strftime('%d/%m/%Y'))
-      @instance.write
-      @buffer.should include('D%s' % date.strftime('%d/%m/%Y'))
+      buffer.should_not include('D%s' % date.strftime('%d/%m/%Y'))
+      instance.write
+      buffer.should include('D%s' % date.strftime('%d/%m/%Y'))
     end
   end
   
   describe '#close' do
     it 'should close the io stream' do
-      @io.should_receive(:close)
-      @instance.close
+      io.should_receive(:close)
+      instance.close
     end
   end
 end

data/spec/spec_helper.rb

@@ -1 +1,3 @@
-require File.dirname(__FILE__) + '/../lib/qif'
+require File.dirname(__FILE__) + '/../lib/qif'
+
+require_relative "support/shared/builder_method"

data/spec/support/shared/builder_method.rb

@@ -0,0 +1,14 @@
+shared_context 'builder method' do |attribute, input, method = nil, expected = nil|
+  expected = input if expected.nil?
+  method = "set_#{attribute}" if method.nil?
+
+  it 'and set the #{attribute} on the transaction' do
+    builder.send(method, input)
+    expect(do_build.send(attribute)).to eq(expected)
+  end
+
+  it 'and return the builder' do
+    expect(builder.send(method, input)).to be_kind_of described_class
+  end
+end
+

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: qif
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.2.0
 platform: ruby
 authors:
 - Jeremy Wells
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-14 00:00:00.000000000 Z
+date: 2016-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.5.0
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.5.0
+        version: 3.0.0
 description: A library for reading and writing quicken QIF files.
 email: jemmyw@gmail.com
 executables: []
@@ -38,15 +38,20 @@ extra_rdoc_files:
 - lib/qif/transaction.rb
 - lib/qif/writer.rb
 files:
-- README.rdoc
-- LICENSE
 - CHANGELOG
+- LICENSE
+- README.rdoc
 - Rakefile
+- lib/qif.rb
+- lib/qif/amount_parser.rb
 - lib/qif/date_format.rb
 - lib/qif/reader.rb
 - lib/qif/transaction.rb
+- lib/qif/transaction/builder.rb
+- lib/qif/transaction/builderable.rb
+- lib/qif/transaction/split.rb
+- lib/qif/transaction/split/builder.rb
 - lib/qif/writer.rb
-- lib/qif.rb
 - spec/fixtures/3_records_ddmmyy.qif
 - spec/fixtures/3_records_ddmmyyyy.qif
 - spec/fixtures/3_records_dmyy.qif
@@ -58,38 +63,42 @@ files:
 - spec/fixtures/not_a_QIF_file.txt
 - spec/fixtures/quicken_investment_account.qif
 - spec/fixtures/quicken_non_investement_account.qif
+- spec/fixtures/splits.qif
 - spec/lib/date_format_spec.rb
 - spec/lib/reader_spec.rb
+- spec/lib/transaction_builder_spec.rb
 - spec/lib/transaction_spec.rb
+- spec/lib/transaction_split_builder_spec.rb
 - spec/lib/writer_spec.rb
 - spec/spec.opts
 - spec/spec_helper.rb
+- spec/support/shared/builder_method.rb
 homepage: http://qif.github.com/qif
 licenses: []
 metadata: {}
 post_install_message: 
 rdoc_options:
-- --line-numbers
-- --inline-source
-- --title
+- "--line-numbers"
+- "--inline-source"
+- "--title"
 - Qif
-- --main
+- "--main"
 - README.rdoc
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '1.2'
 requirements: []
 rubyforge_project: qif
-rubygems_version: 2.1.11
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: A library for reading and writing quicken QIF files.