qif 0.3 → 0.4

data/CHANGELOG

@@ -1,3 +1,6 @@
+v0.4 Follow QIF specification that an end of entry should not appear under a
+header [jscipione]
+
 v0.3 Allow two digit years [caleb]
 
 v0.2 Added documentation

data/lib/qif/reader.rb

@@ -81,9 +81,29 @@ module Qif
         read_transaction
       end
     end
+
+    # lineno= and seek don't seem
+    # to work with StringIO
+    def rewind_to(n)
+      @data.rewind
+      while @data.lineno != n
+        @data.readline
+      end
+    end
   
     def read_header
-      @header = read_record
+      headers = []
+      begin
+        line = @data.readline.strip
+        headers << line.strip if line =~ /^!/
+      end until line !~ /^!/
+
+      @header = headers.shift
+      @options = headers.map{|h| h.split(':').last }
+      
+      unless line =~ /^\^/
+        rewind_to @data.lineno - 1
+      end
     end
   
     def read_transaction

data/qif.gemspec

@@ -2,17 +2,17 @@
 
 Gem::Specification.new do |s|
   s.name = %q{qif}
-  s.version = "0.3"
+  s.version = "0.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jeremy Wells"]
-  s.date = %q{2010-11-09}
+  s.date = %q{2010-11-24}
   s.description = %q{A library for reading and writing quicken QIF files.}
   s.email = %q{jemmyw@gmail.com}
   s.extra_rdoc_files = ["CHANGELOG", "LICENSE", "lib/qif.rb", "lib/qif/date_format.rb", "lib/qif/reader.rb", "lib/qif/transaction.rb", "lib/qif/writer.rb"]
   s.files = ["CHANGELOG", "LICENSE", "Manifest", "Rakefile", "lib/qif.rb", "lib/qif/date_format.rb", "lib/qif/reader.rb", "lib/qif/transaction.rb", "lib/qif/writer.rb", "qif.gemspec", "spec/fixtures/3_records_ddmmyy.qif", "spec/fixtures/3_records_ddmmyyyy.qif", "spec/fixtures/3_records_mmddyy.qif", "spec/fixtures/3_records_mmddyyyy.qif", "spec/lib/date_format_spec.rb", "spec/lib/reader_spec.rb", "spec/lib/transaction_spec.rb", "spec/lib/writer_spec.rb", "spec/spec.opts", "spec/spec_helper.rb"]
   s.homepage = %q{}
-  s.rdoc_options = ["--line-numbers", "--inline-source", "--title", "Qif"]
+  s.rdoc_options = ["--line-numbers", "--inline-source", "--title", "Qif", "--main", "README.rdoc"]
   s.require_paths = ["lib"]
   s.rubyforge_project = %q{qif}
   s.rubygems_version = %q{1.3.7}

data/spec/fixtures/3_records_ddmmyy.qif

@@ -1,5 +1,4 @@
 !Type:Bank
-^
 D01/01/10
 T-10.00
 LDebit
@@ -17,4 +16,4 @@ T30.00
 LCredit
 PDescription
 MReference
-^
+^

data/spec/fixtures/3_records_ddmmyyyy.qif

@@ -1,5 +1,4 @@
 !Type:Bank
-^
 D01/01/2010
 T-10.00
 LDebit
@@ -17,4 +16,4 @@ T30.00
 LCredit
 PDescription
 MReference
-^
+^

data/spec/fixtures/3_records_mmddyy.qif

@@ -1,5 +1,4 @@
 !Type:Bank
-^
 D01/01/10
 T-10.00
 LDebit
@@ -17,4 +16,4 @@ T30.00
 LCredit
 PDescription
 MReference
-^
+^

data/spec/fixtures/3_records_mmddyyyy.qif

@@ -1,5 +1,4 @@
 !Type:Bank
-^
 D01/01/2010
 T-10.00
 LDebit
@@ -17,4 +16,4 @@ T30.00
 LCredit
 PDescription
 MReference
-^
+^

data/spec/lib/reader_spec.rb

@@ -1,48 +1,57 @@
 require 'spec/spec_helper'
 
+shared_examples_for "3 record files" do
+  it 'should have 3 records' do
+    instance.size.should == 3
+  end
+
+  it 'should have a debit of $10 on the 1st of January 2010' do
+    transaction = instance.transactions.detect{|t| t.date == Time.mktime(2010, 1, 1)}
+    transaction.should_not be_nil
+    transaction.name.should == 'Debit'
+    transaction.amount.should == -10.0
+  end
+
+  it 'should have a debit of $20 on the 1st of June 1020' do
+    transaction = instance.transactions.detect{|t| t.date == Time.mktime(2010, 6, 1)}
+    transaction.should_not be_nil
+    transaction.name.should == 'Debit'
+    transaction.amount.should == -20.0
+  end
+
+  it 'should have a credit of $30 on the 29th of December 2010' do
+    transaction = instance.transactions.detect{|t| t.date == Time.mktime(2010, 12, 29)}
+    transaction.should_not be_nil
+    transaction.name.should == 'Credit'
+    transaction.amount.should == 30.0
+  end
+
+  describe '#each' do
+    it 'should yield each transaction' do
+      transactions = []
+      instance.each do |t|
+        transactions << t
+      end
+      transactions.should == instance.transactions
+    end
+  end
+end
+
 describe Qif::Reader do
   %w(dd/mm/yyyy mm/dd/yyyy dd/mm/yy mm/dd/yy).each do |format|
-    before do
-      @file = 'spec/fixtures/3_records_%s.qif' % format.gsub('/', '')
-      @instance = Qif::Reader.new(open(@file), format)
-    end
-    
-    it 'should have 3 records' do
-      @instance.size.should == 3
-    end
-    
-    it 'should have a debit of $10 on the 1st of January 2010' do
-      transaction = @instance.transactions.detect{|t| t.date == Time.mktime(2010, 1, 1)}
-      transaction.should_not be_nil
-      transaction.name.should == 'Debit'
-      transaction.amount.should == -10.0
-    end
-    
-    it 'should have a debit of $20 on the 1st of June 1020' do
-      transaction = @instance.transactions.detect{|t| t.date == Time.mktime(2010, 6, 1)}
-      transaction.should_not be_nil
-      transaction.name.should == 'Debit'
-      transaction.amount.should == -20.0
-    end
-    
-    it 'should have a credit of $30 on the 29th of December 2010' do
-      transaction = @instance.transactions.detect{|t| t.date == Time.mktime(2010, 12, 29)}
-      transaction.should_not be_nil
-      transaction.name.should == 'Credit'
-      transaction.amount.should == 30.0
-    end
-    
-    describe '#each' do
-      it 'should yield each transaction' do
-        transactions = []
-        @instance.each do |t|
-          transactions << t
-        end
-        transactions.should == @instance.transactions
+    context "when format is #{format}" do
+      it_behaves_like "3 record files" do
+        let(:instance) { Qif::Reader.new(open('spec/fixtures/3_records_%s.qif' % format.gsub('/', '')).read, format) }
       end
     end
   end
-  
+
+  context "it should still work when the record header is followed by an invalid transaction terminator" do
+    it_behaves_like "3 record files" do
+      let(:instance) { Qif::Reader.new(open('spec/fixtures/3_records_invalid_header.qif'), 'dd/mm/yy') }
+    end
+  end
+
   it 'should initialize with an io object' do
     @instance = Qif::Reader.new(open('spec/fixtures/3_records_ddmmyyyy.qif'))
     @instance.size.should == 3
@@ -57,4 +66,4 @@ describe Qif::Reader do
     @instance = Qif::Reader.new(open('spec/fixtures/3_records_ddmmyyyy.qif'), 'mm/dd/yyyy')
     @instance.size.should == 2
   end
-end
+end

metadata

@@ -1,12 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: qif
 version: !ruby/object:Gem::Version 
-  hash: 13
+  hash: 3
   prerelease: false
   segments: 
   - 0
-  - 3
-  version: "0.3"
+  - 4
+  version: "0.4"
 platform: ruby
 authors: 
 - Jeremy Wells
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-11-09 00:00:00 +13:00
+date: 2010-11-24 00:00:00 +13:00
 default_executable: 
 dependencies: []
 
@@ -63,6 +63,8 @@ rdoc_options:
 - --inline-source
 - --title
 - Qif
+- --main
+- README.rdoc
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement