qbrick 2.5.0.pre → 2.5.0

data/spec/features/cms_pages_spec.rb

@@ -2,11 +2,15 @@
 
 require 'spec_helper'
 
-describe 'Cms/Pages' do
+describe 'Cms/Pages', type: :feature do
+  before do
+    admin = FactoryGirl.create(:admin)
+    login_as(admin, scope: :admin)
+  end
 
   context '#new' do
     before do
-      visit kuhsaft.new_cms_page_path
+      visit qbrick.new_cms_page_path
       fill_in 'Title', with: 'The Title of the page'
       fill_in 'Keywords', with: 'My keywords'
       fill_in 'Description', with: 'My Description'
@@ -15,24 +19,24 @@ describe 'Cms/Pages' do
     describe '#create' do
       context 'when page is valid' do
         it 'creates a new page' do
-          expect { click_on 'Create Page' }.to change(Kuhsaft::Page, :count).by(1)
+          expect { click_on 'Create Page' }.to change(Qbrick::Page, :count).by(1)
         end
 
         it 'is not possible to change the value in url' do
-          page.find('#page_url')['disabled'].should be_true
+          expect(page.find('#page_url')['disabled']).to be_truthy
         end
       end
 
       context 'when page is invalid' do
         it 'does not create a routing error by switching the locale' do
           @page = FactoryGirl.create(:page, title: 'DummyPage', title_en: 'DummyEN', slug: 'dummy_page')
-          visit kuhsaft.edit_cms_page_path(@page)
+          visit qbrick.edit_cms_page_path(@page)
           fill_in 'page_title', with: ''
           click_on 'Update Page'
-          within '.nav-pills' do
+          within '.language-navigation' do
             click_on 'EN'
           end
-          page.should have_content(@page.title_en)
+          expect(page).to have_content(@page.title_en)
         end
       end
     end
@@ -41,7 +45,7 @@ describe 'Cms/Pages' do
       context 'when creating a redirect page' do
         before do
           @page = FactoryGirl.create(:page, url: 'de/dumdidum')
-          visit kuhsaft.edit_cms_page_path(@page)
+          visit qbrick.edit_cms_page_path(@page)
           select 'redirect', from: 'Pagetyp'
         end
 
@@ -52,7 +56,7 @@ describe 'Cms/Pages' do
 
         it 'is invalid when no value is in redirect_page' do
           click_on 'Update Page'
-          page.should have_css('.error', count: 1)
+          expect(page).to have_css('.error', count: 1)
         end
 
         it 'does not change the value in url' do
@@ -69,8 +73,8 @@ describe 'Cms/Pages' do
       invalid_brick = FactoryGirl.build(:text_brick, text: nil, brick_list: @page)
       invalid_brick.save(validate: false)
 
-      visit kuhsaft.edit_cms_page_path(@page)
-      page.should have_css('.error', count: 1)
+      visit qbrick.edit_cms_page_path(@page)
+      expect(page).to have_css('.error', count: 1)
     end
   end
 end

data/spec/features/search_spec.rb

@@ -1,13 +1,13 @@
 require 'spec_helper'
 
-describe 'pages#index' do
+describe 'pages#index', type: :feature do
   context 'with search parameter' do
     let! :page1 do
       p = create :page,
                  published: true,
                  title: 'Chromodorididae Ardeadoris'
-      p.bricks << Kuhsaft::TextBrick.new(locale: I18n.locale,
-                                         text: "#{'foo bar' * 300} Chromodorididae #{'foo bar' * 300}")
+      p.bricks << Qbrick::TextBrick.new(locale: I18n.locale,
+                                        text: "#{'foo bar' * 300} Chromodorididae #{'foo bar' * 300}")
       p.save!
       p
     end
@@ -26,52 +26,52 @@ describe 'pages#index' do
 
     context 'with fulltext' do
       before do
-        visit kuhsaft.pages_path(locale: :en, search: 'Chromodorididae')
+        visit qbrick.pages_path(locale: :en, search: 'Chromodorididae')
       end
 
       it 'highlights search term in preview' do
         within('ul.search-results.success') do
-          page.should have_content('Chromodorididae')
+          expect(page).to have_content('Chromodorididae')
         end
       end
 
       it 'truncates the text' do
-        find('.summary .excerpt').text.length.should == 110
+        expect(find('.summary .excerpt').text.length).to eq(110)
       end
     end
 
     context 'with multiple matches' do
       before do
-        visit kuhsaft.pages_path(locale: :en, search: 'Chromodorididae')
+        visit qbrick.pages_path(locale: :en, search: 'Chromodorididae')
       end
 
       it 'renders match count' do
-        page.should have_content('2 results')
+        expect(page).to have_content('2 results')
       end
 
       it 'renders the search results list' do
         within('ul.search-results.success') do
-          page.should have_content('Chromodorididae Ardeadoris')
-          page.should have_content('Chromodorididae Berlanguella')
-          page.should_not have_content('Gastropoda')
+          expect(page).to have_content('Chromodorididae Ardeadoris')
+          expect(page).to have_content('Chromodorididae Berlanguella')
+          expect(page).not_to have_content('Gastropoda')
         end
       end
 
       it 'renders links to the pages' do
         within('ul.search-results.success') do
-          page.should have_link('Chromodorididae Ardeadoris', href: page1.link)
-          page.should have_link('Chromodorididae Berlanguella', href: page2.link)
+          expect(page).to have_link('Chromodorididae Ardeadoris', href: page1.link)
+          expect(page).to have_link('Chromodorididae Berlanguella', href: page2.link)
         end
       end
     end
 
     context 'without matches' do
       before do
-        visit kuhsaft.pages_path(locale: :en, search: 'foobar')
+        visit qbrick.pages_path(locale: :en, search: 'foobar')
       end
 
       it 'renders match count' do
-        page.should have_content('No results')
+        expect(page).to have_content('No results')
       end
     end
   end

data/spec/features_helper.rb

@@ -0,0 +1,36 @@
+require_relative './postgres_helper'
+
+def test_app_path
+  File.expand_path(File.join(File.dirname(__FILE__), '../spec/dummy'))
+end
+
+def reload_application_gemfile
+  ENV['BUNDLE_GEMFILE'] = File.expand_path('../../Gemfile', __FILE__)
+end
+
+def application_file_path(file)
+  File.join test_app_path, file
+end
+
+def application_file(file)
+  File.read(application_file_path file)
+end
+
+def drop_qbrick_scaffold_for(name)
+  app_path = test_app_path
+  unless File.exist? app_path
+    puts "won't destroy scaffold for #{name.inspect} while app #{app_path} doesn't exist."
+    return
+  end
+
+  Dir.chdir(app_path) do
+    database_name = app_path.split('/').last
+    rails "destroy scaffold #{name}"
+    rails "destroy scaffold #{name.pluralize}"
+    rails "destroy scaffold cms/#{name.pluralize}"
+    database = "#{database_name}_test"
+    next unless Postgres.database_exists? database
+
+    Postgres.drop_table database_name, database, name
+  end
+end

data/spec/generators/custom_model_generator_spec.rb

@@ -0,0 +1,83 @@
+require 'spec_helper'
+require 'features_helper'
+require_relative '../command_wrapper_helper.rb'
+
+describe 'rails generate qbrick:custom_model', generator: true do
+  let(:cars_controller) { application_file 'app/controllers/cms/cars_controller.rb' }
+
+  it 'is available in the generated app' do
+    cli_output = rails 'generate'
+    expect(cli_output).to match(/qbrick:custom_model/)
+  end
+
+  context 'generating a cms resource' do
+    before :all do
+      rails 'destroy scaffold cms/car'
+      rails 'destroy scaffold car'
+      `rm -rf #{File.join test_app_path, 'db/migrate/*_cars*'}`
+      rails 'generate qbrick:custom_model car tires:integer model:string'
+    end
+
+    after :all do
+      drop_qbrick_scaffold_for('car')
+      `rm #{File.join test_app_path, 'app/controllers/qbrick/base_controller.rb'}`
+      `rm -r #{File.join test_app_path, 'app/views/qbrick'}`
+      `rm -r #{File.join test_app_path, 'config/locales/de'}`
+    end
+
+    context 'for the first time' do
+      it 'sets up the cms routes namespace' do
+        expect(application_file('config/routes.rb')).to match(/namespace :cms do/)
+      end
+
+      it 'generates inherited resource views' do
+        views = Dir[File.join(test_app_path, 'app/views/qbrick/base/*.html.haml')]
+        views.map! { |v| v.scan(%r{^.+app/views/qbrick/base/(.*).html.haml}).flatten.first.to_sym }
+        expected_action_views = [:edit, :index, :new, :_form]
+        expect(expected_action_views - views).to be_empty
+      end
+    end
+
+    context 'generates a CRUD controller' do
+      it 'inherits from the qbrick base controller' do
+        expect(application_file('app/controllers/cms/cars_controller.rb')).to match(/Qbrick..BaseController/)
+      end
+    end
+
+    it 'generates a model' do
+      expect(application_file('app/models/car.rb')).not_to be_nil
+    end
+
+    it 'uses the fields given in the command line to pre-fill editable and index attributes' do
+      expect(application_file('app/models/car.rb')).to match('editable_attributes :tires, :model')
+      expect(application_file('app/models/car.rb')).to match('index_attributes :tires, :model')
+    end
+
+    it 'generates a migration' do
+      expect(Dir.glob("#{test_app_path}/db/migrate/*create*cars*").size).to be 1
+    end
+
+    it 'adds a resource route' do
+      expect(application_file('config/routes.rb')).to match(/resources :cars/)
+    end
+
+    it 'does not generate routing specs' do
+      routing_spec = File.join(test_app_path, 'spec/routing/cars_routing_spec.rb')
+      expect(File.exist? routing_spec).to be(false)
+    end
+
+    it 'does not generate view specs' do
+      view_specs = File.join(test_app_path, 'spec/views/cars')
+      expect(File.exist? view_specs).to be(false)
+    end
+
+    it 'does not generate controller specs' do
+      controller_specs = File.join(test_app_path, 'spec/controllers/cars_controller_spec.rb')
+      expect(File.exist? controller_specs).to be(false)
+    end
+
+    it 'does not generate json views' do
+      expect(Dir.glob("#{test_app_path}/app/views/cars/*.jbuilder").size).to be 0
+    end
+  end
+end

data/spec/helpers/{kuhsaft → qbrick}/cms/admin_helper_spec.rb

@@ -1,24 +1,24 @@
 require 'spec_helper'
 
-describe Kuhsaft::Cms::AdminHelper do
+describe Qbrick::Cms::AdminHelper, type: :helper do
   describe '#render_language_switch?' do
     context 'when there is one language' do
       before do
-        I18n.stub(:available_locales).and_return([:de])
+        allow(I18n).to receive(:available_locales).and_return([:de])
       end
 
       it 'returns false' do
-        helper.render_language_switch?.should be_false
+        expect(helper.render_language_switch?).to be_falsey
       end
     end
 
     context 'when there are multiple languages' do
       before do
-        I18n.stub(:available_locales).and_return([:de, :en])
+        allow(I18n).to receive(:available_locales).and_return([:de, :en])
       end
 
       it 'returns true' do
-        helper.render_language_switch?.should be_true
+        expect(helper.render_language_switch?).to be_truthy
       end
     end
   end

data/spec/helpers/{kuhsaft → qbrick}/cms/pages_helper_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Kuhsaft::Cms::PagesHelper do
+describe Qbrick::Cms::PagesHelper, type: :helper do
   describe '#content_tab_active' do
     it 'returns active when page has a title and no errors' do
       @page = create(:page, title: 'Page 1', slug: 'page1')
@@ -28,19 +28,19 @@ describe Kuhsaft::Cms::PagesHelper do
     it 'has a page without translations' do
       @page = create(:page, title: 'Page 1', slug: 'page1')
       I18n.with_locale :de do
-        expect(helper.hide_content_tab?(@page)).to be_true
+        expect(helper.hide_content_tab?(@page)).to be_truthy
       end
     end
 
     it 'has a redirect page' do
       @page = create(:page, title: 'Page 1', slug: 'page1',
-                            page_type: Kuhsaft::PageType::REDIRECT, redirect_url: 'en/references')
-      expect(helper.hide_content_tab?(@page)).to be_true
+                            page_type: Qbrick::PageType::REDIRECT, redirect_url: 'en/references')
+      expect(helper.hide_content_tab?(@page)).to be_truthy
     end
 
     it 'has a not saved page' do
-      @page = Kuhsaft::Page.new
-      expect(helper.hide_content_tab?(@page)).to be_true
+      @page = Qbrick::Page.new
+      expect(helper.hide_content_tab?(@page)).to be_truthy
     end
   end
 end

data/spec/helpers/{kuhsaft → qbrick}/pages_helper_spec.rb

@@ -1,14 +1,13 @@
 require 'spec_helper'
 
-describe PagesHelper do
+describe PagesHelper, type: :helper do
   describe '#search_page_form' do
-
     context 'without block' do
       it 'renders the default search form' do
         form = search_page_form
-        form.should have_css('form.form-inline')
-        form.should have_css('input[type=text]')
-        form.should have_css('input[type=submit]')
+        expect(form).to have_css('form.form-inline')
+        expect(form).to have_css('input[type=text]')
+        expect(form).to have_css('input[type=submit]')
       end
     end
 

data/spec/lib/brick_list_spec.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
+require 'rspec/active_model/mocks'
 
-describe Kuhsaft::BrickList do
-
+describe Qbrick::BrickList do
   class TestBrick
-    include Kuhsaft::BrickList
+    include Qbrick::BrickList
   end
 
   let :brick do
@@ -13,21 +13,22 @@ describe Kuhsaft::BrickList do
   describe '#collect_fulltext' do
     context 'with bricks' do
       it 'collects its childs fulltext' do
-        brick.stub_chain(:bricks, :localized).and_return([mock_model(Kuhsaft::Brick, collect_fulltext: 'hallo')])
-        brick.collect_fulltext.should == 'hallo'
+        result = [mock_model(Qbrick::Brick, collect_fulltext: 'hallo')]
+        allow(brick).to receive_message_chain(:bricks, :localized).and_return(result)
+        expect(brick.collect_fulltext).to eq('hallo')
       end
     end
 
     context 'with bricks without content' do
       it 'returns a string' do
-        brick.stub_chain(:bricks, :localized).and_return([])
-        brick.collect_fulltext.should == ''
+        allow(brick).to receive_message_chain(:bricks, :localized).and_return([])
+        expect(brick.collect_fulltext).to eq('')
       end
     end
 
     context 'without bricks' do
       it 'returns a string' do
-        brick.collect_fulltext.should == ''
+        expect(brick.collect_fulltext).to eq('')
       end
 
       it 'does not fail' do
@@ -38,13 +39,13 @@ describe Kuhsaft::BrickList do
 
   describe '#allowed_brick_types' do
     it 'returns an array of possible classes as strings' do
-      brick.allowed_brick_types.should be_a(Array)
+      expect(brick.allowed_brick_types).to be_a(Array)
     end
   end
 
   describe '#brick_types' do
-    it 'returns a Kuhsaft::BrickTypeFilter' do
-      brick.brick_types.should be_a(Kuhsaft::BrickTypeFilter)
+    it 'returns a Qbrick::BrickTypeFilter' do
+      expect(brick.brick_types).to be_a(Qbrick::BrickTypeFilter)
     end
   end
 end

data/spec/lib/engine_spec.rb

@@ -1,25 +1,21 @@
 require 'spec_helper'
 
-describe Kuhsaft::Engine do
-
+describe Qbrick::Engine do
   describe '.configure' do
-
     describe '.image_sizes' do
       it 'delegates .clear to ImageSize' do
-        Kuhsaft::ImageSize.should_receive(:clear!)
-        Kuhsaft::Engine.configure do
+        expect(Qbrick::ImageSize).to receive(:clear!)
+        Qbrick::Engine.configure do
           config.image_sizes.clear!
         end
       end
 
       it 'delegates .add to ImageSize' do
-        Kuhsaft::ImageSize.should_receive(:add).with(:something, 100, 200)
-        Kuhsaft::Engine.configure do
+        expect(Qbrick::ImageSize).to receive(:add).with(:something, 100, 200)
+        Qbrick::Engine.configure do
           config.image_sizes.add(:something, 100, 200)
         end
       end
     end
-
   end
-
 end