qa_server 7.6.0 → 7.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 76e06f7b15b4f8041797890dd3e4f7c362d73e73a31808060361cbcf16b4fe46
-  data.tar.gz: efbd4527118c03ea42c1075a69196fd4aa6696a524d2c675085a280aa0838d5d
+  metadata.gz: 57808d7b02e3ca992f1d927f43dd6630025451e6fb6c7cebab7ed2882acd79c9
+  data.tar.gz: 3ab76c0ebda5fd6e1ebe9811ff522bf0a7d13e0461b28a4b7a421ac5bdd66a18
 SHA512:
-  metadata.gz: d22de7e60cfb453837013bc4b0ca6df756bfbc9f180ea9d27f28734a6822e3606dd32f73cd1fd8eb9fd563985ce706c9e18fb4055129fa3c17a6cc11f6955deb
-  data.tar.gz: c334da18f0a702644149e7228ecfb2407234feb3fe3e663388429f5513e3ca1a3f39ba9f364ce48213b17907b7bb0a27b4dbd53eb21d157047c7b254eeb8bacb
+  metadata.gz: 77d4103d2ff49636bf353f8d5ca93019fb2f477c90ff62e9f94832d9d7f387ed3be3f1577692025863882c53bbc38ae2020a1435a6d84379e73d1bee4bb06714
+  data.tar.gz: b99e3284b1e690236f83e088fd78ece19e743a995ad65342da4d8b75022e962b96478222529132d1965521a7a57e5c01a0b38cd5bc68e05fd6e709ea6c334970

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+### 7.7.0 (2021-04-13)
+
+* remove unused translations
+* show notification when refreshing starts on monitor status page
+* hide data in Authority Connection History for non-active authorities
+* loosen threshold for caution in historical uptime table
+* minor tweaks missed in original sync
+
 ### 7.6.0 (2021-04-12)
 
 * update authority configs and test scenarios to use the new cache indexing with results stored as blobs in the index

data/app/controllers/qa_server/monitor_status_controller.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 # Controller for Monitor Status header menu item
 module QaServer
-  class MonitorStatusController < ApplicationController
+  class MonitorStatusController < ApplicationController # rubocop:disable Metrics/ClassLength
     layout 'qa_server'
 
     include QaServer::AuthorityValidationBehavior
@@ -77,7 +77,8 @@ module QaServer
     end
 
     def refresh?
-      params.key?(:refresh) && validate_auth_reload_token("refresh status")
+      return @refresh unless @refresh.nil?
+      @refresh ||= params.key?(:refresh) && validate_auth_reload_token("refresh status")
     end
 
     def refresh_all?
@@ -86,15 +87,36 @@ module QaServer
     end
 
     def refresh_tests?
-      refresh? ? (refresh_all? || params[:refresh].casecmp?('tests')) : false
+      return @refresh_tests unless @refresh_tests.nil?
+      @refresh_tests = refresh? && (refresh_all? || params[:refresh].casecmp?('tests'))
+      if @refresh_tests
+        msg = I18n.t('qa_server.monitor_status.refreshing_tests')
+        logger.info msg
+        flash.now[:success] = msg
+      end
+      @refresh_tests
     end
 
     def refresh_history?
-      refresh? ? (refresh_all? || params[:refresh].casecmp?('history')) : false
+      return @refresh_history unless @refresh_history.nil?
+      @refresh_history = refresh? && (refresh_all? || params[:refresh].casecmp?('history'))
+      if @refresh_history
+        msg = I18n.t('qa_server.monitor_status.refreshing_history')
+        logger.info msg
+        flash.now[:success] = msg
+      end
+      @refresh_history
     end
 
     def refresh_performance?
-      refresh? ? (refresh_all? || params[:refresh].casecmp?('performance')) : false
+      return @refresh_performance unless @refresh_performance.nil?
+      @refresh_performance = refresh? && (refresh_all? || params[:refresh].casecmp?('performance'))
+      if @refresh_performance
+        msg = I18n.t('qa_server.monitor_status.refreshing_performance')
+        logger.info msg
+        flash.now[:success] = msg
+      end
+      @refresh_performance
     end
 
     def refresh_performance_table?
@@ -117,7 +139,7 @@ module QaServer
       token = params.key?(:auth_token) ? params[:auth_token] : nil
       valid = Qa.config.valid_authority_reload_token?(token)
       return true if valid
-      msg = "Permission denied. Unable to #{action}."
+      msg = I18n.t('qa_server.monitor_status.permission_denied', action: action)
       logger.warn msg
       flash.now[:error] = msg
       false

data/app/models/qa_server/scenario_run_history.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 # Provide access to the scenario_run_history database table which tracks scenario runs over time.
 module QaServer
-  class ScenarioRunHistory < ApplicationRecord
+  class ScenarioRunHistory < ApplicationRecord # rubocop:disable Metrics/ClassLength
     self.table_name = 'scenario_run_history'
     belongs_to :scenario_run_registry
     enum scenario_type: { connection: 0, accuracy: 1, performance: 2 }, _suffix: :type
@@ -11,9 +11,9 @@ module QaServer
     BAD_MARKER = 'X'
     UNKNOWN_MARKER = '?'
 
-    class_attribute :summary_class
-
+    class_attribute :summary_class, :authority_lister_class
     self.summary_class = QaServer::ScenarioRunSummary
+    self.authority_lister_class = QaServer::AuthorityListerService
 
     class << self
       # Save a scenario result
@@ -92,12 +92,21 @@ module QaServer
         days_unknown = count_days(:unknown)
         keys = (days_good.keys + days_bad.keys + days_unknown.keys).uniq.sort
         keys.each_with_object({}) do |auth, hash|
+          next unless active_authority? auth
           hash[auth] = { good: day_count(auth, days_good), bad: day_count(auth, days_bad) + day_count(auth, days_unknown) }
         end
       end
 
     private
 
+      def active_authority?(auth)
+        active_authorities.include? auth.to_sym
+      end
+
+      def active_authorities
+        @active_authorities = authority_lister_class.authorities_list
+      end
+
       def day_count(auth, days)
         days&.key?(auth) ? days[auth] : 0
       end

data/app/presenters/qa_server/monitor_status/history_presenter.rb

@@ -2,6 +2,9 @@
 # This presenter class provides historical testing data needed by the view that monitors status of authorities.
 module QaServer::MonitorStatus
   class HistoryPresenter
+    CAUTION_THRESHOLD = 0.05
+    WARNING_THRESHOLD = 0.1
+
     # @param parent [QaServer::MonitorStatusPresenter] parent presenter
     # @param historical_summary_data [Array<Hash>] summary of past failuring runs per authority to drive chart
     def initialize(parent:, historical_summary_data:)
@@ -94,8 +97,8 @@ module QaServer::MonitorStatus
     end
 
     def failure_style_class(historical_entry)
-      return "status-neutral" if days_authority_failing(historical_entry) <= 0
-      percent_authority_failing(historical_entry) < 0.10 ? "status-unknown" : "status-bad"
+      return "status-neutral" if days_authority_failing(historical_entry) <= CAUTION_THRESHOLD
+      percent_authority_failing(historical_entry) < WARNING_THRESHOLD ? "status-unknown" : "status-bad"
     end
 
     def passing_style_class(historical_entry)

data/config/locales/qa_server.en.yml

@@ -58,7 +58,11 @@ en:
       wait_message:      Fetching term...
       term_results:      Results
     monitor_status:
-      title:             Monitor Status
+      title:               Monitor Status
+      permission_denied:   'Permission denied. Unable to %{action}.'
+      refreshing_tests:    Refreshing tests.
+      refreshing_history:  Refreshing connection history.
+      refreshing_performance: Refreshing performance metrics.
       summary:
         title:           Latest Monitored Status
         summary_table:   Summary
@@ -72,7 +76,6 @@ en:
       failures:
         title:           Failures During Latest Status Update
         status:          Status
-        authority:       Authority
         subauthority:    Subauthority
         service:         Service
         action:          Action
@@ -80,7 +83,6 @@ en:
         errmsg:          Errors
       history:
         title:           Authority Connection History
-        since:           'Since %{date} ET'
         range:           'From %{from} to %{to}'
         authority:       Authority
         days_failing:    Days Failing
@@ -101,7 +103,6 @@ en:
         graph_load_time_ms:    Graph Load Time (ms)
         normalization_time_ms: Normalization Time (ms)
         retrieve_time_ms:      Retrieve Time (ms)
-        full_request_time_ms:  Full Request Time (ms)
         x_axis_hour:     Hour
         x_axis_day:      Day
         x_axis_month:    Month
@@ -114,7 +115,6 @@ en:
         datatable_month_desc: 'Month'
         datatable_year_desc:  'Year'
         datarange:            'From %{from} to %{to}'
-        authority:            Authority
         average_times:        Average (ms)
         fastest_times:        10th percentile (ms)
         slowest_times:        90th percentile (ms)

data/lib/generators/qa_server/templates/config/authorities/linked_data/locvocabs_ld4l_cache.json

@@ -12,7 +12,7 @@
     "url": {
       "@context": "http://www.w3.org/ns/hydra/context.jsonld",
       "@type": "IriTemplate",
-      "template": "http://wintermute.info-science.uiowa.edu:8081/ld4l_services/loc_vocab_batch.jsp?{?query}&{?entity}&{?maxRecords}&{?startRecord}&{?lang}",
+      "template": "http://services.ld4l.org/ld4l_services/loc_vocab_batch.jsp?{?query}&{?entity}&{?maxRecords}&{?startRecord}&{?lang}",
       "variableRepresentation": "BasicRepresentation",
       "mapping": [
         {

data/lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/cerl_ld4l_cache_validation.yml

@@ -64,10 +64,10 @@ search:
   -
     query: Plantin
     subauth: imprint
-    position: 18
+    position: 1
     subject_uri: "http://thesaurus.cerl.org/record/cni00007649"
     replacements:
-      maxRecords: '30'
+      maxRecords: '8'
 term:
   -
     identifier: "http://thesaurus.cerl.org/record/cnp00895966"

data/lib/qa_server/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module QaServer
-  VERSION = '7.6.0'
+  VERSION = '7.7.0'
 end

data/spec/i18n_spec.rb

@@ -14,7 +14,6 @@ RSpec.describe I18n do
   end
 
   it 'does not have unused keys' do
-    pending 'need to explore unused keys further'
     expect(unused_keys).to be_empty,
                            "#{unused_keys.leaves.count} unused i18n keys, run `i18n-tasks unused' to show them"
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: qa_server
 version: !ruby/object:Gem::Version
-  version: 7.6.0
+  version: 7.7.0
 platform: ruby
 authors:
 - E. Lynette Rayle
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-12 00:00:00.000000000 Z
+date: 2021-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails