qa_server 7.5.0 → 7.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9b6bf0cabbc1c7f810733789f43c7f0b253f71b0d887fd5be6638aacd3a7e6be
-  data.tar.gz: '0988c35dcea9f1dd1dc565db686835bd63a5812c5ed198f0d39f3e83a055e684'
+  metadata.gz: 794b6a1df8268f9b316ba8626f45ace1241f5208538c2dab2965c36077ce8ad3
+  data.tar.gz: ad7b9425e8f9d4fcdca98dfa0f6ae31ac0fa6a0fe5d4b6b8207d648db023edfd
 SHA512:
-  metadata.gz: ee5d4b62a4176cdc00a31446541a9e421506cc1ceca98066ff684a51346c976ced23a6778931365f5023ede8ec4d52784326b0af52865599c078401363e34444
-  data.tar.gz: 545ee665c7eceb70ed8459033d86247eeb4a414010b95a41f2cfe4393983e809e9b7756027c6da115df3ea6452f2f97643ba53e2976614f151a2b9578ec59a68
+  metadata.gz: 2efb90f8b0d3409fc7058557497820476791b642db776ef406855c3e4c5d3bd581e0661662b8eeb74dec146f59ae7e9a5a5a1aad36c297524ab6a88ee07e6505
+  data.tar.gz: 5f32bb54311cbd6cc58c4f6cf4017c7dff1d64047672af9b303cb57a3dae7010e8d64353a49666d1e5378ab2ddb3f1f8108e48a7114926b49badda60a6f425bf

data/.rubocop_fixme.yml

@@ -16,5 +16,6 @@ Style/SpecialGlobalVars:
 Layout/AccessModifierIndentation:
   EnforcedStyle: outdent
 
-#Layout/IndentationWidth:
-#  Enabled: false
+Layout/HashAlignment:
+  Exclude:
+    - 'spec/presenters/qa_server/monitor_status/history_presenter_spec.rb'

data/.travis.yml

@@ -26,7 +26,7 @@ env:
   # It should be sufficient to test only the latest of the patch versions for a minor version, they
   # should be compatible across patch versions (only bug fixes are released in patch versions).
   matrix:
-    - "RAILS_VERSION=5.2.4"
+    - "RAILS_VERSION=5.2.5"
 
 services:
   - redis-server

data/CHANGELOG.md

@@ -1,3 +1,33 @@
+### 7.8.0 (2021-04-14)
+
+* add geographic subauth for Mesh-NLM
+* dogear expected and actual cells when accuracy test is pending
+
+### 7.7.1 (2021-04-14)
+
+* fix background colors in historical uptime table
+
+### 7.7.0 (2021-04-13)
+
+* remove unused translations
+* show notification when refreshing starts on monitor status page
+* hide data in Authority Connection History for non-active authorities
+* loosen threshold for caution in historical uptime table
+* minor tweaks missed in original sync
+
+### 7.6.0 (2021-04-12)
+
+* update authority configs and test scenarios to use the new cache indexing with results stored as blobs in the index
+* update to Rails 5.2.5
+* update dependencies
+* fix exception when first time running monitor status
+
+### 7.5.1 (2020-12-08)
+
+* define missing i18n translations
+* add i18n-tasks gem for managing translations
+* add spec test to check for missing translations
+
 ### 7.5.0 (2020-12-07)
 
 * UI improvements of check_status page

data/app/assets/stylesheets/qa_server/_check-status.scss

@@ -88,6 +88,10 @@ td.bold-left-border {
   border-left: 2px solid black;
 }
 
+.status-dogear {
+  background: linear-gradient(135deg, #333 0%, #333 10%, transparent 10%, transparent 100%);
+}
+
 .status-good {
   text-align: center;
   background-color: #ccffcc;

data/app/controllers/qa_server/monitor_status_controller.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 # Controller for Monitor Status header menu item
 module QaServer
-  class MonitorStatusController < ApplicationController
+  class MonitorStatusController < ApplicationController # rubocop:disable Metrics/ClassLength
     layout 'qa_server'
 
     include QaServer::AuthorityValidationBehavior
@@ -21,7 +21,7 @@ module QaServer
                                        historical_summary_data: historical_data,
                                        performance_data: performance_table_data)
       QaServer.config.monitor_logger.debug("~~~~~~~~ DONE rendering monitor status")
-      render 'index', status: :internal_server_error if latest_summary.failing_authority_count.positive?
+      render 'index', status: :internal_server_error if latest_summary&.failing_authority_count&.positive?
     end
 
   private
@@ -43,13 +43,13 @@ module QaServer
 
     # @returns [QaServer::ScenarioRunSummary] summary statistics on the latest run
     def latest_summary
-      QaServer::ScenarioRunSummaryCache.summary_for_run(run: latest_test_run)
+      latest_test_run ? QaServer::ScenarioRunSummaryCache.summary_for_run(run: latest_test_run) : nil
     end
 
     # @returns [Array<Hash>] scenario details for any failing scenarios in the latest run
     # @see QaServer::ScenarioRunHistory#run_failures for structure of output
     def latest_failures
-      QaServer::ScenarioRunFailuresCache.failures_for_run(run: latest_test_run)
+      latest_test_run ? QaServer::ScenarioRunFailuresCache.failures_for_run(run: latest_test_run) : nil
     end
 
     # Get a summary level of historical data
@@ -77,7 +77,8 @@ module QaServer
     end
 
     def refresh?
-      params.key?(:refresh) && validate_auth_reload_token("refresh status")
+      return @refresh unless @refresh.nil?
+      @refresh ||= params.key?(:refresh) && validate_auth_reload_token("refresh status")
     end
 
     def refresh_all?
@@ -86,15 +87,36 @@ module QaServer
     end
 
     def refresh_tests?
-      refresh? ? (refresh_all? || params[:refresh].casecmp?('tests')) : false
+      return @refresh_tests unless @refresh_tests.nil?
+      @refresh_tests = refresh? && (refresh_all? || params[:refresh].casecmp?('tests'))
+      if @refresh_tests
+        msg = I18n.t('qa_server.monitor_status.refreshing_tests')
+        logger.info msg
+        flash.now[:success] = msg
+      end
+      @refresh_tests
     end
 
     def refresh_history?
-      refresh? ? (refresh_all? || params[:refresh].casecmp?('history')) : false
+      return @refresh_history unless @refresh_history.nil?
+      @refresh_history = refresh? && (refresh_all? || params[:refresh].casecmp?('history'))
+      if @refresh_history
+        msg = I18n.t('qa_server.monitor_status.refreshing_history')
+        logger.info msg
+        flash.now[:success] = msg
+      end
+      @refresh_history
     end
 
     def refresh_performance?
-      refresh? ? (refresh_all? || params[:refresh].casecmp?('performance')) : false
+      return @refresh_performance unless @refresh_performance.nil?
+      @refresh_performance = refresh? && (refresh_all? || params[:refresh].casecmp?('performance'))
+      if @refresh_performance
+        msg = I18n.t('qa_server.monitor_status.refreshing_performance')
+        logger.info msg
+        flash.now[:success] = msg
+      end
+      @refresh_performance
     end
 
     def refresh_performance_table?
@@ -117,7 +139,7 @@ module QaServer
       token = params.key?(:auth_token) ? params[:auth_token] : nil
       valid = Qa.config.valid_authority_reload_token?(token)
       return true if valid
-      msg = "Permission denied. Unable to #{action}."
+      msg = I18n.t('qa_server.monitor_status.permission_denied', action: action)
       logger.warn msg
       flash.now[:error] = msg
       false

data/app/models/qa_server/scenario_run_history.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 # Provide access to the scenario_run_history database table which tracks scenario runs over time.
 module QaServer
-  class ScenarioRunHistory < ApplicationRecord
+  class ScenarioRunHistory < ApplicationRecord # rubocop:disable Metrics/ClassLength
     self.table_name = 'scenario_run_history'
     belongs_to :scenario_run_registry
     enum scenario_type: { connection: 0, accuracy: 1, performance: 2 }, _suffix: :type
@@ -11,9 +11,9 @@ module QaServer
     BAD_MARKER = 'X'
     UNKNOWN_MARKER = '?'
 
-    class_attribute :summary_class
-
+    class_attribute :summary_class, :authority_lister_class
     self.summary_class = QaServer::ScenarioRunSummary
+    self.authority_lister_class = QaServer::AuthorityListerService
 
     class << self
       # Save a scenario result
@@ -92,12 +92,21 @@ module QaServer
         days_unknown = count_days(:unknown)
         keys = (days_good.keys + days_bad.keys + days_unknown.keys).uniq.sort
         keys.each_with_object({}) do |auth, hash|
+          next unless active_authority? auth
           hash[auth] = { good: day_count(auth, days_good), bad: day_count(auth, days_bad) + day_count(auth, days_unknown) }
         end
       end
 
     private
 
+      def active_authority?(auth)
+        active_authorities.include? auth.to_sym
+      end
+
+      def active_authorities
+        @active_authorities = authority_lister_class.authorities_list
+      end
+
       def day_count(auth, days)
         days&.key?(auth) ? days[auth] : 0
       end

data/app/models/qa_server/search_scenario.rb

@@ -60,5 +60,11 @@ module QaServer
     def subauthority?
       subauthority_name.present?
     end
+
+    def context?
+      # don't include context for accuracy tests
+      return false if expected_by_position.present?
+      super
+    end
   end
 end

data/app/presenters/qa_server/check_status_presenter.rb

@@ -81,7 +81,7 @@ module QaServer
 
     # @return [String] the name of the css style class to use for the status cell based on the status of the scenario test.
     def status_style_class(status)
-      "status-#{status}"
+      status[:pending] ? "status-dogear status-#{status[:status]}" : "status-#{status[:status]}"
     end
 
     # @return [String] the name of the css style class to use for the status cell based on the status of the scenario test.

data/app/presenters/qa_server/monitor_status/current_status_presenter.rb

@@ -13,12 +13,13 @@ module QaServer::MonitorStatus
 
     # @return [ActiveSupport::TimeWithZone] date time stamp of last test run
     def last_updated_dt
-      @current_summary.run_dt_stamp
+      @current_summary ? @current_summary.run_dt_stamp : QaServer::TimeService.current_time
     end
 
     # @return [String] date with time of last test run
     def last_updated
-      QaServer::TimeService.pretty_time(last_updated_dt)
+      return I18n.t('qa_server.monitor_status.summary.no_data') if @current_summary.blank?
+      I18n.t('qa_server.monitor_status.summary.last_updated', date: QaServer::TimeService.pretty_time(last_updated_dt))
     end
 
     # @return [ActiveSupport::TimeWithZone] date time stamp of first recorded test run
@@ -33,12 +34,12 @@ module QaServer::MonitorStatus
 
     # @return [Integer] number of loaded authorities
     def authorities_count
-      @current_summary.authority_count
+      @current_summary ? @current_summary.authority_count : "N/A"
     end
 
     # @return [Integer] number of authorities with failing tests in the latest test run
     def failing_authorities_count
-      @current_failure_data.map { |f| f[:authority_name] }.uniq.count
+      @current_failure_data ? @current_failure_data.map { |f| f[:authority_name] }.uniq.count : "N/A"
     end
 
     # @return [String] css style class representing whether all tests passed or any failed
@@ -48,17 +49,17 @@ module QaServer::MonitorStatus
 
     # @return [Integer] number of tests in the latest test run
     def tests_count
-      @current_summary.total_scenario_count
+      @current_summary ? @current_summary.total_scenario_count : 0
     end
 
     # @return [Integer] number of passing tests in the latest test run
     def passing_tests_count
-      @current_summary.passing_scenario_count
+      @current_summary ? @current_summary.passing_scenario_count : 0
     end
 
     # @return [Integer] number of failing tests in the latest test run
     def failing_tests_count
-      @current_summary.failing_scenario_count
+      @current_summary ? @current_summary.failing_scenario_count : 0
     end
 
     # @return [String] css style class representing whether all tests passed or any failed
@@ -77,7 +78,7 @@ module QaServer::MonitorStatus
     #       url: '/qa/search/linked_data/locnames_ld4l_cache/person?q=mark twain&maxRecords=4',
     #       err_message: 'Exception: Something went wrong.' }, ... ]
     def failures
-      @current_failure_data
+      @current_failure_data ? @current_failure_data : []
     end
 
     # @return [Boolean] true if failure data exists for the latest test run; otherwise false

data/app/presenters/qa_server/monitor_status/history_presenter.rb

@@ -2,8 +2,16 @@
 # This presenter class provides historical testing data needed by the view that monitors status of authorities.
 module QaServer::MonitorStatus
   class HistoryPresenter
+    CAUTION_THRESHOLD = 0.05
+    WARNING_THRESHOLD = 0.1
+
     # @param parent [QaServer::MonitorStatusPresenter] parent presenter
     # @param historical_summary_data [Array<Hash>] summary of past failuring runs per authority to drive chart
+    # @example historical_summary_data
+    # {
+    #   "AGROVOC_DIRECT"=>{:good=>4, :bad=>0},
+    #   "AGROVOC_LD4L_CACHE"=>{:good=>4, :bad=>0}
+    # }
     def initialize(parent:, historical_summary_data:)
       @parent = parent
       @historical_summary_data = historical_summary_data
@@ -11,8 +19,10 @@ module QaServer::MonitorStatus
 
     # @return [Array<Hash>] historical test data to be displayed (authname, failing, passing)
     # @example
-    #   [ [ 'agrovoc', 0, 24 ],
-    #     [ 'geonames_ld4l_cache', 2, 22 ] ... ]
+    # {
+    #   "AGROVOC_DIRECT"=>{:good=>4, :bad=>0},
+    #   "AGROVOC_LD4L_CACHE"=>{:good=>4, :bad=>0}
+    # }
     def historical_summary
       @historical_summary_data
     end
@@ -69,47 +79,88 @@ module QaServer::MonitorStatus
       end
     end
 
+    # @param historical_entry [Array<String,Hash>] data for a single authority including name, # passing tests (good), # failing tests (bad)
+    # @return [String] name of the authority (e.g. 'AUTH_NAME')
+    # @example historical_entry
+    #   [ 'AUTH_NAME',  { good: 949, bad: 51 } ]
     def historical_data_authority_name(historical_entry)
       historical_entry[0]
     end
 
+    # @param historical_entry [Array<String,Hash>] data for a single authority including name, # passing tests (good), # failing tests (bad)
+    # @return [Integer] number of days with passing tests (e.g. 949)
+    # @example historical_entry
+    #   [ 'AUTH_NAME',  { good: 949, bad: 51 } ]
     def days_authority_passing(historical_entry)
       historical_entry[1][:good]
     end
 
+    # @param historical_entry [Array<String,Hash>] data for a single authority including name, # passing tests (good), # failing tests (bad)
+    # @return [Integer] number of days with failing tests (e.g. 51)
+    # @example historical_entry
+    #   [ 'AUTH_NAME',  { good: 949, bad: 51 } ]
     def days_authority_failing(historical_entry)
       historical_entry[1][:bad]
     end
 
+    # @param historical_entry [Array<String,Hash>] data for a single authority including name, # passing tests (good), # failing tests (bad)
+    # @return [Integer] number of days tested (e.g. 1000)
+    # @example historical_entry
+    #   [ 'AUTH_NAME',  { good: 949, bad: 51 } ]
     def days_authority_tested(historical_entry)
       days_authority_passing(historical_entry) + days_authority_failing(historical_entry)
     end
 
+    # @param historical_entry [Array<String,Hash>] data for a single authority including name, # passing tests (good), # failing tests (bad)
+    # @return [Float] percent of failing to passing tests (e.g. 0.05374 )
+    # @example historical_entry
+    #   [ 'AUTH_NAME',  { good: 949, bad: 51 } ]
     def percent_authority_failing(historical_entry)
       days_authority_failing(historical_entry).to_f / days_authority_tested(historical_entry)
     end
 
+    # @param historical_entry [Array<String,Hash>] data for a single authority including name, # passing tests (good), # failing tests (bad)
+    # @return [String] percent of failing to passing tests (e.g. '5.4%')
+    # @example historical_entry
+    #   [ 'AUTH_NAME',  { good: 949, bad: 51 } ]
     def percent_authority_failing_str(historical_entry)
       ActiveSupport::NumberHelper.number_to_percentage(percent_authority_failing(historical_entry) * 100, precision: 1)
     end
 
+    # @param historical_entry [Array<String,Hash>] data for a single authority including name, # passing tests (good), # failing tests (bad)
+    # @return [String] css class for background in Days Failing and Percent Failing columns (e.g. 'status-neutral', 'status-unknown', 'status-bad')
+    # @example historical_entry
+    #   [ 'AUTH_NAME',  { good: 949, bad: 51 } ]
     def failure_style_class(historical_entry)
-      return "status-neutral" if days_authority_failing(historical_entry) <= 0
-      percent_authority_failing(historical_entry) < 0.10 ? "status-unknown" : "status-bad"
+      case percent_authority_failing(historical_entry)
+      when 0.0...CAUTION_THRESHOLD
+        "status-neutral"
+      when CAUTION_THRESHOLD...WARNING_THRESHOLD
+        "status-unknown"
+      else
+        "status-bad"
+      end
     end
 
+    # @param historical_entry [Array<String,Hash>] data for a single authority including name, # passing tests (good), # failing tests (bad)
+    # @return [String] css class for background in Days Passing column (e.g. 'status-good', 'status-bad')
+    # @example historical_entry
+    #   [ 'AUTH_NAME',  { good: 949, bad: 51 } ]
     def passing_style_class(historical_entry)
       days_authority_passing(historical_entry) <= 0 ? "status-bad" : "status-good"
     end
 
+    # @return [Boolean] true if historical section should be visible; otherwise false
     def display_history_details?
       display_historical_graph? || display_historical_datatable?
     end
 
+    # @return [Boolean] true if historical graph should be visible; otherwise false
     def display_historical_graph?
       QaServer.config.display_historical_graph? && QaServer::HistoryGraphingService.history_graph_image_exists?
     end
 
+    # @return [Boolean] true if historical datatable should be visible; otherwise false
     def display_historical_datatable?
       QaServer.config.display_historical_datatable?
     end

data/app/views/qa_server/check_status/index.html.erb

@@ -44,8 +44,6 @@
       <select name="authority" id="authority" class="string optional form-control form-control" value="" aria-labelledby="authority" onchange="hide_data()">
         <option value=""><%= t('qa_server.check_status.select_authority') %></option>
         <option disabled>──────────</option>
-        <option value="<%= @presenter.value_all_collections %>"><%= t('qa_server.check_status.show_all') %></option>
-        <option disabled>──────────</option>
         <% @authorities_list.each do |auth_name| %>
           <option value="<%= auth_name %>"<%= " selected" if auth_name == selected_authority %>><%= auth_name.upcase %></option>
         <% end %>
@@ -77,7 +75,10 @@
   <% end %>
 
 
-<div id="status-loading-message" class="wait-message"><%= t('qa_server.check_status.wait_message') %></div>
+<div id="status-loading-message" class="wait-message">
+  <%= t('qa_server.check_status.wait_message_ln1') %><br>
+  <%= t('qa_server.check_status.wait_message_ln2') %>
+</div>
 
 <% if @presenter.connection_status_data? %>
 <div id="connection-status-section" class="status-section">
@@ -100,7 +101,7 @@
           </tr>
       <% end %>
       <tr>
-        <td class="<%= @presenter.status_style_class(status[:status]) %>"><%= @presenter.status_label(status[:status]) %></td>
+        <td class="<%= @presenter.status_style_class(status) %>"><%= @presenter.status_label(status[:status]) %></td>
         <td><%= status[:subauthority_name] %></td>
         <td><%= status[:service] %></td>
         <td><%= status[:action] %></td>
@@ -137,8 +138,8 @@
         </tr>
       <% end %>
     <tr>
-      <td class="position <%= @presenter.status_style_class(status[:status]) %>"><%= status[:expected] %></td>
-      <td class="position <%= @presenter.status_style_class(status[:status]) %>"><%= status[:actual] %></td>
+      <td class="position <%= @presenter.status_style_class(status) %>"><%= status[:expected] %></td>
+      <td class="position <%= @presenter.status_style_class(status) %>"><%= status[:actual] %></td>
       <td><%= status[:request_data] %></td>
       <td><a href="<%= status[:target] %>"><%= status[:target] %></a></td>
       <td><%= status[:authority_name] %></td>