qa_server 7.4.0 → 7.7.1

data/lib/qa_server/configuration.rb

@@ -199,13 +199,17 @@ module QaServer
     # Performance data is gathered on every incoming query.  Basic stats are logged from QA.  Full stats are logged
     # by QaServer and can eat up logging realestate.  To suppress the logging of details, set this config to true.
     # @param [Boolean] do not log performance data details when true (defaults to false for backward compatibitily)
-    attr_writer :suppress_logging_performance_datails
-    def suppress_logging_performance_datails?
-      return @suppress_logging_performance_datails unless @suppress_logging_performance_datails.nil?
-      @suppress_logging_performance_datails ||= false
-    end
-    alias suppress_logging_performance_datails suppress_logging_performance_datails?
+    attr_writer :suppress_logging_performance_details
+    def suppress_logging_performance_details?
+      return @suppress_logging_performance_details unless @suppress_logging_performance_details.nil?
+      @suppress_logging_performance_details ||= false
+    end
+    alias suppress_logging_performance_datails suppress_logging_performance_details?
+    alias suppress_logging_performance_datails? suppress_logging_performance_details?
+    alias suppress_logging_performance_datails= suppress_logging_performance_details=
     deprecation_deprecate suppress_logging_performance_datails: "use #suppress_logging_performance_datails? instead"
+    deprecation_deprecate suppress_logging_performance_datails?: "use #suppress_logging_performance_details? instead"
+    # deprecation_deprecate suppress_logging_performance_datails=: "use #suppress_logging_performance_details= instead"
 
     # Maximum amount of memory the performance cache can occupy before it is written to the database.
     # @param [Integer] maximum size of performance cache before flushing
@@ -249,23 +253,23 @@ module QaServer
       @monitor_logger ||= Logger.new(ENV['MONITOR_LOG_PATH'] || File.join("log", "monitor.log"))
     end
 
-    private
-
-      def convert_size_to_bytes(size)
-        return if size.nil?
-        md = size.match(/^(?<num>\d+)\s?(?<unit>\w+)?$/)
-        return md[:num].to_i if md[:unit].nil?
-        md[:num].to_i *
-          case md[:unit].upcase
-          when 'KB'
-            1024
-          when 'MB'
-            1024**2
-          when 'GB'
-            1024**3
-          else
-            1
-          end
-      end
+  private
+
+    def convert_size_to_bytes(size)
+      return if size.nil?
+      md = size.match(/^(?<num>\d+)\s?(?<unit>\w+)?$/)
+      return md[:num].to_i if md[:unit].nil?
+      md[:num].to_i *
+        case md[:unit].upcase
+        when 'KB'
+          1024
+        when 'MB'
+          1024**2
+        when 'GB'
+          1024**3
+        else
+          1
+        end
+    end
   end
 end

data/lib/qa_server/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module QaServer
-  VERSION = '7.4.0'
+  VERSION = '7.7.1'
 end

data/qa_server.gemspec

@@ -22,11 +22,11 @@ Gem::Specification.new do |spec|
   # Note: rails does not follow sem-ver conventions, it's
   # minor version releases can include breaking changes; see
   # http://guides.rubyonrails.org/maintenance_policy.html
-  spec.add_dependency 'rails', '~> 5.0' # Keep in sync with version supported by Hyrax
+  spec.add_dependency 'rails', '~> 5.2', '>= 5.2.5' # v5.2.5 required to address mimemagic gem yank
   spec.add_dependency 'useragent'
 
   # Required gems for QA and linked data access
-  spec.add_development_dependency 'qa', '~> 5.3'
+  spec.add_development_dependency 'qa', '~> 5.5', '>= 5.5.1' # questioning_authority
   spec.add_development_dependency 'linkeddata'
 
   # Produces dashboard charts on monitor status page
@@ -34,13 +34,14 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'better_errors' # provide debugging command line in
   spec.add_development_dependency 'binding_of_caller' # provides deep stack info used by better_errors
-  spec.add_development_dependency 'bixby', '~> 1.0.0' # rubocop styleguide
+  spec.add_development_dependency 'bixby', '~> 3.0', ">= 3.0.2" # rubocop styleguide
   # spec.add_development_dependency "capybara", '~> 3.29'
   # spec.add_development_dependency 'capybara-maleficent', '~> 0.3.0'
   # spec.add_development_dependency 'chromedriver-helper', '~> 2.1'
   spec.add_development_dependency 'deprecation'
-  spec.add_development_dependency 'engine_cart', '~> 2.0'
+  spec.add_development_dependency 'engine_cart', '~> 2.2'
   spec.add_development_dependency "factory_bot", '~> 4.4'
+  spec.add_development_dependency 'i18n-tasks'
   spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'sqlite3'
   spec.add_development_dependency 'rails-controller-testing', '~> 1'
@@ -48,7 +49,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec-its', '~> 1.1'
   spec.add_development_dependency 'rspec-rails', '~> 3.1'
   spec.add_development_dependency 'selenium-webdriver'
-  spec.add_development_dependency 'webdrivers', '~> 3.0'
+  spec.add_development_dependency 'webdrivers', '~> 4.4'
   spec.add_development_dependency 'webmock'
 
   ########################################################

data/spec/feature/accuracy_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+require 'spec_helper'
+
+# rubocop:disable RSpec/InstanceVariable
+RSpec.describe 'Accuracy test' do # rubocop:disable RSpec/DescribeClass
+  before(:all) { WebMock.allow_net_connect! }
+  after(:all) { WebMock.disable_net_connect! }
+
+  let(:authority_list) { QaServer::AuthorityListerService.authorities_list }
+  let(:authority_name) { :CERL_LD4L_CACHE }
+
+  describe 'for authority:' do
+    @status_log = QaServer::ScenarioLogger.new
+    QaServer::AuthorityListerService.authorities_list.each do |authority_name| # rubocop:disable Style/MultilineIfModifier
+      QaServer::AuthorityValidatorService.run(authority_name: authority_name,
+                                              status_log: @status_log,
+                                              validation_type: QaServer::ScenarioValidator::VALIDATE_ACCURACY)
+    end unless ENV['TRAVIS']
+    @status_log.each do |test_result|
+      context "#{test_result[:authority_name]}:#{test_result[:subauthority_name]}:#{test_result[:request_data]}:" do
+        it "finds actual <= expected" do
+          pending 'test is known to fail' if test_result[:pending]
+          expect(test_result[:err_message]).to be_empty
+          expect(test_result[:request_data]).to be_present
+          expect(test_result[:actual]).not_to be_nil
+          expect(test_result[:actual]).to be <= test_result[:expected]
+        end
+      end
+    end
+  end
+end
+# rubocop:enable RSpec/InstanceVariable

data/spec/i18n_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require 'i18n/tasks'
+
+RSpec.describe I18n do
+  let(:i18n) { I18n::Tasks::BaseTask.new }
+  let(:missing_keys) { i18n.missing_keys }
+  let(:unused_keys) { i18n.unused_keys }
+  let(:inconsistent_interpolations) { i18n.inconsistent_interpolations }
+
+  it 'does not have missing keys' do
+    expect(missing_keys).to be_empty,
+                            "Missing #{missing_keys.leaves.count} i18n keys, run `i18n-tasks missing' to show them"
+  end
+
+  it 'does not have unused keys' do
+    expect(unused_keys).to be_empty,
+                           "#{unused_keys.leaves.count} unused i18n keys, run `i18n-tasks unused' to show them"
+  end
+
+  it 'files are normalized' do # rubocop:disable RSpec/ExampleLength
+    pending 'need to explore further normalization process'
+    non_normalized = i18n.non_normalized_paths
+    error_message = "The following files need to be normalized:\n" \
+                    "#{non_normalized.map { |path| "  #{path}" }.join("\n")}\n" \
+                    "Please run `i18n-tasks normalize' to fix"
+    expect(non_normalized).to be_empty, error_message
+  end
+
+  it 'does not have inconsistent interpolations' do
+    error_message = "#{inconsistent_interpolations.leaves.count} i18n keys have inconsistent interpolations.\n" \
+                    "Run `i18n-tasks check-consistent-interpolations' to show them"
+    expect(inconsistent_interpolations).to be_empty, error_message
+  end
+end

data/spec/presenters/qa_server/monitor_status/history_presenter_spec.rb

@@ -0,0 +1,81 @@
+# frozen_string_literal: true
+require 'spec_helper'
+
+RSpec.describe QaServer::MonitorStatus::HistoryPresenter do
+  let(:presenter) { described_class.new(parent: nil, historical_summary_data: historical_summary_data) }
+  # rubocop:disable Layout/ExtraSpacing
+  let(:historical_summary_data) do
+    # { 'auth_name' => { good: count_of_passing_tests, bad: count_of_failing_tests } }
+    {
+      'GOOD_AUTH'   => { good:    0, bad: 1000 },
+      'BARELY_GOOD' => { good:   49, bad:  951 },
+      'OK_AUTH'     => { good:   50, bad:  950 },
+      'STILL_OK'    => { good:   51, bad:  949 },
+      'BARELY_OK'   => { good:   99, bad:  901 },
+      'BAD_AUTH'    => { good:  100, bad:  900 },
+      'STILL_BAD'   => { good:  101, bad:  899 },
+      'REALLY_BAD'  => { good:  500, bad:  500 },
+      'HORRIBLE'    => { good: 1000, bad:    0 }
+    }
+    # rubocop:enable Layout/ExtraSpacing
+  end
+
+  describe '.failure_style_class' do
+    context 'returns NEUTRAL style' do
+      let(:expected_css_style) { "status-neutral" }
+      let(:zero_failure_entry) { ['GOOD_AUTH',   { good: 1000, bad:  0 }] } # rubocop:disable Layout/ExtraSpacing
+      let(:just_below_caution) { ['BARELY_GOOD', { good:  951, bad: 49 }] } # rubocop:disable Layout/ExtraSpacing
+
+      it 'when no failures' do
+        expect(presenter.failure_style_class(zero_failure_entry)).to eq expected_css_style
+      end
+
+      it 'when percent of failures is just below the CAUTION_THRESHOLD' do
+        expect(presenter.failure_style_class(just_below_caution)).to eq expected_css_style
+      end
+    end
+
+    context 'returns CAUTION style' do
+      let(:expected_css_style) { "status-unknown" }
+      let(:equal_caution)      { ['OK_AUTH',   { good: 950, bad: 50 }] }
+      let(:just_above_caution) { ['STILL_OK',  { good: 949, bad: 51 }] }
+      let(:just_below_warning) { ['BARELY_OK', { good: 901, bad: 99 }] }
+
+      it 'when percent of failures is equal to CAUTION_THRESHOLD' do
+        expect(presenter.failure_style_class(equal_caution)).to eq expected_css_style
+      end
+
+      it 'when percent of failures is just above CAUTION_THRESHOLD' do
+        expect(presenter.failure_style_class(just_above_caution)).to eq expected_css_style
+      end
+
+      it 'when percent of failures is just below WARNING_THRESHOLD' do
+        expect(presenter.failure_style_class(just_below_warning)).to eq expected_css_style
+      end
+    end
+
+    context 'returns WARNING style' do
+      let(:expected_css_style) { "status-bad" }
+      let(:equal_warning)      { ['BAD_AUTH',   { good: 900, bad:  100 }] }
+      let(:just_above_warning) { ['STILL_BAD',  { good: 899, bad:  101 }] }
+      let(:well_above_warning) { ['REALLY_BAD', { good: 500, bad:  500 }] }
+      let(:all_failures)       { ['HORRIBLE',   { good:   0, bad: 1000 }] }
+
+      it 'when percent of failures is equal to WARNING_THRESHOLD' do
+        expect(presenter.failure_style_class(equal_warning)).to eq expected_css_style
+      end
+
+      it 'when percent of failures is just above WARNING_THRESHOLD' do
+        expect(presenter.failure_style_class(just_above_warning)).to eq expected_css_style
+      end
+
+      it 'when percent of failures is well above WARNING_THRESHOLD' do
+        expect(presenter.failure_style_class(well_above_warning)).to eq expected_css_style
+      end
+
+      it 'when percent of failures is 100%' do
+        expect(presenter.failure_style_class(all_failures)).to eq expected_css_style
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -62,3 +62,7 @@ def load_fixture_file(fname)
     return f.read
   end
 end
+
+QaServer.config.suppress_performance_gathering = true
+QaServer.config.suppress_logging_performance_details = true
+QaServer.config.preferred_time_zone_name = 'Eastern Time (US & Canada)'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: qa_server
 version: !ruby/object:Gem::Version
-  version: 7.4.0
+  version: 7.7.1
 platform: ruby
 authors:
 - E. Lynette Rayle
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-04-13 00:00:00.000000000 Z
+date: 2021-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,14 +16,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.2.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.2.5
 - !ruby/object:Gem::Dependency
   name: useragent
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +50,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '5.5'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.5.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '5.5'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.5.1
 - !ruby/object:Gem::Dependency
   name: linkeddata
   requirement: !ruby/object:Gem::Requirement
@@ -114,14 +126,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '3.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.0.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '3.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.0.2
 - !ruby/object:Gem::Dependency
   name: deprecation
   requirement: !ruby/object:Gem::Requirement
@@ -142,14 +160,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: factory_bot
   requirement: !ruby/object:Gem::Requirement
@@ -164,6 +182,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '4.4'
+- !ruby/object:Gem::Dependency
+  name: i18n-tasks
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -268,14 +300,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.4'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -418,6 +450,7 @@ files:
 - app/views/qa_server/monitor_status/index.html.erb
 - app/views/qa_server/usage/index.html.erb
 - app/views/shared/_footer.html.erb
+- config/i18n-tasks.yml
 - config/locales/qa_server.en.yml
 - config/routes.rb
 - lib/generators/qa_server/assets_generator.rb
@@ -437,13 +470,18 @@ files:
 - lib/generators/qa_server/templates/config/authorities/linked_data/getty_aat_ld4l_cache.json
 - lib/generators/qa_server/templates/config/authorities/linked_data/getty_tgn_ld4l_cache.json
 - lib/generators/qa_server/templates/config/authorities/linked_data/getty_ulan_ld4l_cache.json
+- lib/generators/qa_server/templates/config/authorities/linked_data/isni_ld4l_cache.json
+- lib/generators/qa_server/templates/config/authorities/linked_data/ligatus_ld4l_cache.json
 - lib/generators/qa_server/templates/config/authorities/linked_data/loc_direct.json
 - lib/generators/qa_server/templates/config/authorities/linked_data/locdemographics_ld4l_cache.json
 - lib/generators/qa_server/templates/config/authorities/linked_data/locgenres_ld4l_cache.json
 - lib/generators/qa_server/templates/config/authorities/linked_data/locnames_ld4l_cache.json
+- lib/generators/qa_server/templates/config/authorities/linked_data/locnames_rwo2_ld4l_cache.json
+- lib/generators/qa_server/templates/config/authorities/linked_data/locnames_rwo3_ld4l_cache.json
 - lib/generators/qa_server/templates/config/authorities/linked_data/locnames_rwo_ld4l_cache.json
 - lib/generators/qa_server/templates/config/authorities/linked_data/locperformance_ld4l_cache.json
 - lib/generators/qa_server/templates/config/authorities/linked_data/locsubjects_ld4l_cache.json
+- lib/generators/qa_server/templates/config/authorities/linked_data/locvocabs_ld4l_cache.json
 - lib/generators/qa_server/templates/config/authorities/linked_data/mesh_nlm_ld4l_cache.json
 - lib/generators/qa_server/templates/config/authorities/linked_data/nalt_direct.json
 - lib/generators/qa_server/templates/config/authorities/linked_data/nalt_ld4l_cache.json
@@ -460,14 +498,19 @@ files:
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/getty_aat_ld4l_cache_validation.yml
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/getty_tgn_ld4l_cache_validation.yml
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/getty_ulan_ld4l_cache_validation.yml
+- lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/isni_ld4l_cache_validation.yml
+- lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/ligatus_ld4l_cache_validation.yml
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/loc_direct_validation.yml
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/loc_validation.yml
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/locdemographics_ld4l_cache_validation.yml
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/locgenres_ld4l_cache_validation.yml
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/locnames_ld4l_cache_validation.yml
+- lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/locnames_rwo2_ld4l_cache_validation.yml
+- lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/locnames_rwo3_ld4l_cache_validation.yml
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/locnames_rwo_ld4l_cache_validation.yml
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/locperformance_ld4l_cache_validation.yml
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/locsubjects_ld4l_cache_validation.yml
+- lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/locvocabs_ld4l_cache_validation.yml
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/mesh_nlm_ld4l_cache_validation.yml
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/nalt_direct_validation.yml
 - lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/nalt_ld4l_cache_validation.yml
@@ -499,8 +542,11 @@ files:
 - qa_server.gemspec
 - spec/.gitignore
 - spec/cache_processors/qa_server/cache_expiry_service_spec.rb
+- spec/feature/accuracy_spec.rb
+- spec/i18n_spec.rb
 - spec/lib/configuration_spec.rb
 - spec/lib/qa_server_spec.rb
+- spec/presenters/qa_server/monitor_status/history_presenter_spec.rb
 - spec/rails_helper.rb
 - spec/services/qa_server/time_period_service_spec.rb
 - spec/services/qa_server/time_service_spec.rb
@@ -513,7 +559,7 @@ homepage: http://github.com/LD4P/qa_server
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -528,16 +574,18 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
-signing_key: 
+rubygems_version: 3.0.8
+signing_key:
 specification_version: 4
 summary: Authority Lookup Server
 test_files:
 - spec/.gitignore
 - spec/cache_processors/qa_server/cache_expiry_service_spec.rb
+- spec/feature/accuracy_spec.rb
+- spec/i18n_spec.rb
 - spec/lib/configuration_spec.rb
 - spec/lib/qa_server_spec.rb
+- spec/presenters/qa_server/monitor_status/history_presenter_spec.rb
 - spec/rails_helper.rb
 - spec/services/qa_server/time_period_service_spec.rb
 - spec/services/qa_server/time_service_spec.rb