qa_server 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c54a8298febf924d051837fef371b727c32912f7
-  data.tar.gz: 5c038a7a516bd50834670fd393ee215086708b73
+  metadata.gz: 07b0fa2f20f5bb153db7ad23e9b220acac6c6207
+  data.tar.gz: 26780210f6c2e80b2be8964ec0bfa31fd24f962b
 SHA512:
-  metadata.gz: a36a6e1d5072d3978a18a34b84bf338b9d318c7db8948a6fb8bbb3ae2506714e8281b4dfa42faae61f5410a3379d38c2e2c2077d848c14a8895ce9dfb7193fb8
-  data.tar.gz: 1a5df12683d02f30c8bccc9f96d721faaffe06484223fe3ae543dc94f2948c11c164fa93a9833c57b0d523b898de54b19a02b344d5a56f9018d27f2a1b3a8304
+  metadata.gz: a32e34c94603bc1fa5cda525882ba8a60a1d7feb1afa190f081bfad7fc919895931f530c7847db6dace78d8639f4aa307d84fab1ff9d93ae525055a4cda1f4fb
+  data.tar.gz: 7eb0925bf1f3fc0cc4ee5a8afec876fa6a8fa8cbbd27417c3e844f3e9ab82f2516d95caf88fe93c9fc41188a78019e1e6c0a98d504237119f6fb4e47265275b6

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+### 3.0.1 (2019-10-09)
+
+* use old :load data when split :retrieve and :graph_load are not available
+* bug fix - make sure count is counting based on the current set of times
+* bug fix - add in missing translations
+* bug fix - fix performance data table data style for retrieve
+* bug fix - unsupported_action? for performance datatable handles all 0 stats
+
 ### 3.0.0 (2019-10-09)
 
 * refactor performance data and graphs to include stats by action as well as by authority and time period

data/app/presenters/concerns/qa_server/monitor_status/performance_datatable_behavior.rb

@@ -105,7 +105,9 @@ module QaServer::MonitorStatus
       end
 
       def unsupported_action?(stats)
-        stats[AVG_ACTN].nan?
+        values = stats.values
+        return true if values.all? &:zero?
+        values.any? { |v| v.respond_to?(:nan?) && v.nan? }
       end
 
       def format_stat(stats, idx)

data/app/services/qa_server/performance_calculator_service.rb

@@ -21,6 +21,7 @@ module QaServer
     #     retrieve_10th_ms: 12.3, graph_load_10th_ms: 12.3, normalization_10th_ms: 4.2, full_request_10th_ms: 16.5,
     #     retrieve_90th_ms: 12.3, graph_load_90th_ms: 12.3, normalization_90th_ms: 4.2, full_request_90th_ms: 16.5 }
     def calculate_stats(avg: false, low: false, high: false, load: true, norm: true, full: true) # rubocop:disable Metrics/ParameterLists
+      calculate_load_stats(avg, low, high) if load
       calculate_retrieve_stats(avg, low, high) if load
       calculate_graph_load_stats(avg, low, high) if load
       calculate_normalization_stats(avg, low, high) if norm
@@ -30,6 +31,12 @@ module QaServer
 
     private
 
+      def calculate_load_stats(avg, low, high)
+        stats[AVG_LOAD] = calculate_average(full_load_times) if avg
+        stats[LOW_LOAD] = calculate_10th_percentile(full_load_times) if low
+        stats[HIGH_LOAD] = calculate_90th_percentile(full_load_times) if high
+      end
+
       def calculate_retrieve_stats(avg, low, high)
         stats[AVG_RETR] = calculate_average(retrieve_times) if avg
         stats[LOW_RETR] = calculate_10th_percentile(retrieve_times) if low
@@ -54,10 +61,6 @@ module QaServer
         stats[HIGH_ACTN] = calculate_90th_percentile(action_times) if high
       end
 
-      def count
-        @count ||= records.count
-      end
-
       def tenth_percentile_count(times)
         percentile_count = (times.count * 0.1).round
         percentile_count = 1 if percentile_count.zero? && count > 1
@@ -69,6 +72,10 @@ module QaServer
         records.where(where_clause).where.not(column => nil).order(column).pluck(column)
       end
 
+      def full_load_times
+        @full_load_times ||= times(:retrieve_plus_graph_load_time_ms)
+      end
+
       def retrieve_times
         @retrieve_times ||= times(:retrieve_time_ms)
       end
@@ -86,8 +93,8 @@ module QaServer
       end
 
       def calculate_average(times)
-        return 0 if count.zero?
-        return times[0] if count == 1
+        return 0 if times.count.zero?
+        return times[0] if times.count == 1
         times.inject(0.0) { |sum, el| sum + el } / times.count
       end
 

data/app/services/qa_server/performance_graphing_service.rb

@@ -82,18 +82,31 @@ module QaServer
 
         def rework_performance_data_for_gruff(performance_data, label_key)
           labels = {}
+          full_load_data = []
           retrieve_data = []
           graph_load_data = []
           normalization_data = []
           performance_data.each do |i, data|
             labels[i] = data[label_key]
             retrieve_data << data[STATS][AVG_RETR]
-            graph_load_data << data[STATS][AVG_GRPH]
+            graph_load_data << graph_load_time(data)
             normalization_data << data[STATS][AVG_NORM]
           end
           [labels, normalization_data, graph_load_data, retrieve_data]
         end
 
+        def graph_load_time(data)
+          # For some sense of backward compatibility and to avoid losing the usefulness of previously collected data,
+          # create the graph using the old :load stat when both :retrieve and :graph_load are 0. If the value truly
+          # is 0, then :load will also be 0.
+          # NOTE: It's ok to use AVG_RETR for the retrieve data point because it is 0.
+          (data[STATS][AVG_RETR].zero? && data[STATS][AVG_GRPH].zero?) ? data[STATS][AVG_LOAD] : data[STATS][AVG_GRPH]
+        end
+
+        def empty(stat_data)
+          !stat_data.any? { |f| f > 0 }
+        end
+
         def performance_graph_theme(g, x_axis_label)
           g.theme_pastel
           g.colors = [QaServer.config.performance_normalization_color,

data/app/views/qa_server/monitor_status/_performance.html.erb

@@ -112,7 +112,7 @@
           </tr>
           <tr>
             <th><%= t('qa_server.monitor_status.performance.retrieve_times') %></th>
-            <td class="<%= @presenter.high_full_request_style(search_stats) %>"><%= @presenter.high_retrieve(search_stats) %></td>
+            <td class="<%= @presenter.datatable_data_style(search_stats) %>"><%= @presenter.high_retrieve(search_stats) %></td>
             <td class="<%= @presenter.datatable_data_style(search_stats) %>"><%= @presenter.avg_retrieve(search_stats) %></td>
             <td class="<%= @presenter.datatable_data_style(search_stats) %>"><%= @presenter.low_retrieve(search_stats) %></td>
             <td class="<%= @presenter.datatable_data_style(fetch_stats) %>"><%= @presenter.high_retrieve(fetch_stats) %></td>

data/config/locales/qa_server.en.yml

@@ -103,7 +103,8 @@ en:
         average_times:        Average (ms)
         fastest_times:        10th percentile (ms)
         slowest_times:        90th percentile (ms)
-        load_times:           Load
+        retrieve_times:       Retrieve
+        graph_load_times:     Graph Load
         normalization_times:  Normalization
         full_request_times:   Total
     usage:

data/lib/qa_server/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module QaServer
-  VERSION = '3.0.0'
+  VERSION = '3.0.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: qa_server
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - E. Lynette Rayle