qa 5.8.1 → 5.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7529be1fa8e0db065216d3fd303c3db02c739ede3ffed6ca0d56cda3b0d8bc5
-  data.tar.gz: ae2e1179e435d2cc82f6c8e068c413cfb6cf0e3fdee0a478fff4eccfff82b64c
+  metadata.gz: 30ab17e283e9e6cf2e8234ef90d32bbbebe83ecdb7f52e7b07ccccf853eebd2c
+  data.tar.gz: 83abfe73a222b69a782c54ed9120ec08c07db796656c9e942b5494c3cd32f847
 SHA512:
-  metadata.gz: 05b1ea7d2611b2fd349d070171a9856059ae0c0a5ea8dfab12fcdddab55e76b6a0939c6e451e3c7852f6bdf782e3aff8f2dda0c2f8c043a2a61c9407c7a76fce
-  data.tar.gz: 0454fd9d3ce8663f9cc3e00e4a922cca3b33c6657213448f40de9b7601fb553b236dd822f1b8e5fb196ca91b1e7973134950003f52f4d33153c1e8e6c36b0517
+  metadata.gz: e8e0c392d5c1c54c29e53281e2903722de989e6ce2eea8e50edef227604f4de74855f9d029123e76ce42948951603bbe56be8f32d7af5d4709c82e8dd7d35e97
+  data.tar.gz: 28c4963e4852df3ce295c8df16cf074bb00ea123a18e62011c6f020cfaaa81c2da2da05134956d0a6a5dac921471c0bc4ea9764e81c50d810ff64d145c96f8b6

data/README.md

@@ -1,10 +1,15 @@
 # Questioning Authority
 
-Code: [![Gem Version](https://badge.fury.io/rb/qa.png)](http://badge.fury.io/rb/qa) [![Build Status](https://circleci.com/gh/samvera/questioning_authority.svg?style=svg)](https://circleci.com/gh/samvera/questioning_authority) [![Coverage Status](https://coveralls.io/repos/github/samvera/questioning_authority/badge.svg?branch=main)](https://coveralls.io/github/samvera/questioning_authority?branch=main)
+Code:
+[![Gem Version](https://badge.fury.io/rb/qa.png)](http://badge.fury.io/rb/qa)
+[![Build Status](https://circleci.com/gh/samvera/questioning_authority.svg?style=svg)](https://circleci.com/gh/samvera/questioning_authority)
+[![Coverage Status](https://coveralls.io/repos/github/samvera/questioning_authority/badge.svg?branch=main)](https://coveralls.io/github/samvera/questioning_authority?branch=main)
 
-Docs: [![Contribution Guidelines](http://img.shields.io/badge/CONTRIBUTING-Guidelines-blue.svg)](./CONTRIBUTING.md) [![Apache 2.0 License](http://img.shields.io/badge/APACHE2-license-blue.svg)](./LICENSE)
+Docs:
+[![Contribution Guidelines](http://img.shields.io/badge/CONTRIBUTING-Guidelines-blue.svg)](./CONTRIBUTING.md)
+[![Apache 2.0 License](http://img.shields.io/badge/APACHE2-license-blue.svg)](./LICENSE)
 
-Jump In: [![Slack Status](http://slack.samvera.org/badge.svg)](http://slack.samvera.org/)
+Community Support: [![Samvera Community Slack](https://img.shields.io/badge/samvera-slack-blueviolet)](http://slack.samvera.org/)
 
 You should question your authorities.
 
@@ -145,24 +150,31 @@ rake ci
 
 Commit your features into a new branch and submit a pull request.
 
-## Contributing 
+## Contributing
 
-If you're working on PR for this project, create a feature branch off of `main`. 
+If you're working on PR for this project, create a feature branch off of `main`.
 
 This repository follows the [Samvera Community Code of Conduct](https://samvera.atlassian.net/wiki/spaces/samvera/pages/405212316/Code+of+Conduct) and [language recommendations](https://github.com/samvera/maintenance/blob/main/templates/CONTRIBUTING.md#language).  Please ***do not*** create a branch called `master` for this repository or as part of your pull request; the branch will either need to be removed or renamed before it can be considered for inclusion in the code base and history of this repository.
 
 ## Compatibility
+This gem works with Rails 5.0-7.0 and Ruby 2.5-3.1, provided the version of Rails supports the version of Ruby.
+ - Consult `.circleci/config.yml` for a list of supported combinations.
+ - The combination of Ruby 3.1 and Rails 6.0 comes with three caveats:
+   - your app will not be able to use `psych 4` (which ordinarily comes with 3.1). See https://bugs.ruby-lang.org/issues/17866 and https://stackoverflow.com/questions/71191685/visit-psych-nodes-alias-unknown-alias-default-psychbadalias/71192990#71192990 for an explanation. One workaround is to modify your app's `Gemfile` to hold back `psych`: `gem 'psych', '< 4'`.
+   - likewise, you want to add gem 'net-smtp', require: false to your Gemfile to get around the bug described in https://stackoverflow.com/questions/70500220/rails-7-ruby-3-1-loaderror-cannot-load-such-file-net-smtp .
+   - finally, you may want to opt in to the latest version of "mail". Again, add to your Gemfile the line `gem "mail", ">= 2.8.0.rc1"`.
 
-- Ruby 2.5 or the latest 2.4 version is recommended. Later versions may also work.
-- Rails 5 is required. We recommend the latest Rails 5.2 release.
+See also  `.circleci/config.yml` and `spec/test_app_templates/Gemfile.extra`.
 
 ## Product Owner & Maintenance
 
-Questioning Authority is a Core Component of the Samvera community. The documentation for what this means can be found [here](http://samvera.github.io/core_components.html#requirements-for-a-core-component).
+`qa` was a Core Component of the Samvera Community. Given a decline in available labor required for maintenance, this project no longer has a dedicated Product Owner. The documentation for what this means can be found [here](http://samvera.github.io/core_components.html#requirements-for-a-core-component).
 
 ### Product Owner
 
-[elrayle](https://github.com/elrayle)
+**Vacant**
+
+_Until a Product Owner has been identified, we ask that you please direct all requests for support, bug reports, and general questions to the [`#dev` Channel on the Samvera Slack](https://samvera.slack.com/app_redirect?channel=dev)._
 
 ## Releasing
 

data/app/services/qa/linked_data/graph_service.rb

@@ -57,7 +57,7 @@ module Qa
         def deep_copy(graph:)
           new_graph = RDF::Graph.new
           graph.statements.each do |st|
-            new_graph.insert(st.dup)
+            new_graph << st.dup
           end
           new_graph
         end

data/lib/qa/authorities/assign_fast/generic_authority.rb

@@ -4,7 +4,9 @@ module Qa::Authorities
   # http://www.oclc.org/developer/develop/web-services/fast-api/assign-fast.en.html
   class AssignFast::GenericAuthority < Base
     attr_reader :subauthority
+
     def initialize(subauthority)
+      super()
       @subauthority = subauthority
     end
 

data/lib/qa/authorities/crossref/generic_authority.rb

@@ -5,6 +5,7 @@ module Qa::Authorities
     attr_reader :subauthority
 
     def initialize(subauthority)
+      super()
       @subauthority = subauthority
     end
 

data/lib/qa/authorities/discogs/generic_authority.rb

@@ -11,6 +11,7 @@ module Qa::Authorities
 
     # @param [String] subauthority to use
     def initialize(subauthority)
+      super()
       @subauthority = subauthority
       self.primary_artists = []
       self.work_uri = "workn1"

data/lib/qa/authorities/geonames.rb

@@ -64,7 +64,7 @@ module Qa::Authorities
       # Reformats the data received from the service
       def parse_authority_response(response)
         response['geonames'].map do |result|
-          # Note: the trailing slash is meaningful.
+          # NOTE: the trailing slash is meaningful.
           { 'id' => "https://sws.geonames.org/#{result['geonameId']}/",
             'label' => label.call(result) }
         end

data/lib/qa/authorities/linked_data/config.rb

@@ -60,7 +60,7 @@ module Qa::Authorities
       def authority_config
         @authority_config ||= Qa::LinkedData::AuthorityService.authority_config(@authority_name)
         raise Qa::InvalidLinkedDataAuthority, "Unable to initialize linked data authority '#{@authority_name}'" if @authority_config.nil?
-        convert_1_0_to_2_0 if @authority_config.fetch(:QA_CONFIG_VERSION, '1.0') == '1.0'
+        convert_1_0_to_2_0_version if @authority_config.fetch(:QA_CONFIG_VERSION, '1.0') == '1.0'
         @authority_config
       end
 
@@ -78,7 +78,7 @@ module Qa::Authorities
 
       private
 
-        def convert_1_0_to_2_0
+        def convert_1_0_to_2_0_version
           convert_1_0_url_to_2_0_url(:search)
           convert_1_0_url_to_2_0_url(:term)
         end

data/lib/qa/authorities/linked_data/find_term.rb

@@ -136,7 +136,11 @@ module Qa::Authorities
         # Special processing for loc ids for backward compatibility.  IDs may be in the form 'n123' or 'n 123'.  This adds
         # the <blank> into the ID to allow it to be found as the object of a triple in the graph.
         def loc_id
-          loc_id = URI.unescape(id)
+          # NOTE: this call to unescape may not be necessary.
+          # loc_id = id.dup works just as well.
+          # See https://github.com/samvera/questioning_authority/pull/369
+          # for more discussion.
+          loc_id = CGI.unescape(id)
           digit_idx = loc_id.index(/\d/)
           loc_id.insert(digit_idx, ' ') if loc? && loc_id.index(' ').blank? && digit_idx > 0
           loc_id
@@ -162,9 +166,11 @@ module Qa::Authorities
         end
 
         def extract_uri_by_id(id_predicate)
+          # NOTE: calls to CGI.unescape in this method may not be necessary.
+          # See discussion at https://github.com/samvera/questioning_authority/pull/369 .
           @uri = graph_service.subjects_for_object_value(graph: @filtered_graph,
                                                          predicate: id_predicate,
-                                                         object_value: URI.unescape(id)).first
+                                                         object_value: CGI.unescape(id)).first
           return if @uri.present? || !loc?
 
           # NOTE: Second call to try and extract using the loc_id allows for special processing on the id for LOC authorities.
@@ -172,7 +178,7 @@ module Qa::Authorities
           #       the ID is provided without the <blank>, this tries a second time to find it with the <blank>.
           @uri = graph_service.subjects_for_object_value(graph: @filtered_graph,
                                                          predicate: id_predicate,
-                                                         object_value: URI.unescape(loc_id)).first
+                                                         object_value: CGI.unescape(loc_id)).first
           return if @uri.blank? # only show the depercation warning if the loc_id was used
           Qa.deprecation_warning(
             in_msg: 'Qa::Authorities::LinkedData::FindTerm',

data/lib/qa/authorities/linked_data/generic_authority.rb

@@ -20,6 +20,7 @@ module Qa::Authorities
       delegate :subauthority?, :subauthorities?, to: :search_config, prefix: 'search'
 
       def initialize(auth_name)
+        super()
         @authority_config = Qa::Authorities::LinkedData::Config.new(auth_name)
       end
 

data/lib/qa/authorities/loc/generic_authority.rb

@@ -2,6 +2,7 @@ module Qa::Authorities
   class Loc::GenericAuthority < Base
     attr_reader :subauthority
     def initialize(subauthority)
+      super()
       @subauthority = subauthority
     end
 

data/lib/qa/authorities/local/file_based_authority.rb

@@ -2,6 +2,7 @@ module Qa::Authorities
   class Local::FileBasedAuthority < Base
     attr_reader :subauthority
     def initialize(subauthority)
+      super()
       @subauthority = subauthority
     end
 

data/lib/qa/authorities/local/registry.rb

@@ -19,9 +19,7 @@ module Qa::Authorities
       end
 
       def self.logger
-        @logger ||= begin
-          ::Rails.logger if defined? Rails && Rails.respond_to?(:logger)
-        end
+        @logger ||= ::Rails.logger if defined? Rails && Rails.respond_to?(:logger)
       end
 
       class << self

data/lib/qa/authorities/local/table_based_authority.rb

@@ -34,6 +34,7 @@ module Qa::Authorities
     attr_reader :subauthority
 
     def initialize(subauthority)
+      super()
       self.class.check_for_index
       @subauthority = subauthority
     end

data/lib/qa/authorities/local.rb

@@ -36,10 +36,8 @@ module Qa::Authorities
       end
 
       def registry
-        @registry ||= begin
-          Registry.new do |reg|
-            register_defaults(reg)
-          end
+        @registry ||= Registry.new do |reg|
+          register_defaults(reg)
         end
       end
 

data/lib/qa/authorities/mesh_tools/mesh_data_parser.rb

@@ -7,7 +7,9 @@ module Qa::Authorities
         @file = file
       end
 
-      def each_mesh_record # rubocop:disable Metrics/MethodLength
+      # rubocop:disable Metrics/MethodLength
+      # rubocop:disable Metrics/CyclomaticComplexity
+      def each_mesh_record
         current_data = {}
         in_record = false
         file.each_line do |line|

data/lib/qa/authorities/oclcts/generic_oclc_authority.rb

@@ -3,6 +3,7 @@ module Qa::Authorities
     attr_reader :subauthority
 
     def initialize(subauthority)
+      super()
       @subauthority = subauthority
     end
     include WebServiceBase
@@ -34,7 +35,7 @@ module Qa::Authorities
 
       def get_raw_response(query_type, id)
         query_url = Oclcts.url_pattern(query_type).gsub("{query}", id).gsub("{id}", id).gsub("{authority-id}", subauthority)
-        @raw_response = Nokogiri::XML(open(query_url))
+        @raw_response = Nokogiri::XML(URI.open(query_url))
       end
   end
 end

data/lib/qa/engine.rb

@@ -1,3 +1,6 @@
+# used in initializer where autoload is unavailable, must be required here:
+require 'qa/linked_data/authority_service'
+
 module Qa
   class Engine < ::Rails::Engine
     isolate_namespace Qa

data/lib/qa/version.rb

@@ -1,3 +1,3 @@
 module Qa
-  VERSION = "5.8.1".freeze
+  VERSION = "5.10.0".freeze
 end

data/spec/controllers/terms_controller_spec.rb

@@ -65,6 +65,7 @@ describe Qa::TermsController, type: :controller do
         class Qa::Authorities::Local::TwoArgs < Qa::Authorities::Base
           attr_reader :subauthority
           def initialize(subauthority)
+            super()
             @subauthority = subauthority
           end
 

data/spec/lib/authorities/discogs/generic_authority_spec.rb

@@ -212,7 +212,7 @@ describe Qa::Authorities::Discogs::GenericAuthority do
           expect(JSON.parse(results).keys).to match_array ["@context", "@graph"]
           expect(JSON.parse(results)["@context"]["bf2"]).to eq("http://id.loc.gov/ontologies/bibframe/")
           expect(results).to include("You Go To My Head")
-          expect(results).to include("Rodgers & Hart")
+          expect(JSON.parse(results).inspect).to include("Rodgers & Hart")
           expect(results).to include("Ray Brown")
           expect(results).to include("1952")
           expect(results).to include("Single")

data/spec/lib/authorities/getty/aat_spec.rb

@@ -35,7 +35,10 @@ describe Qa::Authorities::Getty::AAT do
         end
 
         it 'logs error and returns empty results' do
-          expect(Rails.logger).to receive(:warn).with("  ERROR fetching Getty response: undefined method `[]' for nil:NilClass; cause: UNKNOWN")
+          # Rails 3.1 actually quotes the failing code in the error message,
+          # so let's match this error message with a multiline regex instead of
+          # a string.
+          expect(Rails.logger).to receive(:warn).with(/ERROR fetching Getty response: .*undefined method.*for nil:NilClass.*; cause: UNKNOWN/m)
           expect(subject).to be {}
         end
       end

data/spec/lib/authorities/getty/tgn_spec.rb

@@ -35,7 +35,10 @@ describe Qa::Authorities::Getty::TGN do
         end
 
         it 'logs error and returns empty results' do
-          expect(Rails.logger).to receive(:warn).with("  ERROR fetching Getty response: undefined method `[]' for nil:NilClass; cause: UNKNOWN")
+          # Rails 3.1 actually quotes the failing code in the error message,
+          # so let's match this error message with a multiline regex instead of
+          # a string.
+          expect(Rails.logger).to receive(:warn).with(/ERROR fetching Getty response: .*undefined method.*for nil:NilClass.*; cause: UNKNOWN/m)
           expect(subject).to be {}
         end
       end

data/spec/lib/authorities/getty/ulan_spec.rb

@@ -35,7 +35,10 @@ describe Qa::Authorities::Getty::Ulan do
         end
 
         it 'logs error and returns empty results' do
-          expect(Rails.logger).to receive(:warn).with("  ERROR fetching Getty response: undefined method `[]' for nil:NilClass; cause: UNKNOWN")
+          # Rails 3.1 actually quotes the failing code in the error message,
+          # so let's match this error message with a multiline regex instead of
+          # a string.
+          expect(Rails.logger).to receive(:warn).with(/ERROR fetching Getty response: .*undefined method.*for nil:NilClass.*; cause: UNKNOWN/m)
           expect(subject).to be {}
         end
       end

data/spec/spec_helper.rb

@@ -1,25 +1,17 @@
-require 'linkeddata'
+# Not sure why these RDF-related gems are only being used in CI and not general
+# dependencies... maybe meant to be optional dependencies?
+require 'rdf/n3'
+require 'rdf/rdfxml'
+require 'json/ld'
+require 'rdf/vocab'
+
 require 'json'
 require 'engine_cart'
-require 'simplecov'
-require 'coveralls'
 require 'byebug' unless ENV['TRAVIS']
 
 ENV["RAILS_ENV"] ||= "test"
 
-SimpleCov.formatter = Coveralls::SimpleCov::Formatter
-SimpleCov.start('rails') do
-  add_filter '/.internal_test_app'
-  add_filter '/lib/generators'
-  add_filter '/spec'
-  add_filter '/tasks'
-  add_filter '/lib/qa/version.rb'
-  add_filter '/lib/qa/engine.rb'
-end
-SimpleCov.command_name 'spec'
-
 EngineCart.load_application!
-Coveralls.wear!
 
 require 'rspec/rails'
 require 'webmock/rspec'

data/spec/test_app_templates/Gemfile.extra

@@ -1,5 +1,24 @@
 # Use this file to reference specific commits of gems.
 
+
 group :development do
-  gem 'linkeddata'
+  # Rails < 6.1 are not compatible with psych 4, although doesn't know it.
+  # Local apps using old Rails will have to lock locally.  Latest versions
+  # of Rails 6.1+ has been updated to work with psych 4.
+  # See also:
+  #
+  # https://stackoverflow.com/questions/71191685/visit-psych-nodes-alias-unknown-alias-default-psychbadalias/71192990#71192990
+  #
+  if ENV['RAILS_VERSION'] && Gem::Version.new(ENV['RAILS_VERSION']) < Gem::Version.new("6.1")
+    gem 'psych', '< 4'
+  end
+
+  if ENV['RAILS_VERSION'] =~ /^6\.1\./ && ENV['RUBY_VERSION'] =~ /^3\.1\./
+    # opt into mail 2.8.0.rc1 so we get extra dependencies
+    # Once mail 2.8.0 final is released this will not be required.
+    # https://github.com/mikel/mail/pull/1472
+    gem "mail", ">= 2.8.0.rc1"
+    # See https://stackoverflow.com/questions/70500220/rails-7-ruby-3-1-loaderror-cannot-load-such-file-net-smtp
+    gem 'net-smtp', require: false
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: qa
 version: !ruby/object:Gem::Version
-  version: 5.8.1
+  version: 5.10.0
 platform: ruby
 authors:
 - Stephen Anderson
@@ -16,7 +16,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-07 00:00:00.000000000 Z
+date: 2022-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord-import
@@ -52,14 +52,20 @@ dependencies:
     requirements:
     - - "<"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 2.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "<"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: geocoder
   requirement: !ruby/object:Gem::Requirement
@@ -111,7 +117,7 @@ dependencies:
         version: '5.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.2'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -121,7 +127,7 @@ dependencies:
         version: '5.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.2'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: rdf
   requirement: !ruby/object:Gem::Requirement
@@ -142,14 +148,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '5.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.0.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '5.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.0.2
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -205,35 +217,63 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: linkeddata
+  name: rdf-n3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rdf-rdfxml
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: pry-byebug
+  name: json-ld
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rdf-vocab
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -247,7 +287,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -261,7 +301,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -355,7 +395,6 @@ files:
 - app/models/qa/mesh_tree.rb
 - app/models/qa/subject_mesh_term.rb
 - app/services/qa/iri_template_service.rb
-- app/services/qa/linked_data/authority_service.rb
 - app/services/qa/linked_data/authority_url_service.rb
 - app/services/qa/linked_data/deep_sort_service.rb
 - app/services/qa/linked_data/graph_service.rb
@@ -464,6 +503,7 @@ files:
 - lib/qa/configuration.rb
 - lib/qa/data/TGN_LANGUAGES.xml
 - lib/qa/engine.rb
+- lib/qa/linked_data/authority_service.rb
 - lib/qa/services.rb
 - lib/qa/services/rdf_authority_parser.rb
 - lib/qa/version.rb
@@ -636,156 +676,156 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.3.20
 signing_key:
 specification_version: 4
 summary: You should question your authorities.
 test_files:
-- spec/spec_helper.rb
+- spec/controllers/linked_data_terms_controller_spec.rb
+- spec/controllers/terms_controller_spec.rb
 - spec/features/linked_data/language_spec.rb
-- spec/models/linked_data/config/context_map_spec.rb
-- spec/models/linked_data/config/context_property_map_spec.rb
-- spec/models/iri_template/variable_map_spec.rb
-- spec/models/iri_template/url_config_spec.rb
-- spec/models/subject_mesh_term_spec.rb
-- spec/requests/cors_headers_spec.rb
-- spec/support/matchers/include_hash.rb
-- spec/test_app_templates/lib/generators/test_app_generator.rb
-- spec/test_app_templates/Gemfile.extra
-- spec/lib/tasks/mesh.rake_spec.rb
-- spec/lib/configuration_spec.rb
-- spec/lib/authorities_loc_subauthorities.rb
-- spec/lib/mesh_data_parser_spec.rb
-- spec/lib/authorities/linked_data/config_spec.rb
-- spec/lib/authorities/linked_data/search_config_spec.rb
-- spec/lib/authorities/linked_data/search_query_spec.rb
-- spec/lib/authorities/linked_data/term_config_spec.rb
-- spec/lib/authorities/linked_data/find_term_spec.rb
-- spec/lib/authorities/linked_data/generic_authority_spec.rb
-- spec/lib/authorities/loc_spec.rb
-- spec/lib/authorities/tgnlang_spec.rb
-- spec/lib/authorities/crossref_spec.rb
-- spec/lib/authorities/oclcts_spec.rb
-- spec/lib/authorities/local/file_based_authority_spec.rb
-- spec/lib/authorities/local/table_based_authority_spec.rb
-- spec/lib/authorities/local/mysql_table_based_authority_spec.rb
-- spec/lib/authorities/space_fix_encoder.rb
-- spec/lib/authorities/assign_fast_spec.rb
-- spec/lib/authorities/getty/tgn_spec.rb
-- spec/lib/authorities/getty/ulan_spec.rb
-- spec/lib/authorities/getty/aat_spec.rb
-- spec/lib/authorities/discogs_spec.rb
-- spec/lib/authorities/mesh_spec.rb
-- spec/lib/authorities/local_spec.rb
-- spec/lib/authorities/discogs/generic_authority_spec.rb
-- spec/lib/authorities/geonames_spec.rb
-- spec/lib/authorities/base_spec.rb
-- spec/lib/authorities/getty_spec.rb
-- spec/lib/services/rdf_authority_parser_spec.rb
-- spec/fixtures/lod_lang_search_enesfrde.rdf.xml
-- spec/fixtures/oclcts-response-mesh-3.txt
-- spec/fixtures/discogs-search-response-set-record.json
-- spec/fixtures/loc-names-response.txt
-- spec/fixtures/oclcts-response-mesh-2.txt
-- spec/fixtures/lod_loc_term_bad_id.rdf.xml
 - spec/fixtures/aat-response.txt
-- spec/fixtures/journals-result.json
-- spec/fixtures/discogs-search-response-no-subauth.json
-- spec/fixtures/lod_lang_search_fr.rdf.xml
-- spec/fixtures/oclcts-response-mesh-1.txt
-- spec/fixtures/lod_lang_term_fr.rdf.xml
-- spec/fixtures/discogs-search-response-no-auth.json
-- spec/fixtures/lod_3_ranked_varying_preds.nt
-- spec/fixtures/lod_lang_search_filtering.nt
-- spec/fixtures/discogs-find-response-jsonld-release.json
-- spec/fixtures/funders-noquery.json
-- spec/fixtures/lod_lang_term_enfrde.rdf.xml
-- spec/fixtures/assign-fast-oneresult.json
-- spec/fixtures/discogs-id-not-found-master.json
-- spec/fixtures/getty-aat-find-response.json
-- spec/fixtures/lod_lang_term_enfr_noalt.rdf.xml
+- spec/fixtures/assign-fast-noheader.json
 - spec/fixtures/assign-fast-noresults.json
-- spec/fixtures/discogs-search-response-per-page.json
-- spec/fixtures/getty-error-response.txt
-- spec/fixtures/lod_loc_term_found.rdf.xml
-- spec/fixtures/lod_lang_term_enfr.rdf.xml
+- spec/fixtures/assign-fast-oneresult.json
 - spec/fixtures/assign-fast-topical-result.json
-- spec/fixtures/getty-ulan-find-response.json
-- spec/fixtures/loc-subjects-response.txt
+- spec/fixtures/authorities/authority_A.yml
+- spec/fixtures/authorities/authority_B.yml
+- spec/fixtures/authorities/authority_C.yml
+- spec/fixtures/authorities/authority_D.yml
+- spec/fixtures/authorities/authority_U.yml
+- spec/fixtures/authorities/linked_data/lod_encoding_config.json
+- spec/fixtures/authorities/linked_data/lod_full_config.json
+- spec/fixtures/authorities/linked_data/lod_full_config_1_0.json
+- spec/fixtures/authorities/linked_data/lod_lang_defaults.json
+- spec/fixtures/authorities/linked_data/lod_lang_multi_defaults.json
+- spec/fixtures/authorities/linked_data/lod_lang_no_defaults.json
+- spec/fixtures/authorities/linked_data/lod_lang_param.json
+- spec/fixtures/authorities/linked_data/lod_min_config.json
+- spec/fixtures/authorities/linked_data/lod_search_only_config.json
+- spec/fixtures/authorities/linked_data/lod_sort.json
+- spec/fixtures/authorities/linked_data/lod_term_id_param_config.json
+- spec/fixtures/authorities/linked_data/lod_term_only_config.json
+- spec/fixtures/authorities/linked_data/lod_term_uri_param_config.json
 - spec/fixtures/discogs-find-response-json.json
-- spec/fixtures/loc-subject-find-response.txt
-- spec/fixtures/lod_oclc_all_query_3_results.rdf.xml
-- spec/fixtures/lod_2_ranked_2_unranked.nt
+- spec/fixtures/discogs-find-response-jsonld-master.json
+- spec/fixtures/discogs-find-response-jsonld-release.json
+- spec/fixtures/discogs-id-matches-master.json
+- spec/fixtures/discogs-id-matches-release.json
+- spec/fixtures/discogs-id-not-found-master.json
+- spec/fixtures/discogs-id-not-found-release.json
+- spec/fixtures/discogs-search-response-no-auth.json
+- spec/fixtures/discogs-search-response-no-subauth.json
+- spec/fixtures/discogs-search-response-per-page.json
+- spec/fixtures/discogs-search-response-set-record.json
+- spec/fixtures/discogs-search-response-subauth.json
+- spec/fixtures/funders-find-response.json
+- spec/fixtures/funders-noquery.json
 - spec/fixtures/funders-noresults.json
+- spec/fixtures/funders-result.json
+- spec/fixtures/geonames-find-response.json
+- spec/fixtures/geonames-response.json
+- spec/fixtures/getty-aat-find-response.json
+- spec/fixtures/getty-error-response.txt
 - spec/fixtures/getty-tgn-find-response.json
-- spec/fixtures/lod_lang_search_enfr.rdf.xml
+- spec/fixtures/getty-ulan-find-response.json
 - spec/fixtures/journals-find-response-two-issn.json
-- spec/fixtures/mesh.txt
-- spec/fixtures/discogs-search-response-subauth.json
-- spec/fixtures/lod_term_with_blanknode_objects.nt
-- spec/fixtures/geonames-find-response.json
-- spec/fixtures/lod_oclc_personalName_query_3_results.rdf.xml
-- spec/fixtures/loc-response.txt
-- spec/fixtures/discogs-id-not-found-release.json
-- spec/fixtures/funders-find-response.json
-- spec/fixtures/lexvo_snippet.rdf.xml
 - spec/fixtures/journals-find-response.json
-- spec/fixtures/discogs-id-matches-master.json
-- spec/fixtures/discogs-find-response-jsonld-master.json
+- spec/fixtures/journals-noquery.json
+- spec/fixtures/journals-noresults.json
+- spec/fixtures/journals-result.json
+- spec/fixtures/lexvo_snippet.rdf.xml
+- spec/fixtures/loc-names-response.txt
+- spec/fixtures/loc-response.txt
+- spec/fixtures/loc-subject-find-response.txt
+- spec/fixtures/loc-subjects-response.txt
+- spec/fixtures/lod_2_ranked_2_unranked.nt
+- spec/fixtures/lod_3_ranked_varying_preds.nt
 - spec/fixtures/lod_lang_search_en.rdf.xml
+- spec/fixtures/lod_lang_search_enesfrde.rdf.xml
+- spec/fixtures/lod_lang_search_enfr.rdf.xml
+- spec/fixtures/lod_lang_search_enfrde.rdf.xml
+- spec/fixtures/lod_lang_search_filtering.nt
+- spec/fixtures/lod_lang_search_fr.rdf.xml
+- spec/fixtures/lod_lang_search_sv.rdf.xml
 - spec/fixtures/lod_lang_term_en.rdf.xml
-- spec/fixtures/journals-noresults.json
-- spec/fixtures/discogs-id-matches-release.json
-- spec/fixtures/journals-noquery.json
+- spec/fixtures/lod_lang_term_enfr.rdf.xml
+- spec/fixtures/lod_lang_term_enfr_noalt.rdf.xml
+- spec/fixtures/lod_lang_term_enfrde.rdf.xml
+- spec/fixtures/lod_lang_term_fr.rdf.xml
+- spec/fixtures/lod_loc_second_term_found.rdf.xml
+- spec/fixtures/lod_loc_term_bad_id.rdf.xml
+- spec/fixtures/lod_loc_term_found.rdf.xml
+- spec/fixtures/lod_oclc_all_query_3_results.rdf.xml
+- spec/fixtures/lod_oclc_personalName_query_3_results.rdf.xml
 - spec/fixtures/lod_oclc_query_no_results.rdf.xml
-- spec/fixtures/authorities/linked_data/lod_search_only_config.json
-- spec/fixtures/authorities/linked_data/lod_sort.json
-- spec/fixtures/authorities/linked_data/lod_min_config.json
-- spec/fixtures/authorities/linked_data/lod_encoding_config.json
-- spec/fixtures/authorities/linked_data/lod_term_id_param_config.json
-- spec/fixtures/authorities/linked_data/lod_lang_multi_defaults.json
-- spec/fixtures/authorities/linked_data/lod_full_config_1_0.json
-- spec/fixtures/authorities/linked_data/lod_lang_defaults.json
-- spec/fixtures/authorities/linked_data/lod_term_only_config.json
-- spec/fixtures/authorities/linked_data/lod_lang_no_defaults.json
-- spec/fixtures/authorities/linked_data/lod_term_uri_param_config.json
-- spec/fixtures/authorities/linked_data/lod_full_config.json
-- spec/fixtures/authorities/linked_data/lod_lang_param.json
-- spec/fixtures/authorities/authority_D.yml
-- spec/fixtures/authorities/authority_A.yml
-- spec/fixtures/authorities/authority_C.yml
-- spec/fixtures/authorities/authority_U.yml
-- spec/fixtures/authorities/authority_B.yml
-- spec/fixtures/geonames-response.json
-- spec/fixtures/tgn-response.txt
-- spec/fixtures/lod_oclc_term_found.rdf.xml
 - spec/fixtures/lod_oclc_term_bad_id.nt
+- spec/fixtures/lod_oclc_term_found.rdf.xml
 - spec/fixtures/lod_search_with_blanknode_subjects.nt
-- spec/fixtures/assign-fast-noheader.json
-- spec/fixtures/lod_loc_second_term_found.rdf.xml
-- spec/fixtures/lod_lang_search_enfrde.rdf.xml
-- spec/fixtures/funders-result.json
-- spec/fixtures/lod_lang_search_sv.rdf.xml
+- spec/fixtures/lod_term_with_blanknode_objects.nt
+- spec/fixtures/mesh.txt
+- spec/fixtures/oclcts-response-mesh-1.txt
+- spec/fixtures/oclcts-response-mesh-2.txt
+- spec/fixtures/oclcts-response-mesh-3.txt
+- spec/fixtures/tgn-response.txt
 - spec/fixtures/ulan-response.txt
+- spec/lib/authorities/assign_fast_spec.rb
+- spec/lib/authorities/base_spec.rb
+- spec/lib/authorities/crossref_spec.rb
+- spec/lib/authorities/discogs/generic_authority_spec.rb
+- spec/lib/authorities/discogs_spec.rb
+- spec/lib/authorities/geonames_spec.rb
+- spec/lib/authorities/getty/aat_spec.rb
+- spec/lib/authorities/getty/tgn_spec.rb
+- spec/lib/authorities/getty/ulan_spec.rb
+- spec/lib/authorities/getty_spec.rb
+- spec/lib/authorities/linked_data/config_spec.rb
+- spec/lib/authorities/linked_data/find_term_spec.rb
+- spec/lib/authorities/linked_data/generic_authority_spec.rb
+- spec/lib/authorities/linked_data/search_config_spec.rb
+- spec/lib/authorities/linked_data/search_query_spec.rb
+- spec/lib/authorities/linked_data/term_config_spec.rb
+- spec/lib/authorities/loc_spec.rb
+- spec/lib/authorities/local/file_based_authority_spec.rb
+- spec/lib/authorities/local/mysql_table_based_authority_spec.rb
+- spec/lib/authorities/local/table_based_authority_spec.rb
+- spec/lib/authorities/local_spec.rb
+- spec/lib/authorities/mesh_spec.rb
+- spec/lib/authorities/oclcts_spec.rb
+- spec/lib/authorities/space_fix_encoder.rb
+- spec/lib/authorities/tgnlang_spec.rb
+- spec/lib/authorities_loc_subauthorities.rb
+- spec/lib/configuration_spec.rb
+- spec/lib/mesh_data_parser_spec.rb
+- spec/lib/services/rdf_authority_parser_spec.rb
+- spec/lib/tasks/mesh.rake_spec.rb
+- spec/models/iri_template/url_config_spec.rb
+- spec/models/iri_template/variable_map_spec.rb
+- spec/models/linked_data/config/context_map_spec.rb
+- spec/models/linked_data/config/context_property_map_spec.rb
+- spec/models/subject_mesh_term_spec.rb
+- spec/requests/cors_headers_spec.rb
 - spec/routing/linked_data_route_spec.rb
 - spec/routing/route_spec.rb
-- spec/controllers/terms_controller_spec.rb
-- spec/controllers/linked_data_terms_controller_spec.rb
-- spec/services/linked_data/request_header_service_spec.rb
+- spec/services/iri_template_service_spec.rb
 - spec/services/linked_data/authority_service_spec.rb
-- spec/services/linked_data/ldpath_service_spec.rb
+- spec/services/linked_data/authority_url_service_spec.rb
+- spec/services/linked_data/deep_sort_service_spec.rb
 - spec/services/linked_data/graph_service_spec.rb
+- spec/services/linked_data/language_service_spec.rb
 - spec/services/linked_data/language_sort_service_spec.rb
+- spec/services/linked_data/ldpath_service_spec.rb
+- spec/services/linked_data/mapper/context_mapper_service_spec.rb
 - spec/services/linked_data/mapper/graph_ldpath_mapper_service_spec.rb
-- spec/services/linked_data/mapper/term_results_mapper_service_spec.rb
-- spec/services/linked_data/mapper/search_results_mapper_service_spec.rb
 - spec/services/linked_data/mapper/graph_mapper_service_spec.rb
-- spec/services/linked_data/mapper/context_mapper_service_spec.rb
 - spec/services/linked_data/mapper/graph_predicate_mapper_service_spec.rb
-- spec/services/linked_data/deep_sort_service_spec.rb
+- spec/services/linked_data/mapper/search_results_mapper_service_spec.rb
+- spec/services/linked_data/mapper/term_results_mapper_service_spec.rb
 - spec/services/linked_data/performance_data_service_spec.rb
-- spec/services/linked_data/language_service_spec.rb
-- spec/services/linked_data/authority_url_service_spec.rb
+- spec/services/linked_data/request_header_service_spec.rb
 - spec/services/linked_data/response_header_service_spec.rb
 - spec/services/pagination_service_spec.rb
-- spec/services/iri_template_service_spec.rb
+- spec/spec_helper.rb
+- spec/support/matchers/include_hash.rb
+- spec/test_app_templates/Gemfile.extra
+- spec/test_app_templates/lib/generators/test_app_generator.rb