qa 4.0.0 → 4.1.0

data/spec/fixtures/authorities/linked_data/lod_lang_param.json

@@ -4,12 +4,12 @@
     "url": {
       "@context": "http://www.w3.org/ns/hydra/context.jsonld",
       "@type":    "IriTemplate",
-      "template": "http://localhost/test_replacement/term/{term_id}?{?lang}",
+      "template": "{term_uri}?{?lang}",
       "variableRepresentation": "BasicRepresentation",
       "mapping": [
         {
           "@type":    "IriTemplateMapping",
-          "variable": "term_id",
+          "variable": "term_uri",
           "property": "hydra:freetextQuery",
           "required": true
         },
@@ -23,9 +23,9 @@
       ]
     },
     "qa_replacement_patterns": {
-      "term_id": "term_id"
+      "term_id": "term_uri"
     },
-    "term_id": "ID",
+    "term_id": "URI",
     "results": {
       "id_predicate":       "http://id.loc.gov/vocabulary/identifiers/lccn",
       "label_predicate":    "http://www.w3.org/2004/02/skos/core#prefLabel",

data/spec/fixtures/authorities/linked_data/lod_term_uri_param_config.json

@@ -20,7 +20,7 @@
     },
     "term_id": "URI",
     "results": {
-      "id_predicate":       "http://id.loc.gov/vocabulary/identifiers/lccn",
+      "id_predicate":       "http://purl.org/dc/terms/identifier",
       "label_predicate":    "http://www.w3.org/2004/02/skos/core#prefLabel"
     }
   },

data/spec/fixtures/discogs-find-response-json.json

@@ -0,0 +1 @@
+{"status":"Accepted","series":[],"labels":[{"name":"Blue Note"}],"year":1962,"artists":[{"name":"Dexter Gordon"}],"id":3380671,"genres":["Jazz"],"title":"A Swingin' Affair","styles":["Hard Bop"],"formats":[{"qty":"1","descriptions":["LP","Album","Mono"],"name":"Vinyl"}]}

data/spec/fixtures/discogs-find-response-jsonld-master.json

@@ -0,0 +1 @@
+{"genres":["Jazz"],"num_for_sale":0,"title":"Blue Moon / You Go To My Head","most_recent_release":12028368,"main_release":8035918,"main_release_url":"https://api.discogs.com/releases/8035918","year":1952,"uri":"https://www.discogs.com/Billie-Holiday-And-Her-Orchestra-Blue-Moon-You-Go-To-My-Head/master/950011","versions_url":"https://api.discogs.com/masters/950011/versions","extraartists":[{"join":"","name":"Ray Brown","anv":"","tracks":"","role":"Bass","resource_url":"https://api.discogs.com/artists/252998","id":252998},{"join":"","name":"Alvin Stoller","anv":"","tracks":"","role":"Drums","resource_url":"https://api.discogs.com/artists/258467","id":258467},{"join":"","name":"Barney Kessel","anv":"","tracks":"","role":"Guitar","resource_url":"https://api.discogs.com/artists/253476","id":253476},{"join":"","name":"Oscar Peterson","anv":"","tracks":"","role":"Piano","resource_url":"https://api.discogs.com/artists/254394","id":254394},{"join":"","name":"Flip Phillips","anv":"","tracks":"","role":"Tenor Saxophone","resource_url":"https://api.discogs.com/artists/265641","id":265641},{"join":"","name":"Charlie Shavers","anv":"","tracks":"","role":"Trumpet","resource_url":"https://api.discogs.com/artists/265683","id":265683}],"tracklist":[{"duration":"","position":"A","type_":"track","extraartists":[{"join":"","name":"Rodgers & Hart","anv":"","tracks":"","role":"Written-By","resource_url":"https://api.discogs.com/artists/604171","id":604171}],"title":"Blue Moon"},{"duration":"","position":"AA","type_":"track","extraartists":[{"join":"","name":"Haven Gillespie","anv":"Gillespie","tracks":"","role":"Written-By","resource_url":"https://api.discogs.com/artists/583502","id":583502},{"join":"","name":"J. Fred Coots","anv":"Coots","tracks":"","role":"Written-By","resource_url":"https://api.discogs.com/artists/583506","id":583506}],"title":"You Go To My Head"}],"most_recent_release_url":"https://api.discogs.com/releases/12028368","artists":[{"join":"","name":"Billie Holiday And Her Orchestra","anv":"","tracks":"","role":"","resource_url":"https://api.discogs.com/artists/312936","id":312936}],"resource_url":"https://api.discogs.com/masters/950011","lowest_price":null,"id":950011,"data_quality":"Correct"}

data/spec/fixtures/discogs-find-response-jsonld-release.json

@@ -0,0 +1 @@
+{"series":[],"labels":[{"name":"Mercury Record Corporation","entity_type":"1","catno":"89004-X45","resource_url":"https://api.discogs.com/labels/269924","id":269924,"entity_type_name":"Label"}],"year":0,"artists":[{"join":"","name":"Billie Holiday And Her Orchestra","anv":"","tracks":"","role":"","resource_url":"https://api.discogs.com/artists/312936","id":312936}],"format_quantity":1,"id":7143179,"artists_sort":"Billie Holiday And Her Orchestra","genres":["Jazz"],"thumb":"","num_for_sale":0,"title":"Blue Moon / You Go To My Head","date_changed":"2017-06-16T09:04:56-07:00","master_id":950011,"status":"Accepted","estimated_weight":60,"master_url":"https://api.discogs.com/masters/950011","date_added":"2015-06-18T19:03:08-07:00","tracklist":[{"duration":"","position":"A","type_":"track","extraartists":[{"join":"","name":"Rodgers & Hart","anv":"Rodgers - Hart","tracks":"","role":"Written-By","resource_url":"https://api.discogs.com/artists/604171","id":604171}],"title":"Blue Moon"},{"duration":"","position":"AA","type_":"track","extraartists":[{"join":"","name":"Haven Gillespie","anv":"Gillespie","tracks":"","role":"Written-By","resource_url":"https://api.discogs.com/artists/583502","id":583502},{"join":"","name":"J. Fred Coots","anv":"Coots","tracks":"","role":"Written-By","resource_url":"https://api.discogs.com/artists/583506","id":583506}],"title":"You Go To My Head"}],"extraartists":[{"join":"","name":"Ray Brown","anv":"","tracks":"","role":"Bass","resource_url":"https://api.discogs.com/artists/252998","id":252998},{"join":"","name":"Alvin Stoller","anv":"","tracks":"","role":"Drums","resource_url":"https://api.discogs.com/artists/258467","id":258467},{"join":"","name":"Barney Kessel","anv":"","tracks":"","role":"Guitar","resource_url":"https://api.discogs.com/artists/253476","id":253476},{"join":"","name":"Oscar Peterson","anv":"","tracks":"","role":"Piano","resource_url":"https://api.discogs.com/artists/254394","id":254394},{"join":"","name":"Flip Phillips","anv":"","tracks":"","role":"Tenor Saxophone","resource_url":"https://api.discogs.com/artists/265641","id":265641},{"join":"","name":"Charlie Shavers","anv":"","tracks":"","role":"Trumpet","resource_url":"https://api.discogs.com/artists/265683","id":265683}],"country":"US","identifiers":[{"type":"Matrix / Runout","description":"Side A","value":"45 YWR-765-1"},{"type":"Matrix / Runout","description":"Side AA","value":"45 YWR-766-3"}],"companies":[],"uri":"https://www.discogs.com/Billie-Holiday-And-Her-Orchestra-Blue-Moon-You-Go-To-My-Head/release/7143179","formats":[{"descriptions":["7\"","45 RPM","Single","Mono"],"name":"Vinyl","qty":"1"}],"resource_url":"https://api.discogs.com/releases/7143179","data_quality":"Complete and Correct"}

data/spec/fixtures/discogs-id-matches-master.json

@@ -0,0 +1 @@
+{"styles":["Techno","Ambient"],"genres":["Electronic"],"num_for_sale":39,"title":"Simulation","most_recent_release":10824503,"main_release":10824503,"main_release_url":"https://api.discogs.com/releases/10824503","year":2017,"uri":"https://www.discogs.com/Aleksi-Per%C3%A4l%C3%A4-Simulation/master/1234567","versions_url":"https://api.discogs.com/masters/1234567/versions","most_recent_release_url":"https://api.discogs.com/releases/10824503","artists":[{"join":"","name":"Aleksi Perälä","anv":"","tracks":"","role":"","resource_url":"https://api.discogs.com/artists/15690","id":15690}],"resource_url":"https://api.discogs.com/masters/1234567","lowest_price":22.61,"id":1234567,"data_quality":"Correct"}

data/spec/fixtures/discogs-id-matches-release.json

@@ -0,0 +1 @@
+{"series":[],"labels":[],"year":0,"format_quantity":0,"id":1234567,"artists_sort":"Asia Minor","thumb":"","extraartists":[],"title":"Longa Nova","artists":[{"join":"","name":"Asia Minor","anv":"","tracks":"","role":"","resource_url":"https://api.discogs.com/artists/1138249","id":1138249}],"date_changed":null,"lowest_price":null,"status":"Draft","date_added":null,"num_for_sale":0,"tracklist":[],"identifiers":[],"companies":[],"uri":"https://www.discogs.com/release/1234567","formats":[],"resource_url":"https://api.discogs.com/releases/1234567","data_quality":"Needs Major Changes"}

data/spec/fixtures/discogs-id-not-found-master.json

@@ -0,0 +1 @@
+{"message": "Master Release not found."}

data/spec/fixtures/discogs-id-not-found-release.json

@@ -0,0 +1 @@
+{"message": "Release not found."}

data/spec/fixtures/discogs-search-response-no-auth.json

@@ -0,0 +1 @@
+{"id": "Error", "label": "Cannot access Discogs without authentication."}

data/spec/fixtures/discogs-search-response-no-subauth.json

@@ -0,0 +1 @@
+{"pagination": {"per_page": 50, "items": 1, "page": 1, "urls": {}, "pages": 1}, "results": [{"style": ["Smooth Jazz", "Contemporary Jazz"], "master_id": 812047, "thumb": "https://img.discogs.com/yh2qJ9upQDTqm4p-37Qxr-NLTzw=/fit-in/150x150/filters:strip_icc():format(jpeg):mode_rgb():quality(40)/discogs-images/R-1750352-1240940672.jpeg.jpg", "format": ["Vinyl", "7\"", "Promo"], "country": "Germany", "barcode": ["LC 00383", "B963180-01 A1 HL", "B963180-01 B1 HL"], "uri": "/Melody-Gardot-Who-Will-Comfort-Me-Over-The-Rainbow/release/1750352", "master_url": "https://api.discogs.com/masters/812047", "label": ["Verve Records", "Universal Music Classics & Jazz", "Universal Music Classics & Jazz"], "cover_image": "https://img.discogs.com/Vjya6pq52cXLYpDS4SI6H_2yyEA=/fit-in/600x595/filters:strip_icc():format(jpeg):mode_rgb():quality(90)/discogs-images/R-1750352-1240940672.jpeg.jpg", "catno": "none", "community": {"have": 27, "want": 29}, "year": "2009", "genre": ["Jazz"], "title": "Melody Gardot - Who Will Comfort Me / Over The Rainbow", "resource_url": "https://api.discogs.com/releases/1750352", "type": "release", "id": 1750352}]}

data/spec/fixtures/discogs-search-response-subauth.json

@@ -0,0 +1 @@
+{"pagination": {"per_page": 50, "items": 1, "page": 1, "urls": {}, "pages": 1}, "results": [{"style": ["Soul-Jazz"], "master_id": 606116, "thumb": "https://img.discogs.com/yxXxXcaRv3f92Fs7msRvDll0j9E=/fit-in/150x150/filters:strip_icc():format(jpeg):mode_rgb():quality(40)/discogs-images/R-4543663-1367897598-4591.jpeg.jpg", "format": ["Vinyl", "7\"", "45 RPM", "Single"], "country": "US", "barcode": [], "uri": "/Wes-Montgomery-Bumpin-On-Sunset-Tequila/master/606116", "master_url": "https://api.discogs.com/masters/606116", "label": ["Verve Records"], "cover_image": "https://img.discogs.com/V6ftY0lAFE9mHlzBIhGZMMos3Dg=/fit-in/593x572/filters:strip_icc():format(jpeg):mode_rgb():quality(90)/discogs-images/R-4543663-1367897598-4591.jpeg.jpg", "catno": "VK-10432", "community": {"have": 42, "want": 118}, "year": "1966", "genre": ["Jazz", "Funk / Soul"], "title": "Wes Montgomery - Bumpin' On Sunset / Tequila", "resource_url": "https://api.discogs.com/masters/606116", "type": "master", "id": 606116}]}

data/spec/fixtures/lod_lang_search_enesfrde.rdf.xml

@@ -0,0 +1,60 @@
+<rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:coord="http://whatever/java/ORG.oclc.util.CoordToDecimal" xmlns:naco="http://whatever/java/ORG.oclc.util.NacoNormalize" xmlns:norm="http://whatever/java/ORG.oclc.util.NormalFormC" xmlns:schema="http://schema.org/" xmlns:madsrdf="http://www.loc.gov/mads/rdf/v1#" xmlns:skosxl="http://www.w3.org/2008/05/skos-xl#" xmlns:dct="http://purl.org/dc/terms/" xmlns:foaf="http://xmlns.com/foaf/0.1/" xmlns:void="http://rdfs.org/ns/void#" xmlns:owl="http://www.w3.org/2002/07/owl#" xmlns:mx="http://www.loc.gov/MARC21/slim" xmlns:skos="http://www.w3.org/2004/02/skos/core#" xmlns:rdfs="http://www.w3.org/2000/01/rdf-schema#" xml:base="http://id.worldcat.org/fast/">
+  <rdf:Description rdf:about="530369">
+    <dct:identifier>530369</dct:identifier>
+    <skos:prefLabel xml:lang="en">buttermilk</skos:prefLabel>
+    <skos:prefLabel xml:lang="fr">Babeurre</skos:prefLabel>
+    <skos:prefLabel xml:lang="de">Buttermilch</skos:prefLabel>
+    <skos:altLabel xml:lang="en">yummy</skos:altLabel>
+    <skos:altLabel xml:lang="fr">délicieux</skos:altLabel>
+    <skos:altLabel xml:lang="de">lecker</skos:altLabel>
+  </rdf:Description>
+  <rdf:Description rdf:about="fst00530369">
+    <rdfs:comment>This identifier is deprecated. See the rdfs:seeAlso link for the new identifier.</rdfs:comment>
+    <rdfs:seeAlso rdf:resource="530369"/>
+  </rdf:Description>
+  <foaf:Document rdf:about="530369/rdf.xml">
+    <foaf:primaryTopic rdf:resource="530369"/>
+    <dc:format>application/rdf+xml</dc:format>
+    <dct:created rdf:datatype="http://www.w3.org/2001/XMLSchema#dateTime">2005-05-13T00:00:00.0</dct:created>
+    <dct:modified rdf:datatype="http://www.w3.org/2001/XMLSchema#dateTime">2012-07-06T14:07:21.0</dct:modified>
+    <dct:language rdf:resource="http://lexvo.org/id/iso639-3/eng"/>
+  </foaf:Document>
+  <rdf:Description rdf:about="5140">
+    <dct:identifier>5140</dct:identifier>
+    <skos:prefLabel xml:lang="en">dried milk</skos:prefLabel>
+    <skos:prefLabel xml:lang="fr">lait en poudre</skos:prefLabel>
+    <skos:prefLabel xml:lang="de">getrocknete Milch</skos:prefLabel>
+    <skos:prefLabel xml:lang="es">leche en polvo</skos:prefLabel>
+    <skos:altLabel xml:lang="en">powdery</skos:altLabel>
+    <skos:altLabel xml:lang="fr">poudreux</skos:altLabel>
+    <skos:altLabel xml:lang="de">Pulverförmig</skos:altLabel>
+    <skos:altLabel xml:lang="es">en polvo</skos:altLabel>
+    <skos:altLabel>pulvora</skos:altLabel>
+  </rdf:Description>
+  <rdf:Description rdf:about="fst00005140">
+    <rdfs:comment>This identifier is deprecated. See the rdfs:seeAlso link for the new identifier.</rdfs:comment>
+    <rdfs:seeAlso rdf:resource="5140"/>
+  </rdf:Description>
+  <foaf:Document rdf:about="5140/rdf.xml">
+    <foaf:primaryTopic rdf:resource="5140"/>
+    <dc:format>application/rdf+xml</dc:format>
+    <dct:created rdf:datatype="http://www.w3.org/2001/XMLSchema#dateTime">2004-09-24T00:00:00.0</dct:created>
+    <dct:modified rdf:datatype="http://www.w3.org/2001/XMLSchema#dateTime">2012-07-06T14:07:21.0</dct:modified>
+  </foaf:Document>
+  <rdf:Description rdf:about="557490">
+    <dct:identifier>557490</dct:identifier>
+    <skos:prefLabel xml:lang="en">condensed milk</skos:prefLabel>
+    <skos:prefLabel xml:lang="fr">lait condensé</skos:prefLabel>
+    <skos:prefLabel xml:lang="de">Kondensmilch</skos:prefLabel>
+    <skos:prefLabel xml:lang="es">leche condensada</skos:prefLabel>
+    <skos:prefLabel>lakto densigita</skos:prefLabel>
+    <skos:altLabel xml:lang="en">creamy</skos:altLabel>
+    <skos:altLabel xml:lang="fr">crémeux</skos:altLabel>
+    <skos:altLabel xml:lang="de">cremig</skos:altLabel>
+    <skos:altLabel xml:lang="es">cremoso</skos:altLabel>
+  </rdf:Description>
+  <rdf:Description rdf:about="fst00557490">
+    <rdfs:comment>This identifier is deprecated. See the rdfs:seeAlso link for the new identifier.</rdfs:comment>
+    <rdfs:seeAlso rdf:resource="557490"/>
+  </rdf:Description>
+</rdf:RDF>

data/spec/fixtures/lod_lang_search_sv.rdf.xml

@@ -0,0 +1,42 @@
+<rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:coord="http://whatever/java/ORG.oclc.util.CoordToDecimal" xmlns:naco="http://whatever/java/ORG.oclc.util.NacoNormalize" xmlns:norm="http://whatever/java/ORG.oclc.util.NormalFormC" xmlns:schema="http://schema.org/" xmlns:madsrdf="http://www.loc.gov/mads/rdf/v1#" xmlns:skosxl="http://www.w3.org/2008/05/skos-xl#" xmlns:dct="http://purl.org/dc/terms/" xmlns:foaf="http://xmlns.com/foaf/0.1/" xmlns:void="http://rdfs.org/ns/void#" xmlns:owl="http://www.w3.org/2002/07/owl#" xmlns:mx="http://www.loc.gov/MARC21/slim" xmlns:skos="http://www.w3.org/2004/02/skos/core#" xmlns:rdfs="http://www.w3.org/2000/01/rdf-schema#" xml:base="http://id.worldcat.org/fast/">
+  <rdf:Description rdf:about="530369">
+    <dct:identifier>530369</dct:identifier>
+    <skos:prefLabel xml:lang="en">kärnmjölk</skos:prefLabel>
+    <skos:altLabel xml:lang="en">smaskigt</skos:altLabel>
+  </rdf:Description>
+  <rdf:Description rdf:about="fst00530369">
+    <rdfs:comment>This identifier is deprecated. See the rdfs:seeAlso link for the new identifier.</rdfs:comment>
+    <rdfs:seeAlso rdf:resource="530369"/>
+  </rdf:Description>
+  <foaf:Document rdf:about="530369/rdf.xml">
+    <foaf:primaryTopic rdf:resource="530369"/>
+    <dc:format>application/rdf+xml</dc:format>
+    <dct:created rdf:datatype="http://www.w3.org/2001/XMLSchema#dateTime">2005-05-13T00:00:00.0</dct:created>
+    <dct:modified rdf:datatype="http://www.w3.org/2001/XMLSchema#dateTime">2012-07-06T14:07:21.0</dct:modified>
+    <dct:language rdf:resource="http://lexvo.org/id/iso639-3/eng"/>
+  </foaf:Document>
+  <rdf:Description rdf:about="5140">
+    <dct:identifier>5140</dct:identifier>
+    <skos:prefLabel xml:lang="en">mjölkpulver</skos:prefLabel>
+    <skos:altLabel xml:lang="en">pulver-</skos:altLabel>
+  </rdf:Description>
+  <rdf:Description rdf:about="fst00005140">
+    <rdfs:comment>This identifier is deprecated. See the rdfs:seeAlso link for the new identifier.</rdfs:comment>
+    <rdfs:seeAlso rdf:resource="5140"/>
+  </rdf:Description>
+  <foaf:Document rdf:about="5140/rdf.xml">
+    <foaf:primaryTopic rdf:resource="5140"/>
+    <dc:format>application/rdf+xml</dc:format>
+    <dct:created rdf:datatype="http://www.w3.org/2001/XMLSchema#dateTime">2004-09-24T00:00:00.0</dct:created>
+    <dct:modified rdf:datatype="http://www.w3.org/2001/XMLSchema#dateTime">2012-07-06T14:07:21.0</dct:modified>
+  </foaf:Document>
+  <rdf:Description rdf:about="557490">
+    <dct:identifier>557490</dct:identifier>
+    <skos:prefLabel xml:lang="en">kondenserad mjölk</skos:prefLabel>
+    <skos:altLabel xml:lang="en">krämig</skos:altLabel>
+  </rdf:Description>
+  <rdf:Description rdf:about="fst00557490">
+    <rdfs:comment>This identifier is deprecated. See the rdfs:seeAlso link for the new identifier.</rdfs:comment>
+    <rdfs:seeAlso rdf:resource="557490"/>
+  </rdf:Description>
+</rdf:RDF>

data/spec/fixtures/lod_loc_term_found.rdf.xml

@@ -119,6 +119,11 @@
     <identifiers:lccn xmlns:identifiers="http://id.loc.gov/vocabulary/identifiers/">sh 85118553</identifiers:lccn>
     <owl:sameAs rdf:resource="info:lc/authorities/sh85118553" xmlns:owl="http://www.w3.org/2002/07/owl#"/>
     <owl:sameAs rdf:resource="http://id.loc.gov/authorities/sh85118553#concept" xmlns:owl="http://www.w3.org/2002/07/owl#"/>
+    <madsrdf:hasNarrowerAuthority>
+      <madsrdf:Authority rdf:about="http://id.loc.gov/authorities/subjects/sh92004048">
+        <madsrdf:authoritativeLabel xml:lang="en">Environmental sciences</madsrdf:authoritativeLabel>
+      </madsrdf:Authority>
+    </madsrdf:hasNarrowerAuthority>
     <madsrdf:adminMetadata>
       <ri:RecordInfo xmlns:ri="http://id.loc.gov/ontologies/RecordInfo#">
 	<ri:recordChangeDate rdf:datatype="http://www.w3.org/2001/XMLSchema#dateTime">2000-06-20T00:00:00</ri:recordChangeDate>

data/spec/lib/authorities/discogs/generic_authority_spec.rb

@@ -0,0 +1,235 @@
+require 'spec_helper'
+
+describe Qa::Authorities::Discogs::GenericAuthority do
+  before do
+    described_class.discogs_key = 'dummy_key'
+    described_class.discogs_secret = 'dummy_secret'
+  end
+
+  let(:authority) { described_class.new "all" }
+
+  describe "#build_query_url" do
+    subject { authority.build_query_url("foo", 'master') }
+    it { is_expected.to eq 'https://api.discogs.com/database/search?q=foo&type=master&key=dummy_key&secret=dummy_secret' }
+  end
+
+  describe "#find_url" do
+    subject { authority.find_url("10018955", "release") }
+    it { is_expected.to eq "https://api.discogs.com/releases/10018955" }
+  end
+
+  describe "#find" do
+    context "find variations" do
+      before do
+        stub_request(:get, "https://api.discogs.com/releases/3380671")
+          .to_return(status: 200, body: webmock_fixture("discogs-find-response-json.json"))
+
+        stub_request(:get, "https://api.discogs.com/masters/3380671")
+          .to_return(status: 200, body: webmock_fixture("discogs-id-not-found-master.json"))
+
+        stub_request(:get, "https://api.discogs.com/masters/1234567")
+          .to_return(status: 200, body: webmock_fixture("discogs-id-matches-master.json"))
+
+        stub_request(:get, "https://api.discogs.com/releases/1234567")
+          .to_return(status: 200, body: webmock_fixture("discogs-id-matches-release.json"))
+
+        stub_request(:get, "https://api.discogs.com/masters/123459876")
+          .to_return(status: 200, body: webmock_fixture("discogs-id-not-found-master.json"))
+
+        stub_request(:get, "https://api.discogs.com/releases/123459876")
+          .to_return(status: 200, body: webmock_fixture("discogs-id-not-found-release.json"))
+
+        stub_request(:get, "https://api.discogs.com/releases/7143179")
+          .to_return(status: 200, body: webmock_fixture("discogs-find-response-jsonld-release.json"))
+
+        stub_request(:get, "https://api.discogs.com/masters/7143179")
+          .to_return(status: 200, body: webmock_fixture("discogs-id-not-found-master.json"))
+
+        stub_request(:get, "https://api.discogs.com/masters/950011")
+          .to_return(status: 200, body: webmock_fixture("discogs-find-response-jsonld-master.json"))
+      end
+
+      context "json format and release subauthority" do
+        let(:tc) { instance_double(Qa::TermsController) }
+        let :results do
+          authority.find("3380671", tc)
+        end
+        before do
+          allow(Qa::TermsController).to receive(:new).and_return(tc)
+          allow(tc).to receive(:params).and_return('format' => "json", 'subauthority' => "release")
+        end
+
+        it "returns the Discogs data for a given id" do
+          expect(results['title']).to eq "A Swingin' Affair"
+          expect(results['genres'][0]).to eq "Jazz"
+        end
+      end
+
+      context "json format and subauthority all" do
+        let(:tc) { instance_double(Qa::TermsController) }
+        let :results do
+          authority.find("3380671", tc)
+        end
+        before do
+          allow(Qa::TermsController).to receive(:new).and_return(tc)
+          allow(tc).to receive(:params).and_return('format' => "json", 'subauthority' => "all")
+        end
+
+        it "returns the Discogs data for a given id" do
+          expect(results['title']).to eq "A Swingin' Affair"
+          expect(results['genres'][0]).to eq "Jazz"
+        end
+      end
+
+      context "id matches a Discogs release and a master" do
+        let(:tc) { instance_double(Qa::TermsController) }
+        let :results do
+          authority.find("1234567", tc)
+        end
+        before do
+          allow(Qa::TermsController).to receive(:new).and_return(tc)
+          allow(tc).to receive(:params).and_return('format' => "json", 'subauthority' => "all")
+        end
+
+        it "returns two matches message and resource urls" do
+          expect(results['message']).to eq "Both a master and a release match the requested ID."
+          expect(results['resource_url'][0]).to eq "https://api.discogs.com/masters/1234567"
+          expect(results['resource_url'][1]).to eq "https://api.discogs.com/releases/1234567"
+        end
+      end
+
+      context "id matches neither a release nor a master" do
+        let(:tc) { instance_double(Qa::TermsController) }
+        let :results do
+          authority.find("123459876", tc)
+        end
+        before do
+          allow(Qa::TermsController).to receive(:new).and_return(tc)
+          allow(tc).to receive(:params).and_return('format' => "json", 'subauthority' => "all")
+        end
+
+        it "returns two matches message and resource urls" do
+          expect(results['message']).to eq "Neither a master nor a release matches the requested ID."
+        end
+      end
+
+      context "json-ld format and subauthority master" do
+        let(:tc) { instance_double(Qa::TermsController) }
+        let :results do
+          authority.find("950011", tc)
+        end
+        before do
+          allow(Qa::TermsController).to receive(:new).and_return(tc)
+          allow(tc).to receive(:params).and_return('format' => "jsonld", 'subauthority' => "master")
+        end
+
+        it "returns the Discogs data converted to json-ld for a given id" do
+          expect(JSON.parse(results).keys).to match_array ["@context", "@graph"]
+          expect(JSON.parse(results)["@context"]["bf2"]).to eq("http://id.loc.gov/ontologies/bibframe/")
+          expect(results).to include("Blue Moon / You Go To My Head")
+          expect(results).to include("Billie Holiday And Her Orchestra")
+          expect(results).to include("Haven Gillespie")
+          expect(results).to include("1952")
+          expect(results).to include("Jazz")
+          expect(results).to include("Barney Kessel")
+          expect(results).to include("Guitar")
+        end
+      end
+
+      context "json-ld format and subauthority all" do
+        let(:tc) { instance_double(Qa::TermsController) }
+        let :results do
+          authority.find("7143179", tc)
+        end
+        before do
+          allow(Qa::TermsController).to receive(:new).and_return(tc)
+          allow(tc).to receive(:params).and_return('format' => "jsonld", 'subauthority' => "all")
+        end
+
+        it "returns the Discogs data converted to json-ld for a given id" do
+          expect(JSON.parse(results).keys).to match_array ["@context", "@graph"]
+          expect(JSON.parse(results)["@context"]["bf2"]).to eq("http://id.loc.gov/ontologies/bibframe/")
+          expect(results).to include("You Go To My Head")
+          expect(results).to include("Rodgers & Hart")
+          expect(results).to include("Ray Brown")
+          expect(results).to include("1952")
+          expect(results).to include("Single")
+          expect(results).to include("mono")
+          expect(results).to include("45 RPM")
+          expect(results).to include("Vinyl")
+          expect(results).to include("http://id.loc.gov/vocabulary/carriers/sd")
+          expect(results).to include("1952")
+        end
+      end
+    end
+  end
+
+  describe "#search" do
+    context "search variations" do
+      context "with subauthority all" do
+        let(:tc) { instance_double(Qa::TermsController) }
+        let :results do
+          stub_request(:get, "https://api.discogs.com/database/search?q=melody+gardot+who+will+comfort+me+over+the+rainbo&type=all&key=dummy_key&secret=dummy_secret")
+            .to_return(status: 200, body: webmock_fixture("discogs-search-response-no-subauth.json"))
+          authority.search("melody gardot who will comfort me over the rainbo", tc)
+        end
+        before do
+          allow(Qa::TermsController).to receive(:new).and_return(tc)
+          allow(tc).to receive(:params).and_return('subauthority' => "all")
+        end
+
+        it "has id and label keys" do
+          expect(results.first["uri"]).to eq("https://api.discogs.com/releases/1750352")
+          expect(results.first["id"]).to eq "1750352"
+          expect(results.first["label"]).to eq "Melody Gardot - Who Will Comfort Me / Over The Rainbow"
+          expect(results.first["context"]["Year"]).to eq ['2009']
+          expect(results.first["context"]["Formats"][0]).to eq "Vinyl"
+          expect(results.first["context"]["Record Labels"][1]).to eq "Universal Music Classics & Jazz"
+          expect(results.first["context"]["Type"][0]).to eq "release"
+        end
+      end
+
+      context "with subauthority master" do
+        let(:tc) { instance_double(Qa::TermsController) }
+        let :results do
+          stub_request(:get, "https://api.discogs.com/database/search?q=wes+montgomery+tequila+bumpin'+on+sunse&type=master&key=dummy_key&secret=dummy_secret")
+            .to_return(status: 200, body: webmock_fixture("discogs-search-response-subauth.json"))
+          authority.search("wes montgomery tequila bumpin' on sunse", tc)
+        end
+        before do
+          allow(Qa::TermsController).to receive(:new).and_return(tc)
+          allow(tc).to receive(:params).and_return('subauthority' => "master")
+        end
+
+        it "has id and label keys" do
+          expect(results.first['uri']).to eq "https://api.discogs.com/masters/606116"
+          expect(results.first['id']).to eq "606116"
+          expect(results.first['label']).to eq "Wes Montgomery - Bumpin' On Sunset / Tequila"
+          expect(results.first['context']["Year"]).to eq ['1966']
+          expect(results.first['context']["Formats"][2]).to eq "45 RPM"
+          expect(results.first["context"]["Type"][0]).to eq "master"
+        end
+      end
+
+      context "when authentication isn't set" do
+        let(:tc) { instance_double(Qa::TermsController) }
+        let :results do
+          stub_request(:get, "https://api.discogs.com/database/search?q=wes+montgomery+tequila+bumpin'+on+sunse&type=master")
+            .to_return(status: 200, body: webmock_fixture("discogs-search-response-no-auth.json"))
+          authority.search("wes montgomery tequila bumpin' on sunse", tc)
+        end
+        before do
+          described_class.discogs_secret = nil
+          described_class.discogs_key = nil
+          allow(Qa::TermsController).to receive(:new).and_return(tc)
+          allow(tc).to receive(:params).and_return('subauthority' => "master")
+        end
+
+        it "logs an error" do
+          expect(Rails.logger).to receive(:error).with('Questioning Authority tried to call Discogs, but no secret and/or key were set.')
+          expect(results).to be_empty
+        end
+      end
+    end
+  end
+end

data/spec/lib/authorities/discogs_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe Qa::Authorities::Discogs do
+  describe "#subauthority_for" do
+    context "with an invalid sub-authority" do
+      it "raises an exception" do
+        expect { described_class.subauthority_for("foo") }.to raise_error Qa::InvalidSubAuthority
+      end
+    end
+
+    context "with a valid sub-authority" do
+      it "creates the authority" do
+        expect(described_class.subauthority_for("master")).to be_kind_of Qa::Authorities::Discogs::GenericAuthority
+      end
+    end
+  end
+end

data/spec/lib/authorities/linked_data/config_spec.rb

@@ -34,7 +34,7 @@ describe Qa::Authorities::LinkedData::Config do
           url: {
             :@context => 'http://www.w3.org/ns/hydra/context.jsonld',
             :@type => 'IriTemplate',
-            template: 'http://localhost/test_default/term/{subauth}/{term_id}?{?param1}&{?param2}',
+            template: 'http://localhost/test_default/term/{subauth}/{term_id}?{?param1}&{?param2}&{?lang}',
             variableRepresentation: 'BasicRepresentation',
             mapping: [
               {
@@ -63,15 +63,23 @@ describe Qa::Authorities::LinkedData::Config do
                 property: 'hydra:freetextQuery',
                 required: false,
                 default: 'beta'
+              },
+              {
+                :@type => 'IriTemplateMapping',
+                variable: 'lang',
+                property: 'hydra:freetextQuery',
+                required: false,
+                default: 'de'
               }
             ]
           },
           qa_replacement_patterns: {
             term_id: 'term_id',
-            subauth: 'subauth'
+            subauth: 'subauth',
+            lang: 'lang'
           },
           term_id: 'ID',
-          language: ['en'],
+          language: ['es'],
           results: {
             id_predicate: 'http://purl.org/dc/terms/identifier',
             label_predicate: 'http://www.w3.org/2004/02/skos/core#prefLabel',
@@ -90,7 +98,7 @@ describe Qa::Authorities::LinkedData::Config do
           url: {
             :@context => 'http://www.w3.org/ns/hydra/context.jsonld',
             :@type => 'IriTemplate',
-            template: 'http://localhost/test_default/search?{?subauth}&{?query}&{?param1}&{?param2}',
+            template: 'http://localhost/test_default/search?{?subauth}&{?query}&{?param1}&{?param2}&{?lang}',
             variableRepresentation: 'BasicRepresentation',
             mapping: [
               {
@@ -119,12 +127,20 @@ describe Qa::Authorities::LinkedData::Config do
                 property: 'hydra:freetextQuery',
                 required: false,
                 default: 'echo'
+              },
+              {
+                :@type => 'IriTemplateMapping',
+                variable: 'lang',
+                property: 'hydra:freetextQuery',
+                required: false,
+                default: 'fr'
               }
             ]
           },
           qa_replacement_patterns: {
             query: 'query',
-            subauth: 'subauth'
+            subauth: 'subauth',
+            lang: 'lang'
           },
           language: ['en', 'fr', 'de'],
           results: {
@@ -396,6 +412,53 @@ describe Qa::Authorities::LinkedData::Config do
     end
   end
 
+  describe '#authority_info' do
+    let(:term_details) do
+      {
+        "label" => "oclc_fast term (QA)",
+        "uri" => "urn:qa:term:oclc_fast",
+        "authority" => "oclc_fast",
+        "action" => "term",
+        "language" => ["en"]
+      }
+    end
+
+    let(:search_details) do
+      {
+        "label" => "oclc_fast search (QA)",
+        "uri" => "urn:qa:search:oclc_fast",
+        "authority" => "oclc_fast",
+        "action" => "search",
+        "language" => ["en"]
+      }
+    end
+
+    let(:search_details_with_subauth) do
+      {
+        "label" => "oclc_fast search topic (QA)",
+        "uri" => "urn:qa:search:oclc_fast:topic",
+        "authority" => "oclc_fast",
+        "subauthority" => "topic",
+        "action" => "search",
+        "language" => ["en"]
+      }
+    end
+
+    let(:details) { described_class.new(:OCLC_FAST).authority_info }
+
+    it "returns a list with details for term without subauthorities" do
+      expect(details).to include_hash(term_details)
+    end
+
+    it "returns a list with details for search without subauthorities" do
+      expect(details).to include_hash(search_details)
+    end
+
+    it "returns a list with details for search with a subauthority" do
+      expect(details).to include_hash(search_details_with_subauth)
+    end
+  end
+
   describe '#config_version' do
     context 'when version is NOT in the config file' do
       it 'returns default as 1.0' do