qa 2.0.1 → 2.1.1

data/spec/fixtures/{lexvo_snippet.rdf → lexvo_snippet.rdf.xml}

@@ -89,3 +89,4 @@ Niger–Congo family.</rdfs:comment>
   <lvont:label rdf:resource="http://lexvo.org/id/term/pms/Lenga%20Ari" /> <!-- Lenga Ari -->
   <skos:prefLabel xml:lang="en">Ari</skos:prefLabel>
 </rdf:Description>
+</rdf:RDF>

data/spec/lib/authorities/assign_fast_spec.rb

@@ -48,7 +48,9 @@ describe Qa::Authorities::AssignFast do
           .to_return(status: 200, body: "", headers: {})
       end
       it "logs an info and returns an empty array" do
-        expect(Rails.logger).to receive(:info).with("Could not parse response as JSON. Request url: http://fast.oclc.org/searchfast/fastsuggest?&query=word%20ling&queryIndex=suggestall&queryReturn=suggestall%2Cidroot%2Cauth%2Ctype&suggest=autoSubject&rows=20")
+        msg = "Could not parse response as JSON. Request url: " \
+              "http://fast.oclc.org/searchfast/fastsuggest?&query=word%20ling&queryIndex=suggestall&queryReturn=suggestall%2Cidroot%2Cauth%2Ctype&suggest=autoSubject&rows=20"
+        expect(Rails.logger).to receive(:info).with(msg)
         results = authority.search("word (ling")
         expect(results).to eq([])
       end

data/spec/lib/authorities/file_based_authority_spec.rb

@@ -7,24 +7,30 @@ describe Qa::Authorities::Local::FileBasedAuthority do
   let(:authority_d) { Qa::Authorities::Local.subauthority_for("authority_D") }
 
   describe "#all" do
-    let(:expected) { [{ 'id' => "A1", 'label' => "Abc Term A1", 'active' => true },
-                      { 'id' => "A2", 'label' => "Term A2", 'active' => false },
-                      { 'id' => "A3", 'label' => "Abc Term A3", 'active' => true }] }
+    let(:expected) do
+      [{ 'id' => "A1", 'label' => "Abc Term A1", 'active' => true },
+       { 'id' => "A2", 'label' => "Term A2", 'active' => false },
+       { 'id' => "A3", 'label' => "Abc Term A3", 'active' => true }]
+    end
     it "returns all the entries" do
       expect(authority_a.all).to eq(expected)
     end
     context "when terms do not have ids" do
-      let(:expected) { [{ 'id' => "Term B1", 'label' => "Term B1", 'active' => true },
-                        { 'id' => "Term B2", 'label' => "Term B2", 'active' => true },
-                        { 'id' => "Term B3", 'label' => "Term B3", 'active' => true }] }
+      let(:expected) do
+        [{ 'id' => "Term B1", 'label' => "Term B1", 'active' => true },
+         { 'id' => "Term B2", 'label' => "Term B2", 'active' => true },
+         { 'id' => "Term B3", 'label' => "Term B3", 'active' => true }]
+      end
       it "sets the id to be same as the label" do
         expect(authority_b.all).to eq(expected)
       end
     end
     context "authority YAML file is a list of terms" do
-      let(:expected) { [{ 'id' => "Term C1", 'label' => "Term C1", 'active' => true },
-                        { 'id' => "Term C2", 'label' => "Term C2", 'active' => true },
-                        { 'id' => "Term C3", 'label' => "Term C3", 'active' => true }] }
+      let(:expected) do
+        [{ 'id' => "Term C1", 'label' => "Term C1", 'active' => true },
+         { 'id' => "Term C2", 'label' => "Term C2", 'active' => true },
+         { 'id' => "Term C3", 'label' => "Term C3", 'active' => true }]
+      end
       it "uses the terms as labels" do
         expect(authority_c.all).to eq(expected)
       end
@@ -44,8 +50,10 @@ describe Qa::Authorities::Local::FileBasedAuthority do
       end
     end
     context "with at least one matching entry" do
-      let(:expected) { [{ 'id' => "A1", 'label' => "Abc Term A1" },
-                        { 'id' => "A3", 'label' => "Abc Term A3" }] }
+      let(:expected) do
+        [{ 'id' => "A1", 'label' => "Abc Term A1" },
+         { 'id' => "A3", 'label' => "Abc Term A3" }]
+      end
       it "returns only entries matching the query term" do
         expect(authority_a.search("Abc")).to eq(expected)
       end

data/spec/lib/authorities/geonames_spec.rb

@@ -37,12 +37,12 @@ describe Qa::Authorities::Geonames do
       end
 
       context "with custom label" do
+        let!(:original_label) { described_class.label }
         before do
-          @original_label = described_class.label
-          described_class.label = -> (item) { item['name'] }
+          described_class.label = ->(item) { item['name'] }
         end
         after do
-          described_class.label = @original_label
+          described_class.label = original_label
         end
         it "uses the lambda" do
           expect(subject.first['label']).to eq("Port Moresby")

data/spec/lib/authorities/getty/aat_spec.rb

@@ -68,7 +68,8 @@ describe Qa::Authorities::Getty::AAT do
 
   describe "#sparql" do
     subject { authority.sparql('search_term') }
-    it { is_expected.to eq 'SELECT ?s ?name {
+    it {
+      is_expected.to eq 'SELECT ?s ?name {
               ?s a skos:Concept; luc:term "search_term";
                  skos:inScheme <http://vocab.getty.edu/aat/> ;
                  gvp:prefLabelGVP [skosxl:literalForm ?name].

data/spec/lib/authorities/getty/tgn_spec.rb

@@ -69,7 +69,8 @@ describe Qa::Authorities::Getty::TGN do
   describe "#sparql" do
     context "using a single subject term" do
       subject { authority.sparql('search_term') }
-      it { is_expected.to eq 'SELECT DISTINCT ?s ?name ?par {
+      it {
+        is_expected.to eq 'SELECT DISTINCT ?s ?name ?par {
               ?s a skos:Concept; luc:term "search_term";
                  skos:inScheme <http://vocab.getty.edu/tgn/> ;
                  gvp:prefLabelGVP [skosxl:literalForm ?name] ;
@@ -79,13 +80,16 @@ describe Qa::Authorities::Getty::TGN do
     end
     context "using a two subject terms" do
       subject { authority.sparql('search term') }
-      it { is_expected.to eq "SELECT DISTINCT ?s ?name ?par {
+      # rubocop:disable Metrics/LineLength
+      it {
+        is_expected.to eq "SELECT DISTINCT ?s ?name ?par {
               ?s a skos:Concept; luc:term \"search term\";
                  skos:inScheme <http://vocab.getty.edu/tgn/> ;
                  gvp:prefLabelGVP [skosxl:literalForm ?name] ;
                   gvp:parentString ?par .
               FILTER ((regex(CONCAT(?name, ', ', REPLACE(str(?par), \",[^,]+,[^,]+$\", \"\")), \"search\",\"i\" ) && regex(CONCAT(?name, ', ', REPLACE(str(?par), \",[^,]+,[^,]+$\", \"\")), \"term\",\"i\" ) ) && (regex(?name, \"search\",\"i\" ) || regex(?name, \"term\",\"i\" ) ) ) .
             } ORDER BY ?name ASC(?par)" }
+      # rubocop:enable Metrics/LineLength
     end
   end
 end

data/spec/lib/authorities/getty/ulan_spec.rb

@@ -69,7 +69,8 @@ describe Qa::Authorities::Getty::Ulan do
   describe "#sparql" do
     context "using a single subject term" do
       subject { authority.sparql('search_term') }
-      it { is_expected.to eq 'SELECT DISTINCT ?s ?name ?bio {
+      it {
+        is_expected.to eq 'SELECT DISTINCT ?s ?name ?bio {
               ?s a skos:Concept; luc:term "search_term";
                  skos:inScheme <http://vocab.getty.edu/ulan/> ;
                  gvp:prefLabelGVP [skosxl:literalForm ?name] ;
@@ -80,7 +81,8 @@ describe Qa::Authorities::Getty::Ulan do
     end
     context "using a two subject terms" do
       subject { authority.sparql('search term') }
-      it { is_expected.to eq "SELECT DISTINCT ?s ?name ?bio {
+      it {
+        is_expected.to eq "SELECT DISTINCT ?s ?name ?bio {
               ?s a skos:Concept; luc:term \"search term\";
                  skos:inScheme <http://vocab.getty.edu/ulan/> ;
                  gvp:prefLabelGVP [skosxl:literalForm ?name] ;

data/spec/lib/authorities/getty_spec.rb

@@ -3,7 +3,8 @@ require 'spec_helper'
 describe Qa::Authorities::Getty do
   describe "#new" do
     it "raises an exception" do
-      expect { described_class.new }.to raise_error RuntimeError, "Initializing with as sub authority is removed. use Module.subauthority_for(nil) instead"
+      msg = "Initializing with as sub authority is removed. use Module.subauthority_for(nil) instead"
+      expect { described_class.new }.to raise_error RuntimeError, msg
     end
   end
 

data/spec/lib/authorities/linked_data/generic_authority_spec.rb

@@ -93,6 +93,7 @@ RSpec.describe Qa::Authorities::LinkedData::GenericAuthority do
     #   # let(:lod_loc) { Qa::Authorities::LinkedData::GenericAuthority.new(:LOC) }
     # end
 
+    # rubocop:disable RSpec/NestedGroups
     describe "language processing" do
       context "when filtering #search results" do
         context "and lang NOT passed in" do
@@ -184,6 +185,7 @@ RSpec.describe Qa::Authorities::LinkedData::GenericAuthority do
         end
       end
     end
+    # rubocop:enable RSpec/NestedGroups
   end
 
   describe '#find' do
@@ -195,7 +197,7 @@ RSpec.describe Qa::Authorities::LinkedData::GenericAuthority do
       context 'with bad id' do
         before do
           stub_request(:get, 'http://id.worldcat.org/fast/FAKE_ID')
-            .to_return(status: 404, body: '', headers:  {})
+            .to_return(status: 404, body: '', headers: {})
         end
         it 'raises a TermNotFound exception' do
           expect { lod_oclc.find('FAKE_ID') }.to raise_error Qa::TermNotFound, /.*\/FAKE_ID\ Not Found - Term may not exist at LOD Authority./
@@ -256,14 +258,19 @@ RSpec.describe Qa::Authorities::LinkedData::GenericAuthority do
         it 'has primary predicates in pred-obj list' do
           expect(results['predicates']['http://purl.org/dc/terms/identifier']).to eq ['530369']
           expect(results['predicates']['http://www.w3.org/2004/02/skos/core#prefLabel']).to eq ['Cornell University']
-          expect(results['predicates']['http://www.w3.org/2004/02/skos/core#altLabel']).to include('Ithaca (N.Y.). Cornell University', "Kornel\\xCA\\xB9skii universitet", "K\\xCA\\xBBang-nai-erh ta hs\\xC3\\xBCeh")
+          expect(results['predicates']['http://www.w3.org/2004/02/skos/core#altLabel'])
+            .to include('Ithaca (N.Y.). Cornell University', "Kornel\\xCA\\xB9skii universitet",
+                        "K\\xCA\\xBBang-nai-erh ta hs\\xC3\\xBCeh")
           expect(results['predicates']['http://schema.org/sameAs']).to include('http://id.loc.gov/authorities/names/n79021621', 'https://viaf.org/viaf/126293486')
         end
 
         it 'has unspecified predicate values' do
           expect(results['predicates']['http://www.w3.org/1999/02/22-rdf-syntax-ns#type']).to eq ['http://schema.org/Organization']
-          expect(results['predicates']['http://www.w3.org/2004/02/skos/core#inScheme']).to include('http://id.worldcat.org/fast/ontology/1.0/#fast', 'http://id.worldcat.org/fast/ontology/1.0/#facet-Corporate')
-          expect(results['predicates']['http://schema.org/name']).to include('Cornell University', 'Ithaca (N.Y.). Cornell University', "Kornel\\xCA\\xB9skii universitet", "K\\xCA\\xBBang-nai-erh ta hs\\xC3\\xBCeh")
+          expect(results['predicates']['http://www.w3.org/2004/02/skos/core#inScheme'])
+            .to include('http://id.worldcat.org/fast/ontology/1.0/#fast', 'http://id.worldcat.org/fast/ontology/1.0/#facet-Corporate')
+          expect(results['predicates']['http://schema.org/name'])
+            .to include('Cornell University', 'Ithaca (N.Y.). Cornell University', "Kornel\\xCA\\xB9skii universitet",
+                        "K\\xCA\\xBBang-nai-erh ta hs\\xC3\\xBCeh")
         end
       end
     end
@@ -290,11 +297,24 @@ RSpec.describe Qa::Authorities::LinkedData::GenericAuthority do
         it 'has primary predicates in pred-obj list' do
           expect(results['predicates']['http://www.w3.org/2004/02/skos/core#prefLabel']).to eq ['buttermilk']
           expect(results['predicates']['http://www.w3.org/2004/02/skos/core#broader']).to eq ['http://aims.fao.org/aos/agrovoc/c_4830']
-          expect(results['predicates']['http://www.w3.org/2004/02/skos/core#exactMatch']).to include('http://cat.aii.caas.cn/concept/c_26308', 'http://lod.nal.usda.gov/nalt/20627', 'http://d-nb.info/gnd/4147072-2')
+          expect(results['predicates']['http://www.w3.org/2004/02/skos/core#exactMatch'])
+            .to include('http://cat.aii.caas.cn/concept/c_26308', 'http://lod.nal.usda.gov/nalt/20627',
+                        'http://d-nb.info/gnd/4147072-2')
         end
 
         it 'has skos predicate values' do
-          expect(results['predicates']['http://www.w3.org/2008/05/skos-xl#prefLabel']).to include('http://aims.fao.org/aos/agrovoc/xl_es_1299487482038', 'http://aims.fao.org/aos/agrovoc/xl_it_1299487482154', 'http://aims.fao.org/aos/agrovoc/xl_ko_1299487482210', 'http://aims.fao.org/aos/agrovoc/xl_pl_1299487482273', 'http://aims.fao.org/aos/agrovoc/xl_sk_1299487482378', 'http://aims.fao.org/aos/agrovoc/xl_en_1299487482019', 'http://aims.fao.org/aos/agrovoc/xl_tr_9513_1321792194941', 'http://aims.fao.org/aos/agrovoc/xl_de_1299487482000', 'http://aims.fao.org/aos/agrovoc/xl_fa_1299487482058', 'http://aims.fao.org/aos/agrovoc/xl_th_1299487482417', 'http://aims.fao.org/aos/agrovoc/xl_fr_1299487482080', 'http://aims.fao.org/aos/agrovoc/xl_hi_1299487482102', 'http://aims.fao.org/aos/agrovoc/xl_ar_1299487481966', 'http://aims.fao.org/aos/agrovoc/xl_ja_1299487482181', 'http://aims.fao.org/aos/agrovoc/xl_lo_1299487482240', 'http://aims.fao.org/aos/agrovoc/xl_ru_1299487482341', 'http://aims.fao.org/aos/agrovoc/xl_cs_1299487481982', 'http://aims.fao.org/aos/agrovoc/xl_zh_1299487482458', 'http://aims.fao.org/aos/agrovoc/xl_pt_1299487482307', 'http://aims.fao.org/aos/agrovoc/xl_hu_1299487482127')
+          expect(results['predicates']['http://www.w3.org/2008/05/skos-xl#prefLabel'])
+            .to include('http://aims.fao.org/aos/agrovoc/xl_es_1299487482038', 'http://aims.fao.org/aos/agrovoc/xl_it_1299487482154',
+                        'http://aims.fao.org/aos/agrovoc/xl_ko_1299487482210', 'http://aims.fao.org/aos/agrovoc/xl_pl_1299487482273',
+                        'http://aims.fao.org/aos/agrovoc/xl_sk_1299487482378', 'http://aims.fao.org/aos/agrovoc/xl_en_1299487482019',
+                        'http://aims.fao.org/aos/agrovoc/xl_tr_9513_1321792194941',
+                        'http://aims.fao.org/aos/agrovoc/xl_de_1299487482000', 'http://aims.fao.org/aos/agrovoc/xl_fa_1299487482058',
+                        'http://aims.fao.org/aos/agrovoc/xl_th_1299487482417', 'http://aims.fao.org/aos/agrovoc/xl_fr_1299487482080',
+                        'http://aims.fao.org/aos/agrovoc/xl_hi_1299487482102', 'http://aims.fao.org/aos/agrovoc/xl_ar_1299487481966',
+                        'http://aims.fao.org/aos/agrovoc/xl_ja_1299487482181', 'http://aims.fao.org/aos/agrovoc/xl_lo_1299487482240',
+                        'http://aims.fao.org/aos/agrovoc/xl_ru_1299487482341', 'http://aims.fao.org/aos/agrovoc/xl_cs_1299487481982',
+                        'http://aims.fao.org/aos/agrovoc/xl_zh_1299487482458', 'http://aims.fao.org/aos/agrovoc/xl_pt_1299487482307',
+                        'http://aims.fao.org/aos/agrovoc/xl_hu_1299487482127')
           expect(results['predicates']['http://www.w3.org/2004/02/skos/core#inScheme']).to eq ['http://aims.fao.org/aos/agrovoc']
           expect(results['predicates']['http://www.w3.org/2004/02/skos/core#closeMatch']).to eq ['http://dbpedia.org/resource/Buttermilk']
           expect(results['predicates']['http://www.w3.org/2008/05/skos-xl#altLabel']).to eq ['http://aims.fao.org/aos/agrovoc/xl_fa_1299487482544']
@@ -337,22 +357,43 @@ RSpec.describe Qa::Authorities::LinkedData::GenericAuthority do
 
         it 'has loc mads predicate values' do
           expect(results['predicates']['http://www.loc.gov/mads/rdf/v1#classification']).to eq ['Q']
-          expect(results['predicates']['http://www.loc.gov/mads/rdf/v1#isMemberOfMADSCollection']).to include('http://id.loc.gov/authorities/subjects/collection_LCSHAuthorizedHeadings', 'http://id.loc.gov/authorities/subjects/collection_LCSH_General', 'http://id.loc.gov/authorities/subjects/collection_SubdivideGeographically')
-          expect(results['predicates']['http://www.loc.gov/mads/rdf/v1#hasCloseExternalAuthority']).to include('http://data.bnf.fr/ark:/12148/cb12321484k', 'http://data.bnf.fr/ark:/12148/cb119673416', 'http://data.bnf.fr/ark:/12148/cb119934236', 'http://data.bnf.fr/ark:/12148/cb12062047t', 'http://data.bnf.fr/ark:/12148/cb119469567', 'http://data.bnf.fr/ark:/12148/cb11933232c', 'http://data.bnf.fr/ark:/12148/cb122890536', 'http://data.bnf.fr/ark:/12148/cb121155321', 'http://data.bnf.fr/ark:/12148/cb15556043g', 'http://data.bnf.fr/ark:/12148/cb123662513', 'http://d-nb.info/gnd/4066562-8', 'http://data.bnf.fr/ark:/12148/cb120745812', 'http://data.bnf.fr/ark:/12148/cb11973101n', 'http://data.bnf.fr/ark:/12148/cb13328497r')
-          expect(results['predicates']['http://www.loc.gov/mads/rdf/v1#isMemberOfMADSScheme']).to eq ['http://id.loc.gov/authorities/subjects']
-          expect(results['predicates']['http://www.loc.gov/mads/rdf/v1#editorialNote']).to eq ['headings beginning with the word [Scientific;] and subdivision [Science] under ethnic groups and individual wars, e.g. [World War, 1939-1945--Science]']
+          expect(results['predicates']['http://www.loc.gov/mads/rdf/v1#isMemberOfMADSCollection'])
+            .to include('http://id.loc.gov/authorities/subjects/collection_LCSHAuthorizedHeadings',
+                        'http://id.loc.gov/authorities/subjects/collection_LCSH_General',
+                        'http://id.loc.gov/authorities/subjects/collection_SubdivideGeographically')
+          expect(results['predicates']['http://www.loc.gov/mads/rdf/v1#hasCloseExternalAuthority'])
+            .to include('http://data.bnf.fr/ark:/12148/cb12321484k', 'http://data.bnf.fr/ark:/12148/cb119673416',
+                        'http://data.bnf.fr/ark:/12148/cb119934236', 'http://data.bnf.fr/ark:/12148/cb12062047t',
+                        'http://data.bnf.fr/ark:/12148/cb119469567', 'http://data.bnf.fr/ark:/12148/cb11933232c',
+                        'http://data.bnf.fr/ark:/12148/cb122890536', 'http://data.bnf.fr/ark:/12148/cb121155321',
+                        'http://data.bnf.fr/ark:/12148/cb15556043g', 'http://data.bnf.fr/ark:/12148/cb123662513',
+                        'http://d-nb.info/gnd/4066562-8', 'http://data.bnf.fr/ark:/12148/cb120745812',
+                        'http://data.bnf.fr/ark:/12148/cb11973101n', 'http://data.bnf.fr/ark:/12148/cb13328497r')
+          expect(results['predicates']['http://www.loc.gov/mads/rdf/v1#isMemberOfMADSScheme'])
+            .to eq ['http://id.loc.gov/authorities/subjects']
+          expect(results['predicates']['http://www.loc.gov/mads/rdf/v1#editorialNote'])
+            .to eq ['headings beginning with the word [Scientific;] and subdivision [Science] under ethnic groups and individual wars, e.g. [World War, 1939-1945--Science]']
         end
 
         it 'has more unspecified predicate values' do
           expect(results['predicates']['http://www.w3.org/1999/02/22-rdf-syntax-ns#type']).to include('http://www.loc.gov/mads/rdf/v1#Topic', 'http://www.loc.gov/mads/rdf/v1#Authority', 'http://www.w3.org/2004/02/skos/core#Concept')
           expect(results['predicates']['http://www.w3.org/2002/07/owl#sameAs']).to include('info:lc/authorities/sh85118553', 'http://id.loc.gov/authorities/sh85118553#concept')
-          expect(results['predicates']['http://www.w3.org/2004/02/skos/core#closeMatch']).to include('http://data.bnf.fr/ark:/12148/cb12321484k', 'http://data.bnf.fr/ark:/12148/cb119673416', 'http://data.bnf.fr/ark:/12148/cb119934236', 'http://data.bnf.fr/ark:/12148/cb12062047t', 'http://data.bnf.fr/ark:/12148/cb119469567', 'http://data.bnf.fr/ark:/12148/cb11933232c', 'http://data.bnf.fr/ark:/12148/cb122890536', 'http://data.bnf.fr/ark:/12148/cb121155321', 'http://data.bnf.fr/ark:/12148/cb15556043g', 'http://data.bnf.fr/ark:/12148/cb123662513', 'http://d-nb.info/gnd/4066562-8', 'http://data.bnf.fr/ark:/12148/cb120745812', 'http://data.bnf.fr/ark:/12148/cb11973101n', 'http://data.bnf.fr/ark:/12148/cb13328497r')
-          expect(results['predicates']['http://www.w3.org/2004/02/skos/core#editorial']).to eq ['headings beginning with the word [Scientific;] and subdivision [Science] under ethnic groups and individual wars, e.g. [World War, 1939-1945--Science]']
+          expect(results['predicates']['http://www.w3.org/2004/02/skos/core#closeMatch'])
+            .to include('http://data.bnf.fr/ark:/12148/cb12321484k', 'http://data.bnf.fr/ark:/12148/cb119673416',
+                        'http://data.bnf.fr/ark:/12148/cb119934236', 'http://data.bnf.fr/ark:/12148/cb12062047t',
+                        'http://data.bnf.fr/ark:/12148/cb119469567', 'http://data.bnf.fr/ark:/12148/cb11933232c',
+                        'http://data.bnf.fr/ark:/12148/cb122890536', 'http://data.bnf.fr/ark:/12148/cb121155321',
+                        'http://data.bnf.fr/ark:/12148/cb15556043g', 'http://data.bnf.fr/ark:/12148/cb123662513',
+                        'http://d-nb.info/gnd/4066562-8', 'http://data.bnf.fr/ark:/12148/cb120745812',
+                        'http://data.bnf.fr/ark:/12148/cb11973101n', 'http://data.bnf.fr/ark:/12148/cb13328497r')
+          expect(results['predicates']['http://www.w3.org/2004/02/skos/core#editorial'])
+            .to eq ['headings beginning with the word [Scientific;] and subdivision [Science] under ethnic groups and individual wars, e.g. [World War, 1939-1945--Science]']
           expect(results['predicates']['http://www.w3.org/2004/02/skos/core#inScheme']).to eq ['http://id.loc.gov/authorities/subjects']
         end
       end
     end
 
+    # rubocop:disable RSpec/NestedGroups
     describe "language processing" do
       context "when filtering #find result" do
         context "and lang NOT passed in" do
@@ -461,6 +502,7 @@ RSpec.describe Qa::Authorities::LinkedData::GenericAuthority do
         end
       end
     end
+    # rubocop:enable RSpec/NestedGroups
   end
 
   describe '#new' do

data/spec/lib/authorities/linked_data/search_config_spec.rb

@@ -336,29 +336,32 @@ RSpec.describe Qa::Authorities::LinkedData::SearchConfig do
     end
   end
 
+  # rubocop:disable RSpec/RepeatedExample
   describe '#search_url_with_replacements' do
     it 'returns nil if only term configuration is defined' do
       expect(term_only_config.url_with_replacements('Smith')).to eq nil
     end
-    it 'returns the url with query substitution applied' do
-      expected_url = 'http://localhost/test_default/search?subauth=search_sub1_name&query=Smith&param1=delta&param2=echo'
-      expect(full_config.url_with_replacements('Smith')).to eq expected_url
-    end
-    it 'returns the url with default subauthority when NOT specified' do
-      expected_url = 'http://localhost/test_default/search?subauth=search_sub1_name&query=Smith&param1=delta&param2=echo'
-      expect(full_config.url_with_replacements('Smith')).to eq expected_url
-    end
-    it 'returns the url with subauthority substitution when specified' do
-      expected_url = 'http://localhost/test_default/search?subauth=search_sub3_name&query=Smith&param1=delta&param2=echo'
-      expect(full_config.url_with_replacements('Smith', 'search_sub3_key')).to eq expected_url
-    end
-    it 'returns the url with default values when replacements are NOT specified' do
-      expected_url = 'http://localhost/test_default/search?subauth=search_sub1_name&query=Smith&param1=delta&param2=echo'
-      expect(full_config.url_with_replacements('Smith')).to eq expected_url
-    end
-    it 'returns the url with replacement substitution values when replacements are specified' do
-      expected_url = 'http://localhost/test_default/search?subauth=search_sub1_name&query=Smith&param1=golf&param2=hotel'
-      expect(full_config.url_with_replacements('Smith', nil, param1: 'golf', param2: 'hotel')).to eq expected_url
+    context 'when subauthorities ARE defined' do
+      it 'returns the url with query substitution applied' do
+        expected_url = 'http://localhost/test_default/search?subauth=search_sub1_name&query=Smith&param1=delta&param2=echo'
+        expect(full_config.url_with_replacements('Smith')).to eq expected_url
+      end
+      it 'returns the url with default subauthority when NOT specified' do
+        expected_url = 'http://localhost/test_default/search?subauth=search_sub1_name&query=Smith&param1=delta&param2=echo'
+        expect(full_config.url_with_replacements('Smith')).to eq expected_url
+      end
+      it 'returns the url with subauthority substitution when specified' do
+        expected_url = 'http://localhost/test_default/search?subauth=search_sub3_name&query=Smith&param1=delta&param2=echo'
+        expect(full_config.url_with_replacements('Smith', 'search_sub3_key')).to eq expected_url
+      end
+      it 'returns the url with default values when replacements are NOT specified' do
+        expected_url = 'http://localhost/test_default/search?subauth=search_sub1_name&query=Smith&param1=delta&param2=echo'
+        expect(full_config.url_with_replacements('Smith')).to eq expected_url
+      end
+      it 'returns the url with replacement substitution values when replacements are specified' do
+        expected_url = 'http://localhost/test_default/search?subauth=search_sub1_name&query=Smith&param1=golf&param2=hotel'
+        expect(full_config.url_with_replacements('Smith', nil, param1: 'golf', param2: 'hotel')).to eq expected_url
+      end
     end
 
     context 'when subauthorities are not defined' do
@@ -392,4 +395,5 @@ RSpec.describe Qa::Authorities::LinkedData::SearchConfig do
       end
     end
   end
+  # rubocop:enable RSpec/RepeatedExample
 end

data/spec/lib/authorities/linked_data/search_query_spec.rb

@@ -14,7 +14,9 @@ RSpec.describe Qa::Authorities::LinkedData::SearchQuery do
       let(:auth_name) { :LOD_MIN_CONFIG }
 
       it "does not change order" do
-        json_results = [{ label: "[#{term_b}, #{term_c}]", sort: [term_b, term_c] }, { label: "[#{term_b}, #{term_d}]", sort: [term_b, term_d] }, { label: "[#{term_b}, #{term_a}]", sort: [term_b, term_a] }]
+        json_results = [{ label: "[#{term_b}, #{term_c}]", sort: [term_b, term_c] },
+                        { label: "[#{term_b}, #{term_d}]", sort: [term_b, term_d] },
+                        { label: "[#{term_b}, #{term_a}]", sort: [term_b, term_a] }]
         expect(instance.send(:sort_search_results, json_results)).to eq json_results
       end
     end
@@ -22,28 +24,58 @@ RSpec.describe Qa::Authorities::LinkedData::SearchQuery do
     context 'when sort predicate is specified in configuration' do
       let(:auth_name) { :LOD_SORT }
 
-      context "when sort term is empty" do
+      context "and sort term is empty" do
         context "for all" do
           it "does not change order" do
-            json_results = [{ label: "[#{term_b}]", sort: [""] }, { label: "[#{term_a}]", sort: [""] }, { label: "[#{term_c}]", sort: [""] }]
+            json_results = [{ label: "[#{term_b}]", sort: [""] },
+                            { label: "[#{term_a}]", sort: [""] },
+                            { label: "[#{term_c}]", sort: [""] }]
             expect(instance.send(:sort_search_results, json_results)).to eq json_results
           end
         end
 
         context "for one" do
-          it "puts empty first" do
-            json_results = [{ label: "[#{term_b}]", sort: [""] }, { label: "[#{term_c}]", sort: [term_c] }, { label: "[#{term_a}]", sort: [term_a] }]
-            expected_results = [{ label: "[#{term_b}]" }, { label: "[#{term_a}]" }, { label: "[#{term_c}]" }]
+          it "puts empty first when empty is in 1st position" do
+            json_results = [{ label: "['_empty_1_']", sort: [""] },
+                            { label: "[#{term_c}]", sort: [term_c] },
+                            { label: "[#{term_a}]", sort: [term_a] }]
+            expected_results = [{ label: "['_empty_1_']" },
+                                { label: "[#{term_a}]" },
+                                { label: "[#{term_c}]" }]
+            expect(instance.send(:sort_search_results, json_results)).to eq expected_results
+          end
+
+          it "puts empty first when empty is in 2nd position" do
+            json_results = [{ label: "[#{term_b}]", sort: [term_b] },
+                            { label: "['_empty_2_']", sort: [""] },
+                            { label: "[#{term_a}]", sort: [term_a] }]
+            expected_results = [{ label: "['_empty_2_']" },
+                                { label: "[#{term_a}]" },
+                                { label: "[#{term_b}]" }]
+            expect(instance.send(:sort_search_results, json_results)).to eq expected_results
+          end
+
+          it "puts empty first when empty is in last position" do
+            json_results = [{ label: "[#{term_b}]", sort: [term_b] },
+                            { label: "[#{term_c}]", sort: [term_c] },
+                            { label: "['_empty_last_']", sort: [""] }]
+            expected_results = [{ label: "['_empty_last_']" },
+                                { label: "[#{term_b}]" },
+                                { label: "[#{term_c}]" }]
             expect(instance.send(:sort_search_results, json_results)).to eq expected_results
           end
         end
       end
 
-      context "when sort term is single value" do
+      context "and sort term is single value" do
         context "for all" do
           it "sorts on the single value" do
-            json_results = [{ label: "[#{term_b}]", sort: [term_b] }, { label: "[#{term_c}]", sort: [term_c] }, { label: "[#{term_a}]", sort: [term_a] }]
-            expected_results = [{ label: "[#{term_a}]" }, { label: "[#{term_b}]" }, { label: "[#{term_c}]" }]
+            json_results = [{ label: "[#{term_b}]", sort: [term_b] },
+                            { label: "[#{term_c}]", sort: [term_c] },
+                            { label: "[#{term_a}]", sort: [term_a] }]
+            expected_results = [{ label: "[#{term_a}]" },
+                                { label: "[#{term_b}]" },
+                                { label: "[#{term_c}]" }]
             expect(instance.send(:sort_search_results, json_results)).to eq expected_results
           end
         end
@@ -51,8 +83,12 @@ RSpec.describe Qa::Authorities::LinkedData::SearchQuery do
 
       context "when first sort term is same" do
         it "sorts on second sort term" do
-          json_results = [{ label: "[#{term_b}, #{term_c}]", sort: [term_b, term_c] }, { label: "[#{term_b}, #{term_d}]", sort: [term_b, term_d] }, { label: "[#{term_b}, #{term_a}]", sort: [term_b, term_a] }]
-          expected_results = [{ label: "[#{term_b}, #{term_a}]" }, { label: "[#{term_b}, #{term_c}]" }, { label: "[#{term_b}, #{term_d}]" }]
+          json_results = [{ label: "[#{term_b}, #{term_c}]", sort: [term_b, term_c] },
+                          { label: "[#{term_b}, #{term_d}]", sort: [term_b, term_d] },
+                          { label: "[#{term_b}, #{term_a}]", sort: [term_b, term_a] }]
+          expected_results = [{ label: "[#{term_b}, #{term_a}]" },
+                              { label: "[#{term_b}, #{term_c}]" },
+                              { label: "[#{term_b}, #{term_d}]" }]
           expect(instance.send(:sort_search_results, json_results)).to eq expected_results
         end
       end
@@ -60,20 +96,36 @@ RSpec.describe Qa::Authorities::LinkedData::SearchQuery do
       context "when different number of sort terms" do
         context "and initial terms match" do
           it "puts shorter set of terms before longer set" do
-            json_results = [{ label: "[#{term_b}, #{term_c}]", sort: [term_b, term_c] }, { label: "[#{term_b}]", sort: [term_b] }, { label: "[#{term_b}, #{term_a}]", sort: [term_b, term_a] }]
-            expected_results = [{ label: "[#{term_b}]" }, { label: "[#{term_b}, #{term_a}]" }, { label: "[#{term_b}, #{term_c}]" }]
+            json_results = [{ label: "[#{term_b}, #{term_c}]", sort: [term_b, term_c] },
+                            { label: "[#{term_b}]", sort: [term_b] },
+                            { label: "[#{term_b}, #{term_a}]", sort: [term_b, term_a] }]
+            expected_results = [{ label: "[#{term_b}]" },
+                                { label: "[#{term_b}, #{term_a}]" },
+                                { label: "[#{term_b}, #{term_c}]" }]
             expect(instance.send(:sort_search_results, json_results)).to eq expected_results
           end
         end
 
         context "and a difference happens before end of term sets" do
           it "stops ordering as soon as a difference is found" do
-            json_results = [{ label: "[#{term_b}, #{term_d}, #{term_c}]", sort: [term_b, term_d, term_c] }, { label: "[#{term_a}, #{term_c}]", sort: [term_a, term_c] }, { label: "[#{term_b}, #{term_d}, #{term_a}]", sort: [term_b, term_d, term_a] }]
-            expected_results = [{ label: "[#{term_a}, #{term_c}]" }, { label: "[#{term_b}, #{term_d}, #{term_a}]" }, { label: "[#{term_b}, #{term_d}, #{term_c}]" }]
+            json_results = [{ label: "[#{term_b}, #{term_d}, #{term_c}]", sort: [term_b, term_d, term_c] },
+                            { label: "[#{term_a}, #{term_c}]", sort: [term_a, term_c] },
+                            { label: "[#{term_b}, #{term_d}, #{term_a}]", sort: [term_b, term_d, term_a] }]
+            expected_results = [{ label: "[#{term_a}, #{term_c}]" },
+                                { label: "[#{term_b}, #{term_d}, #{term_a}]" },
+                                { label: "[#{term_b}, #{term_d}, #{term_c}]" }]
             expect(instance.send(:sort_search_results, json_results)).to eq expected_results
           end
         end
       end
+
+      context "and sort values are numeric" do
+        it "does numeric compare" do
+          json_results = [{ label: "['22']", sort: ["22"] }, { label: "['1']", sort: ["1"] }, { label: "['215']", sort: ["215"] }]
+          expected_results = [{ label: "['1']" }, { label: "['22']" }, { label: "['215']" }]
+          expect(instance.send(:sort_search_results, json_results)).to eq expected_results
+        end
+      end
     end
   end
 end