qa 2.0.0 → 2.3.0

data/spec/lib/authorities/loc_spec.rb

@@ -28,14 +28,14 @@ describe Qa::Authorities::Loc do
     end
 
     context "for searching" do
-      let(:url) { 'http://id.loc.gov/search/?q=foo&q=cs%3Ahttp%3A%2F%2Fid.loc.gov%2Fauthorities%2Fsubjects&format=json' }
+      let(:url) { 'https://id.loc.gov/search/?q=foo&q=cs%3Ahttp%3A%2F%2Fid.loc.gov%2Fauthorities%2Fsubjects&format=json' }
       it "returns a url" do
         expect(authority.build_query_url("foo")).to eq(url)
       end
     end
 
     context "for returning single terms" do
-      let(:url) { "http://id.loc.gov/authorities/subjects/sh2002003586.json" }
+      let(:url) { "https://id.loc.gov/authorities/subjects/sh2002003586.json" }
       it "returns a url with an authority and id" do
         expect(authority.find_url("sh2002003586")).to eq(url)
       end
@@ -49,15 +49,15 @@ describe Qa::Authorities::Loc do
     end
 
     before do
-      stub_request(:get, "http://id.loc.gov/search/?format=json&q=cs:http://id.loc.gov/authorities/subjects")
+      stub_request(:get, "https://id.loc.gov/search/?format=json&q=cs:http://id.loc.gov/authorities/subjects")
         .with(headers: { 'Accept' => 'application/json' })
         .to_return(status: 200, body: "")
     end
 
     context "with flat params encoded" do
-      let(:url) { 'http://id.loc.gov/search/?q=foo&q=cs%3Ahttp%3A%2F%2Fid.loc.gov%2Fauthorities%2Fsubjects&format=json' }
+      let(:url) { 'https://id.loc.gov/search/?q=foo&q=cs%3Ahttp%3A%2F%2Fid.loc.gov%2Fauthorities%2Fsubjects&format=json' }
       it "returns a response" do
-        flat_params_url = "http://id.loc.gov/search/?format=json&q=foo&q=cs%3Ahttp%3A%2F%2Fid.loc.gov%2Fauthorities%2Fsubjects"
+        flat_params_url = "https://id.loc.gov/search/?format=json&q=foo&q=cs%3Ahttp%3A%2F%2Fid.loc.gov%2Fauthorities%2Fsubjects"
         expect(subject.env.url.to_s).to eq(flat_params_url)
       end
     end
@@ -66,7 +66,7 @@ describe Qa::Authorities::Loc do
   describe "#search" do
     context "any LOC authorities" do
       let :authority do
-        stub_request(:get, "http://id.loc.gov/search/?format=json&q=s&q=cs:http://id.loc.gov/vocabulary/geographicAreas")
+        stub_request(:get, "https://id.loc.gov/search/?format=json&q=s&q=cs:http://id.loc.gov/vocabulary/geographicAreas")
           .with(headers: { 'Accept' => 'application/json' })
           .to_return(body: webmock_fixture("loc-response.txt"), status: 200)
         described_class.subauthority_for("geographicAreas")
@@ -95,7 +95,7 @@ describe Qa::Authorities::Loc do
 
     context "subject terms" do
       let :results do
-        stub_request(:get, "http://id.loc.gov/search/?format=json&q=History--&q=cs:http://id.loc.gov/authorities/subjects")
+        stub_request(:get, "https://id.loc.gov/search/?format=json&q=History--&q=cs:http://id.loc.gov/authorities/subjects")
           .with(headers: { 'Accept' => 'application/json' })
           .to_return(body: webmock_fixture("loc-subjects-response.txt"), status: 200)
         described_class.subauthority_for("subjects").search("History--")
@@ -111,7 +111,7 @@ describe Qa::Authorities::Loc do
 
     context "name terms" do
       let :results do
-        stub_request(:get, "http://id.loc.gov/search/?format=json&q=Berry&q=cs:http://id.loc.gov/authorities/names")
+        stub_request(:get, "https://id.loc.gov/search/?format=json&q=Berry&q=cs:http://id.loc.gov/authorities/names")
           .with(headers: { 'Accept' => 'application/json' })
           .to_return(body: webmock_fixture("loc-names-response.txt"), status: 200)
         described_class.subauthority_for("names").search("Berry")
@@ -125,7 +125,7 @@ describe Qa::Authorities::Loc do
   describe "#find" do
     context "using a subject id" do
       let :results do
-        stub_request(:get, "http://id.loc.gov/authorities/subjects/sh2002003586.json")
+        stub_request(:get, "https://id.loc.gov/authorities/subjects/sh2002003586.json")
           .with(headers: { 'Accept' => 'application/json' })
           .to_return(status: 200, body: webmock_fixture("loc-subject-find-response.txt"), headers: {})
         described_class.subauthority_for("subjects").find("sh2002003586")

data/spec/lib/authorities/local_spec.rb

@@ -8,11 +8,11 @@ describe Qa::Authorities::Local do
   end
 
   describe "#subauthorities_path" do
+    let!(:original_path) { described_class.config[:local_path] }
     before do
-      @original_path = described_class.config[:local_path]
       described_class.config[:local_path] = path
     end
-    after { described_class.config[:local_path] = @original_path }
+    after { described_class.config[:local_path] = original_path }
 
     context "configured with a full path" do
       let(:path) { "/full/path" }
@@ -25,8 +25,8 @@ describe Qa::Authorities::Local do
     context "configured with a relative path" do
       let(:path) { "relative/path" }
 
-      it "returns a path relative to the Rails applicaition" do
-        expect(described_class.subauthorities_path).to eq(File.join(Rails.root, path))
+      it "returns a path relative to the Rails application" do
+        expect(described_class.subauthorities_path).to eq(Rails.root.join(path).to_s)
       end
     end
   end
@@ -37,11 +37,11 @@ describe Qa::Authorities::Local do
     end
 
     context "when the path doesn't exist" do
+      let!(:original_path) { described_class.config[:local_path] }
       before do
-        @original_path = described_class.config[:local_path]
         described_class.config[:local_path] = '/foo/bar'
       end
-      after { described_class.config[:local_path] = @original_path }
+      after { described_class.config[:local_path] = original_path }
 
       it "raises an error" do
         expect { described_class.names }.to raise_error Qa::ConfigDirectoryNotFound
@@ -70,8 +70,7 @@ describe Qa::Authorities::Local do
   describe ".register" do
     before do
       class SolrAuthority
-        def initialize(one)
-        end
+        def initialize(one); end
       end
       described_class.register_subauthority('new_sub', 'SolrAuthority')
     end

data/spec/lib/authorities/oclcts_spec.rb

@@ -1,46 +1,53 @@
 require 'spec_helper'
 
 describe Qa::Authorities::Oclcts do
+  let(:first_query) { described_class.subauthority_for("mesh") }
+  let(:terms) { first_query.search("ball") }
+  let(:term_record) { first_query.find(terms.first["id"]) }
+  let(:second_query) { described_class.subauthority_for("mesh") }
+
   before do
-    stub_request(:get, "http://tspilot.oclc.org/mesh/?maximumRecords=10&operation=searchRetrieve&query=oclcts.rootHeading%20exact%20%22ball*%22&recordPacking=xml&recordSchema=http://zthes.z3950.org/xml/1.0/&recordXPath=&resultSetTTL=300&sortKeys=&startRecord=1&version=1.1")
+    stub_request(:get, "http://tspilot.oclc.org/mesh/?maximumRecords=10&operation=searchRetrieve&query=oclcts" \
+                       ".rootHeading%20exact%20%22ball*%22&recordPacking=xml&recordSchema=" \
+                       "http://zthes.z3950.org/xml/1.0/&recordXPath=&resultSetTTL=300&sortKeys=&startRecord=1&version=1.1")
       .to_return(body: webmock_fixture("oclcts-response-mesh-1.txt"), status: 200)
-    stub_request(:get, "http://tspilot.oclc.org/mesh/?maximumRecords=10&operation=searchRetrieve&query=oclcts.rootHeading%20exact%20%22alph*%22&recordPacking=xml&recordSchema=http://zthes.z3950.org/xml/1.0/&recordXPath=&resultSetTTL=300&sortKeys=&startRecord=1&version=1.1")
+    stub_request(:get, "http://tspilot.oclc.org/mesh/?maximumRecords=10&operation=searchRetrieve&query=oclcts" \
+                       ".rootHeading%20exact%20%22alph*%22&recordPacking=xml&recordSchema=" \
+                       "http://zthes.z3950.org/xml/1.0/&recordXPath=&resultSetTTL=300&sortKeys=&startRecord=1&version=1.1")
       .to_return(body: webmock_fixture("oclcts-response-mesh-2.txt"), status: 200)
-    stub_request(:get, "http://tspilot.oclc.org/mesh/?maximumRecords=10&operation=searchRetrieve&query=dc.identifier%20exact%20%22D031329Q000821%22&recordPacking=xml&recordSchema=http://zthes.z3950.org/xml/1.0/&recordXPath=&resultSetTTL=300&sortKeys=&startRecord=1&version=1.1")
+    stub_request(:get, "http://tspilot.oclc.org/mesh/?maximumRecords=10&operation=searchRetrieve&query=dc" \
+                       ".identifier%20exact%20%22D031329Q000821%22&recordPacking=xml&recordSchema=" \
+                       "http://zthes.z3950.org/xml/1.0/&recordXPath=&resultSetTTL=300&sortKeys=&startRecord=1&version=1.1")
       .to_return(body: webmock_fixture("oclcts-response-mesh-3.txt"), status: 200)
 
-    @first_query = described_class.subauthority_for("mesh")
-    @terms = @first_query.search("ball")
-    @term_record = @first_query.find(@terms.first["id"])
-    @second_query = described_class.subauthority_for("mesh")
-    @second_query.search("alph")
+    second_query.search("alph")
   end
 
   describe "a query for terms" do
     it "has an array of hashes that match the query" do
-      expect(@terms).to be_kind_of Array
-      expect(@terms.first).to be_kind_of Hash
-      expect(@terms.first["label"]).to be_kind_of String
-      expect(@terms.first["label"]).to include "Ballota"
+      expect(terms).to be_kind_of Array
+      expect(terms.first).to be_kind_of Hash
+      expect(terms.first["label"]).to be_kind_of String
+      expect(terms.first["label"]).to include "Ballota"
     end
 
     it "has an array of hashes containing unique id and label" do
-      expect(@terms.first).to have_key("id")
-      expect(@terms.first).to have_key("label")
+      expect(terms.first).to have_key("id")
+      expect(terms.first).to have_key("label")
     end
   end
 
   describe "a query for a single item" do
     it "has a hash of values that represent the item requested" do
-      expect(@term_record).to be_kind_of Hash
-      expect(@term_record.values).to include @terms.first["id"]
-      expect(@term_record.values).to include @terms.first["label"]
+      expect(term_record).to be_kind_of Hash
+      expect(term_record.values).to include terms.first["id"]
+      expect(term_record.values).to include terms.first["label"]
     end
 
     it "succeeds for valid ids, even if the id is not in the initial list of responses" do
-      record = @second_query.find(@terms.first["id"])
-      expect(record.values).to include @terms.first["id"]
-      expect(record.values).to include @terms.first["label"]
+      record = second_query.find(terms.first["id"])
+      expect(record.values).to include terms.first["id"]
+      expect(record.values).to include terms.first["label"]
     end
   end
 end

data/spec/lib/authorities/table_based_authority_spec.rb

@@ -25,9 +25,11 @@ describe Qa::Authorities::Local::TableBasedAuthority do
   end
 
   describe "#all" do
-    let(:expected) { [{ 'id' => "A1", 'label' => "Abc Term A1" },
-                      { 'id' => "A2", 'label' => "Term A2" },
-                      { 'id' => "A3", 'label' => "Abc Term A3" }] }
+    let(:expected) do
+      [{ 'id' => "A1", 'label' => "Abc Term A1" },
+       { 'id' => "A2", 'label' => "Term A2" },
+       { 'id' => "A3", 'label' => "Abc Term A3" }]
+    end
     it "returns all the entries" do
       expect(language.all).to eq [
         { "id" => "http://id.loc.gov/vocabulary/languages/fre", "label" => "French" },

data/spec/lib/authorities_loc_subauthorities.rb

@@ -10,7 +10,7 @@ describe Qa::Authorities::LocSubauthority do
 
   context "with a valid subauthority" do
     it "returns a url" do
-      subauthority_table.keys.each do |authority|
+      subauthority_table.each_key do |authority|
         expect(subject.get_url_for_authority(authority)).to eq(subauthority_table[authority])
       end
     end
@@ -24,7 +24,7 @@ describe Qa::Authorities::LocSubauthority do
 
   # This is the original data structure that was used to define subauthority urls
   # It is retained here to ensure our refactor succeeded
-  def subauthority_table
+  def subauthority_table # rubocop:disable Metrics/MethodLength
     vocab_base_url = 'cs%3Ahttp%3A%2F%2Fid.loc.gov%2Fvocabulary%2F'
     authority_base_url = 'cs%3Ahttp%3A%2F%2Fid.loc.gov%2Fauthorities%2F'
     datatype_base_url = 'cs%3Ahttp%3A%2F%2Fid.loc.gov%2Fdatatypes%2F'

data/spec/lib/configuration_spec.rb

@@ -0,0 +1,58 @@
+RSpec.describe Qa::Configuration do
+  subject { described_class.new }
+
+  it { is_expected.to respond_to(:cors_headers?) }
+  it { is_expected.to respond_to(:enable_cors_headers) }
+  it { is_expected.to respond_to(:disable_cors_headers) }
+  it { is_expected.to respond_to(:authorized_reload_token=) }
+  it { is_expected.to respond_to(:authorized_reload_token) }
+  it { is_expected.to respond_to(:valid_authority_reload_token?) }
+
+  describe '#enable_cors_headers' do
+    it 'turns on cors headers support' do
+      subject.enable_cors_headers
+      expect(subject.cors_headers?).to be true
+    end
+  end
+
+  describe '#disable_cors_headers' do
+    it 'turns off cors headers support' do
+      subject.disable_cors_headers
+      expect(subject.cors_headers?).to be false
+    end
+  end
+
+  describe '#valid_authority_reload_token?' do
+    it 'defaults to invalid' do
+      expect(subject.valid_authority_reload_token?('any value')).to be false
+    end
+
+    context 'when token is set to blank' do
+      before do
+        subject.authorized_reload_token = ''
+      end
+
+      it 'returns false if token matches' do
+        expect(subject.valid_authority_reload_token?('')).to be false
+      end
+
+      it "returns false if token doesn't match" do
+        expect(subject.valid_authority_reload_token?('any value')).to be false
+      end
+    end
+
+    context 'when token has a value' do
+      before do
+        subject.authorized_reload_token = 'A_TOKEN'
+      end
+
+      it 'returns true if the passed in token matches' do
+        expect(subject.valid_authority_reload_token?('A_TOKEN')).to be true
+      end
+
+      it 'returns false if the passed in token does not match' do
+        expect(subject.valid_authority_reload_token?('BAD TOKEN')).to be false
+      end
+    end
+  end
+end

data/spec/lib/mesh_data_parser_spec.rb

@@ -47,6 +47,7 @@ EOS
     expect(records[1]).to eq({})
   end
 
+  # rubocop:disable Metrics/LineLength
   it 'parses a sample mesh file' do
     mesh = described_class.new(webmock_fixture('mesh.txt'))
     records = mesh.all_records
@@ -116,4 +117,5 @@ EOS
                              "DX" => ["19840101"],
                              "UI" => ["D000001"])
   end
+  # rubocop:enable Metrics/LineLength
 end

data/spec/lib/services/rdf_authority_parser_spec.rb

@@ -2,7 +2,7 @@
 require 'spec_helper'
 
 describe Qa::Services::RDFAuthorityParser do
-  let(:source) { [File.join(fixture_path, 'lexvo_snippet.rdf')] }
+  let(:source) { [File.join(fixture_path, 'lexvo_snippet.rdf.xml')] }
   let(:format) { 'rdfxml' }
   let(:predicate) { RDF::URI("http://www.w3.org/2008/05/skos#prefLabel") }
   let(:name) { 'language' }

data/spec/lib/tasks/mesh.rake_spec.rb

@@ -2,33 +2,34 @@ require 'spec_helper'
 require 'rake'
 require 'stringio'
 
-describe "mesh rake tasks" do
+describe "mesh rake tasks" do # rubocop:disable RSpec/DescribeClass
+  let(:rake) { Rake::Application.new }
   before do
-    @rake = Rake::Application.new
-    Rake.application = @rake
-    Rake.application.rake_require "mesh", ["#{Rails.root}/lib/tasks", "#{Rails.root}/../lib/tasks"], []
+    Rake.application = rake
+    Rake.application.rake_require "mesh", [Rails.root.join('lib', 'tasks'), Rails.root.join('..', 'lib', 'tasks')], []
     Rake::Task.define_task(:environment) # rspec has loaded rails
   end
 
   describe "mesh:import" do
+    let(:task_name) { "mesh:import" }
+    let(:output) { StringIO.new }
     before do
-      @task_name = "mesh:import"
-      @output = StringIO.new
-      $stdout = @output
+      $stdout = output # rubocop:disable RSpec/ExpectOutput # TODO: Explore how to remove this disable
     end
     after :all do
       $stdout = STDOUT
     end
     it "has 'environment' as a prereq" do
-      expect(@rake[@task_name].prerequisites).to include("environment")
+      expect(rake[task_name].prerequisites).to include("environment")
     end
     it "requires $MESH_FILE to be set" do
       old_mesh_file = ENV.delete('MESH_FILE')
-      @rake[@task_name].invoke
-      @output.seek(0)
-      expect(@output.read).to match(/Need to set \$MESH_FILE with path to file to ingest/)
+      rake[task_name].invoke
+      output.seek(0)
+      expect(output.read).to match(/Need to set \$MESH_FILE with path to file to ingest/)
       ENV['MESH_FILE'] = old_mesh_file
     end
+
     describe "create or update" do
       let(:input) { StringIO.new("*NEWRECORD\nUI = 5\nMH = test\n") }
       let(:term)  { Qa::SubjectMeshTerm.find_by_term_id(5) }
@@ -36,7 +37,7 @@ describe "mesh rake tasks" do
       before do
         ENV['MESH_FILE'] = "dummy"
         allow(File).to receive(:open).with("dummy").and_yield(input)
-        @rake[@task_name].invoke
+        rake[task_name].invoke
       end
       it "creates or update all records in the config file" do
         expect(term).not_to be_nil

data/spec/models/subject_mesh_term_spec.rb

@@ -1,5 +1,6 @@
 require 'spec_helper'
 
+# rubocop:disable RSpec/InstanceVariable # TODO: Explore if there is a way to remove this disable
 describe Qa::SubjectMeshTerm, type: :model do
   before(:all) do
     @term = Qa::SubjectMeshTerm.new
@@ -47,3 +48,4 @@ describe Qa::SubjectMeshTerm, type: :model do
   #  @term.parents.map { |p| p.term_id }.should == ["1", "2", "3"]
   # end
 end
+# rubocop:enable RSpec/InstanceVariable

data/spec/requests/cors_headers_spec.rb

@@ -0,0 +1,118 @@
+# spec/requests/cors_headers_spec.rb
+require 'spec_helper'
+
+describe "CORS OPTIONS requests" do # rubocop:disable RSpec/DescribeClass
+  context 'when cors headers are enabled' do
+    before do
+      Qa.config.enable_cors_headers
+    end
+
+    it 'return CORS header info for index' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/terms/loc"
+      correct_cors_response?
+    end
+
+    it 'return CORS header info for index with subauthority' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/terms/local/states"
+      correct_cors_response?
+    end
+
+    it 'return CORS header info for search' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/search/loc"
+      correct_cors_response?
+    end
+
+    it 'return CORS header info for search with subauthority' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/search/local/two_args?q=a query"
+      correct_cors_response?
+    end
+
+    it 'return CORS header info for show' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/show/mesh/D000001"
+      correct_cors_response?
+    end
+
+    it 'return CORS header info for show with subauthority' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/show/local/states/OH"
+      correct_cors_response?
+    end
+
+    it 'return CORS header info for linked_data/search' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/search/linked_data/OCLC_FAST?q=my_query&maximumRecords=3"
+      correct_cors_response?
+    end
+
+    it 'return CORS header info for linked_data/show' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/show/linked_data/OCLC_FAST/n24"
+      correct_cors_response?
+    end
+  end
+
+  def correct_cors_response?
+    expect(response.code).to eq('204')
+    expect(response.headers['Access-Control-Allow-Origin']).to eq '*'
+    expect(response.headers['Access-Control-Allow-Methods']).to eq 'GET, OPTIONS'
+  end
+
+  context 'when cors headers are disabled' do
+    before do
+      Qa.config.disable_cors_headers
+    end
+
+    it 'report method not supported for index' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/terms/loc"
+      expect(response.code).to eq('501')
+    end
+
+    it 'report method not supported for index with subauthority' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/terms/local/states"
+      expect(response.code).to eq('501')
+    end
+
+    it 'report method not supported for search' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/search/loc"
+      expect(response.code).to eq('501')
+    end
+
+    it 'report method not supported for search with subauthority' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/search/local/two_args?q=a query"
+      expect(response.code).to eq('501')
+    end
+
+    it 'report method not supported for show' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/show/mesh/D000001"
+      expect(response.code).to eq('501')
+    end
+
+    it 'report method not supported for show with subauthority' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/show/local/states/OH"
+      expect(response.code).to eq('501')
+    end
+
+    it 'report method not supported for linked_data/search' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/search/linked_data/OCLC_FAST?q=my_query&maximumRecords=3"
+      expect(response.code).to eq('501')
+    end
+
+    it 'report method not supported for linked_data/show' do
+      reset!
+      integration_session.__send__ :process, 'OPTIONS', "/qa/show/linked_data/OCLC_FAST/n24"
+      expect(response.code).to eq('501')
+    end
+  end
+end