qa 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 85e4df1dd651f734f74b024a0414e4d9f7a919ca
-  data.tar.gz: 8308624003069a7af0b16a5248683691acd4ccdc
+  metadata.gz: 04f7b6155dd96973d581100cf2a1dd4a3d354a9e
+  data.tar.gz: fb7def7c149256be271a7b95de1d784f089218f7
 SHA512:
-  metadata.gz: 579dbb01782116c072173f4ca96ae6b142f20a98161c308edb08365da03d52520123483d9d63ea4ed8159197fd94739a1483f91a965920f57aa432b4ef1eee25
-  data.tar.gz: 3ac918adcb01206d99ac08c97ef1e9185f6b2f35c9442fa4cabf2d86dad64ee892c11478488144b320c3da1a97aa2aca6cb4f6ad49ce49eec2d72903b71afcf4
+  metadata.gz: 0a19a175ac1cb3b84fd9af171a426229bf0b757c3daf5a1f76dd95fc6074ed8950f233d97aaaeba0d127f0e0eb7e7fedbeb304f530abf82036a1947d0a46b71a
+  data.tar.gz: 52cea5dc60f4758990f9bc8c73652c1f7396abd9d3b894d0357ae912e794f9e526a8ef2cfa35ead7aca8129a1c16611541fc0fdb1029e1c02cb30754b7b04bc1

data/README.md

@@ -166,11 +166,12 @@ Qa::Authorities::Geonames.username = 'myAccountName'
 
 ### Local Authorities
 
+#### In YAML files
 For simple use cases when you have a few terms that don't change very often.
 
 Run the generator to install configuration files and an example authority.
 
-    rails generate qa:local
+    rails generate qa:local:files
 
 This will install a sample states authority file that lists all the states in the U.S.  To query it,
 
@@ -230,6 +231,44 @@ The second argument is a name of a class that represents your local authority. T
 
 You'll be searching with an instance of `LocalNames`
 
+### In database tables
+
+Run the generator to install configuration files and an example authority.
+
+    rails generate qa:local:tables
+    rake db:migrate
+
+This will create two tables/models Qa::LocalAuthority and Qa::LocalAuthorityEntry. You can then add terms to each:
+
+    language_auth = Qa::LocalAuthority.find_or_create_by(name: 'language')
+    Qa::LocalAuthorityEntry.create(local_authority: language_auth,
+                                   label: 'French',
+                                   uri: 'http://id.loc.gov/vocabulary/languages/fre')
+    Qa::LocalAuthorityEntry.create(local_authority: language_auth,
+                                   label: 'Uighur',
+                                   uri: 'http://id.loc.gov/vocabulary/languages/uig')
+
+Unfortunately, Rails doesn't have a mechnism for adding functional indexes to tables, so if you have a lot of rows, you'll want to add an index:
+
+    CREATE INDEX "index_qa_local_authority_entries_on_lower_label" ON 
+      "qa_local_authority_entries" (local_authority_id, lower(label))
+
+Finall you want register your authority in an initializer:
+
+    Qa::Authorities::Local.register_subauthority('languages', 'Qa::Authorities::Local::TableBasedAuthority')
+
+Then you can search for 
+
+    /qa/search/local/languages?q=Fre
+
+Results are in JSON.
+
+    [{"id":"http://id.loc.gov/vocabulary/languages/fre","label":"French"}]
+
+The entire list (up to the first 1000 terms) can also be returned using:
+
+    /qa/terms/local/languages/
+
 
 ### Medical Subject Headings (MeSH)
 

data/config/initializers/authorities.rb

@@ -1 +1,3 @@
-AUTHORITIES_CONFIG = YAML.load_file(File.expand_path("../../authorities.yml", __FILE__))
+Qa::Authorities::Local.load_config(File.expand_path("../../authorities.yml", __FILE__))
+
+Qa::Authorities::Local::TableBasedAuthority.check_for_index

data/lib/generators/qa/local/files/files_generator.rb

@@ -0,0 +1,10 @@
+module Qa::Local
+  class FilesGenerator < Rails::Generators::Base
+    source_root File.expand_path('../../templates', __FILE__)
+
+    def copy_local_authority_configs
+      copy_file "config/authorities.yml", "config/authorities.yml"
+      directory "config/authorities"
+    end
+  end
+end

data/lib/generators/qa/local/tables/tables_generator.rb

@@ -0,0 +1,19 @@
+require 'rails/generators/active_record/migration'
+module Qa::Local
+  class TablesGenerator < Rails::Generators::Base
+    source_root File.expand_path('../templates', __FILE__)
+    include ActiveRecord::Generators::Migration
+
+    def migrations
+      generate "model qa/local_authority name:string:uniq"
+      generate "model qa/local_authority_entry local_authority:references label:string uri:string:uniq"
+      message = "Rails doesn't support functional indexes in migrations, so you'll have to add this manually:\n" \
+    "CREATE INDEX \"index_qa_local_authority_entries_on_lower_label\" ON \"qa_local_authority_entries\" (local_authority_id, lower(label))\n" \
+    "   OR on Sqlite: \n" \
+    "CREATE INDEX \"index_qa_local_authority_entries_on_lower_label\" ON \"qa_local_authority_entries\" (local_authority_id, label collate nocase)\n"
+      say_status("info", message, :yellow)
+    end
+
+  end
+end
+

data/lib/generators/qa/local/tables/templates/add_index_to_local_authorities.rb

@@ -0,0 +1,6 @@
+class AddIndexToLocalAuthorities < ActiveRecord::Migration
+  # we'd like to be able to run this, but rails quotes the functional index.
+  # add_index :local_authority_entries,
+  #           ['local_authority_id', 'lower(label)'],
+  #           name: 'index_local_authority_entries_on_lower_label'
+end

data/lib/qa/authorities/geonames.rb

@@ -2,9 +2,17 @@ module Qa::Authorities
   class Geonames < Base
     include WebServiceBase
 
-    class_attribute :username
+    class_attribute :username, :label
+
+    self.label = -> (item) do
+      [item['name'], item['adminName1'], item['countryName']].compact.join(', ')
+    end
 
     def search q
+      unless username
+        Rails.logger.error "Questioning Authority tried to call geonames, but no username was set"
+        return []
+      end
       parse_authority_response(json(build_query_url(q)))
     end
 
@@ -36,8 +44,9 @@ module Qa::Authorities
     def parse_authority_response(response)
       response['geonames'].map do |result|
         { 'id' => "http://sws.geonames.org/#{result['geonameId']}",
-          'label' => result['name'] }
+          'label' => label.call(result) }
       end
     end
+
   end
 end

data/lib/qa/authorities/local.rb

@@ -1,9 +1,36 @@
 module Qa::Authorities
   module Local
+    extend ActiveSupport::Autoload
     extend AuthorityWithSubAuthority
-    extend Qa::Authorities::LocalSubauthority
-    require 'qa/authorities/local/file_based_authority'
+    autoload :FileBasedAuthority
+    autoload :Registry
+    autoload :TableBasedAuthority
 
+    def self.config
+      @config
+    end
+
+    def self.load_config(file)
+      @config = YAML.load_file(file)
+    end
+
+    # Path to sub-authority files is either the full path to a directory or
+    # the path to a directory relative to the Rails application
+    def self.subauthorities_path
+      if config[:local_path].starts_with?(File::Separator)
+        config[:local_path]
+      else
+        File.join(Rails.root, config[:local_path])
+      end
+    end
+
+    # Local sub-authorities are any YAML files in the subauthorities_path
+    def self.names
+      unless Dir.exists? subauthorities_path
+        raise Qa::ConfigDirectoryNotFound, "There's no directory at #{subauthorities_path}. You must create it in order to use local authorities"
+      end
+      Dir.entries(subauthorities_path).map { |f| File.basename(f, ".yml") if f.match(/yml$/) }.compact
+    end
 
     def self.subauthority_for(subauthority)
       validate_subauthority!(subauthority)
@@ -18,7 +45,6 @@ module Qa::Authorities
       end
     end
 
-
     def self.register_subauthority(subauthority, class_name)
       registry.add(subauthority, class_name)
     end
@@ -33,54 +59,5 @@ module Qa::Authorities
           reg.add(name, 'Qa::Authorities::Local::FileBasedAuthority')
         end
       end
-
-    class Registry
-      def initialize
-        @hash = {}
-        yield self if block_given?
-      end
-
-      def keys
-        @hash.keys
-      end
-
-      def instance_for(key)
-        fetch(key).instance
-      end
-
-      def fetch(key)
-        @hash.fetch(key)
-      end
-
-      def self.logger
-        @logger ||= begin
-          ::Rails.logger if defined? Rails and Rails.respond_to? :logger
-        end
-      end
-
-      def self.logger= logger
-        @logger = logger
-      end
-
-      def add(subauthority, class_name)
-        Registry.logger.debug "Registering Local QA authority: #{subauthority} - #{class_name}"
-        @hash[subauthority] = RegistryEntry.new(subauthority, class_name)
-      end
-
-
-      class RegistryEntry
-        def initialize(subauthority, class_name)
-          @subauthority, @class_name = subauthority, class_name
-        end
-
-        def klass
-          @class_name.constantize
-        end
-
-        def instance
-          klass.new(@subauthority)
-        end
-      end
-    end
   end
 end

data/lib/qa/authorities/local/registry.rb

@@ -0,0 +1,52 @@
+module Qa::Authorities
+  module Local
+    class Registry
+      def initialize
+        @hash = {}
+        yield self if block_given?
+      end
+
+      def keys
+        @hash.keys
+      end
+
+      def instance_for(key)
+        fetch(key).instance
+      end
+
+      def fetch(key)
+        @hash.fetch(key)
+      end
+
+      def self.logger
+        @logger ||= begin
+          ::Rails.logger if defined? Rails and Rails.respond_to? :logger
+        end
+      end
+
+      def self.logger= logger
+        @logger = logger
+      end
+
+      def add(subauthority, class_name)
+        Registry.logger.debug "Registering Local QA authority: #{subauthority} - #{class_name}"
+        @hash[subauthority] = RegistryEntry.new(subauthority, class_name)
+      end
+
+
+      class RegistryEntry
+        def initialize(subauthority, class_name)
+          @subauthority, @class_name = subauthority, class_name
+        end
+
+        def klass
+          @class_name.constantize
+        end
+
+        def instance
+          klass.new(@subauthority)
+        end
+      end
+    end
+  end
+end

data/lib/qa/authorities/local/table_based_authority.rb

@@ -0,0 +1,53 @@
+module Qa::Authorities
+  class Local::TableBasedAuthority < Base
+    def self.check_for_index
+      conn = ActiveRecord::Base.connection
+      if conn.table_exists?('local_authority_entries') && !conn.indexes('local_authority_entries').find { |i| i.name == 'index_local_authority_entries_on_lower_label' }
+        Rails.logger.error "You've installed local authority tables, but you haven't indexed the label.  Rails doesn't support functional indexes in migrations, so you'll have to add this manually:\n" \
+          "CREATE INDEX \"index_qa_local_authority_entries_on_lower_label\" ON \"qa_local_authority_entries\" (local_authority_id, lower(label))\n" \
+          "   OR on Sqlite: \n" \
+          "CREATE INDEX \"index_qa_local_authority_entries_on_lower_label\" ON \"qa_local_authority_entries\" (local_authority_id, label collate nocase)\n" \
+      end
+    end
+
+    attr_reader :subauthority
+
+    def initialize(subauthority)
+      @subauthority = subauthority
+    end
+
+    def search(q)
+      return [] if q.blank?
+      output_set(base_relation.where('lower(label) like ?', "#{q.downcase}%").limit(25))
+    end
+
+    def all
+      output_set(base_relation.limit(1000))
+    end
+
+    def find(uri)
+      record = base_relation.find_by(uri: uri)
+      return unless record
+      output(record)
+    end
+
+    private
+
+      def base_relation
+        Qa::LocalAuthorityEntry.where(local_authority: local_authority)
+      end
+
+      def output_set(set)
+        set.map { |item| output(item) }
+      end
+
+      def output(item)
+        { id: item[:uri], label: item[:label] }.with_indifferent_access
+      end
+
+      def local_authority
+        Qa::LocalAuthority.find_by_name(subauthority)
+      end
+
+  end
+end

data/lib/qa/version.rb

@@ -1,3 +1,3 @@
 module Qa
-  VERSION = "0.7.0"
+  VERSION = "0.8.0"
 end

data/spec/lib/authorities/assign_fast_spec.rb

@@ -6,7 +6,7 @@ describe Qa::Authorities::AssignFast do
   describe "#new" do
     context "without a sub-authority" do
       it "should raise an exception" do
-        expect { Qa::Authorities::AssignFast.new }.to raise_error
+        expect { described_class.new }.to raise_error RuntimeError, "Initializing with as sub authority is removed. use Module.subauthority_for(nil) instead"
       end
     end
   end
@@ -14,7 +14,7 @@ describe Qa::Authorities::AssignFast do
   describe "#subauthority_for" do
     context "with an invalid sub-authority" do
       it "should raise an exception" do
-        expect { Qa::Authorities::AssignFast.subauthority_for("foo") }.to raise_error
+        expect { Qa::Authorities::AssignFast.subauthority_for("foo") }.to raise_error Qa::InvalidSubAuthority
       end
     end
     context "with a valid sub-authority" do

data/spec/lib/authorities/file_based_authority_spec.rb

@@ -31,7 +31,7 @@ describe Qa::Authorities::Local::FileBasedAuthority do
     end
     context "YAML file is malformed" do
       it "should raise an error" do
-        expect { authority_d.all }.to raise_error
+        expect { authority_d.all }.to raise_error Psych::SyntaxError
       end
     end
   end

data/spec/lib/authorities/geonames_spec.rb

@@ -27,12 +27,35 @@ describe Qa::Authorities::Geonames do
 
       subject { authority.search('whatever') }
 
-      it "has id and label keys" do
-        expect(subject.first).to eq("id" => 'http://sws.geonames.org/2088122',
-                                    "label" => "Port Moresby")
-        expect(subject.last).to eq("id" => 'http://sws.geonames.org/377039',
-                                   "label" => "Port Sudan")
-        expect(subject.size).to eq(10)
+      context "with default label" do
+        it "has id and label keys" do
+          expect(subject.first).to eq("id" => 'http://sws.geonames.org/2088122',
+                                      "label" => "Port Moresby, National Capital, Papua New Guinea")
+          expect(subject.last).to eq("id" => 'http://sws.geonames.org/377039',
+                                     "label" => "Port Sudan, Red Sea, Sudan")
+          expect(subject.size).to eq(10)
+        end
+      end
+
+      context "with custom label" do
+        before do
+          @original_label = described_class.label
+          described_class.label = -> (item) { item['name'] }
+        end
+        after do
+          described_class.label = @original_label
+        end
+        it "uses the lambda" do
+          expect(subject.first['label']).to eq("Port Moresby")
+        end
+      end
+
+      context "when username isn't set" do
+        before { described_class.username = nil }
+        it "logs an error" do
+          expect(Rails.logger).to receive(:error).with('Questioning Authority tried to call geonames, but no username was set')
+          expect(subject).to be_empty
+        end
       end
     end
   end

data/spec/lib/authorities/getty_spec.rb

@@ -4,20 +4,20 @@ describe Qa::Authorities::Getty do
 
   describe "#new" do
     it "should raise an exception" do
-      expect { described_class.new }.to raise_error
+      expect { described_class.new }.to raise_error RuntimeError, "Initializing with as sub authority is removed. use Module.subauthority_for(nil) instead"
     end
   end
 
   describe "#subauthority_for" do
     context "without a sub-authority" do
       it "should raise an exception" do
-        expect { described_class.subauthority_for }.to raise_error
+        expect { described_class.subauthority_for }.to raise_error ArgumentError
       end
     end
 
     context "with an invalid sub-authority" do
       it "should raise an exception" do
-        expect { described_class.subauthority_for("foo") }.to raise_error
+        expect { described_class.subauthority_for("foo") }.to raise_error Qa::InvalidSubAuthority
       end
     end
 

data/spec/lib/authorities/loc_spec.rb

@@ -5,7 +5,7 @@ describe Qa::Authorities::Loc do
   describe "#new" do
     context "without a sub-authority" do
       it "should raise an exception" do
-        expect { Qa::Authorities::Loc.new }.to raise_error
+        expect { described_class.new }.to raise_error RuntimeError, "Initializing with as sub authority is removed. use Module.subauthority_for(nil) instead"
       end
     end
   end
@@ -13,7 +13,7 @@ describe Qa::Authorities::Loc do
   describe "#subauthority_for" do
     context "with an invalid sub-authority" do
       it "should raise an exception" do
-        expect { Qa::Authorities::Loc.subauthority_for("foo") }.to raise_error
+        expect { Qa::Authorities::Loc.subauthority_for("foo") }.to raise_error Qa::InvalidSubAuthority
       end
     end
     context "with a valid sub-authority" do

data/spec/lib/authorities/local_spec.rb

@@ -4,17 +4,60 @@ describe Qa::Authorities::Local do
 
   describe "new" do
     it "should raise an error" do
-      expect { described_class.new }.to raise_error
+      expect { described_class.new }.to raise_error RuntimeError, "Initializing with as sub authority is removed. use Module.subauthority_for(nil) instead"
     end
   end
 
+  describe "#subauthorities_path" do
+    before do
+      @original_path = described_class.config[:local_path]
+      described_class.config[:local_path] = path
+    end
+    after { described_class.config[:local_path] = @original_path }
+
+    context "configured with a full path" do
+      let(:path) { "/full/path" }
+
+      it "returns a full path" do
+        expect(described_class.subauthorities_path).to eq(path)
+      end
+    end
+
+    context "configured with a relative path" do
+      let(:path) { "relative/path" }
+
+      it "returns a path relative to the Rails applicaition" do
+        expect(described_class.subauthorities_path).to eq(File.join(Rails.root, path))
+      end
+    end
+  end
+
+  describe "#names" do
+    it "returns a list of yaml files" do
+      expect(described_class.names).to include("authority_A", "authority_B", "authority_C", "authority_D", "states")
+    end
+
+    context "when the path doesn't exist" do
+      before do
+        @original_path = described_class.config[:local_path]
+        described_class.config[:local_path] = '/foo/bar' 
+      end
+      after { described_class.config[:local_path] = @original_path }
+
+      it "raises an error" do
+        expect { described_class.names }.to raise_error Qa::ConfigDirectoryNotFound
+      end
+    end
+  end
+
+
   describe ".subauthority_for" do
     context "without a sub-authority" do
       it "should raise an error is the sub-authority is not provided" do
-        expect { described_class.subauthority_for }.to raise_error
+        expect { described_class.subauthority_for }.to raise_error ArgumentError
       end
       it "should raise an error is the sub-authority does not exist" do
-        expect { described_class.subauthority_for("foo") }.to raise_error
+        expect { described_class.subauthority_for("foo") }.to raise_error Qa::InvalidSubAuthority
       end
     end
 

data/spec/lib/authorities/table_based_authority_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+
+describe Qa::Authorities::Local::TableBasedAuthority do
+
+  let(:language) { Qa::Authorities::Local.subauthority_for("language") }
+  let(:subj) { Qa::Authorities::Local.subauthority_for("subject") }
+
+  let(:language_auth) { Qa::LocalAuthority.find_or_create_by(name: 'language') }
+  let(:alternate_auth) { Qa::LocalAuthority.find_or_create_by(name: 'subject') }
+  before do
+    Qa::Authorities::Local.register_subauthority('language', described_class.to_s)
+    Qa::Authorities::Local.register_subauthority('subject', described_class.to_s)
+    Qa::LocalAuthorityEntry.create(local_authority: language_auth, label: 'French', uri: 'http://id.loc.gov/vocabulary/languages/fre')
+    Qa::LocalAuthorityEntry.create(local_authority: language_auth, label: 'Uighur', uri: 'http://id.loc.gov/vocabulary/languages/uig')
+    Qa::LocalAuthorityEntry.create(local_authority: alternate_auth, label: 'French', uri: 'http://example.com/french')
+  end
+
+  describe "#all" do
+    let(:expected) { [ { 'id'=> "A1", 'label' => "Abc Term A1" },
+                       { 'id' => "A2", 'label'=> "Term A2" },
+                       { 'id' => "A3", 'label' => "Abc Term A3" } ] }
+    it "should return all the entries" do
+      expect(language.all).to eq [
+        {"id"=>"http://id.loc.gov/vocabulary/languages/fre", "label"=>"French"},
+        {"id"=>"http://id.loc.gov/vocabulary/languages/uig", "label"=>"Uighur"}]
+
+    end
+  end
+
+  describe "#search" do
+    context "with an empty query string" do
+      let(:expected) { [] }
+      it "should return no results" do
+        expect(language.search("")).to eq(expected)
+      end
+    end
+    context "with at least one matching entry" do
+      it "is case insensitive" do
+        expect(language.search("fRe")).to eq [{"id"=>"http://id.loc.gov/vocabulary/languages/fre", "label"=>"French"}]
+      end
+    end
+
+    context "with no matching entries" do
+      it "returns an empty array" do
+        expect(language.search("def")).to be_empty
+      end
+    end
+  end
+
+  describe "#find" do
+    context "term exists" do
+      it "should return the full term record" do
+        record = language.find('http://id.loc.gov/vocabulary/languages/fre')
+        expect(record).to be_a HashWithIndifferentAccess
+        expect(record).to eq('id' => "http://id.loc.gov/vocabulary/languages/fre",
+                             'label' => "French")
+      end
+    end
+    context "term does not exist" do
+      let(:id) { "NonID" }
+      let(:expected) { {} }
+      it "should return an empty hash" do
+        expect(language.find('http://id.loc.gov/vocabulary/languages/eng')).to be_nil
+      end
+    end
+  end
+end

data/spec/test_app_templates/lib/generators/test_app_generator.rb

@@ -14,7 +14,8 @@ class TestAppGenerator < Rails::Generators::Base
   end
 
   def run_local_authority_installer
-    generate "qa:local"
+    generate "qa:local:files"
+    generate "qa:local:tables"
   end
 
   def copy_local_authority_fixtures

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: qa
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Stephen Anderson
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-27 00:00:00.000000000 Z
+date: 2016-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -208,7 +208,9 @@ files:
 - lib/generators/qa/install/install_generator.rb
 - lib/generators/qa/install/templates/config/oclcts-authorities.yml
 - lib/generators/qa/local/USAGE
-- lib/generators/qa/local/local_generator.rb
+- lib/generators/qa/local/files/files_generator.rb
+- lib/generators/qa/local/tables/tables_generator.rb
+- lib/generators/qa/local/tables/templates/add_index_to_local_authorities.rb
 - lib/generators/qa/local/templates/config/authorities.yml
 - lib/generators/qa/local/templates/config/authorities/states.yml
 - lib/qa.rb
@@ -228,7 +230,8 @@ files:
 - lib/qa/authorities/loc_subauthority.rb
 - lib/qa/authorities/local.rb
 - lib/qa/authorities/local/file_based_authority.rb
-- lib/qa/authorities/local_subauthority.rb
+- lib/qa/authorities/local/registry.rb
+- lib/qa/authorities/local/table_based_authority.rb
 - lib/qa/authorities/mesh.rb
 - lib/qa/authorities/mesh_tools.rb
 - lib/qa/authorities/mesh_tools/mesh_data_parser.rb
@@ -278,9 +281,9 @@ files:
 - spec/lib/authorities/local_spec.rb
 - spec/lib/authorities/mesh_spec.rb
 - spec/lib/authorities/oclcts_spec.rb
+- spec/lib/authorities/table_based_authority_spec.rb
 - spec/lib/authorities/tgnlang_spec.rb
 - spec/lib/authorities_loc_subauthorities.rb
-- spec/lib/authorities_local_subauthorities_spec.rb
 - spec/lib/mesh_data_parser_spec.rb
 - spec/lib/tasks/mesh.rake_spec.rb
 - spec/models/subject_mesh_term_spec.rb
@@ -348,9 +351,9 @@ test_files:
 - spec/lib/authorities/local_spec.rb
 - spec/lib/authorities/mesh_spec.rb
 - spec/lib/authorities/oclcts_spec.rb
+- spec/lib/authorities/table_based_authority_spec.rb
 - spec/lib/authorities/tgnlang_spec.rb
 - spec/lib/authorities_loc_subauthorities.rb
-- spec/lib/authorities_local_subauthorities_spec.rb
 - spec/lib/mesh_data_parser_spec.rb
 - spec/lib/tasks/mesh.rake_spec.rb
 - spec/models/subject_mesh_term_spec.rb

data/lib/generators/qa/local/local_generator.rb

@@ -1,9 +0,0 @@
-class Qa::LocalGenerator < Rails::Generators::Base
-  source_root File.expand_path('../templates', __FILE__)
-
-  def copy_local_authority_configs
-    copy_file "config/authorities.yml", "config/authorities.yml"
-    directory "config/authorities"
-  end
-
-end

data/lib/qa/authorities/local_subauthority.rb

@@ -1,21 +0,0 @@
-module Qa::Authorities::LocalSubauthority
-
-  # Path to sub-authority files is either the full path to a directory or
-  # the path to a directory relative to the Rails application
-  def subauthorities_path
-    if AUTHORITIES_CONFIG[:local_path].starts_with?(File::Separator)
-      AUTHORITIES_CONFIG[:local_path]
-    else
-      File.join(Rails.root, AUTHORITIES_CONFIG[:local_path])
-    end
-  end
-
-  # Local sub-authorities are any YAML files in the subauthorities_path
-  def names
-    unless Dir.exists? subauthorities_path
-      raise Qa::ConfigDirectoryNotFound, "There's no directory at #{subauthorities_path}. You must create it in order to use local authorities"
-    end
-    Dir.entries(subauthorities_path).map { |f| File.basename(f, ".yml") if f.match(/yml$/) }.compact
-  end
-
-end

data/spec/lib/authorities_local_subauthorities_spec.rb

@@ -1,51 +0,0 @@
-require 'spec_helper'
-
-describe Qa::Authorities::LocalSubauthority do
-
-  before do
-    class TestClass
-      include Qa::Authorities::LocalSubauthority
-    end
-  end
-
-  after { Object.send(:remove_const, :TestClass) }
-
-  let(:test) { TestClass.new }
-
-  before { @original_path = AUTHORITIES_CONFIG[:local_path] }
-  after { AUTHORITIES_CONFIG[:local_path] = @original_path }
-
-  describe "#subauthorities_path" do
-    before { AUTHORITIES_CONFIG[:local_path] = path }
-    context "configured with a full path" do
-      let(:path) { "/full/path" }
-
-      it "returns a full path" do
-        expect(test.subauthorities_path).to eq(path)
-      end
-    end
-
-    context "configured with a relative path" do
-      let(:path) { "relative/path" }
-
-      it "returns a path relative to the Rails applicaition" do
-        expect(test.subauthorities_path).to eq(File.join(Rails.root, path))
-      end
-    end
-  end
-
-  describe "#names" do
-    it "returns a list of yaml files" do
-      expect(test.names).to include("authority_A", "authority_B", "authority_C", "authority_D", "states")
-    end
-
-    context "when the path doesn't exist" do
-      before { AUTHORITIES_CONFIG[:local_path] = '/foo/bar' }
-
-      it "raises an error" do
-        expect { test.names }.to raise_error Qa::ConfigDirectoryNotFound
-      end
-    end
-  end
-
-end