qa 0.4.2 → 0.4.3

data/spec/lib/authorities_loc_spec.rb

@@ -53,10 +53,9 @@ describe Qa::Authorities::Loc do
       end
 
       it "should retain the raw respsonse from the LC service in JSON" do
-        expect(authority.raw_response).to be_nil
-        json = Qa::Authorities::WebServiceBase.new.get_json(authority.build_query_url("s"))
-        authority.search("s")
-        expect(authority.raw_response).to eq(json)
+        expect { authority.search("s") }.to change { authority.raw_response }.
+          from(nil).
+          to(JSON.parse(webmock_fixture("loc-response.txt").read))
       end
 
       describe "the returned results" do

data/spec/lib/authorities_local_subauthorities_spec.rb

@@ -2,42 +2,50 @@ require 'spec_helper'
 
 describe Qa::Authorities::LocalSubauthority do
 
-  let :test do
+  before do
     class TestClass
       include Qa::Authorities::LocalSubauthority
     end
-    TestClass.new
   end
 
+  after { Object.send(:remove_const, :TestClass) }
+
+  let(:test) { TestClass.new }
+
+  before { @original_path = AUTHORITIES_CONFIG[:local_path] }
+  after { AUTHORITIES_CONFIG[:local_path] = @original_path }
+
   describe "#sub_authorities_path" do
-    before do
-      @original_path = AUTHORITIES_CONFIG[:local_path]
-    end
-    after do
-      AUTHORITIES_CONFIG[:local_path] = @original_path
-    end
+    before { AUTHORITIES_CONFIG[:local_path] = path }
     context "configured with a full path" do
-      before do
-        AUTHORITIES_CONFIG[:local_path] = "/full/path"
-      end
+      let(:path) { "/full/path" }
+
       it "returns a full path" do
-        expect(test.sub_authorities_path).to eq(AUTHORITIES_CONFIG[:local_path])
+        expect(test.sub_authorities_path).to eq(path)
       end
     end
+
     context "configured with a relative path" do
-      before do
-        AUTHORITIES_CONFIG[:local_path] = "relative/path"
-      end
+      let(:path) { "relative/path" }
+
       it "returns a path relative to the Rails applicaition" do
-        expect(test.sub_authorities_path).to eq(File.join(Rails.root, AUTHORITIES_CONFIG[:local_path]))
+        expect(test.sub_authorities_path).to eq(File.join(Rails.root, path))
       end
     end
   end
 
-  describe "#names" do  
+  describe "#names" do
     it "returns a list of yaml files" do
       expect(test.names).to include("authority_A", "authority_B", "authority_C", "authority_D", "states")
     end
+
+    context "when the path doesn't exist" do
+      before { AUTHORITIES_CONFIG[:local_path] = '/foo/bar' }
+
+      it "raises an error" do
+        expect { test.names }.to raise_error Qa::ConfigDirectoryNotFound
+      end
+    end
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: qa
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Stephen Anderson
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-06 00:00:00.000000000 Z
+date: 2015-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -213,6 +213,7 @@ files:
 - lib/generators/qa/local/templates/config/authorities/states.yml
 - lib/qa.rb
 - lib/qa/authorities.rb
+- lib/qa/authorities/authority_with_sub_authority.rb
 - lib/qa/authorities/base.rb
 - lib/qa/authorities/getty.rb
 - lib/qa/authorities/loc.rb