pycall 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f55fc9d9a1eb95adf30ecec437c5fe5aa459e4a5
-  data.tar.gz: c49a974635e8e4fe7c9fc9fc98c6afbc47bc9c5d
+  metadata.gz: fc7457af2e316e61b4e58a0a11075914fad55c34
+  data.tar.gz: 17adfb758a2822733fdeb79ff2d2bc261d6230af
 SHA512:
-  metadata.gz: '09f4f8fa2e3d9353ba31791ba3e689f5b36271ed0170685b82d7580ba3c1afa69f3acd0c39488313c5908143d52cce6a78d2f496b99c0c3975c17a9a2d9f70eb'
-  data.tar.gz: '028d50abd8e1dc5e39eb7161b3f384ac6f4918107dab120c95341a0011f071a63b9fee0feffc1d11b8acce5bff81c9e9ca040625bc1238e8ab71c6b50ccd307b'
+  metadata.gz: 5e309b2814a7ed985e6d3f4c763cbc68f3a354d1beebb1330230825085351a823cae292875bb41984ae308e8d668c83f11e064bb863f9e5e82bb7a3feaad247b
+  data.tar.gz: 0ce1b87b5df41852c11995b794921a929f30a710f53641cdec4b2ed626689493c302e66d359eacfcf66addd062605c5538b5eceb1603c05164d999a1dd9b2895

data/.travis.yml

@@ -12,9 +12,9 @@ env:
   global:
   - PYCALL_DEBUG_FIND_LIBPYTHON=1
   matrix:
-  - PYTHON=python
-  - PYTHON=python3 LIBPYTHON=wrong_value
-  - LIBPYTHON=/opt/python/3.5.3/lib/libpython3.5m.so
+  - PYTHON=python PYENV_VERSION=system
+  - PYTHON=python3 PYENV_VERSION=3.5.3 LIBPYTHON=wrong_value
+  - PYENV_VERSION=3.5.3 LIBPYTHON=/opt/python/3.5.3/lib/libpython3.5m.so
 
 addons:
   apt:
@@ -33,8 +33,8 @@ before_script:
   - echo === python investigator.py ===
   - python lib/pycall/python/investigator.py
   - python3 lib/pycall/python/investigator.py
-  - pip install numpy
-  - pip3 install numpy
+  - travis_retry pip install --user numpy
+  - PYENV_VERSION=3.5.3 travis_retry pip3 install --user numpy
 
 matrix:
   allow_failures:

data/CHANGES.md

@@ -1,5 +1,10 @@
 # The change history of PyCall
 
+## 1.0.2
+
+* Fix the bug that a large Python string is broken when it converted to Ruby string
+  https://github.com/mrkn/pycall.rb/issues/32
+
 ## 1.0.1
 
 * Add PyTypeObject#===.

data/README.md

@@ -1,7 +1,7 @@
 # PyCall: Calling Python functions from the Ruby language
 
-[![Build Status](https://travis-ci.org/mrkn/pycall.svg?branch=master)](https://travis-ci.org/mrkn/pycall)
-[![Build status](https://ci.appveyor.com/api/projects/status/071is0f4iu0vy8lp/branch/master?svg=true)](https://ci.appveyor.com/project/mrkn/pycall/branch/master)
+[![Build Status](https://travis-ci.org/mrkn/pycall.rb.svg?branch=1.0)](https://travis-ci.org/mrkn/pycall.rb)
+[![Build status](https://ci.appveyor.com/api/projects/status/naw56ldru71w7qsw/branch/1.0?svg=true)](https://ci.appveyor.com/project/mrkn/pycall-rb/branch/1.0)
 
 This library provides the features to directly call and partially interoperate
 with Python from the Ruby language.  You can import arbitrary Python modules
@@ -77,7 +77,7 @@ version, push git commits and tags, and push the `.gem` file to
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at
-https://github.com/mrkn/pycall.
+https://github.com/mrkn/pycall.rb.
 
 
 ## Acknowledgement

data/ext/pycall/pycall.c

@@ -1,4 +1,5 @@
 #include "pycall_internal.h"
+#include <ruby/encoding.h>
 
 #include <stdarg.h>
 
@@ -1317,7 +1318,10 @@ pycall_pyobject_to_ruby(PyObject *pyobj)
   if (pyobj->ob_type == Py_API(PyLong_Type))
     return pycall_pylong_to_ruby(pyobj);
 
-  if (pyobj->ob_type == Py_API(PyUnicode_Type) || pyobj->ob_type == Py_API(PyString_Type))
+  if (pyobj->ob_type == Py_API(PyUnicode_Type))
+    return pycall_pyunicode_to_ruby(pyobj);
+
+  if (pyobj->ob_type == Py_API(PyString_Type))
     return pycall_pystring_to_ruby(pyobj);
 
   Py_API(Py_IncRef)(pyobj);
@@ -1469,24 +1473,46 @@ pycall_pystring_to_ruby(PyObject *pyobj)
 {
   char *str = NULL;
   Py_ssize_t len = 0;
-  int res = -1;
+  int res;
+
+  /* TODO: PyString_Check */
+  if (pyobj->ob_type != Py_API(PyString_Type)) {
+    return Qnil;
+  }
+
+  res = Py_API(PyString_AsStringAndSize)(pyobj, &str, &len);
+  if (res < 0) {
+    return Qnil;
+  }
+
+  return rb_enc_str_new(str, len, rb_enc_from_index(rb_ascii8bit_encindex()));
+}
+
+VALUE
+pycall_pyunicode_to_ruby(PyObject *pyobj)
+{
+  char *str = NULL;
+  Py_ssize_t len = 0;
+  int res;
 
   /* TODO: PyUnicode_Check */
-  if (pyobj->ob_type == Py_API(PyUnicode_Type)) {
-    pyobj = Py_API(PyUnicode_AsUTF8String)(pyobj);
-    res = Py_API(PyString_AsStringAndSize)(pyobj, &str, &len);
-    pycall_Py_DecRef(pyobj);
+  if (pyobj->ob_type != Py_API(PyUnicode_Type)) {
+    return Qnil;
   }
-  /* TODO: PyString_Check */
-  else if (pyobj->ob_type == Py_API(PyString_Type)) {
-    res = Py_API(PyString_AsStringAndSize)(pyobj, &str, &len);
+
+  pyobj = Py_API(PyUnicode_AsUTF8String)(pyobj);
+  if (!pyobj) {
+    Py_API(PyErr_Clear)();
+    return Qnil;
   }
 
+  res = Py_API(PyString_AsStringAndSize)(pyobj, &str, &len);
   if (res < 0) {
+    pycall_Py_DecRef(pyobj);
     return Qnil;
   }
 
-  return rb_str_new(str, len);
+  return rb_enc_str_new(str, len, rb_enc_from_index(rb_utf8_encindex()));
 }
 
 static VALUE

data/ext/pycall/pycall_internal.h

@@ -646,6 +646,7 @@ VALUE pycall_pyfloat_to_ruby(PyObject *);
 VALUE pycall_pyint_to_ruby(PyObject *);
 VALUE pycall_pylong_to_ruby(PyObject *);
 VALUE pycall_pystring_to_ruby(PyObject *);
+VALUE pycall_pyunicode_to_ruby(PyObject *);
 VALUE pycall_pyobject_to_a(PyObject *);
 
 VALUE pycall_conv_to_str(VALUE);

data/lib/pycall.rb

@@ -89,3 +89,5 @@ module PyCall
     end
   end
 end
+
+require 'pycall/iruby_helper' if defined? IRuby

data/lib/pycall/iruby_helper.rb

@@ -5,21 +5,19 @@ module PyCall
   module IRubyHelper
     private
 
-    def check_pyobject_respond_to_format_method(obj, method_name)
-      return false unless obj.kind_of? PyObject
-      return false unless PyCall.hasattr?(obj, method_name)
-      PyCall.getattr(obj, method_name).kind_of? PyCall::LibPython.PyMethod_Type
+    def check_python_object_respond_to_format_method(obj, method_name)
+      return false unless obj.kind_of? PyObjectWrapper
+      return false unless obj.respond_to? method_name
+      true
     end
 
-    def register_pyobject_formatter(format_name, mime, priority_value=0)
+    def register_python_object_formatter(format_name, mime, priority_value=0)
       method_name = :"_repr_#{format_name}_"
       match do |obj|
-        check_pyobject_respond_to_format_method(obj, method_name)
+        check_python_object_respond_to_format_method(obj, method_name)
       end
       priority priority_value
-      format mime do |obj|
-        PyCall.getattr(obj, method_name).()
-      end
+      format mime, &method_name
     end
   end
 end
@@ -27,14 +25,14 @@ end
 ::IRuby::Display::Registry.module_eval do
   extend PyCall::IRubyHelper
 
-  register_pyobject_formatter :html, 'text/html'
-  register_pyobject_formatter :markdown, 'text/markdown'
-  register_pyobject_formatter :svg, 'image/svg+xml'
-  register_pyobject_formatter :png, 'image/png'
-  register_pyobject_formatter :jpeg, 'image/jpeg'
-  register_pyobject_formatter :latex, 'text/latex'
-  register_pyobject_formatter :json, 'application/json'
-  register_pyobject_formatter :javascript, 'application/javascript'
-  register_pyobject_formatter :pdf, 'application/pdf'
-  register_pyobject_formatter :pretty, 'text/plain', -1000
+  register_python_object_formatter :html, 'text/html', 1
+  register_python_object_formatter :markdown, 'text/markdown', 1
+  register_python_object_formatter :svg, 'image/svg+xml', 1
+  register_python_object_formatter :png, 'image/png', 1
+  register_python_object_formatter :jpeg, 'image/jpeg', 1
+  register_python_object_formatter :latex, 'text/latex', 1
+  register_python_object_formatter :json, 'application/json', 1
+  register_python_object_formatter :javascript, 'application/javascript', 1
+  register_python_object_formatter :pdf, 'application/pdf', 1
+  register_python_object_formatter :pretty, 'text/plain', -1000
 end

data/lib/pycall/version.rb

@@ -1,3 +1,3 @@
 module PyCall
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pycall
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Kenta Murata
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-09-08 00:00:00.000000000 Z
+date: 2017-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -215,7 +215,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: pycall