pwwka 0.22.3 → 0.22.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2671782bb95ef71a6afbe4908d3652238dbb801091b9fce6823e9f7a7061750c
-  data.tar.gz: 6c44c128ea03d6ffb0d9858bf56c4b38ac004f829167761549f3051a82903c48
+  metadata.gz: 4360e4e1bf6417591a5a20093a59b955c74b0dee9d620b6c517818535b26e4a4
+  data.tar.gz: 21599e4304fc3dd70ca7da613bf58d0eb91011b7cbf857713337cd4f65b37f16
 SHA512:
-  metadata.gz: d88737eeed3ecb7b8eeab1a174dc574dbf38755cae27a374d2cb20841e157e05cc971c5467f81b227cc14389b2b89381da15902de67b5118b498f026b4c5d7a5
-  data.tar.gz: c414a254d881bbf7723ec31a94cfea7f5d46a4d2afc7f527c8e2b4d1d5c02a92d663ec12f422fa444c47e8950edb130285c5c057364b83b2bb70b39b6ed58bd2
+  metadata.gz: 8dbac3016d4ae303afc1d4a3c3e578c499075d2953d44c0d29b9f43746a3b6d72e96159cecd739c0dc3f7fe6d57500b24cc8b97ae35e99a9e5281572c3d4b9be
+  data.tar.gz: a6031931aa591d94868317baebe7d3540fffa16bad9397475ddeb501b741814a5fb2b935c4686b128a385c701ce66905df5a24140ed4e9c65eb4cb0a17bc1ba5

data/lib/pwwka/channel_connector.rb

@@ -19,15 +19,19 @@ module Pwwka
         @connection = Bunny.new(configuration.rabbit_mq_host, connection_options)
         @connection.start
       rescue => e
-        logf "ERROR Connecting to RabbitMQ", error: e
+        logf "ERROR Connecting to RabbitMQ: #{e}", at: :error
+
         @connection.close if @connection
         raise e
       end
 
       begin
         @channel = @connection.create_channel
+        @channel.on_error do |ch, method|
+          logf "ERROR On RabbitMQ channel: #{method.inspect}"
+        end
       rescue => e
-        logf "ERROR Opening RabbitMQ channel", error: e
+        logf "ERROR Opening RabbitMQ channel: #{e}", at: :error
         @connection.close if @connection
         raise e
       end
@@ -81,14 +85,13 @@ module Pwwka
       begin
         channel.close
       rescue => e
-        logf "ERROR Closing RabbitMQ channel", error: e
-        raise e
+        logf "ERROR Closing RabbitMQ channel: #{e}", at: :error
       end
 
       begin
         connection.close
       rescue => e
-        logf "ERROR Closing connection to RabbitMQ", error: e
+        logf "ERROR Closing connection to RabbitMQ: #{e}", at: :error
         raise e
       end
     end

data/lib/pwwka/version.rb

@@ -1,4 +1,4 @@
 module Pwwka
-  VERSION = '0.22.3'
+  VERSION = '0.22.4'
 end
 

data/spec/unit/channel_connector_spec.rb

@@ -14,6 +14,7 @@ describe Pwwka::ChannelConnector do
       allow(bunny_session).to receive(:start)
       allow(bunny_session).to receive(:close)
       allow(bunny_session).to receive(:create_channel).and_return(bunny_channel)
+      allow(bunny_channel).to receive(:on_error)
     end
 
     it "sets a prefetch value if configured to do so" do
@@ -22,6 +23,11 @@ describe Pwwka::ChannelConnector do
       described_class.new(prefetch: 10)
     end
 
+    it "sets an on_error handler" do
+      expect(bunny_channel).to receive(:on_error)
+      described_class.new
+    end
+
     it "does not set a prefetch value unless configured" do
       expect(bunny_channel).not_to receive(:prefetch).with(10)
 
@@ -67,10 +73,14 @@ describe Pwwka::ChannelConnector do
   end
 
   describe "raise_if_delayed_not_allowed" do
+    let(:bunny_channel) { instance_double(Bunny::Channel) }
+
     before do
       allow(Bunny).to receive(:new).and_return(bunny_session)
       allow(bunny_session).to receive(:start)
-      allow(bunny_session).to receive(:create_channel)
+      allow(bunny_session).to receive(:close)
+      allow(bunny_session).to receive(:create_channel).and_return(bunny_channel)
+      allow(bunny_channel).to receive(:on_error)
       @default_allow_delayed = Pwwka.configuration.options[:allow_delayed]
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pwwka
 version: !ruby/object:Gem::Version
-  version: 0.22.3
+  version: 0.22.4
 platform: ruby
 authors:
 - Stitch Fix Engineering