pwwka 0.18.0 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b139453f92c1d63b9c1480164bb5a31e88761621fb27f7614343b5d0b71f4638
-  data.tar.gz: d253aa29930a718c890f026b83b51c0ed919f8b60b87bb8c4d02ce78128cb76d
+  metadata.gz: 5765ddd484db315254a41e9d4e445ca89d7fef1af2f24619de73bf1699f5ae5e
+  data.tar.gz: 7544a009754d7094524a6732a5ea40844abb324e14e97fcbaccb10c3f28f56aa
 SHA512:
-  metadata.gz: 91c2138ab501dc84f508a040bd802d973949d8e49a1167f9f5353a2eaa208fd13530e7623be641418e898cfcb0809d228d95df3dfb0840db3ed32548d8d1a0f5
-  data.tar.gz: 6746ec10356e0988b7fd8af41c226fd71fc7d2fecf20c9c75d8ca7d56025cf82ad619dc6081f6258773851f960245c0e47e1cfd2a5aae707ed5db6d62d2bc698
+  metadata.gz: 9e86c5de727b0d355fa2af8cb5bd3bc99da6f34d539d3f65f025012f47e9fa7517d91d571cb28d778f3dabcb3caa88498a5ad8ce1509e42f941f05d34d6eb985
+  data.tar.gz: 2cfedd5609d5c3b13c8beb42a0873798cc6ae6d5a4309a5bb15138b88e4e6a1f259689494a23254c70693d4f7f46f7e7d3a894cfff6d794c5747fecdf24aa4d8

data/.gitignore

@@ -8,7 +8,7 @@ db
 .tddium*
 .DS_Store
 .jhw-cache
-**.orig
+*.orig
 .rspec
 .bundle
 coverage

data/lib/pwwka/channel_connector.rb

@@ -8,9 +8,10 @@ module Pwwka
     # The channel_connector starts the connection to the message_bus
     # so it should only be instantiated by a method that has a strategy
     # for closing the connection
-    def initialize(prefetch: nil)
+    def initialize(prefetch: nil, connection_name: nil)
       @configuration     = Pwwka.configuration
       connection_options = {automatically_recover: false}.merge(configuration.options)
+      connection_options = {client_properties: {connection_name: connection_name}}.merge(connection_options) if connection_name
       @connection        = Bunny.new(configuration.rabbit_mq_host,
                                   connection_options)
       @connection.start

data/lib/pwwka/receiver.rb

@@ -12,7 +12,7 @@ module Pwwka
     def initialize(queue_name, routing_key, prefetch: Pwwka.configuration.default_prefetch)
       @queue_name        = queue_name
       @routing_key       = routing_key
-      @channel_connector = ChannelConnector.new(prefetch: prefetch)
+      @channel_connector = ChannelConnector.new(prefetch: prefetch, connection_name: "c: #{queue_name}")
       @channel           = @channel_connector.channel
       @topic_exchange    = @channel_connector.topic_exchange
     end

data/lib/pwwka/transmitter.rb

@@ -26,7 +26,7 @@ module Pwwka
     attr_reader :channel_connector
 
     def initialize
-      @channel_connector = ChannelConnector.new
+      @channel_connector = ChannelConnector.new(connection_name: "p: #{Pwwka.configuration.app_id}")
     end
 
     # Send an important message that must go through.  This method allows any raised exception 

data/lib/pwwka/version.rb

@@ -1,3 +1,3 @@
 module Pwwka
-  VERSION = '0.18.0'
+  VERSION = '0.19.0'
 end

data/spec/unit/channel_connector_spec.rb

@@ -26,6 +26,25 @@ describe Pwwka::ChannelConnector do
 
       described_class.new
     end
+
+    it "sets a connection_name if configured to do so" do
+      expect(Bunny).to receive(:new).with(
+        /amqp:\/\/guest:guest@localhost:/, 
+        {:client_properties=>{:connection_name=>"test_connection"},
+         :automatically_recover=>false,
+         :allow_delayed=>true})
+
+      described_class.new(connection_name: "test_connection")
+    end
+
+    it "only contains default options if none provided" do
+      expect(Bunny).to receive(:new).with(
+        /amqp:\/\/guest:guest@localhost:/, 
+        {:automatically_recover=>false, :allow_delayed=>true})
+
+      described_class.new
+    end
+
   end
 
   describe "raise_if_delayed_not_allowed" do

data/spec/unit/receiver_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper.rb'
+
+describe Pwwka::Receiver do
+  describe "#new" do 
+    let(:channel_connector) { double(Pwwka::ChannelConnector)}
+
+    before do
+      allow(Pwwka::ChannelConnector).to receive(:new).with(prefetch: nil, connection_name: "c: test_queue_name").and_return(channel_connector)
+      allow(channel_connector).to receive(:channel)
+      allow(channel_connector).to receive(:topic_exchange)
+    end
+
+    it "should set the connection_name" do
+      Pwwka::Receiver.new("test_queue_name", "test.routing.key")
+    end
+  end
+end

data/spec/unit/transmitter_spec.rb

@@ -20,7 +20,7 @@ describe Pwwka::Transmitter do
     allow(logger).to receive(:info)
     allow(logger).to receive(:warn)
     allow(logger).to receive(:error)
-    allow(Pwwka::ChannelConnector).to receive(:new).and_return(channel_connector)
+    allow(Pwwka::ChannelConnector).to receive(:new).with(connection_name: "p: MyAwesomeApp").and_return(channel_connector)
     allow(channel_connector).to receive(:connection_close)
     allow(topic_exchange).to receive(:publish)
     allow(delayed_exchange).to receive(:publish)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pwwka
 version: !ruby/object:Gem::Version
-  version: 0.18.0
+  version: 0.19.0
 platform: ruby
 authors:
 - Stitch Fix Engineering
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-05 00:00:00.000000000 Z
+date: 2018-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bunny
@@ -264,6 +264,7 @@ files:
 - spec/unit/logging_spec.rb
 - spec/unit/message_queuer_spec.rb
 - spec/unit/queue_resque_job_handler_spec.rb
+- spec/unit/receiver_spec.rb
 - spec/unit/send_message_async_job_spec.rb
 - spec/unit/test_handler_message_spec.rb
 - spec/unit/transmitter_spec.rb
@@ -311,6 +312,7 @@ test_files:
 - spec/unit/logging_spec.rb
 - spec/unit/message_queuer_spec.rb
 - spec/unit/queue_resque_job_handler_spec.rb
+- spec/unit/receiver_spec.rb
 - spec/unit/send_message_async_job_spec.rb
 - spec/unit/test_handler_message_spec.rb
 - spec/unit/transmitter_spec.rb