pushr-core 1.0.0.pre.3 → 1.0.0.pre.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 85274765fb5539ffa61905eecaff1906c03e6d03
-  data.tar.gz: 021a862b5e1398dfff9458feabd115aba12a4e2b
+  metadata.gz: c4013d245094a4659d51610f6448da91813c933e
+  data.tar.gz: dad963d156b9b3d0fda568a7fdbc2426d8ef8230
 SHA512:
-  metadata.gz: 44b509c4f4229aa001e43800ceceed7718615ab03333ff6dbe6949389e8d48529f01e3976fa452a609db35203ab887857b6619ea898e940a6fe2a02fe0e0d26d
-  data.tar.gz: 16525744b386b639176cfdb901c32977c7428735a3046c227614dc864e37f9c6a9cb4f7ec6b32c6f60566e2ee21ca7a1ca6abcd30fdd5f650f8a0bc9cd99dfdf
+  metadata.gz: 03bb413cee574cbe9c314fd52352e91ba0265d345afff11b2db1d811800eaede790823367d6c9ab96d33658b178172ba45637424429a34994b18c10947b4f60c
+  data.tar.gz: 568ff09d71fd0546c0c6508f29d0c5cf2579f80159cb763e75772338132530d36dd353969c3ef87c0c784c1f9f73beaf07f3845e7f7a634cc114a39e340d1912

data/README.md

@@ -43,13 +43,21 @@ it will use that. The configuration is stored in Redis and you add the configura
 APNS ([see](https://github.com/9to5/pushr-core#generating-certificates)):
 ```ruby
 Pushr::ConfigurationApns.create(app: 'app_name', connections: 2, enabled: true,
-    certificate: File.read('certificate.pem'), feedback_poll: 60, sandbox: false)
+    certificate: File.read('certificate.pem'), sandbox: false, skip_check_for_error: false)
 ```
 
-The `skip_check_for_error` parameter is optional and can be set to `true` or `false`. If set to `true` the APNS service
+The `skip_check_for_error` parameter can be set to `true` or `false`. If set to `true` the APNS service
 will not check for errors when sending messages. This option should be used in a production environment and improves
 performance. In production the errors are reported and handled by the feedback service. Please note that if you use
-sandbox devices in your production environment you should not `skip_check_for_error`.
+sandbox devices in your production environment you should not set `skip_check_for_error = true`.
+
+APNS Feedback:
+```ruby
+Pushr::ConfigurationApnsFeedback.create(app: 'app_name', connections: 1, enabled: true,
+    feedback_poll: 60)
+```
+
+Use this configuration to let a thread check for feedback on all APNS Configurations. It checks every `feedback_poll` in seconds.
 
 GCM ([see](http://developer.android.com/guide/google/gcm/gs.html)):
 ```ruby
@@ -131,4 +139,5 @@ Push runs on Heroku with the following line in the `Procfile`.
 
 ## Prerequisites
 
-* Ruby 1.9.x
+* Ruby 1.9.3, 2.0, 2.1
+* Redis

data/lib/pushr/configuration.rb

@@ -9,7 +9,7 @@ module Pushr
 
     def initialize(attributes = {})
       attributes.each do |name, value|
-        send("#{name}=", value)
+        send("#{name}=", value) if respond_to?("#{name}=")
       end
     end
 

data/lib/pushr/daemon/app.rb

@@ -1,27 +1,25 @@
 module Pushr
   module Daemon
     class App
-      @apps = {}
+      @apps = []
 
       class << self
         attr_reader :apps
 
         def load
-          Configuration.all.each do |config|
-            @apps["#{config.app}:#{config.name}"] = App.new(config) if config.enabled == true
-          end
+          @apps = Configuration.all.keep_if { |c| c.enabled == true }.map { |c| App.new(c) }
         end
 
         def total_connections
-          @apps.values.map(&:connections).inject(0, :+)
+          @apps.map(&:connections).inject(0, :+)
         end
 
         def start
-          @apps.values.map(&:start)
+          @apps.map(&:start)
         end
 
         def stop
-          @apps.values.map(&:stop)
+          @apps.map(&:stop)
         end
       end
 
@@ -37,19 +35,10 @@ module Pushr
 
       def start
         @provider = load_provider(@config.name, @config)
-
-        @config.connections.times do |i|
-          connection = @provider.connectiontype.new(@config, i + 1)
-          connection.connect
-
-          handler = MessageHandler.new("pushr:#{@config.app}:#{@config.name}", connection, @config.app, i + 1)
-          handler.start
-          @handlers << handler
-        end
+        @provider.start
       end
 
       def stop
-        @handlers.map(&:stop)
         @provider.stop
       end
 
@@ -60,7 +49,7 @@ module Pushr
           middleware = Pushr::Daemon.const_get("#{klass}".camelize)
         rescue NameError
           message = "Could not find matching push provider for #{klass.inspect}. " \
-                    "You may need to install an additional gem (such as push-#{klass})."
+                    "You may need to install an additional gem (such as pushr-#{klass})."
           raise LoadError, message
         end
 

data/lib/pushr/daemon/delivery_error.rb

@@ -1,7 +1,7 @@
 module Pushr
   module Daemon
     class DeliveryError < StandardError
-      attr_reader :code, :message, :description, :source, :notify
+      attr_reader :code, :description, :source, :notify
 
       def initialize(code, message, description, source, notify = true)
         @code = code

data/lib/pushr/daemon/settings.rb

@@ -1,7 +1,8 @@
 module Pushr
   module Daemon
     class Settings
-      attr_accessor :foreground, :pid_file, :error_notification, :feedback_processor, :stats_processor
+      attr_reader :pid_file
+      attr_accessor :foreground, :error_notification, :feedback_processor, :stats_processor
 
       def initialize
         @foreground = false

data/lib/pushr/feedback.rb

@@ -8,7 +8,7 @@ module Pushr
 
     def initialize(attributes = {})
       attributes.each do |name, value|
-        send("#{name}=", value)
+        send("#{name}=", value) if respond_to?("#{name}=")
       end
     end
 

data/lib/pushr/message.rb

@@ -6,7 +6,7 @@ module Pushr
 
     def initialize(attributes = {})
       attributes.each do |name, value|
-        send("#{name}=", value)
+        send("#{name}=", value) if respond_to?("#{name}=")
       end
     end
 
@@ -19,6 +19,11 @@ module Pushr
       end
     end
 
+    def save!
+      save || fail(RecordNotSaved)
+      # fail 'x' unless save
+    end
+
     def self.next(queue_name, timeout = 3)
       Pushr::Core.redis do |conn|
         message = conn.blpop(queue_name, timeout: timeout)

data/lib/pushr/version.rb

@@ -1,3 +1,3 @@
 module Pushr
-  VERSION = '1.0.0.pre.3'
+  VERSION = '1.0.0.pre.4'
 end

data/spec/support/pushr_dummy.rb

@@ -1,16 +1,27 @@
 module Pushr
   module Daemon
     class Dummy
-      attr_accessor :configuration
+      attr_accessor :configuration, :handlers
+
       def initialize(options)
-        self.configuration = options
+        @configuration = options
+        @handlers = []
       end
 
-      def connectiontype
-        DummySupport::ConnectionDummy
+      def start
+        configuration.connections.times do |i|
+          connection = DummySupport::ConnectionDummy.new(configuration, i + 1)
+          connection.connect
+
+          handler = MessageHandler.new("pushr:#{configuration.app}:#{configuration.name}", connection, configuration.app, i + 1)
+          handler.start
+          @handlers << handler
+        end
       end
 
-      def stop; end
+      def stop
+        @handlers.map(&:stop)
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pushr-core
 version: !ruby/object:Gem::Version
-  version: 1.0.0.pre.3
+  version: 1.0.0.pre.4
 platform: ruby
 authors:
 - Tom Pesman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-19 00:00:00.000000000 Z
+date: 2014-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis