pushpop-slack 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bb3171272177bd57c83136502ab62ecd176a9a0f
-  data.tar.gz: 414f282b050664a3c1bd52399f0f20f9ed918705
+  metadata.gz: 658012ae74ae71ac2c98d20806723256d045224a
+  data.tar.gz: d4677b9f68af36119b758b639bef9f936b1b9b7a
 SHA512:
-  metadata.gz: 576df515bcfba1373f7e4d9d46767d18439f02bbf534c0206d39bff540fa6848e138ebb36397a6fec54e1ac8edc6b92307ac435c666da7922e5a3acae1f81690
-  data.tar.gz: 92fd5604ab64c8b8a15c4d77ec774eb7a23b736021d59d69d243fa26ef44f0fc6bfd1931dc47c8c6689f4546f80d3fde8772b1a9a73a55375c0220060ada2cde
+  metadata.gz: f0f5e83d54726f31a07c9e85c71d97576c69caba6019ddd5766bdc59bd1f647d58b3afd1bab42d76b891c122dd3646b76fd3f939e6cf3bce7f692468ea241cb0
+  data.tar.gz: f31d224af9df3cbf7403ab9070c1c298f04275ec38f4e47b6f637f85677ae30b27b38211c7141f605ca6616082682aa932a3c72ea2569d627435a3c23da3f0fb

data/lib/pushpop-slack/version.rb

@@ -1,5 +1,5 @@
 module Pushpop
   class Slack
-    VERSION = '0.2.1'
+    VERSION = '0.2.2'
   end
 end

data/lib/pushpop-slack.rb

@@ -23,19 +23,23 @@ module Pushpop
 
       ret = configure(last_response, step_responses)
 
-      unless _message
-       raise 'Please set the message to send to Slack'
+      if _message
+        send_message
+      else
+        Pushpop.logger.debug("No slack message sent - message was not set")
       end
 
-      send_message
-
       ret
     end
 
     def send_message
-      notifier = ::Slack::Notifier.new WEBHOOK_URL
+      unless WEBHOOK_URL.nil? || WEBHOOK_URL.empty?
+        notifier = ::Slack::Notifier.new WEBHOOK_URL
 
-      notifier.ping _message, options
+        notifier.ping _message, options
+      else
+        Pushpop.logger.debug("Could not send slack message - SLACK_WEBHOOK_URL is nil or empty")
+      end
     end
 
     def options

data/spec/pushpop-slack_spec.rb

@@ -1,11 +1,26 @@
 require 'spec_helper'
 
 describe Pushpop::Slack do
-  it 'should make sure there is a message' do
+  it 'should not send if there is no message' do
     step = Pushpop::Slack.new do
     end 
 
-    expect{step.run}.to raise_error
+    expect(step).not_to receive(:send_message)
+
+    step.configure
+    step.run
+  end
+
+  it 'should send if there is a message' do
+    step = Pushpop::Slack.new do
+      message 'nothing'
+    end
+
+    allow(step).to receive(:send_message)
+    expect(step).to receive(:send_message)
+
+    step.configure
+    step.run
   end
 
   it 'should prepend a # to the channel if its not there' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pushpop-slack
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Joe Wegner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-06 00:00:00.000000000 Z
+date: 2015-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pushpop