pushpop-keen 0.2 → 0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2f99b446d23b1ca7d137d3975b44f0416d6c7181
-  data.tar.gz: 3db767ef6814b271c2d7ea6641cffe1457e170d4
+  metadata.gz: b76cb926fd8fe661fc862fd055769473f844e7bd
+  data.tar.gz: 96571c39cf9191e6c54ebe1b73be0111d6dd2811
 SHA512:
-  metadata.gz: c97d92e2f35d54f07fb0035b52afaf0e6a16597544ed1444cd505de453b6a03b44f29ac23bc52ffe3c8b005fabefcad9aaf10953faf6be193860031687c48089
-  data.tar.gz: d884e5c7a1d2f963bcf80287c390227056f9cd0971cb0f1aa28d4761b123e4ee9e542115dc203b577b4dd0ffda85827b261479d833d0f059b2b690ad29047475
+  metadata.gz: 1889e66f20cb170e09b9fb2d2fd2fc89ef6a5e95cbb030dd28d7ff14976729c91ce780eb16ef3d188f7bd61b36ceb406bdd257236a91634cbd9f4de4c1a90d14
+  data.tar.gz: 2092041f9e0c8285acc17ee0b30e28663a5f9ee501949d79a577635cddefaa8b419b9390b35b70c7b585806a249caef1004bf938c3323992247c9657c42e0e4c

data/Gemfile

@@ -1,7 +1,7 @@
 source 'https://rubygems.org'
 
 gem 'pushpop'
-gem 'keen'
+gem 'keen', '>=0.9.2'
 
 group :development, :test do
   gem 'rake'

data/Gemfile.lock

@@ -7,18 +7,18 @@ GEM
       minitest (~> 5.1)
       thread_safe (~> 0.1)
       tzinfo (~> 1.1)
-    addressable (2.3.6)
+    addressable (2.3.8)
     clockwork (0.7.5)
       activesupport
       tzinfo
     diff-lcs (1.2.5)
     i18n (0.6.9)
     json (1.8.1)
-    keen (0.8.2)
+    keen (0.9.2)
       addressable (~> 2.3.5)
       multi_json (~> 1.3)
     minitest (5.3.4)
-    multi_json (1.10.1)
+    multi_json (1.11.2)
     pushpop (0.1.1)
       clockwork
     rake (10.3.2)
@@ -42,7 +42,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  keen
+  keen (>= 0.9.2)
   pushpop
   rake
   rspec

data/README.md

@@ -33,7 +33,8 @@ job 'average response time for successful requests last month' do
     target_property   'request.duration'
     group_by          'check.name'
     interval          'daily'
-    timeframe         'last_month',
+    timeframe         'last_month'
+    max_age           '300', #cache the query for 5 minutes
     filters           [{ property_name: "response.successful",
                          operator: "eq",
                          property_value: true }]
@@ -67,4 +68,4 @@ The `keen` plugin requires that the following environment variables are set:
 
 ### Contributing
 
-Code and documentation issues and pull requests are welcome.
+Code, documentation issues, and pull requests welcome!

data/lib/pushpop-keen.rb

@@ -18,6 +18,7 @@ module Pushpop
     attr_accessor :_filters
     attr_accessor :_steps
     attr_accessor :_analyses
+    attr_accessor :_max_age
 
     def run(last_response=nil, step_responses=nil)
       ret = self.configure(last_response, step_responses)
@@ -46,6 +47,7 @@ module Pushpop
         interval: self._interval,
         filters: self._filters,
         analyses: self._analyses,
+        max_age: self._max_age,
         steps: self._steps
       }.delete_if { |_, v| v.nil? }
     end
@@ -86,6 +88,10 @@ module Pushpop
       self._analyses = analyses
     end
 
+    def max_age(max_age)
+      self._max_age = max_age
+    end
+
   end
 
 end

data/lib/pushpop-keen/version.rb

@@ -1,5 +1,5 @@
 module Pushpop
   class Keen
-    VERSION = '0.2'
+    VERSION = '0.3'
   end
 end

data/spec/pushpop-keen_spec.rb

@@ -4,7 +4,7 @@ describe Pushpop::Keen do
 
   describe '#configure' do
 
-    it 'should set various params' do
+    it 'sets various params' do
 
       step = Pushpop::Keen.new do
         event_collection 'pageviews'
@@ -13,6 +13,7 @@ describe Pushpop::Keen do
         target_property 'trinkets'
         group_by 'referer'
         interval 'hourly'
+        max_age '300'
         filters [{ property_value: 'referer',
                    operator: 'ne',
                    property_value: 'yahoo.com' }]
@@ -23,22 +24,23 @@ describe Pushpop::Keen do
 
       step.configure
 
-      step._event_collection.should == 'pageviews'
-      step._analysis_type.should == 'count'
-      step._timeframe.should == 'last_3_days'
-      step._group_by.should == 'referer'
-      step._interval.should == 'hourly'
-      step._steps.should == [{
+      expect(step._event_collection).to eq('pageviews')
+      expect(step._analysis_type).to eq('count')
+      expect(step._timeframe).to eq('last_3_days')
+      expect(step._group_by).to eq('referer')
+      expect(step._interval).to eq('hourly')
+      expect(step._max_age).to eq('300')
+      expect(step._steps).to eq([{
          event_collection: 'pageviews',
          actor_property: 'user.id'
-        }]
-      step._analyses.should == [{ analysis_type: 'count' }]
+        }])
+      expect(step._analyses).to eq([{ analysis_type: 'count' }])
     end
 
   end
 
   describe '#record' do
-    it 'should record an event with properties' do
+    it 'records an event with properties' do
       step = Pushpop::Keen.new do
         record 'Pageview', useragent: 'Chrome'
       end
@@ -49,21 +51,23 @@ describe Pushpop::Keen do
   end
 
   describe '#run' do
-    it 'should run the query based on the analysis type' do
-      Keen.stub(:count).with('pageviews', {
-          timeframe: 'last_3_days'
-      }).and_return(365)
+    it 'runs the query based on the analysis type' do
+      allow(Keen).to receive(:count) { 365 }
+      #Keen.stub(:count).with('pageviews', {
+      #    timeframe: 'last_3_days'
+      #}).and_return(365)
 
       step = Pushpop::Keen.new('one') do
         event_collection 'pageviews'
         analysis_type 'count'
         timeframe 'last_3_days'
       end
+
       response = step.run
-      response.should == 365
+      expect(response).to eq(365)
     end
 
-    it 'should not try to run a query if the analysis type isnt set' do
+    it 'don\'t run a query if the analysis type isnt set' do
       step = Pushpop::Keen.new do
         group_by 'something'
       end
@@ -74,7 +78,7 @@ describe Pushpop::Keen do
       step.run
     end
 
-    it 'should run funnels directly, instead of using send' do
+    it 'run funnels directly, instead of using send' do
       step = Pushpop::Keen.new('one') do
         analysis_type 'funnel'
         steps [
@@ -99,7 +103,7 @@ describe Pushpop::Keen do
   end
 
   describe '#to_analysis_options' do
-    it 'should include various options' do
+    it 'includes various options' do
       step = Pushpop::Keen.new('one') do end
       step._timeframe = 'last_4_days'
       step._group_by = 'referer'
@@ -111,7 +115,8 @@ describe Pushpop::Keen do
       step._steps = [{ event_collection: 'pageviews',
                        actor_property: 'user.id' }]
       step._analyses = [{ analysis_type: 'count' }]
-      step.to_analysis_options.should == {
+
+      expect(step.to_analysis_options).to eq({
           timeframe: 'last_4_days',
           target_property: 'trinkets',
           group_by: 'referer',
@@ -122,12 +127,12 @@ describe Pushpop::Keen do
           steps: [{ event_collection: 'pageviews',
                        actor_property: 'user.id' }],
           analyses: [{ analysis_type: 'count' }]
-      }
+      })
     end
 
-    it 'should not include nils' do
+    it 'doesn\'t include nils' do
       step = Pushpop::Keen.new('one') do end
-      step.to_analysis_options.should == {}
+      expect(step.to_analysis_options).to eq({})
     end
   end
 end

metadata

@@ -1,41 +1,41 @@
 --- !ruby/object:Gem::Specification
 name: pushpop-keen
 version: !ruby/object:Gem::Version
-  version: '0.2'
+  version: '0.3'
 platform: ruby
 authors:
 - Josh Dzielak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-20 00:00:00.000000000 Z
+date: 2015-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pushpop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: keen
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -44,7 +44,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .travis.yml
+- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -64,17 +64,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Pushpop Keen IO plugin for querying and recording events