purolator_ruby 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a8050c49b95ac96e1b0e9e17214d989cb559649c
-  data.tar.gz: 858fd25b68c2c9fc9e63cb345a3ec453be0b4557
+  metadata.gz: 8fc4eeac1e5ce71eb87107f4d662925fdedb0c99
+  data.tar.gz: 53a77989dbacc488ccb22f93f4336d17057e9727
 SHA512:
-  metadata.gz: d3d2ce23fd8c99f2f56966da09661dfb0fa93e96183041fbcb2849564ca292e4aaada0184884dcc1ad6b0a76d8cfbd23bdab21f9d5d08c5b8cb5690eaef1d1cc
-  data.tar.gz: 1de879eab2f59e2d1869d5dd98cfd0303ebcc80fb66238ef75144028aae88142015440b41803b6f92ba353b44bd816bac2c03af46939689ed86e55ff65bf4e35
+  metadata.gz: b5faffc68d0db22afc08f426745cb060c2b2ec4e2ac71e314cdde8d143cfd8bb36c09be1fa205efe76a741f9cfd747f6350e090d6c291fa659239bea98c96c7a
+  data.tar.gz: 64fb9375838b3fe135597ee30ba5dd0614b279ab4d1e175abdac46415f566998bdb4972c2c44661c125d85cda3ac3bc0545998f1eab7b0884f11afddf8ddf0a6

data/lib/purolator_ruby/create_shipment_request.rb

@@ -16,6 +16,7 @@ module PurolatorRuby
     def send!
       send.tap do |resp|
         if resp.status == :error
+          puts resp
           raise ArgumentError, resp.errors
         end
       end
@@ -32,7 +33,11 @@ module PurolatorRuby
         if response[:shipment_pin]
           CreateShipmentResponse.new(:ok, response[:shipment_pin][:value], payload, nil)
         else
-          errors = response[:response_information][:errors].map {|k, v| v[:description]}
+          begin
+            errors = response[:response_information][:errors].map {|k, v| v[:description]}
+          rescue TypeError
+            errors = response[:response_information][:errors].map(&:to_s)
+          end
           CreateShipmentResponse.new(:error, nil, payload, errors)
         end
       else

data/lib/purolator_ruby/version.rb

@@ -1,3 +1,3 @@
 module PurolatorRuby
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/spec/fixtures/vcr_cassettes/shipping_service_integration.yml

@@ -20,7 +20,7 @@ http_interactions:
       Accept:
       - "*/*"
       Date:
-      - Wed, 22 Jul 2015 07:54:43 GMT
+      - Wed, 22 Jul 2015 11:35:14 GMT
       Soapaction:
       - '"http://purolator.com/pws/service/v1/CreateShipment"'
       Content-Type:
@@ -45,14 +45,14 @@ http_interactions:
       X-Powered-By:
       - ASP.NET
       Date:
-      - Wed, 22 Jul 2015 07:54:44 GMT
+      - Wed, 22 Jul 2015 11:35:14 GMT
     body:
       encoding: UTF-8
       string: <s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"><s:Header><h:ResponseContext
         xmlns:h="http://purolator.com/pws/datatypes/v1" xmlns:i="http://www.w3.org/2001/XMLSchema-instance"><h:ResponseReference>Rating
         Example</h:ResponseReference></h:ResponseContext></s:Header><s:Body><CreateShipmentResponse
         xmlns="http://purolator.com/pws/datatypes/v1" xmlns:i="http://www.w3.org/2001/XMLSchema-instance"><ResponseInformation><Errors/><InformationalMessages
-        i:nil="true"/></ResponseInformation><ShipmentPIN><Value>329018601149</Value></ShipmentPIN><PiecePINs><PIN><Value>329018601149</Value></PIN></PiecePINs><ReturnShipmentPINs/><ExpressChequePIN><Value/></ExpressChequePIN></CreateShipmentResponse></s:Body></s:Envelope>
+        i:nil="true"/></ResponseInformation><ShipmentPIN><Value>329018601172</Value></ShipmentPIN><PiecePINs><PIN><Value>329018601172</Value></PIN></PiecePINs><ReturnShipmentPINs/><ExpressChequePIN><Value/></ExpressChequePIN></CreateShipmentResponse></s:Body></s:Envelope>
     http_version: 
-  recorded_at: Wed, 22 Jul 2015 07:54:44 GMT
+  recorded_at: Wed, 22 Jul 2015 11:35:15 GMT
 recorded_with: VCR 2.9.3

data/spec/purolator_ruby/create_shipment_request_spec.rb

@@ -28,7 +28,7 @@ describe PurolatorRuby::CreateShipmentRequest do
     it "succesfully communicates with ShippingService and returns shipment pin" do
       VCR.use_cassette('shipping_service_integration') do
         response = subject.send!
-        expect(response.shipment_pin).to eq('329018601149')
+        expect(response.shipment_pin).to eq('329018601172')
         expect(response.status).to eq(:ok)
        end
     end
@@ -49,4 +49,16 @@ describe PurolatorRuby::CreateShipmentRequest do
     end
   end
 
+  context "invalid but from soap side" do
+    subject do
+      described_class.new(client: client, sender_address: sender_address, receiver_address: receiver_address, shipping_date: Date.new(2014,01,01), weight: '0', pieces: 0, reference: '1')
+    end
+
+    it "raises ArgumentError" do
+      VCR.use_cassette('shipping_service_integration_2') do
+        expect { subject.send!.status }.to raise_error(ArgumentError)
+      end
+    end
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: purolator_ruby
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Boris Filipov