purizumu 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 41586286c24fbf46df721821901d6a0ef19c30cc9b28f4e186202140dd84f8da
-  data.tar.gz: 9c1e474e116fa9f63c817f64f4e00727ee59e69d4c70577292e8a0446f194934
+  metadata.gz: 13e13e8ac2807b2872602bfc6066e18bb4b9c462c3abb09a4d9dc3922ffa93a8
+  data.tar.gz: 68f318bb8f0bfd86d86cf7e2f5490bcf1d47cc9c804ee8edb83d2c8c0f56b501
 SHA512:
-  metadata.gz: 92e7c2d4c42e313b0381ab3f6e327f897dfac150d41644d1e60ffc2d7b5a99948dd5c5679d61b0a03a4d4b79d2e8eb3490104af6a4930ab58e8a700d99699695
-  data.tar.gz: b7d7b134a4c85de69272411df15a21674188a9cedb3d811b9b58923e37d91774d0e7f27c0e97ff95a0c281a183e134631f380a44807381d0846ed165263f1e3c
+  metadata.gz: 818aaf90a7292954a157faa2787d17b1c9dfa643a865d23c7375c211d6a2f10a95e5fddf41f2c8e820b96c9abc1b6e98412873e183b96fe89bc9baf5da0154c2
+  data.tar.gz: 4a1784db93876921e7d32ea8f1db7ba9276017ce27f360aa081ce4aff4632f7e07d23f30424d36c7dc3db9489497ee3fda58b994ae7ccebc3e40c2b5473e2637

data/lib/purizumu/model_extensions.rb

@@ -5,17 +5,40 @@ module Purizumu
   module ModelExtensions
     def self.included(base)
       base.extend(ClassMethods)
+      base.class_attribute :purizumu_translated_attributes, instance_accessor: false, default: []
     end
 
     # Defines translated attribute readers on Active Record models.
     module ClassMethods
       def attribute_translation(*attribute_names)
-        attribute_names.flatten.each do |attribute_name|
+        translated_attribute_names = attribute_names.flatten.map(&:to_s)
+        self.purizumu_translated_attributes = (
+          purizumu_translated_attributes + translated_attribute_names
+        ).uniq
+
+        after_commit :purizumu_clear_translations_after_commit, on: :update
+
+        translated_attribute_names.each do |attribute_name|
           define_method(attribute_name) do
             Purizumu.translate_attribute(self, attribute_name)
           end
         end
       end
     end
+
+    private
+
+    def purizumu_clear_translations_after_commit
+      changed_translated_attributes = (
+        previous_changes.keys & self.class.purizumu_translated_attributes
+      )
+      return if changed_translated_attributes.empty?
+
+      Purizumu::Translation.where(
+        model_class_name: self.class.name,
+        record_id: id,
+        attribute_name: changed_translated_attributes
+      ).delete_all
+    end
   end
 end

data/lib/purizumu/translator.rb

@@ -11,6 +11,7 @@ module Purizumu
 
     def call
       return source_content if source_content.nil? || source_content == ''
+      return source_content unless record.persisted?
 
       existing_translation&.content || create_translation!.content
     end

data/lib/purizumu/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Purizumu
-  VERSION = '0.1.0'
+  VERSION = '0.1.2'
 end

data/spec/purizumu/translator_spec.rb

@@ -9,11 +9,11 @@ RSpec.describe Purizumu::Translator do
     stub_const('GemRecord', Class.new(ActiveRecord::Base) do
       self.table_name = 'gems'
 
-      attribute_translation :human_name
+      attribute_translation :human_name, :tagline
     end)
   end
 
-  let!(:record) { GemRecord.create!(human_name: 'Prism') }
+  let!(:record) { GemRecord.create!(human_name: 'Prism', tagline: 'Crystal clear', slug: 'prism') }
   let(:translation_scope) do
     Purizumu::Translation.where(
       model_class_name: 'GemRecord',
@@ -109,12 +109,171 @@ RSpec.describe Purizumu::Translator do
 
       expect(Purizumu::Translation.where(record_id: blank_record.id)).to be_empty
     end
+
+    context 'with an unsaved record' do
+      let(:unsaved_record) { GemRecord.new(human_name: 'Prism', slug: 'prism') }
+
+      before do
+        allow(Purizumu).to receive(:engine)
+        I18n.locale = :jp
+        unsaved_record.human_name
+      end
+
+      it 'returns the source content' do
+        expect(unsaved_record.human_name).to eq('Prism')
+      end
+
+      it 'does not invoke the engine' do
+        expect(Purizumu).not_to have_received(:engine)
+      end
+
+      it 'does not create a translation row' do
+        expect(Purizumu::Translation.where(model_class_name: 'GemRecord')).to be_empty
+      end
+    end
+
+    context 'when validations read a translated attribute on create' do
+      before do
+        stub_validated_gem_record
+        allow(Purizumu).to receive(:engine)
+        I18n.locale = :jp
+      end
+
+      it 'does not raise during create' do
+        expect { create_validated_gem_record }.not_to raise_error
+      end
+
+      it 'does not invoke the engine' do
+        create_validated_gem_record
+
+        expect(Purizumu).not_to have_received(:engine)
+      end
+
+      it 'does not create translation rows' do
+        create_validated_gem_record
+
+        expect(Purizumu::Translation.where(model_class_name: 'ValidatedGemRecord')).to be_empty
+      end
+    end
+
+    context 'when callbacks read a translated attribute before validation on create' do
+      before do
+        stub_slugged_gem_record
+        allow(Purizumu).to receive(:engine)
+        I18n.locale = :jp
+      end
+
+      it 'allows the callback to derive values from the source attribute' do
+        expect(create_slugged_gem_record.slug).to eq('crystal-clear')
+      end
+
+      it 'does not invoke the engine' do
+        create_slugged_gem_record
+
+        expect(Purizumu).not_to have_received(:engine)
+      end
+
+      it 'does not create translation rows' do
+        create_slugged_gem_record
+
+        expect(Purizumu::Translation.where(model_class_name: 'SluggedGemRecord')).to be_empty
+      end
+    end
+
+    it 'clears persisted translations for a changed translated attribute after commit' do
+      create_existing_translation
+
+      expect { record.update!(human_name: 'Politics') }
+        .to change { translation_scope.pluck(:attribute_name, :locale, :content) }
+        .from([%w[human_name jp プリズム]]).to([])
+    end
+
+    it 'preserves other translated attribute rows when one translated attribute changes' do
+      create_existing_translation
+      create_tagline_translation
+      record.update!(human_name: 'Politics')
+
+      expect(tagline_translation_rows).to eq([%w[tagline jp とても明快]])
+    end
+
+    it 'regenerates translations from the new source content after invalidation' do
+      prepare_regenerated_translation
+
+      expect(record.human_name).to eq('Политика')
+    end
+
+    it 'persists regenerated translations after invalidation' do
+      prepare_regenerated_translation
+      record.human_name
+
+      expect(
+        translation_scope.find_by!(locale: 'ru').content
+      ).to eq('Политика')
+    end
+
+    it 'does not clear translations when only an untranslated attribute changes' do
+      create_existing_translation
+
+      expect do
+        record.update!(slug: 'renamed-prism')
+      end.not_to(change { translation_scope.pluck(:attribute_name, :locale, :content) })
+    end
   end
 
   def create_existing_translation
     Purizumu::Translation.create!(existing_translation_attributes)
   end
 
+  def stub_validated_gem_record
+    stub_const('ValidatedGemRecord', Class.new(ActiveRecord::Base) do
+      self.table_name = 'gems'
+
+      validates :human_name, presence: true
+      attribute_translation :human_name
+    end)
+  end
+
+  def create_validated_gem_record
+    ValidatedGemRecord.create!(human_name: 'Prism', slug: 'prism')
+  end
+
+  def stub_slugged_gem_record
+    stub_const('SluggedGemRecord', Class.new(ActiveRecord::Base) do
+      self.table_name = 'gems'
+
+      validates :human_name, presence: true
+      before_validation :generate_slug, if: -> { slug.blank? }
+      attribute_translation :human_name
+
+      def generate_slug
+        self.slug = human_name.to_s.parameterize
+      end
+    end)
+  end
+
+  def create_slugged_gem_record
+    SluggedGemRecord.create!(human_name: 'Crystal clear')
+  end
+
+  def prepare_regenerated_translation
+    create_existing_translation
+    allow(Purizumu).to receive(:engine).and_return(
+      instance_double(Purizumu::Engines::Xai, translate: 'Политика')
+    )
+    record.update!(human_name: 'Politics')
+    I18n.locale = :ru
+  end
+
+  def create_tagline_translation
+    Purizumu::Translation.create!(
+      model_class_name: 'GemRecord',
+      record_id: record.id,
+      attribute_name: 'tagline',
+      locale: 'jp',
+      content: 'とても明快'
+    )
+  end
+
   def expected_engine_arguments
     {
       model_name: 'GemRecord',
@@ -124,4 +283,12 @@ RSpec.describe Purizumu::Translator do
       source_locale: 'en'
     }
   end
+
+  def tagline_translation_rows
+    Purizumu::Translation.where(
+      model_class_name: 'GemRecord',
+      record_id: record.id,
+      attribute_name: 'tagline'
+    ).pluck(:attribute_name, :locale, :content)
+  end
 end

data/spec/spec_helper.rb

@@ -24,6 +24,8 @@ RSpec.configure do |config|
       suppress_messages do
         create_table :gems, force: true do |t|
           t.string :human_name
+          t.string :slug
+          t.string :tagline
         end
 
         create_table :purizumu_translations, force: true do |t|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: purizumu
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - OpenAI Codex
@@ -79,7 +79,7 @@ files:
 - spec/purizumu/generators/install_generator_spec.rb
 - spec/purizumu/translator_spec.rb
 - spec/spec_helper.rb
-- spec/tmp/generator/db/migrate/20260412193408_create_purizumu_translations.rb
+- spec/tmp/generator/db/migrate/20260413083431_create_purizumu_translations.rb
 homepage: https://example.com/purizumu
 licenses:
 - MIT