puppetlabs_spec_helper 4.0.1 → 5.0.0

data/lib/puppetlabs_spec_helper/module_spec_helper.rb

@@ -53,19 +53,22 @@ if ENV['SIMPLECOV'] == 'yes'
 end
 
 # Add all spec lib dirs to LOAD_PATH
-components = module_path.split(File::PATH_SEPARATOR).collect do |dir|
+components = module_path.split(File::PATH_SEPARATOR).map do |dir|
   next unless Dir.exist? dir
-  Dir.entries(dir).reject { |f| f =~ %r{^\.} }.collect { |f| File.join(dir, f, 'spec', 'lib') }
+  Dir.entries(dir).reject { |f| f =~ %r{^\.} }.map { |f| File.join(dir, f, 'spec', 'lib') }
 end
 components.flatten.each do |d|
   $LOAD_PATH << d if FileTest.directory?(d) && !$LOAD_PATH.include?(d)
 end
 
 RSpec.configure do |c|
-  c.environmentpath = spec_path if Puppet.version.to_f >= 4.0
+  if ENV['GITHUB_ACTIONS'] == 'true'
+    c.formatter = 'RSpec::Github::Formatter'
+  end
+
+  c.environmentpath = spec_path
   c.module_path = module_path
   c.manifest_dir = File.join(fixture_path, 'manifests')
-  c.parser = 'future' if ENV['FUTURE_PARSER'] == 'yes'
 
   c.before :each do
     if c.mock_framework.framework_name == :rspec
@@ -74,12 +77,7 @@ RSpec.configure do |c|
       Puppet.features.stubs(:root?).returns(true)
     end
 
-    # stringify_facts and trusted_node_data were removed in puppet4
-    if Puppet.version.to_f < 4.0
-      Puppet.settings[:stringify_facts] = false if ENV['STRINGIFY_FACTS'] == 'no'
-      Puppet.settings[:trusted_node_data] = true if ENV['TRUSTED_NODE_DATA'] == 'yes'
-    end
-    Puppet.settings[:strict_variables] = true if ENV['STRICT_VARIABLES'] == 'yes' || (Puppet.version.to_f >= 4.0 && ENV['STRICT_VARIABLES'] != 'no')
+    Puppet.settings[:strict_variables] = true if ENV['STRICT_VARIABLES'] == 'yes' || ENV['STRICT_VARIABLES'] != 'no'
     Puppet.settings[:ordering] = ENV['ORDERING'] if ENV['ORDERING']
   end
 end

data/lib/puppetlabs_spec_helper/puppet_spec_helper.rb

@@ -48,83 +48,7 @@ require 'puppetlabs_spec_helper/puppetlabs_spec/files'
 begin
   require 'puppet/test/test_helper'
 rescue LoadError
-end
-
-# This is just a utility class to allow us to isolate the various version-specific
-# branches of initialization logic into methods without polluting the global namespace.#
-module Puppet
-  class PuppetSpecInitializer
-    # This method is for initializing puppet state for testing for older versions
-    # of puppet that do not support the new TestHelper API.  As you can see,
-    # this involves explicitly modifying global variables, directly manipulating
-    # Puppet's Settings singleton object, and other fun implementation details
-    # that code external to puppet should really never know about.
-    def self.initialize_via_fallback_compatibility(config)
-      warn('Warning: you appear to be using an older version of puppet; spec_helper will use fallback compatibility mode.')
-      config.before :all do
-        # nothing to do for now
-      end
-
-      config.after :all do
-        # nothing to do for now
-      end
-
-      config.before :each do
-        # these globals are set by Application
-        $puppet_application_mode = nil
-        $puppet_application_name = nil
-
-        # REVISIT: I think this conceals other bad tests, but I don't have time to
-        # fully diagnose those right now.  When you read this, please come tell me
-        # I suck for letting this float. --daniel 2011-04-21
-        Signal.stubs(:trap)
-
-        # Set the confdir and vardir to gibberish so that tests
-        # have to be correctly mocked.
-        Puppet[:confdir] = '/dev/null'
-        Puppet[:vardir] = '/dev/null'
-
-        # Avoid opening ports to the outside world
-        Puppet.settings[:bindaddress] = '127.0.0.1'
-      end
-
-      config.after :each do
-        Puppet.settings.clear
-
-        Puppet::Node::Environment.clear
-        Puppet::Util::Storage.clear
-        Puppet::Util::ExecutionStub.reset if Puppet::Util.constants.include? 'ExecutionStub'
-
-        PuppetlabsSpec::Files.cleanup
-      end
-    end
-  end
-end
-
-# JJM Hack to make the stdlib tests run in Puppet 2.6 (See puppet commit cf183534)
-unless Puppet.constants.include? 'Test'
-  module Puppet::Test
-    class LogCollector
-      def initialize(logs)
-        @logs = logs
-      end
-
-      def <<(value)
-        @logs << value
-      end
-    end
-  end
-  Puppet::Util::Log.newdesttype :log_collector do
-    match 'Puppet::Test::LogCollector'
-
-    def initialize(messages)
-      @messages = messages
-    end
-
-    def handle(msg)
-      @messages << msg
-    end
-  end
+  # Continue gracefully
 end
 
 # And here is where we do the main rspec configuration / setup.
@@ -134,15 +58,7 @@ RSpec.configure do |config|
   # `mock_framework`'s autoloading to distinguish between the default, and
   # the module's choice.
   if config.instance_variable_get(:@mock_framework).nil?
-    RSpec.warn_deprecation('puppetlabs_spec_helper: defaults `mock_with` to `:mocha`. See https://github.com/puppetlabs/puppetlabs_spec_helper#mock_with to choose a sensible value for you')
-    config.mock_with :mocha
-  end
-
-  # determine whether we can use the new API or not, and call the appropriate initializer method.
-  if defined?(Puppet::Test::TestHelper)
-    # This case is handled by rspec-puppet since v1.0.0 (via 41257b33cb1f9ade4426b044f70be511b0c89112)
-  else
-    Puppet::PuppetSpecInitializer.initialize_via_fallback_compatibility(config)
+    config.mock_with :rspec
   end
 
   # Here we do some general setup that is relevant to all initialization modes, regardless

data/lib/puppetlabs_spec_helper/puppetlabs_spec/files.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# rubocop:disable Style/GlobalVars # TODO: investigate the use of instance variables
+
 require 'fileutils'
 require 'tempfile'
 require 'pathname'
@@ -20,7 +22,7 @@ module PuppetlabsSpec::Files
 
   def self.cleanup
     $global_tempfiles ||= []
-    while path = $global_tempfiles.pop
+    while (path = $global_tempfiles.pop)
       raise "Not deleting tmpfile #{path} outside regular tmpdir" unless in_tmp(path)
 
       begin

data/lib/puppetlabs_spec_helper/puppetlabs_spec/fixtures.rb

@@ -14,8 +14,8 @@ module PuppetlabsSpec::Fixtures
   # <project>/spec/fixture/unit/facter/foo
   def my_fixture_dir
     callers = caller
-    while line = callers.shift
-      next unless found = line.match(%r{/spec/(.*)_spec\.rb:})
+    while (line = callers.shift)
+      next unless (found = line.match(%r{/spec/(.*)_spec\.rb:}))
 
       return fixtures(found[1])
     end
@@ -47,7 +47,7 @@ module PuppetlabsSpec::Fixtures
       raise "fixture '#{glob}' for #{my_fixture_dir} had no files!"
     end
 
-    block_given? && files.each(&block)
+    block && files.each(&block)
     files
   end
 end

data/lib/puppetlabs_spec_helper/puppetlabs_spec/matchers.rb

@@ -3,23 +3,6 @@
 require 'stringio'
 require 'rspec/expectations'
 
-########################################################################
-# Backward compatibility for Jenkins outdated environment.
-module RSpec
-  module Matchers
-    module BlockAliases
-      if method_defined?(:should) && !method_defined?(:to)
-        alias to should
-      end
-      if method_defined? :should_not
-        alias to_not should_not unless method_defined? :to_not
-        alias not_to should_not unless method_defined? :not_to
-      end
-    end
-  end
-end
-
-########################################################################
 # Custom matchers...
 RSpec::Matchers.define :have_matching_element do |expected|
   match do |actual|

data/lib/puppetlabs_spec_helper/puppetlabs_spec/puppet_internals.rb

@@ -4,74 +4,41 @@
 # 'puppetlabs_spec_helper/puppet_spec_helper' library
 require 'puppetlabs_spec_helper/puppet_spec_helper'
 
-module PuppetlabsSpec
-  module PuppetInternals
-    # parser_scope is intended to return a Puppet::Parser::Scope
-    # instance suitable for placing in a test harness with the intent of
-    # testing parser functions from modules.
-    def scope(parts = {})
-      RSpec.deprecate('scope', replacement: 'rspec-puppet 2.2.0 provides a scope property')
-
-      if %r{^2\.[67]}.match?(Puppet.version)
-        # loadall should only be necessary prior to 3.x
-        # Please note, loadall needs to happen first when creating a scope, otherwise
-        # you might receive undefined method `function_*' errors
-        Puppet::Parser::Functions.autoloader.loadall
-      end
-
-      scope_compiler = parts[:compiler] || compiler
-      scope_parent = parts[:parent] || scope_compiler.topscope
-      scope_resource = parts[:resource] || resource(type: :node, title: scope_compiler.node.name)
-
-      scope = if %r{^2\.[67]}.match?(Puppet.version)
-                Puppet::Parser::Scope.new(compiler: scope_compiler)
-              else
-                Puppet::Parser::Scope.new(scope_compiler)
-              end
-
-      scope.source = Puppet::Resource::Type.new(:node, 'foo')
-      scope.parent = scope_parent
-      scope
-    end
-    module_function :scope
-
-    def resource(parts = {})
-      resource_type = parts[:type] || :hostclass
-      resource_name = parts[:name] || 'testing'
-      Puppet::Resource::Type.new(resource_type, resource_name)
-    end
-    module_function :resource
-
-    def compiler(parts = {})
-      compiler_node = parts[:node] || node
-      Puppet::Parser::Compiler.new(compiler_node)
-    end
-    module_function :compiler
-
-    def node(parts = {})
-      node_name = parts[:name] || 'testinghost'
-      options = parts[:options] || {}
-      node_environment = if Puppet.version.to_f >= 4.0
-                           Puppet::Node::Environment.create(parts[:environment] || 'test', [])
-                         else
-                           Puppet::Node::Environment.new(parts[:environment] || 'test')
-                         end
-      options[:environment] = node_environment
-      Puppet::Node.new(node_name, options)
-    end
-    module_function :node
-
-    # Return a method instance for a given function.  This is primarily useful
-    # for rspec-puppet
-    def function_method(name, parts = {})
-      scope = parts[:scope] || scope()
-      # Ensure the method instance is defined by side-effect of checking if it
-      # exists.  This is a hack, but at least it's a hidden hack and not an
-      # exposed hack.
-      return nil unless Puppet::Parser::Functions.function(name)
+# PuppetInternals provides a set of methods that interface
+# with internal puppet implementations.
+module PuppetlabsSpec::PuppetInternals
+  def resource(parts = {})
+    resource_type = parts[:type] || :hostclass
+    resource_name = parts[:name] || 'testing'
+    Puppet::Resource::Type.new(resource_type, resource_name)
+  end
+  module_function :resource
 
-      scope.method("function_#{name}".intern)
-    end
-    module_function :function_method
+  def compiler(parts = {})
+    compiler_node = parts[:node] || node
+    Puppet::Parser::Compiler.new(compiler_node)
+  end
+  module_function :compiler
+
+  def node(parts = {})
+    node_name = parts[:name] || 'testinghost'
+    options = parts[:options] || {}
+    node_environment = Puppet::Node::Environment.create(parts[:environment] || 'test', [])
+    options[:environment] = node_environment
+    Puppet::Node.new(node_name, options)
+  end
+  module_function :node
+
+  # Return a method instance for a given function.  This is primarily useful
+  # for rspec-puppet
+  def function_method(name, parts = {})
+    scope = parts[:scope] || scope()
+    # Ensure the method instance is defined by side-effect of checking if it
+    # exists.  This is a hack, but at least it's a hidden hack and not an
+    # exposed hack.
+    return nil unless Puppet::Parser::Functions.function(name)
+
+    scope.method("function_#{name}".to_sym)
   end
+  module_function :function_method
 end

data/lib/puppetlabs_spec_helper/rake_tasks.rb

@@ -79,13 +79,11 @@ end
 
 desc 'Run spec tests and clean the fixtures directory if successful'
 task :spec do |_t, args|
-  begin
-    Rake::Task[:spec_prep].invoke
-    Rake::Task[:spec_standalone].invoke(*args.extras)
-    Rake::Task[:spec_clean].invoke
-  ensure
-    Rake::Task[:spec_clean_symlinks].invoke
-  end
+  Rake::Task[:spec_prep].invoke
+  Rake::Task[:spec_standalone].invoke(*args.extras)
+  Rake::Task[:spec_clean].invoke
+ensure
+  Rake::Task[:spec_clean_symlinks].invoke
 end
 
 desc 'Run spec tests with ruby simplecov code coverage'
@@ -98,13 +96,11 @@ end
 
 desc 'Run spec tests in parallel and clean the fixtures directory if successful'
 task :parallel_spec do |_t, args|
-  begin
-    Rake::Task[:spec_prep].invoke
-    Rake::Task[:parallel_spec_standalone].invoke(*args.extras)
-    Rake::Task[:spec_clean].invoke
-  ensure
-    Rake::Task[:spec_clean_symlinks].invoke
-  end
+  Rake::Task[:spec_prep].invoke
+  Rake::Task[:parallel_spec_standalone].invoke(*args.extras)
+  Rake::Task[:spec_clean].invoke
+ensure
+  Rake::Task[:spec_clean_symlinks].invoke
 end
 
 desc 'Parallel spec tests'
@@ -126,39 +122,25 @@ end
 
 desc 'Build puppet module package'
 task :build do
-  if Gem::Specification.find_by_name('puppet').version < Gem::Version.new('6.0.0')
-    Rake::Task['build:pmt'].invoke
-  else
-    Rake::Task['build:pdk'].invoke
-  end
+  Rake::Task['build:pdk'].invoke
 end
 
 namespace :build do
-  desc 'Build Puppet module package with PMT (Puppet < 6.0.0 only)'
-  task :pmt do
-    require 'puppet/face'
-
-    pmod = Puppet::Face['module', :current]
-    pmod.build('./')
-  end
-
   desc 'Build Puppet module with PDK'
   task :pdk do
-    begin
-      require 'pdk/util'
-      require 'pdk/module/build'
-
-      path = PDK::Module::Build.invoke(force: true, 'target-dir': File.join(Dir.pwd, 'pkg'))
-      puts "Module built: #{path}"
-    rescue LoadError
-      _ = `pdk --version`
-      unless $CHILD_STATUS.success?
-        warn 'Unable to build module. Please install PDK or add the `pdk` gem to your Gemfile.'
-        abort
-      end
-
-      system('pdk build --force')
+    require 'pdk/util'
+    require 'pdk/module/build'
+
+    path = PDK::Module::Build.invoke(force: true, 'target-dir': File.join(Dir.pwd, 'pkg'))
+    puts "Module built: #{path}"
+  rescue LoadError
+    _ = `pdk --version`
+    unless $CHILD_STATUS.success?
+      warn 'Unable to build module. Please install PDK or add the `pdk` gem to your Gemfile.'
+      abort
     end
+
+    system('pdk build --force')
   end
 end
 
@@ -171,6 +153,7 @@ require 'puppet-lint/tasks/puppet-lint'
 # Must clear as it will not override the existing puppet-lint rake task since we require to import for
 # the PuppetLint::RakeTask
 Rake::Task[:lint].clear
+PuppetLint.configuration.fail_on_warnings = true
 # Utilize PuppetLint global configuration so that these settings can be tweaked by
 # spec_helper.rb in an individual module
 PuppetLint.configuration.relative = true
@@ -182,15 +165,16 @@ PuppetLint.configuration.ignore_paths << 'spec/**/*.pp'
 PuppetLint.configuration.ignore_paths << 'tests/**/*.pp'
 PuppetLint.configuration.ignore_paths << 'types/**/*.pp'
 PuppetLint.configuration.ignore_paths << 'vendor/**/*.pp'
-puppet_lint_disable_checks = %w[
-  80chars
-  140chars
-  class_inherits_from_params_class
-  class_parameter_defaults
-  disable_autoloader_layout
-  documentation
-  single_quote_string_with_variables
+puppet_lint_disable_checks = [
+  '80chars',
+  '140chars',
+  'class_inherits_from_params_class',
+  'class_parameter_defaults',
+  'disable_autoloader_layout',
+  'documentation',
+  'single_quote_string_with_variables',
 ]
+
 puppet_lint_disable_checks.each do |check|
   PuppetLint.configuration.send("disable_#{check}")
 end
@@ -208,10 +192,6 @@ PuppetSyntax.exclude_paths << 'pkg/**/*'
 PuppetSyntax.exclude_paths << 'vendor/**/*'
 PuppetSyntax.exclude_paths << '.vendor/**/*'
 PuppetSyntax.exclude_paths << 'plans/**/*'
-if Puppet.version.to_f < 4.0
-  PuppetSyntax.exclude_paths << 'types/**/*'
-end
-PuppetSyntax.future_parser = true if ENV['FUTURE_PARSER'] == 'yes'
 
 desc 'Check syntax of Ruby files and call :syntax and :metadata_lint'
 task :validate do
@@ -227,14 +207,13 @@ task :validate do
       warn 'Skipping metadata validation; the metadata-json-lint gem was not found'
     end
   end
-end
 
-task :metadata do
-  warn "The 'metadata' task is deprecated. Please use 'metadata_lint' instead."
-  if Rake::Task.task_defined?(:metadata_lint)
-    Rake::Task[:metadata_lint].invoke
-  else
-    warn 'Skipping metadata validation; the metadata-json-lint gem was not found'
+  if File.exist?('REFERENCE.md')
+    if Rake::Task.task_defined?('strings:validate:reference')
+      Rake::Task['strings:validate:reference'].invoke
+    else
+      warn 'Skipping reference documentation validation; the puppet-strings gem was not found'
+    end
   end
 end
 
@@ -260,7 +239,7 @@ task :compute_dev_version do
   # If the branch is a release branch we append an 'r' into the new_version,
   # this is due to the release branch buildID conflicting with main branch when trying to push to the staging forge.
   # More info can be found at https://tickets.puppetlabs.com/browse/FM-6170
-  new_version = if build = (ENV['BUILD_NUMBER'] || ENV['TRAVIS_BUILD_NUMBER'])
+  new_version = if (build = ENV['BUILD_NUMBER'])
                   if branch.eql? 'release'
                     '%s-%s%04d-%s' % [version, 'r', build, sha] # legacy support code # rubocop:disable Style/FormatStringToken
                   else
@@ -315,7 +294,9 @@ namespace :check do
 
   desc 'Fails if directories contain the files specified in .gitignore'
   task :git_ignore do
-    matched = `git ls-files --ignored --exclude-standard`
+    matched = `git ls-files --ignored --exclude-standard --cached`
+    raise 'git ls-files failed' unless $CHILD_STATUS.success?
+
     unless matched == ''
       puts matched
       raise 'File specified in .gitignore has been committed'
@@ -406,7 +387,7 @@ def create_gch_task(changelog_user = nil, changelog_project = nil, changelog_sin
         },
         'Added' => {
           'prefix' => '### Added',
-          'labels' => %w[feature enhancement],
+          'labels' => ['feature', 'enhancement'],
         },
         'Fixed' => {
           'prefix' => '### Fixed',

data/lib/puppetlabs_spec_helper/tasks/check_symlinks.rb

@@ -2,9 +2,7 @@
 
 require 'pathspec'
 
-module PuppetlabsSpecHelper; end
-module PuppetlabsSpecHelper::Tasks; end
-
+# Helpers for validating symlinks.
 class PuppetlabsSpecHelper::Tasks::CheckSymlinks
   DEFAULT_IGNORED = [
     '/.git/',

data/lib/puppetlabs_spec_helper/tasks/fixtures.rb

@@ -4,9 +4,10 @@ require 'yaml'
 require 'open3'
 require 'json'
 
-module PuppetlabsSpecHelper; end
-module PuppetlabsSpecHelper::Tasks; end
+# Top level namespace for spec helper tasks.
+module PuppetlabsSpecHelper::Tasks end
 
+# Helpers for workfing with fixtures.
 module PuppetlabsSpecHelper::Tasks::FixtureHelpers
   # This is a helper for the self-symlink entry of fixtures.yml
   def source_dir
@@ -136,6 +137,8 @@ module PuppetlabsSpecHelper::Tasks::FixtureHelpers
 
         next unless include_repo?(opts['puppet_version'])
 
+        # rubocop:disable Security/Eval
+        # TODO: Remove eval
         real_target = eval("\"#{opts['target']}\"", binding, __FILE__, __LINE__) # evaluating target reference in this context (see auto_symlink)
         real_source = eval("\"#{opts['repo']}\"", binding, __FILE__, __LINE__) # evaluating repo reference in this context (see auto_symlink)
 
@@ -157,7 +160,7 @@ module PuppetlabsSpecHelper::Tasks::FixtureHelpers
     return hash unless hash['scm'] == 'git'
 
     # Forward slashes in the ref aren't allowed. And is probably a branch name.
-    raise ArgumentError, "The ref for #{hash['target']} is invalid (Contains a forward slash). If this is a branch name, please use the 'branch' setting instead." if hash['ref'] =~ %r{/}
+    raise ArgumentError, "The ref for #{hash['target']} is invalid (Contains a forward slash). If this is a branch name, please use the 'branch' setting instead." if hash['ref'].include?('/')
 
     hash
   end
@@ -248,12 +251,11 @@ module PuppetlabsSpecHelper::Tasks::FixtureHelpers
   end
 
   def remove_subdirectory(target, subdir)
-    unless subdir.nil?
-      Dir.mktmpdir do |tmpdir|
-        FileUtils.mv(Dir.glob("#{target}/#{subdir}/{.[^\.]*,*}"), tmpdir)
-        FileUtils.rm_rf("#{target}/#{subdir}")
-        FileUtils.mv(Dir.glob("#{tmpdir}/{.[^\.]*,*}"), target.to_s)
-      end
+    return if subdir.nil?
+    Dir.mktmpdir do |tmpdir|
+      FileUtils.mv(Dir.glob("#{target}/#{subdir}/{.[^\.]*,*}"), tmpdir)
+      FileUtils.rm_rf("#{target}/#{subdir}")
+      FileUtils.mv(Dir.glob("#{tmpdir}/{.[^\.]*,*}"), target.to_s)
     end
   end
 
@@ -284,7 +286,7 @@ module PuppetlabsSpecHelper::Tasks::FixtureHelpers
   # so when anything else we count that as a active thread
   # @return [Integer] - current thread count
   def current_thread_count(items)
-    active_threads = items.find_all do |_item, opts|
+    active_threads = items.select do |_item, opts|
       if opts[:thread]
         opts[:thread].status
       else
@@ -316,7 +318,7 @@ module PuppetlabsSpecHelper::Tasks::FixtureHelpers
         end
       else
         # the last thread started should be the longest wait
-        item, item_opts = items.find_all { |_i, o| o.key?(:thread) }.last
+        item, item_opts = items.reverse.find { |_i, o| o.key?(:thread) }
         logger.debug "Waiting on #{item}"
         item_opts[:thread].join # wait for the thread to finish
         # now that we waited lets try again
@@ -405,7 +407,7 @@ module PuppetlabsSpecHelper::Tasks::FixtureHelpers
   end
 end
 
-include PuppetlabsSpecHelper::Tasks::FixtureHelpers # DSL include # rubocop:disable Style/MixinUsage
+include PuppetlabsSpecHelper::Tasks::FixtureHelpers # DSL include
 
 desc 'Create the fixtures directory'
 task :spec_prep do

data/lib/puppetlabs_spec_helper/version.rb

@@ -1,10 +1,5 @@
 # frozen_string_literal: true
 
 module PuppetlabsSpecHelper
-  VERSION = '4.0.1'
-
-  # compat for pre-1.2.0 users; deprecated
-  module Version
-    STRING = PuppetlabsSpecHelper::VERSION
-  end
+  VERSION = '5.0.0'
 end

data/spec/acceptance/fixtures/Rakefile

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require 'puppetlabs_spec_helper/rake_tasks'

data/spec/acceptance/smoke_spec.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'open3'
+
+# some smoke tests to verify overall sanity
+RSpec.describe 'rake' do
+  let(:output) do
+    Open3.capture2e('rake', '--rakefile', 'spec/acceptance/fixtures/Rakefile', '-T')
+  end
+
+  it { expect(output[0]).to match %r{spec_prep} }
+  it { expect(output[1]).to be_success }
+end

data/spec/spec_helper.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+if ENV['COVERAGE'] == 'yes'
+  require 'simplecov'
+  require 'simplecov-console'
+  require 'codecov'
+
+  SimpleCov.formatters = [
+    SimpleCov::Formatter::HTMLFormatter,
+    SimpleCov::Formatter::Console,
+    SimpleCov::Formatter::Codecov,
+  ]
+  SimpleCov.start do
+    track_files 'lib/**/*.rb'
+
+    add_filter 'lib/puppetlabs_spec_helper/version.rb'
+
+    add_filter '/spec'
+
+    # do not track vendored files
+    add_filter '/vendor'
+    add_filter '/.vendor'
+  end
+end
+
+require 'fakefs/spec_helpers'
+
+FakeFS::Pathname.class_eval do
+  def symlink?
+    File.symlink?(@path)
+  end
+end
+
+require 'puppetlabs_spec_helper/puppet_spec_helper'
+require 'puppetlabs_spec_helper/puppetlabs_spec/puppet_internals'
+require 'puppetlabs_spec_helper/rake_tasks'
+
+RSpec.shared_context 'with a rake task', type: :task do
+  subject(:task) { Rake::Task[task_name] }
+
+  include FakeFS::SpecHelpers
+
+  let(:task_name) { self.class.top_level_description.sub(%r{\Arake }, '') }
+end
+
+# configure RSpec after including all the code
+RSpec.configure do |config|
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+
+  config.include_context 'with a rake task', type: :task
+end