puppetlabs_spec_helper 2.7.0 → 3.0.0

data/lib/puppetlabs_spec_helper/tasks/beaker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec/core/rake_task'
 
 module PuppetlabsSpecHelper; end
@@ -10,9 +12,7 @@ module PuppetlabsSpecHelper::Tasks::BeakerHelpers
 
   # cache the repositories and return a hash object
   def repositories
-    unless @repositories
-      @repositories = fixtures('repositories')
-    end
+    @repositories ||= fixtures('repositories')
     @repositories
   end
 
@@ -20,6 +20,7 @@ module PuppetlabsSpecHelper::Tasks::BeakerHelpers
   # @return [Array<String>]
   def beaker_node_sets
     return @beaker_nodes if @beaker_nodes
+
     @beaker_nodes = Dir['spec/acceptance/nodesets/*.yml'].sort.map do |node_set|
       node_set.slice!('.yml')
       File.basename(node_set)
@@ -42,43 +43,46 @@ module PuppetlabsSpecHelper::Tasks::BeakerHelpers
       # Vagrant is not distributed as a normal gem
       # and we should protect it from the current Ruby environment
       env = {
-          'RUBYLIB' => nil,
-          'GEM_PATH' => nil,
-          'BUNDLE_BIN_PATH' => nil,
+        'RUBYLIB' => nil,
+        'GEM_PATH' => nil,
+        'BUNDLE_BIN_PATH' => nil,
       }
       system env, command
     end
   end
 end
-include PuppetlabsSpecHelper::Tasks::BeakerHelpers
+include PuppetlabsSpecHelper::Tasks::BeakerHelpers # legacy support code # rubocop:disable Style/MixinUsage
 
-desc "Run beaker acceptance tests"
+desc 'Run beaker acceptance tests'
 RSpec::Core::RakeTask.new(:beaker) do |t|
   SetupBeaker.setup_beaker(t)
 end
 
 class SetupBeaker
-  def self.setup_beaker(t)
-    t.rspec_opts = ['--color']
-    t.pattern = 'spec/acceptance'
+  def self.setup_beaker(task)
+    task.rspec_opts = []
+    task.pattern = 'spec/acceptance'
     # TEST_TIERS env variable is a comma separated list of tiers to run. e.g. low, medium, high
     if ENV['TEST_TIERS']
       test_tiers = ENV['TEST_TIERS'].split(',')
-      raise 'TEST_TIERS env variable must have at least 1 tier specified. low, medium or high (comma separated).' if test_tiers.count == 0
+      test_tiers_allowed = ENV.fetch('TEST_TIERS_ALLOWED', 'low,medium,high').split(',')
+      raise 'TEST_TIERS env variable must have at least 1 tier specified. Either low, medium or high or one of the tiers listed in TEST_TIERS_ALLOWED (comma separated).' if test_tiers.count == 0
+
       test_tiers.each do |tier|
         tier_to_add = tier.strip.downcase
-        raise "#{tier_to_add} not a valid test tier." unless %w(low medium high).include?(tier_to_add)
+        raise "#{tier_to_add} not a valid test tier." unless test_tiers_allowed.include?(tier_to_add)
+
         tiers = "--tag tier_#{tier_to_add}"
-        t.rspec_opts.push(tiers)
+        task.rspec_opts.push(tiers)
       end
     else
       puts 'TEST_TIERS env variable not defined. Defaulting to run all tests.'
     end
-    return t
+    task
   end
 end
 
-desc "List available beaker nodesets"
+desc 'List available beaker nodesets'
 task 'beaker:sets' do
   beaker_node_sets.each do |set|
     puts set

data/lib/puppetlabs_spec_helper/tasks/check_symlinks.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+require 'pathspec'
+
+module PuppetlabsSpecHelper; end
+module PuppetlabsSpecHelper::Tasks; end
+
+class PuppetlabsSpecHelper::Tasks::CheckSymlinks
+  DEFAULT_IGNORED = [
+    '/.git/',
+    '/.bundle/',
+    '/vendor/',
+  ].freeze
+
+  IGNORE_LIST_FILES = [
+    '.pdkignore',
+    '.gitignore',
+  ].freeze
+
+  def check(dir = Dir.pwd)
+    dir = Pathname.new(dir) unless dir.is_a?(Pathname)
+    results = []
+
+    dir.each_child(true) do |child|
+      next if ignored?(child.to_s)
+
+      if child.symlink?
+        results << child
+      elsif child.directory? && child.basename.to_s !~ %r{^(\.git|\.?bundle)$}
+        results.concat(check(child))
+      end
+    end
+
+    results
+  end
+
+  def ignored?(path)
+    path = "#{path}/" if File.directory?(path)
+
+    !ignore_pathspec.match_paths([path], Dir.pwd).empty?
+  end
+
+  def ignore_pathspec
+    @ignore_pathspec ||= PathSpec.new(DEFAULT_IGNORED).tap do |pathspec|
+      IGNORE_LIST_FILES.each do |f|
+        next unless File.file?(f) && File.readable?(f)
+
+        File.open(f, 'r') { |fd| pathspec.add(fd) }
+      end
+    end
+  end
+end