puppetlabs-onceover 5.0.3 → 5.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fb1a24d9bef771393d000adc120dab6bd26792308495f707c1387e945145258c
-  data.tar.gz: a56a0f741a879b4e6842efc2f221426dbc8c4b77f5edb298ca3d7d962e8076e1
+  metadata.gz: c991dea08d7eb606b8f13d8cd9c270ef3e7fba1ce7b3adb1761f212cecbc1d5c
+  data.tar.gz: ebb53a42b2538e507d1d40db33787efdd33eacf81e4b22ceec03229244c27d40
 SHA512:
-  metadata.gz: 5a38763ed527cc6c56a7e25df2f71485a8e46359bd78add331ba772c305f21eb1b39917c35d77ccb79f3100ce56be4f20f732000e3b5075d51901e5239ae1ff1
-  data.tar.gz: 3ca76442583fb941fa5c934d837f20cfd2b36fdc79e7ec2328571dcac369d8e2f682a4d0891692906549787b1d33f2d9fe11ca9d1bd19b53bf0cda87ae6b0c3f
+  metadata.gz: fe347612ab83e67a31f1850db126ce95e9da6e6a4e8dd8ec77cb6f605db8c5ddb3a20e7e1edcee5aa998d42b8f544433ee0d5e400fee636ef7e89dc1004dcf84
+  data.tar.gz: eca5387e7eebb1b790cdabb9917722b44b6312622bf6fae26e3b3ec0593ba917769b190feca48605cb6d12fc85f5a5c2dabbe716eae0aa94c882f9040e53ef44

data/.gitignore

@@ -7,10 +7,14 @@ Gemfile.local
 /.bundle
 /.bin
 /.ruby-version
+/mise.toml
 tmp
 /vendor
 /.vendor
 
+# rspec/simplecov coverage reports
+/coverage
+
 # Vim
 /.projections.json
 /tags

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --no-auto-gen-timestamp`
-# using RuboCop version 1.85.1.
+# using RuboCop version 1.90.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -41,7 +41,7 @@ Layout/IndentationWidth:
 
 # Offense count: 12
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment, AllowRBSInlineAnnotation, AllowSteepAnnotation.
+# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment, AllowRBSInlineAnnotation, AllowSteepAnnotation, AllowYARDCommentBlockSeparator.
 Layout/LeadingCommentSpace:
   Exclude:
     - 'lib/puppetlabs-onceover/beaker/spec_helper.rb'
@@ -184,6 +184,12 @@ Lint/AssignmentInCondition:
     - 'lib/puppetlabs-onceover/controlrepo.rb'
     - 'lib/puppetlabs-onceover/node.rb'
 
+# Offense count: 1
+# Configuration parameters: AllowComments.
+Lint/EmptyClass:
+  Exclude:
+    - 'spec/puppetlabs-onceover/beaker_spec.rb'
+
 # Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
 Lint/ErbNewArguments:
@@ -246,27 +252,32 @@ Lint/UselessAssignment:
 Metrics/AbcSize:
   Max: 156
 
-# Offense count: 5
+# Offense count: 54
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 # AllowedMethods: refine
 Metrics/BlockLength:
-  Max: 51
+  Max: 656
 
 # Offense count: 6
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 494
+  Max: 495
 
-# Offense count: 15
+# Offense count: 14
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 31
 
-# Offense count: 51
+# Offense count: 53
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 110
 
+# Offense count: 2
+# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
+Metrics/ParameterLists:
+  Max: 6
+
 # Offense count: 15
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
@@ -367,7 +378,7 @@ Style/ClassAndModuleChildren:
   Exclude:
     - 'lib/puppetlabs-onceover/logger.rb'
 
-# Offense count: 6
+# Offense count: 24
 Style/ClassVars:
   Exclude:
     - 'lib/puppetlabs-onceover/class.rb'
@@ -375,6 +386,12 @@ Style/ClassVars:
     - 'lib/puppetlabs-onceover/group.rb'
     - 'lib/puppetlabs-onceover/node.rb'
     - 'lib/puppetlabs-onceover/test.rb'
+    - 'spec/puppetlabs-onceover/class_spec.rb'
+    - 'spec/puppetlabs-onceover/controlrepo_spec.rb'
+    - 'spec/puppetlabs-onceover/group_spec.rb'
+    - 'spec/puppetlabs-onceover/node_spec.rb'
+    - 'spec/puppetlabs-onceover/test_spec.rb'
+    - 'spec/puppetlabs-onceover/testconfig_spec.rb'
 
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
@@ -428,7 +445,7 @@ Style/Encoding:
   Exclude:
     - 'puppetlabs-onceover.gemspec'
 
-# Offense count: 34
+# Offense count: 50
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
@@ -442,12 +459,13 @@ Style/GlobalStdStream:
     - 'features/step_definitions/formatter.rb'
     - 'lib/puppetlabs-onceover/runner.rb'
 
-# Offense count: 6
+# Offense count: 8
 # Configuration parameters: AllowedVariables.
 Style/GlobalVars:
   Exclude:
     - 'lib/puppetlabs-onceover/controlrepo.rb'
     - 'lib/puppetlabs-onceover/logger.rb'
+    - 'spec/puppetlabs-onceover/logger_spec.rb'
 
 # Offense count: 5
 # This cop supports safe autocorrection (--autocorrect).
@@ -572,6 +590,8 @@ Style/NumericPredicate:
 # Configuration parameters: AllowedClasses.
 Style/OneClassPerFile:
   Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
     - 'lib/puppetlabs-onceover/rspec/formatters.rb'
 
 # Offense count: 2
@@ -739,14 +759,14 @@ Style/StringConcatenation:
     - 'lib/puppetlabs-onceover/rspec/formatters.rb'
     - 'lib/puppetlabs-onceover/runner.rb'
 
-# Offense count: 95
+# Offense count: 343
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Enabled: false
 
-# Offense count: 5
+# Offense count: 9
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets
@@ -763,7 +783,7 @@ Style/SymbolProc:
     - 'lib/puppetlabs-onceover/testconfig.rb'
     - 'spec/spec_helper.rb'
 
-# Offense count: 4
+# Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, diff_comma, no_comma
@@ -796,9 +816,9 @@ Style/WhileUntilDo:
   Exclude:
     - 'lib/puppetlabs-onceover/controlrepo.rb'
 
-# Offense count: 31
+# Offense count: 65
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, AllowRBSInlineAnnotation, AllowCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https
 Layout/LineLength:
-  Max: 421
+  Max: 421

data/CHANGELOG.md

@@ -5,14 +5,33 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org).
 
+## [v5.0.5](https://github.com/puppetlabs/puppetlabs-onceover/tree/v5.0.5) - 2026-09-15
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v5.0.4...v5.0.5)
+
+### Other
+
+- Replace GitHub REST tag lookups with git ls-remote to fix rate-limit CI failures [#28](https://github.com/puppetlabs/puppetlabs-onceover/pull/28) ([actowery](https://github.com/actowery))
+- Pin json < 3.0 to fix r10k module deploy arity error [#27](https://github.com/puppetlabs/puppetlabs-onceover/pull/27) ([actowery](https://github.com/actowery))
+- Fix ERB.new calls broken on Ruby 4.0 (rake_tasks.rb) [#26](https://github.com/puppetlabs/puppetlabs-onceover/pull/26) ([actowery](https://github.com/actowery))
+- Pin facter to Puppetcore, fix PUPPET_FORGE_TOKEN truthiness bug [#25](https://github.com/puppetlabs/puppetlabs-onceover/pull/25) ([actowery](https://github.com/actowery))
+
+## [v5.0.4](https://github.com/puppetlabs/puppetlabs-onceover/tree/v5.0.4) - 2026-09-03
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v5.0.3...v5.0.4)
+
+### Other
+
+- (CAT-2820) Raise rspec unit test coverage to >90% [#23](https://github.com/puppetlabs/puppetlabs-onceover/pull/23) ([actowery](https://github.com/actowery))
+- Fix plugin-discovery regex for renamed addon gems (CAT-2819) [#21](https://github.com/puppetlabs/puppetlabs-onceover/pull/21) ([actowery](https://github.com/actowery))
+- (CAT-2817) Fix malformed CHANGELOG.md archive-boundary heading [#20](https://github.com/puppetlabs/puppetlabs-onceover/pull/20) ([actowery](https://github.com/actowery))
+
 ## [v5.0.3](https://github.com/puppetlabs/puppetlabs-onceover/tree/v5.0.3) - 2026-09-03
 
 [Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v5.0.2...v5.0.3)
 
 ### Changed
 
-This version is a pure refactor of the original gem into a new namespace.  For more information, see the following PRs:
-
 - (CAT-2814) Drop voxpupuli-test's monolithic rake integration [#16](https://github.com/puppetlabs/puppetlabs-onceover/pull/16) ([actowery](https://github.com/actowery))
 - (CAT-2778) Decouple from voxpupuli-test; fix stale pre-rename rake_tasks require [#13](https://github.com/puppetlabs/puppetlabs-onceover/pull/13) ([actowery](https://github.com/actowery))
 - (CAT-2775/CAT-2776) Land namespace rename + dependency flip on main [#10](https://github.com/puppetlabs/puppetlabs-onceover/pull/10) ([actowery](https://github.com/actowery))
@@ -20,6 +39,382 @@ This version is a pure refactor of the original gem into a new namespace.  For m
 - (CAT-2775) Rename runtime namespace: Onceover -> PuppetlabsOnceover (Gate 3) [#6](https://github.com/puppetlabs/puppetlabs-onceover/pull/6) ([actowery](https://github.com/actowery))
 - (CAT-2774) Rename gem publisher identity: onceover -> puppetlabs-onceover (Gate 2) [#5](https://github.com/puppetlabs/puppetlabs-onceover/pull/5) ([actowery](https://github.com/actowery))
 
+### Other
+
+- Fix release workflow [#19](https://github.com/puppetlabs/puppetlabs-onceover/pull/19) ([gavindidrichsen](https://github.com/gavindidrichsen))
+
 ## [v5.0.2](https://github.com/puppetlabs/puppetlabs-onceover/tree/v5.0.2) - 2025-10-10
 
-For all previous changes see [ARCHIVE.md](ARCHIVE.md)
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v5.0.1...v5.0.2)
+
+## [v5.0.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v5.0.1) - 2025-10-10
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v5.0.0...v5.0.1)
+
+## [v5.0.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v5.0.0) - 2025-06-27
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v4.0.0...v5.0.0)
+
+## [v4.0.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v4.0.0) - 2024-11-21
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.22.0...v4.0.0)
+
+## [v3.22.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.22.0) - 2024-03-16
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.21.0...v3.22.0)
+
+## [v3.21.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.21.0) - 2023-06-17
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.20.0...v3.21.0)
+
+## [v3.20.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.20.0) - 2021-04-08
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.19.2...v3.20.0)
+
+## [v3.19.2](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.19.2) - 2021-03-17
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.19.1...v3.19.2)
+
+## [v3.19.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.19.1) - 2021-01-26
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.19.0...v3.19.1)
+
+## [v3.19.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.19.0) - 2020-11-10
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.18.1...v3.19.0)
+
+## [v3.18.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.18.1) - 2020-09-23
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.18.0...v3.18.1)
+
+## [v3.18.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.18.0) - 2020-07-29
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.17.3...v3.18.0)
+
+## [v3.17.3](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.17.3) - 2020-07-17
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.17.2...v3.17.3)
+
+## [v3.17.2](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.17.2) - 2020-07-08
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.17.1...v3.17.2)
+
+## [v3.17.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.17.1) - 2020-07-01
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.17.0...v3.17.1)
+
+## [v3.17.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.17.0) - 2020-05-04
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.16.0...v3.17.0)
+
+## [v3.16.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.16.0) - 2020-04-21
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.15.2...v3.16.0)
+
+## [v3.15.2](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.15.2) - 2020-03-20
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.15.1...v3.15.2)
+
+## [v3.15.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.15.1) - 2020-03-10
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.15.0...v3.15.1)
+
+## [v3.15.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.15.0) - 2019-10-19
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.14.1...v3.15.0)
+
+## [v3.14.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.14.1) - 2019-06-19
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.14.0...v3.14.1)
+
+## [v3.14.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.14.0) - 2019-06-19
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.13.4...v3.14.0)
+
+## [v3.13.4](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.13.4) - 2019-06-12
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.13.3...v3.13.4)
+
+## [v3.13.3](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.13.3) - 2019-06-11
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.13.2...v3.13.3)
+
+## [v3.13.2](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.13.2) - 2019-06-04
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.13.1...v3.13.2)
+
+## [v3.13.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.13.1) - 2019-06-04
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.13.0...v3.13.1)
+
+## [v3.13.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.13.0) - 2019-05-08
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.12.5...v3.13.0)
+
+## [v3.12.5](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.12.5) - 2019-04-09
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.12.4...v3.12.5)
+
+## [v3.12.4](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.12.4) - 2019-04-03
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.12.3...v3.12.4)
+
+## [v3.12.3](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.12.3) - 2019-03-27
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.12.2...v3.12.3)
+
+## [v3.12.2](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.12.2) - 2019-03-21
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.12.1...v3.12.2)
+
+## [v3.12.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.12.1) - 2019-03-17
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.12.0...v3.12.1)
+
+## [v3.12.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.12.0) - 2019-03-16
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.11.1...v3.12.0)
+
+## [v3.11.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.11.1) - 2019-02-26
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.11.0...v3.11.1)
+
+## [v3.11.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.11.0) - 2019-02-26
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.10.2...v3.11.0)
+
+## [v3.10.2](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.10.2) - 2019-02-06
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.10.1...v3.10.2)
+
+## [v3.10.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.10.1) - 2019-02-06
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.10.0...v3.10.1)
+
+## [v3.10.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.10.0) - 2019-02-05
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.9.0...v3.10.0)
+
+## [v3.9.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.9.0) - 2018-12-24
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.8.0...v3.9.0)
+
+## [v3.8.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.8.0) - 2018-09-05
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.7.0...v3.8.0)
+
+## [v3.7.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.7.0) - 2018-05-15
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.6.2...v3.7.0)
+
+## [v3.6.2](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.6.2) - 2018-05-13
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.6.1...v3.6.2)
+
+## [v3.6.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.6.1) - 2018-04-05
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.6.0...v3.6.1)
+
+## [v3.6.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.6.0) - 2018-03-27
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.5.2...v3.6.0)
+
+## [v3.5.2](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.5.2) - 2018-03-15
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.5.1...v3.5.2)
+
+## [v3.5.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.5.1) - 2018-03-08
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.5.0...v3.5.1)
+
+## [v3.5.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.5.0) - 2018-03-06
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.4.0...v3.5.0)
+
+## [v3.4.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.4.0) - 2018-02-27
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.3.3...v3.4.0)
+
+## [v3.3.3](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.3.3) - 2018-02-26
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.3.2...v3.3.3)
+
+## [v3.3.2](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.3.2) - 2018-01-16
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.3.1...v3.3.2)
+
+## [v3.3.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.3.1) - 2018-01-05
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.3.0...v3.3.1)
+
+## [v3.3.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.3.0) - 2018-01-05
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.2.8...v3.3.0)
+
+## [v3.2.8](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.2.8) - 2017-12-11
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.2.7...v3.2.8)
+
+## [v3.2.7](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.2.7) - 2017-10-04
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.2.6...v3.2.7)
+
+## [v3.2.6](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.2.6) - 2017-09-12
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.2.5...v3.2.6)
+
+## [v3.2.5](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.2.5) - 2017-08-29
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.2.4...v3.2.5)
+
+## [v3.2.4](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.2.4) - 2017-08-29
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.2.3...v3.2.4)
+
+## [v3.2.3](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.2.3) - 2017-08-07
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.2.2...v3.2.3)
+
+## [v3.2.2](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.2.2) - 2017-07-13
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.2.1...v3.2.2)
+
+## [v3.2.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.2.1) - 2017-07-13
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.2.0...v3.2.1)
+
+## [v3.2.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.2.0) - 2017-03-13
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.1.1...v3.2.0)
+
+## [v3.1.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.1.1) - 2017-03-04
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.1.0...v3.1.1)
+
+## [v3.1.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.1.0) - 2017-02-21
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.0.11...v3.1.0)
+
+## [v3.0.11](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.0.11) - 2017-01-19
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.0.10...v3.0.11)
+
+## [v3.0.10](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.0.10) - 2016-12-14
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.0.9...v3.0.10)
+
+## [v3.0.9](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.0.9) - 2016-12-13
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.0.8...v3.0.9)
+
+## [v3.0.8](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.0.8) - 2016-10-15
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.0.7...v3.0.8)
+
+## [v3.0.7](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.0.7) - 2016-05-31
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.0.6...v3.0.7)
+
+## [v3.0.6](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.0.6) - 2016-05-24
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.0.5...v3.0.6)
+
+## [v3.0.5](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.0.5) - 2016-05-16
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.0.4...v3.0.5)
+
+## [v3.0.4](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.0.4) - 2016-05-15
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.0.3...v3.0.4)
+
+## [v3.0.3](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.0.3) - 2016-05-06
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.0.2...v3.0.3)
+
+## [v3.0.2](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.0.2) - 2016-04-30
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.0.1...v3.0.2)
+
+## [v3.0.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.0.1) - 2016-04-28
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v3.0.0...v3.0.1)
+
+## [v3.0.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v3.0.0) - 2016-04-28
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v2.0.10...v3.0.0)
+
+## [v2.0.10](https://github.com/puppetlabs/puppetlabs-onceover/tree/v2.0.10) - 2016-03-21
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v2.0.9...v2.0.10)
+
+## [v2.0.9](https://github.com/puppetlabs/puppetlabs-onceover/tree/v2.0.9) - 2016-03-21
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v2.0.8...v2.0.9)
+
+## [v2.0.8](https://github.com/puppetlabs/puppetlabs-onceover/tree/v2.0.8) - 2016-02-11
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v2.0.7...v2.0.8)
+
+## [v2.0.7](https://github.com/puppetlabs/puppetlabs-onceover/tree/v2.0.7) - 2016-02-11
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v2.0.6...v2.0.7)
+
+## [v2.0.6](https://github.com/puppetlabs/puppetlabs-onceover/tree/v2.0.6) - 2016-02-11
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v2.0.5...v2.0.6)
+
+## [v2.0.5](https://github.com/puppetlabs/puppetlabs-onceover/tree/v2.0.5) - 2016-02-08
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v2.0.4...v2.0.5)
+
+## [v2.0.4](https://github.com/puppetlabs/puppetlabs-onceover/tree/v2.0.4) - 2016-02-08
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v2.0.3...v2.0.4)
+
+## [v2.0.3](https://github.com/puppetlabs/puppetlabs-onceover/tree/v2.0.3) - 2015-11-20
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v2.0.2...v2.0.3)
+
+## [v2.0.2](https://github.com/puppetlabs/puppetlabs-onceover/tree/v2.0.2) - 2015-11-20
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v2.0.1...v2.0.2)
+
+## [v2.0.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/v2.0.1) - 2015-11-16
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v2.0.0...v2.0.1)
+
+## [v2.0.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v2.0.0) - 2015-11-11
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/2.0.0...v2.0.0)
+
+## [2.0.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/2.0.0) - 2015-11-11
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/1.1.1...2.0.0)
+
+## [1.1.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/1.1.1) - 2015-11-10
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/v1.1.0...1.1.1)
+
+## [v1.1.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/v1.1.0) - 2015-11-06
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/1.1.0...v1.1.0)
+
+## [1.1.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/1.1.0) - 2015-10-28
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/1.0.0...1.1.0)
+
+## [1.0.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/1.0.0) - 2015-10-19
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/0.2.0...1.0.0)
+
+## [0.2.0](https://github.com/puppetlabs/puppetlabs-onceover/tree/0.2.0) - 2015-09-29
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/0.1.1...0.2.0)
+
+## [0.1.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/0.1.1) - 2015-09-28
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/0.0.1...0.1.1)
+
+## [0.0.1](https://github.com/puppetlabs/puppetlabs-onceover/tree/0.0.1) - 2015-09-24
+
+[Full Changelog](https://github.com/puppetlabs/puppetlabs-onceover/compare/192099961f3ffe616b5811815a9df013f1284e54...0.0.1)

data/Gemfile

@@ -2,7 +2,7 @@
 gemsource_default = ENV['GEM_SOURCE'] || 'https://rubygems.org'
 gemsource_puppetcore = if ENV['GEM_SOURCE']
                          gemsource_default
-                       elsif ENV['PUPPET_FORGE_TOKEN']
+                       elsif ENV['PUPPET_FORGE_TOKEN'] && !ENV['PUPPET_FORGE_TOKEN'].empty?
                          'https://rubygems-puppetcore.puppet.com'
                        else
                          ENV['GEM_SOURCE_PUPPETCORE'] || gemsource_default
@@ -20,9 +20,28 @@ gem 'pry-coolline', '> 0.0', '< 1.0.0'
 # and no auth is attempted against Puppetcore.
 gem 'puppet', ENV['PUPPET_GEM_VERSION'] || '~> 8', source: gemsource_puppetcore
 
+# facter is a runtime dependency of puppet, but pinning `puppet`'s own source
+# does NOT pin its transitive dependencies to that same source -- bundler
+# still resolves facter from whichever source(s) declare it, so without this
+# explicit pin facter would silently keep resolving from public rubygems.org
+# (built from the public facter repo) even when puppet itself correctly comes
+# from Puppetcore (built from the private facter-private source). Pin it
+# explicitly so both come from the same place.
+gem 'facter', source: gemsource_puppetcore
+
 # Puppet on Ruby 3.3 / 3.4 has some missing dependencies
 gem 'syslog', '~> 0.3' if RUBY_VERSION >= '3.4'
 
+# json 3.0 made JSON.parse keyword-only (dropped the legacy positional-hash
+# opts argument). faraday's JSON response middleware
+# (Faraday::Response::Json#parse) still calls `decoder.public_send(method,
+# body, @parser_options || {})` positionally, so with json ~> 3.0 every
+# Forge/HTTP JSON response r10k parses raises
+# `wrong number of arguments (given 2, expected 1)`. Pin to the last
+# compatible major until faraday releases a fix for json 3.0's new
+# signature.
+gem 'json', '< 3.0'
+
 # Windows platform runtime deps. The published puppet/openvox rubygems.org
 # artefacts are built on Linux and guard `ffi` / `win32ole` with build-host
 # platform checks, so those deps never make it into the Linux-published
@@ -38,6 +57,7 @@ end
 group :test do
   # Required for the final controlrepo tests
   gem 'rexml', '~> 3.3', '>= 3.3.9'
+  gem 'simplecov', require: false
   gem 'toml-rb'
 end
 

data/lib/puppetlabs-onceover/cli/plugins.rb

@@ -1,10 +1,10 @@
 require 'rubygems'
 
-# Get all of the gems that start with onceover-
+# Get all of the gems that start with puppetlabs-onceover-
 plugins = Gem::Specification.group_by{ |g| g.name }.keep_if do |name, details|
-  name =~ /^onceover-.*$/
+  name =~ /^puppetlabs-onceover-.*$/
 end.keys
 
 plugins.each do |plugin|
-  require plugin.gsub('-', '/')
+  require plugin.sub('puppetlabs-onceover-', 'puppetlabs-onceover/')
 end