puppetfile_editor 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b99bd7f019aa2f0f45886781196541dbc26ee417563c442ec108f64c35127dc1
-  data.tar.gz: 512cc9b743df97fe6ea944b6aa47a1cd2ce82f37ec84072d06053ca409482470
+  metadata.gz: c87e60bcb47337f1e82ddebb3cf63438ca86d16d469c4a7837bc179a7a2ca1c9
+  data.tar.gz: 1cdd31477c5668a7fb8170b60df48a0156a8f8e2786a575c52b56ecfadf0d563
 SHA512:
-  metadata.gz: 4dc9b545e14367eb025409bb3e00f0fa1771ce01d5725eb45c2f3544425391896899a7a7bce02d1d8e1d611ce3b5912018d4b6722cd60b098c756d1ae2ba421a
-  data.tar.gz: ad6327a2c9eaed1f8e9f1bf60369f009c580a8a0763cc1cfc75a8df3ae71574ea22ef7a311c4056790e81202de5e64860413722e2d8ffeae71c9d03c87aa0b0f
+  metadata.gz: 1095879f6b4423febcc3c225e944ad410622155ab4d3ed6a196b33dd96f87114d7b2d028f94ff626fa993a7492831df7d275791dc06f7abd443a6f5071872ce4
+  data.tar.gz: 84f21e96aee3e29ea6513a0b6012242aa5b41b9fd2ac1e2fba6cc85a8817d162b9c7cdaa80ad8d0c3997eab33e6b7f517f69b82e70fb660df190048cb910dbc2

data/CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.7.1] - 2018-02-22
+### Fixed
+- Fix for older rubies where `Gem::Version` broke for versions like `0.1.0-dev1`.
+
 ## [0.7.0] - 2018-02-15
 ### Added
 - Warn about downgrading forge, git, and hg modules while merging.

data/lib/puppetfile_editor/module.rb

@@ -74,11 +74,23 @@ module PuppetfileEditor
         if full_version == mod.full_version
           set_message("versions match (#{full_version})", :matched)
           return
-        elsif Gem::Version.new(full_version.sub('tag: ', '')) > Gem::Version.new(mod.full_version.sub('tag: ', ''))
-          set_message("DOWNGRADED (#{full_version} to #{mod.full_version})", :downgrade)
+        end
+
+        begin
+          old_version = Gem::Version.new(full_version.sub('tag: ', ''))
+          new_version = Gem::Version.new(mod.full_version.sub('tag: ', ''))
+        rescue ArgumentError
+          # Older rubies throw ArgumentError when version is '0.1.0-dev1', for example.
+          # Sad.
+          set_message("could not compare versions, so updating (#{full_version} to #{mod.full_version})", :updated)
         else
-          set_message("updated (#{full_version} to #{mod.full_version})", :updated)
+          if old_version > new_version
+            set_message("DOWNGRADED (#{full_version} to #{mod.full_version})", :downgrade)
+          else
+            set_message("updated (#{full_version} to #{mod.full_version})", :updated)
+          end
         end
+
         @params.delete_if { |param, _| [:branch, :tag, :ref, :changeset].include? param }
         @params.merge!(new)
         calculate_indent
@@ -110,10 +122,10 @@ module PuppetfileEditor
         output.push "mod '#{full_title}'"
         @params.each do |param_name, param_value|
           value = if param_value == :latest
-                    ':latest'
-                  else
-                    "'#{param_value}'"
-                  end
+            ':latest'
+          else
+            "'#{param_value}'"
+          end
           param = "#{param_name}:".ljust(@indent)
           output.push "    #{param} #{value}"
         end

data/lib/puppetfile_editor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PuppetfileEditor
-  VERSION = '0.7.0'
+  VERSION = '0.7.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppetfile_editor
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Eugene Piven
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-15 00:00:00.000000000 Z
+date: 2018-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler