puppeteer-ruby 0.50.0.alpha9 → 0.50.0.alpha10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 904e4fe437eb2088c1c1f6650e840818b9d8b0be5d420cdf4aa33142dd7468a4
-  data.tar.gz: 27ca94c22baf6edcf0ebf6173df06142a071803995a3c29462ccd00286adf723
+  metadata.gz: 6ad92e4a471db943a70ea1f6e928ba29e611cba0fc4b62b001bafb0cf444c797
+  data.tar.gz: 226103f1934651f038099e58a7b94414e248db9290f928c4fc2d4b262df59807
 SHA512:
-  metadata.gz: a874a9d182af6525021f91a2cf3eeaeffe6fd5380eef345b8fd9e6bb896b3468543d67900af2b827a263a6c2adc0a8a85f06bf6d05241e4477033863dd6a4601
-  data.tar.gz: 3d99750cef4daa4438786a581f8246d1f03c2920c0ff6bc3ebc7f2fbe5f97cbb47ea577faae87f45bf37933adfa7a40d3df6b3ae1347a2c37eeb3488e1142029
+  metadata.gz: 1ba290b15ba557824715b8aa82ad8695cdc9d08200381c7e004cb3c3fe63e041bc732e5e27f904e6bf75ff4eef51e6fdb905972d4225cfa495bbde9637a5f2ac
+  data.tar.gz: c7a208b38765265b77cef6f81dc1945daa6b4f4c09957c0b9b8e20484630a20a0359bbd3bbde26d5d88c1b55ea5c17cb02d522e358e294aa3db814685559a736

data/docs/api_coverage.md

@@ -1,6 +1,6 @@
 # API coverages
 - Puppeteer version: v24.35.0
-- puppeteer-ruby version: 0.50.0.alpha9
+- puppeteer-ruby version: 0.50.0.alpha10
 
 ## Puppeteer
 

data/lib/puppeteer/connection.rb

@@ -1,4 +1,5 @@
 require 'json'
+require 'async/queue'
 
 class Puppeteer::Connection
   include Puppeteer::DebugPrint
@@ -44,11 +45,16 @@ class Puppeteer::Connection
     @delay = delay
     @protocol_timeout = protocol_timeout
 
+    @network_message_queue = Async::Queue.new
+    @network_message_task = nil
+
     @transport = transport
     @transport.on_message do |data|
       message = JSON.parse(data)
       sleep_before_handling_message(message)
-      if should_handle_synchronously?(message)
+      if network_event_message?(message)
+        enqueue_network_message(message)
+      elsif should_handle_synchronously?(message)
         handle_message(message)
       else
         async_handle_message(message)
@@ -87,7 +93,8 @@ class Puppeteer::Connection
     when nil
       false
     when /^Network\./
-      true
+      # Network events are queued for ordered async processing.
+      false
     when /^Page\.frame/
       # Page.frameAttached
       # Page.frameNavigated
@@ -112,6 +119,34 @@ class Puppeteer::Connection
     end
   end
 
+  private def network_event_message?(message)
+    message['method']&.start_with?('Network.')
+  end
+
+  private def ensure_network_message_task
+    return if @network_message_task&.alive?
+    return unless Async::Task.current?
+
+    @network_message_task = Async do
+      while (queued = @network_message_queue.dequeue)
+        handle_message(queued)
+      end
+    end
+  end
+
+  private def enqueue_network_message(message)
+    if Async::Task.current?
+      ensure_network_message_task
+      begin
+        @network_message_queue.enqueue(message)
+      rescue Async::Queue::ClosedError
+        # Connection is closing; ignore late network events.
+      end
+    else
+      handle_message(message)
+    end
+  end
+
   def self.from_session(session)
     session.connection
   end
@@ -310,6 +345,12 @@ class Puppeteer::Connection
     @closed = true
     @transport.on_message
     @transport.on_close
+    @network_message_queue.close
+    begin
+      @network_message_task&.stop
+    rescue Async::Stop
+      # Task already stopping; ignore.
+    end
     callbacks = @callbacks_mutex.synchronize do
       @callbacks.values.tap { @callbacks.clear }
     end

data/lib/puppeteer/frame_manager.rb

@@ -35,33 +35,48 @@ class Puppeteer::FrameManager
     # Keeps track of frames that are in the process of being attached in #onFrameAttached.
     @frames_pending_attachment = {}
     @frame_tree_handled_promise = nil
-    @queued_lifecycle_events = []
+    @queued_frame_events = []
+    @frame_tree_mutex = Mutex.new
 
     setup_listeners(@client)
   end
 
   private def setup_listeners(client)
     client.on_event('Page.frameAttached') do |event|
-      handle_frame_attached(client, event['frameId'], event['parentFrameId'])
+      with_frame_tree_handled do
+        handle_frame_attached(client, event['frameId'], event['parentFrameId'])
+      end
     end
     client.on_event('Page.frameNavigated') do |event|
-      @frame_naviigated_received << event['frame']['id']
-      handle_frame_navigated(event['frame'])
+      with_frame_tree_handled do
+        @frame_naviigated_received << event['frame']['id']
+        handle_frame_navigated(event['frame'])
+      end
     end
     client.on_event('Page.navigatedWithinDocument') do |event|
-      handle_frame_navigated_within_document(event['frameId'], event['url'])
+      with_frame_tree_handled do
+        handle_frame_navigated_within_document(event['frameId'], event['url'])
+      end
     end
     client.on_event('Page.frameDetached') do |event|
-      handle_frame_detached(event['frameId'], event['reason'])
+      with_frame_tree_handled do
+        handle_frame_detached(event['frameId'], event['reason'])
+      end
     end
     client.on_event('Page.frameStartedLoading') do |event|
-      handle_frame_started_loading(event['frameId'])
+      with_frame_tree_handled do
+        handle_frame_started_loading(event['frameId'])
+      end
     end
     client.on_event('Page.frameStoppedLoading') do |event|
-      handle_frame_stopped_loading(event['frameId'])
+      with_frame_tree_handled do
+        handle_frame_stopped_loading(event['frameId'])
+      end
     end
     client.on_event('Runtime.executionContextCreated') do |event|
-      handle_execution_context_created(event['context'], client)
+      with_frame_tree_handled do
+        handle_execution_context_created(event['context'], client)
+      end
     end
     client.on_event('Runtime.executionContextDestroyed') do |event|
       handle_execution_context_destroyed(event['executionContextId'], client)
@@ -70,7 +85,9 @@ class Puppeteer::FrameManager
       handle_execution_contexts_cleared(client)
     end
     client.on_event('Page.lifecycleEvent') do |event|
-      handle_lifecycle_event(event)
+      with_frame_tree_handled do
+        handle_lifecycle_event(event)
+      end
     end
   end
 
@@ -98,15 +115,13 @@ class Puppeteer::FrameManager
   rescue => err
     # The target might have been closed before the initialization finished.
     if err.message.include?('Target closed') || err.message.include?('Session closed')
-      finish_frame_tree_handling(process_queue: false)
+      finish_frame_tree_handling
       return
     end
 
     raise
   ensure
-    if @frame_tree_handled_promise && !@frame_tree_handled_promise.resolved?
-      finish_frame_tree_handling(process_queue: false)
-    end
+    finish_frame_tree_handling if @frame_tree_handled_promise && !@frame_tree_handled_promise.resolved?
     @frames_pending_target_init.delete(target_id)&.resolve(nil)
   end
 
@@ -224,21 +239,52 @@ class Puppeteer::FrameManager
 
   # @param event [Hash]
   def handle_lifecycle_event(event)
-    if @frame_tree_handled_promise && !@frame_tree_handled_promise.resolved?
-      @queued_lifecycle_events << event
-      return
-    end
-
-    handle_lifecycle_event_impl(event)
-  end
-
-  private def handle_lifecycle_event_impl(event)
     frame = @frames[event['frameId']]
     return if !frame
     frame.handle_lifecycle_event(event['loaderId'], event['name'])
     emit_event(FrameManagerEmittedEvents::LifecycleEvent, frame)
   end
 
+  private def with_frame_tree_handled(&block)
+    promise = @frame_tree_handled_promise
+    if promise && !promise.resolved?
+      queued = false
+      @frame_tree_mutex.synchronize do
+        promise = @frame_tree_handled_promise
+        if promise && !promise.resolved?
+          @queued_frame_events << block
+          queued = true
+        end
+      end
+      return if queued
+    end
+    block.call
+  end
+
+  private def prepare_frame_tree_handling
+    queued = nil
+    @frame_tree_mutex.synchronize do
+      if @frame_tree_handled_promise && !@frame_tree_handled_promise.resolved?
+        @frame_tree_handled_promise.resolve(nil)
+        queued = @queued_frame_events
+      end
+      @queued_frame_events = []
+      @frame_tree_handled_promise = Async::Promise.new
+    end
+    queued&.each(&:call)
+  end
+
+  private def finish_frame_tree_handling
+    queued = nil
+    @frame_tree_mutex.synchronize do
+      return unless @frame_tree_handled_promise
+      @frame_tree_handled_promise.resolve(nil) unless @frame_tree_handled_promise.resolved?
+      queued = @queued_frame_events
+      @queued_frame_events = []
+    end
+    queued&.each(&:call)
+  end
+
   # @param frame_id [String]
   def handle_frame_started_loading(frame_id)
     frame = @frames[frame_id]
@@ -270,29 +316,6 @@ class Puppeteer::FrameManager
     end
   end
 
-  private def prepare_frame_tree_handling
-    if @frame_tree_handled_promise && !@frame_tree_handled_promise.resolved?
-      @frame_tree_handled_promise.resolve(nil)
-    end
-    @frame_tree_handled_promise = Async::Promise.new
-    @queued_lifecycle_events = []
-  end
-
-  private def finish_frame_tree_handling(process_queue: true)
-    return unless @frame_tree_handled_promise
-
-    @frame_tree_handled_promise.resolve(nil) unless @frame_tree_handled_promise.resolved?
-    flush_queued_lifecycle_events if process_queue
-  end
-
-  private def flush_queued_lifecycle_events
-    return if @queued_lifecycle_events.empty?
-
-    queued = @queued_lifecycle_events
-    @queued_lifecycle_events = []
-    queued.each { |event| handle_lifecycle_event_impl(event) }
-  end
-
   # @return {!Puppeteer.Page}
   def page
     @page
@@ -394,8 +417,11 @@ class Puppeteer::FrameManager
     if is_main_frame
       if frame
         # Update frame id to retain frame identity on cross-process navigation.
-        @frames.delete(frame.id)
-        frame.id = frame_id
+        if frame.id != frame_id
+          old_frame_id = frame.id
+          @frames.delete(old_frame_id)
+          frame.id = frame_id
+        end
       else
         # Initial main frame navigation.
         frame = Puppeteer::Frame.new(self, nil, frame_id, @client)

data/lib/puppeteer/version.rb

@@ -1,3 +1,3 @@
 module Puppeteer
-  VERSION = '0.50.0.alpha9'
+  VERSION = '0.50.0.alpha10'
 end

data/sig/_supplementary.rbs

@@ -178,10 +178,9 @@ class Puppeteer::FrameManager
 
   def setup_listeners: (Puppeteer::CDPSession client) -> void
   def init: (String target_id, ?Puppeteer::CDPSession cdp_session) -> void
-  def handle_lifecycle_event_impl: (Hash[String, untyped] event) -> void
+  def with_frame_tree_handled: () { () -> void } -> void
   def prepare_frame_tree_handling: () -> void
-  def finish_frame_tree_handling: (?process_queue: bool) -> void
-  def flush_queued_lifecycle_events: () -> void
+  def finish_frame_tree_handling: () -> void
   def attach_child_frame: (Puppeteer::Frame parent_frame, String parent_frame_id, String frame_id, Puppeteer::CDPSession? session) -> void
   def reattach_frame: (Puppeteer::Frame frame, String frame_id, bool is_main_frame, Hash[String, untyped] frame_payload) -> void
   def ensure_isolated_world: (Puppeteer::CDPSession session, String name) -> void
@@ -290,6 +289,9 @@ class Puppeteer::Connection
 
   def sleep_before_handling_message: (Hash[String, untyped] message) -> void
   def should_handle_synchronously?: (Hash[String, untyped] message) -> bool
+  def network_event_message?: (Hash[String, untyped] message) -> bool
+  def ensure_network_message_task: () -> void
+  def enqueue_network_message: (Hash[String, untyped] message) -> void
   def request_debug_printer: () -> untyped
   def response_debug_printer: () -> untyped
   def handle_message: (Hash[String, untyped] message) -> void

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppeteer-ruby
 version: !ruby/object:Gem::Version
-  version: 0.50.0.alpha9
+  version: 0.50.0.alpha10
 platform: ruby
 authors:
 - YusukeIwaki
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-24 00:00:00.000000000 Z
+date: 2026-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: async