puppeteer-ruby 0.37.0 → 0.37.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e46056e6227e597554a407d47c132610af952d42b1cd7c2149e2046e0d8f1bb
-  data.tar.gz: 99a5c6fd6885181e32c72086a768c60583738974a3c86a05a693af2b97b51bc3
+  metadata.gz: 56a2cd3d9440bce6f77f2a072e8c8e7ea83fdd3d65a7e85e1887f7f7dd4481ce
+  data.tar.gz: 337c5cd7e4c23bd5e3c154bbaaae229d4285c8ba491ca427197ee7449c1f1849
 SHA512:
-  metadata.gz: d4b1032b52bb5a0ad92e57f0bac5fe5208b785679f1d7efff0ab335cb28478f6110979102d0ec4759ef2f86654b4d231e018aa9cdb3982dc1ffa2e985fa4c55f
-  data.tar.gz: 42f81fe580fcb85b5c57397962362c3c6b0ba7462fe210c65ee017b9e73c0a3d9d091c03a7b18f6e6d78f3a3c52572a5d0bb8284f1087412344a184e8624170d
+  metadata.gz: '005883b864a160d29a8879a8d54945edbce02f6d1b80a0f8816d84244b46c62d11417e2bcf2bc67e8b7f7a4486dc201ecb2961070fe875fc948be0483be8bcee'
+  data.tar.gz: 1a7cd9d0c2aacde091d0f6d0738c61e4a28a96830f2b65dae8e6e84fd3c190ea69bf8e964748d61020f264bfcbc25901e4e1895289b1a98a7d5452c03e2647de

data/CHANGELOG.md

@@ -1,7 +1,13 @@
-### master [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.37.0...master)]
+### master [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.37.1...master)]
 
 - xxx
 
+### 0.37.1 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.37.0...0.37.1)]
+
+Bugfix:
+
+- Fix handle_SIGINT, handle_SIGTERM, handle_SIGHUP options to work with `false` value specified.
+
 ### 0.37.0 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.36.0...0.37.0)]
 
 New features:

data/docs/api_coverage.md

@@ -1,6 +1,6 @@
 # API coverages
 - Puppeteer version: v10.4.0
-- puppeteer-ruby version: 0.37.0
+- puppeteer-ruby version: 0.37.1
 
 ## Puppeteer
 

data/lib/puppeteer/browser_runner.rb

@@ -94,7 +94,7 @@ class Puppeteer::BrowserRunner
         FileUtils.rm_rf(@temp_directory)
       end
     }
-    trap(:EXIT) do
+    at_exit do
       kill
     end
 

data/lib/puppeteer/launcher/launch_options.rb

@@ -35,9 +35,9 @@ module Puppeteer::Launcher
       @channel = options[:channel]
       @executable_path = options[:executable_path]
       @ignore_default_args = options[:ignore_default_args] || false
-      @handle_SIGINT = options[:handle_SIGINT] || true
-      @handle_SIGTERM = options[:handle_SIGTERM] || true
-      @handle_SIGHUP = options[:handle_SIGHUP] || true
+      @handle_SIGINT = options.fetch(:handle_SIGINT, true)
+      @handle_SIGTERM = options.fetch(:handle_SIGTERM, true)
+      @handle_SIGHUP = options.fetch(:handle_SIGHUP, true)
       @timeout = options[:timeout] || 30000
       @dumpio = options[:dumpio] || false
       @env = options[:env] || ENV

data/lib/puppeteer/network_manager.rb

@@ -142,9 +142,14 @@ class Puppeteer::NetworkManager
   end
 
   # @param user_agent [String]
-  def user_agent=(user_agent)
-    @client.send_message('Network.setUserAgentOverride', userAgent: user_agent)
+  # @param user_agent_metadata [Hash]
+  def set_user_agent(user_agent, user_agent_metadata = nil)
+    @client.send_message('Network.setUserAgentOverride', {
+      userAgent: user_agent,
+      userAgentMetadata: user_agent_metadata,
+    }.compact)
   end
+  alias_method :user_agent=, :set_user_agent
 
   def cache_enabled=(enabled)
     @user_cache_disabled = !enabled

data/lib/puppeteer/page.rb

@@ -461,37 +461,6 @@ class Puppeteer::Page
 
     nil
   end
-  # /**
-  #  * @param {string} name
-  #  * @param {Function} puppeteerFunction
-  #  */
-  # async exposeFunction(name, puppeteerFunction) {
-  #   if (this._pageBindings.has(name))
-  #     throw new Error(`Failed to add page binding with name ${name}: window['${name}'] already exists!`);
-  #   this._pageBindings.set(name, puppeteerFunction);
-
-  #   const expression = helper.evaluationString(addPageBinding, name);
-  #   await this._client.send('Runtime.addBinding', {name: name});
-  #   await this._client.send('Page.addScriptToEvaluateOnNewDocument', {source: expression});
-  #   await Promise.all(this.frames().map(frame => frame.evaluate(expression).catch(debugError)));
-
-  #   function addPageBinding(bindingName) {
-  #     const binding = window[bindingName];
-  #     window[bindingName] = (...args) => {
-  #       const me = window[bindingName];
-  #       let callbacks = me['callbacks'];
-  #       if (!callbacks) {
-  #         callbacks = new Map();
-  #         me['callbacks'] = callbacks;
-  #       }
-  #       const seq = (me['lastSeq'] || 0) + 1;
-  #       me['lastSeq'] = seq;
-  #       const promise = new Promise((resolve, reject) => callbacks.set(seq, {resolve, reject}));
-  #       binding(JSON.stringify({name: bindingName, seq, args}));
-  #       return promise;
-  #     };
-  #   }
-  # }
 
   # @param username [String?]
   # @param password [String?]
@@ -505,9 +474,11 @@ class Puppeteer::Page
   end
 
   # @param user_agent [String]
-  def user_agent=(user_agent)
-    @frame_manager.network_manager.user_agent = user_agent
+  # @param user_agent_metadata [Hash]
+  def set_user_agent(user_agent, user_agent_metadata = nil)
+    @frame_manager.network_manager.set_user_agent(user_agent, user_agent_metadata)
   end
+  alias_method :user_agent=, :set_user_agent
 
   def metrics
     response = @client.send_message('Performance.getMetrics')

data/lib/puppeteer/version.rb

@@ -1,3 +1,3 @@
 module Puppeteer
-  VERSION = '0.37.0'
+  VERSION = '0.37.1'
 end

data/puppeteer-ruby.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rollbar'
   spec.add_development_dependency 'rspec', '~> 3.10.0 '
   spec.add_development_dependency 'rspec_junit_formatter' # for CircleCI.
-  spec.add_development_dependency 'rubocop', '~> 1.21.0'
+  spec.add_development_dependency 'rubocop', '~> 1.22.0'
   spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency 'sinatra'
   spec.add_development_dependency 'webrick'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppeteer-ruby
 version: !ruby/object:Gem::Version
-  version: 0.37.0
+  version: 0.37.1
 platform: ruby
 authors:
 - YusukeIwaki
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-09-29 00:00:00.000000000 Z
+date: 2021-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -170,14 +170,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.21.0
+        version: 1.22.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.21.0
+        version: 1.22.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement