puppeteer-ruby 0.34.0 → 0.34.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5338fde85118520d164288e9853e88f3edfadd0c0d6be491edcbde0c9d5609c
-  data.tar.gz: b6ac2dada9f4c7ce72401cf75b39ca452801165d68d5bd6ae537cf3a390e68ff
+  metadata.gz: 759579a77012a03fa74915957ff0c3ed656ea4cdcc280b2f24fede885d01f361
+  data.tar.gz: 390f5ef626fb791dc9744cfe59a977fcd3a9d45c16d32aec60247a652ef73712
 SHA512:
-  metadata.gz: eacd79d2af5cf69228ef6592739d20fd4f1739ec990355d904c32eb226c5dc998f7a37df7364a145df3e8beb763c304eaa8b1e1707c6aa8a237d4d8ec40f3b07
-  data.tar.gz: f0a725e220a109e0498c34e2f3e0d8e8e979b89d6003124d8cff7bb30c8b3579e72e5d1531a6f80669307d5a81a13f62fe99ee3c811ab9cffcb617bd12969830
+  metadata.gz: aa0d6262ed3953a9b15efc2fdad2be48cd6b22cba0f1b89d7c93b0b9cbd52413705f60fe334cbb57b5f6eabffbb599b98db520859bd1239406def453ca314228
+  data.tar.gz: 84632098cf49cf5201528e2ac620321b83210bfb4f0a5bd6fae48a86fb5009a8c4e791b666eaf82b110eb4fc55a569723266e850381fe1b7dda49bd9830422d2

data/CHANGELOG.md

@@ -1,7 +1,13 @@
-### master [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.34.0...master)]
+### master [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.34.1...master)]
 
 * xxx
 
+### 0.34.1 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.34.0...0.34.1)]
+
+Bugfix:
+
+* Fix `Page#pdf` to work without `path` parameter.
+
 ### 0.34.0 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.33.0...0.34.0)]
 
 New features:

data/docs/api_coverage.md

@@ -1,6 +1,6 @@
 # API coverages
 - Puppeteer version: v10.0.0
-- puppeteer-ruby version: 0.34.0
+- puppeteer-ruby version: 0.34.1
 
 ## Puppeteer
 

data/lib/puppeteer/page.rb

@@ -1008,14 +1008,40 @@ class Puppeteer::Page
     end
   end
 
-  # @return [String]
-  def pdf(options = {})
+  # @return [Enumerable<String>]
+  def create_pdf_stream(options = {})
     pdf_options = PDFOptions.new(options)
     omit_background = options[:omit_background]
     set_transparent_background_color if omit_background
     result = @client.send_message('Page.printToPDF', pdf_options.page_print_args)
     reset_default_background_color if omit_background
-    Puppeteer::ProtocolStreamReader.new(client: @client, handle: result['stream'], path: pdf_options.path).read
+
+    Puppeteer::ProtocolStreamReader.new(
+      client: @client,
+      handle: result['stream'],
+    ).read_as_chunks
+  end
+
+  # @return [String]
+  def pdf(options = {})
+    chunks = create_pdf_stream(options)
+
+    StringIO.open do |stringio|
+      if options[:path]
+        File.open(options[:path], 'wb') do |f|
+          chunks.each do |chunk|
+            f.write(chunk)
+            stringio.write(chunk)
+          end
+        end
+      else
+        chunks.each do |chunk|
+          stringio.write(chunk)
+        end
+      end
+
+      stringio.string
+    end
   rescue => err
     if err.message.include?('PrintToPDF is not implemented')
       raise PrintToPdfIsNotImplementedError.new

data/lib/puppeteer/page/pdf_options.rb

@@ -15,17 +15,10 @@ class Puppeteer::Page
   # * @property {string|number=} height
   # * @property {boolean=} preferCSSPageSize
   # * @property {!{top?: string|number, bottom?: string|number, left?: string|number, right?: string|number}=} margin
-  # * @property {string=} path
   # */
   class PDFOptions
     # @params options [Hash]
     def initialize(options)
-      unless options[:path]
-        # Original puppeteer allows path = nil, however nothing to do without path actually.
-        # Also in most case, users forget to specify path parameter. So let's raise ArgumentError.
-        raise ArgumentError('"path" parameter must be specified.')
-      end
-
       @scale = options[:scale]
       @display_header_footer = options[:display_header_footer]
       @header_template = options[:header_template]
@@ -38,11 +31,8 @@ class Puppeteer::Page
       @height = options[:height]
       @prefer_css_page_size = options[:prefer_css_page_size]
       @margin = Margin.new(options[:margin] || {})
-      @path = options[:path]
     end
 
-    attr_reader :path
-
     class PaperSize
       def initialize(width:, height:)
         @width = width

data/lib/puppeteer/protocol_stream_reader.rb

@@ -1,25 +1,14 @@
 class Puppeteer::ProtocolStreamReader
-  def initialize(client:, handle:, path:)
+  def initialize(client:, handle:)
     @client = client
     @handle = handle
-    @path = path
   end
 
-  def read
-    StringIO.open do |out|
-      if @path
-        File.open(@path, 'wb') do |file|
-          io_read do |data|
-            out.write(data)
-            file.write(data)
-          end
-        end
-      else
-        io_read { |data| out.write(data) }
-      end
+  # @returns [Enumerable<String>]
+  def read_as_chunks
+    Enumerator.new do |out|
+      io_read { |data| out << data }
       io_close
-
-      out.string
     end
   end
 

data/lib/puppeteer/tracing.rb

@@ -45,6 +45,23 @@ class Puppeteer::Tracing
     @recording = false
 
     stream = await stream_promise
-    Puppeteer::ProtocolStreamReader.new(client: @client, handle: stream, path: @path).read
+    chunks = Puppeteer::ProtocolStreamReader.new(client: @client, handle: stream).read_as_chunks
+
+    StringIO.open do |stringio|
+      if @path
+        File.open(@path, 'wb') do |f|
+          chunks.each do |chunk|
+            f.write(chunk)
+            stringio.write(chunk)
+          end
+        end
+      else
+        chunks.each do |chunk|
+          stringio.write(chunk)
+        end
+      end
+
+      stringio.string
+    end
   end
 end

data/lib/puppeteer/version.rb

@@ -1,3 +1,3 @@
 module Puppeteer
-  VERSION = '0.34.0'
+  VERSION = '0.34.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppeteer-ruby
 version: !ruby/object:Gem::Version
-  version: 0.34.0
+  version: 0.34.1
 platform: ruby
 authors:
 - YusukeIwaki
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-06-23 00:00:00.000000000 Z
+date: 2021-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby