puppeteer-ruby 0.32.2 → 0.32.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6c8324de827decfcd0aa132c6bf7e3cf65e451631269038f27062f2970eb8f45
-  data.tar.gz: 70d4558f1dcf29f4c9454d6c33f36e59ab53d8c700adc6852b8c449ab7d1a10c
+  metadata.gz: ec9dc0a222f1d9ab65c345585296fdecfb855b2e4b9f28784e9a8563910ca590
+  data.tar.gz: 7073166d8410e4e3817dfd7cb410a4e260c3b9308031d31f79aa05206a19ebc4
 SHA512:
-  metadata.gz: 6759482be60145918aae8475427bbf9ea2e0548cc2cd6a812fd0b9e943c24542f82cfb9ffbc6910a050cbd6d532b2b1177a5f80688bb3c73650837b900f52ccb
-  data.tar.gz: 181663e004ab1a0ce377e6b3215d1468a4823db3beb86478fd3c213d70f14a6ae8e1aea3191b9c04d8e28a5600a05decb2f21661578be380efde57a5bc0d7000
+  metadata.gz: fd566d6c348d2d15170a59a530ea6a1f5fc4e82180af93e6944f142ed60720dab181f97641d4419e4da92823efbc1a8e72ecbe83c42a5bae1328aac0ea35597e
+  data.tar.gz: 2575db60f2f6f7cfc75a60bf04fa9e55b370000ea8d0371eb32d3178ac1a5ae21803c51e83165c0ea3881576848c97775ba06c505501c90e5b66adf6c3275039

data/CHANGELOG.md

@@ -1,7 +1,14 @@
-### master [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.32.2...master)]
+### master [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.32.3...master)]
 
 * xxx
 
+### 0.32.3 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.32.2...0.32.3)]
+
+Bugfix:
+
+* Fix puppeteer-ruby to work on Rails in development mode.
+
+
 ### 0.32.2 [[diff](https://github.com/YusukeIwaki/puppeteer-ruby/compare/0.32.1...0.32.2)]
 
 Bugfix:

data/docs/api_coverage.md

@@ -81,11 +81,11 @@
 * deleteCookie => `#delete_cookie`
 * emulate
 * emulateIdleState => `#emulate_idle_state`
-* ~~emulateMediaFeatures~~
+* emulateMediaFeatures => `#emulate_media_features`
 * emulateMediaType => `#emulate_media_type`
 * ~~emulateNetworkConditions~~
 * emulateTimezone => `#emulate_timezone`
-* ~~emulateVisionDeficiency~~
+* emulateVisionDeficiency => `#emulate_vision_deficiency`
 * evaluate
 * evaluateHandle => `#evaluate_handle`
 * evaluateOnNewDocument => `#evaluate_on_new_document`

data/lib/puppeteer/browser_runner.rb

@@ -161,14 +161,18 @@ class Puppeteer::BrowserRunner
   end
 
   private def wait_for_ws_endpoint(browser_process, timeout, preferred_revision)
+    lines = []
     Timeout.timeout(timeout / 1000.0) do
       loop do
         line = browser_process.stderr.readline
         /^DevTools listening on (ws:\/\/.*)$/.match(line) do |m|
           return m[1]
         end
+        lines << line
       end
     end
+  rescue EOFError
+    raise LaunchError.new("\n#{lines.join("\n")}\nTROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md")
   rescue Timeout::Error
     raise Puppeteer::TimeoutError.new("Timed out after #{timeout} ms while trying to connect to the browser! Only Chrome at revision r#{preferred_revision} is guaranteed to work.")
   end

data/lib/puppeteer/emulation_manager.rb

@@ -15,8 +15,12 @@ class Puppeteer::EmulationManager
     width = viewport.width
     height = viewport.height
     device_scale_factor = viewport.device_scale_factor
-    # /** @type {Protocol.Emulation.ScreenOrientation} */
-    # const screenOrientation = viewport.isLandscape ? { angle: 90, type: 'landscapePrimary' } : { angle: 0, type: 'portraitPrimary' };
+    screen_orientation =
+      if viewport.landscape?
+        { angle: 90, type: 'landscapePrimary' }
+      else
+        { angle: 0, type: 'portraitPrimary' }
+      end
     has_touch = viewport.has_touch?
 
     await_all(
@@ -25,7 +29,7 @@ class Puppeteer::EmulationManager
         width: width,
         height: height,
         deviceScaleFactor: device_scale_factor,
-        # screenOrientation: screen_orientation,
+        screenOrientation: screen_orientation,
       ),
       @client.async_send_message('Emulation.setTouchEmulationEnabled',
         enabled: has_touch,

data/lib/puppeteer/events.rb

@@ -1,11 +1,9 @@
 require 'digest/md5'
 
 module EventsDefinitionUtils
-  refine Kernel do
-    # Symbol is used to prevent external parties listening to these events
-    def Symbol(str)
-      Digest::MD5.hexdigest(str)
-    end
+  # symbol is used to prevent external parties listening to these events
+  module_function def symbol(str)
+    Digest::MD5.hexdigest(str)
   end
 
   refine Hash do
@@ -28,14 +26,14 @@ using EventsDefinitionUtils
 module ConnectionEmittedEvents ; end
 
 {
-  Disconnected: Symbol('Connection.Disconnected'),
+  Disconnected: EventsDefinitionUtils.symbol('Connection.Disconnected'),
 }.define_const_into(ConnectionEmittedEvents)
 
 # Internal events that the CDPSession class emits.
 module CDPSessionEmittedEvents ; end
 
 {
-  Disconnected: Symbol('CDPSession.Disconnected'),
+  Disconnected: EventsDefinitionUtils.symbol('CDPSession.Disconnected'),
 }.define_const_into(CDPSessionEmittedEvents)
 
 # All the events a Browser may emit.
@@ -82,10 +80,10 @@ module BrowserContextEmittedEvents ; end
 module NetworkManagerEmittedEvents ; end
 
 {
-  Request: Symbol('NetworkManager.Request'),
-  Response: Symbol('NetworkManager.Response'),
-  RequestFailed: Symbol('NetworkManager.RequestFailed'),
-  RequestFinished: Symbol('NetworkManager.RequestFinished'),
+  Request: EventsDefinitionUtils.symbol('NetworkManager.Request'),
+  Response: EventsDefinitionUtils.symbol('NetworkManager.Response'),
+  RequestFailed: EventsDefinitionUtils.symbol('NetworkManager.RequestFailed'),
+  RequestFinished: EventsDefinitionUtils.symbol('NetworkManager.RequestFinished'),
 }.define_const_into(NetworkManagerEmittedEvents)
 
 
@@ -94,13 +92,13 @@ module NetworkManagerEmittedEvents ; end
 module FrameManagerEmittedEvents ; end
 
 {
-  FrameAttached: Symbol('FrameManager.FrameAttached'),
-  FrameNavigated: Symbol('FrameManager.FrameNavigated'),
-  FrameDetached: Symbol('FrameManager.FrameDetached'),
-  LifecycleEvent: Symbol('FrameManager.LifecycleEvent'),
-  FrameNavigatedWithinDocument: Symbol('FrameManager.FrameNavigatedWithinDocument'),
-  ExecutionContextCreated: Symbol('FrameManager.ExecutionContextCreated'),
-  ExecutionContextDestroyed: Symbol('FrameManager.ExecutionContextDestroyed'),
+  FrameAttached: EventsDefinitionUtils.symbol('FrameManager.FrameAttached'),
+  FrameNavigated: EventsDefinitionUtils.symbol('FrameManager.FrameNavigated'),
+  FrameDetached: EventsDefinitionUtils.symbol('FrameManager.FrameDetached'),
+  LifecycleEvent: EventsDefinitionUtils.symbol('FrameManager.LifecycleEvent'),
+  FrameNavigatedWithinDocument: EventsDefinitionUtils.symbol('FrameManager.FrameNavigatedWithinDocument'),
+  ExecutionContextCreated: EventsDefinitionUtils.symbol('FrameManager.ExecutionContextCreated'),
+  ExecutionContextDestroyed: EventsDefinitionUtils.symbol('FrameManager.ExecutionContextDestroyed'),
 }.define_const_into(FrameManagerEmittedEvents)
 
 # All the events that a page instance may emit.

data/lib/puppeteer/page.rb

@@ -49,7 +49,7 @@ class Puppeteer::Page
     @client.on_event('Target.attachedToTarget') do |event|
       if event['targetInfo']['type'] != 'worker'
         # If we don't detach from service workers, they will never die.
-        await @client.send_message('Target.detachFromTarget', sessionId: event['sessionId'])
+        @client.async_send_message('Target.detachFromTarget', sessionId: event['sessionId'])
         next
       end
 
@@ -794,21 +794,20 @@ class Puppeteer::Page
     @client.send_message('Emulation.setEmulatedMedia', media: media_type_str)
   end
 
-  # /**
-  #  * @param {?Array<MediaFeature>} features
-  #  */
-  # async emulateMediaFeatures(features) {
-  #   if (features === null)
-  #     await this._client.send('Emulation.setEmulatedMedia', {features: null});
-  #   if (Array.isArray(features)) {
-  #     features.every(mediaFeature => {
-  #       const name = mediaFeature.name;
-  #       assert(/^prefers-(?:color-scheme|reduced-motion)$/.test(name), 'Unsupported media feature: ' + name);
-  #       return true;
-  #     });
-  #     await this._client.send('Emulation.setEmulatedMedia', {features: features});
-  #   }
-  # }
+  # @param features [Array]
+  def emulate_media_features(features)
+    if features.nil?
+      @client.send_message('Emulation.setEmulatedMedia', features: nil)
+    elsif features.is_a?(Array)
+      features.each do |media_feature|
+        name = media_feature[:name]
+        unless /^(?:prefers-(?:color-scheme|reduced-motion)|color-gamut)$/.match?(name)
+          raise ArgumentError.new("Unsupported media feature: #{name}")
+        end
+      end
+      @client.send_message('Emulation.setEmulatedMedia', features: features)
+    end
+  end
 
   # @param timezone_id [String?]
   def emulate_timezone(timezone_id)
@@ -821,6 +820,23 @@ class Puppeteer::Page
     end
   end
 
+  VISION_DEFICIENCY_TYPES = %w[
+    none
+    achromatopsia
+    blurredVision
+    deuteranopia
+    protanopia
+    tritanopia
+  ].freeze
+
+  def emulate_vision_deficiency(vision_deficiency_type)
+    value = vision_deficiency_type || 'none'
+    unless VISION_DEFICIENCY_TYPES.include?(value)
+      raise ArgumentError.new("Unsupported vision deficiency: #{vision_deficiency_type}")
+    end
+    @client.send_message('Emulation.setEmulatedVisionDeficiency', type: value)
+  end
+
   # @param is_user_active [Boolean]
   # @param is_screen_unlocked [Boolean]
   def emulate_idle_state(is_user_active: nil, is_screen_unlocked: nil)

data/lib/puppeteer/puppeteer.rb

@@ -8,6 +8,8 @@ class Puppeteer::Puppeteer
     @is_puppeteer_core = is_puppeteer_core
   end
 
+  class NoViewport ; end
+
   # @param product [String]
   # @param executable_path [String]
   # @param ignore_default_args [Array<String>|nil]
@@ -42,7 +44,7 @@ class Puppeteer::Puppeteer
     devtools: nil,
     headless: nil,
     ignore_https_errors: nil,
-    default_viewport: nil,
+    default_viewport: NoViewport.new,
     slow_mo: nil
   )
     options = {
@@ -63,8 +65,11 @@ class Puppeteer::Puppeteer
       default_viewport: default_viewport,
       slow_mo: slow_mo,
     }
+    if default_viewport.is_a?(NoViewport)
+      options.delete(:default_viewport)
+    end
 
-    @product_name ||= product
+    @product_name = product
     browser = launcher.launch(options)
     if block_given?
       begin
@@ -118,7 +123,7 @@ class Puppeteer::Puppeteer
   end
 
   private def launcher
-    @launcher ||= Puppeteer::Launcher.new(
+    @launcher = Puppeteer::Launcher.new(
       project_root: @project_root,
       preferred_revision: @preferred_revision,
       is_puppeteer_core: @is_puppeteer_core,

data/lib/puppeteer/version.rb

@@ -1,3 +1,3 @@
 module Puppeteer
-  VERSION = '0.32.2'
+  VERSION = '0.32.3'
 end

data/puppeteer-ruby.gemspec

@@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rollbar'
   spec.add_development_dependency 'rspec', '~> 3.10.0 '
   spec.add_development_dependency 'rspec_junit_formatter' # for CircleCI.
-  spec.add_development_dependency 'rubocop', '~> 1.12.0'
+  spec.add_development_dependency 'rubocop', '~> 1.15.0'
   spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency 'sinatra'
   spec.add_development_dependency 'webrick'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppeteer-ruby
 version: !ruby/object:Gem::Version
-  version: 0.32.2
+  version: 0.32.3
 platform: ruby
 authors:
 - YusukeIwaki
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-04-12 00:00:00.000000000 Z
+date: 2021-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -170,14 +170,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.12.0
+        version: 1.15.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.12.0
+        version: 1.15.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement