puppeteer-ruby 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 499744d122eeb8736a1466f17cf9ee09235f488fb19a95d3902da5529406dab0
-  data.tar.gz: f6b27f599887d385c46914e1b255f9738fd7f946a0ff0a4f83a04075e50e092c
+  metadata.gz: 2764adee69056c36a0112866aa1f35a97ccb655ed81bc2977be9707efed7d121
+  data.tar.gz: 8919e7f0228b6dff08a1ee13906c97ad2d08552b1fd7652bc094b506bc9ac4e5
 SHA512:
-  metadata.gz: 54ece5985462bc3f4f30c1a803fd43a5975845911657431aa33d78d70fba6e242d447869a03b3ad6cf925e0e94315db2df62b4d9d74d8b00e381b8d95326e311
-  data.tar.gz: d7d3ab0af4b1bd69588b3998d0a47031d04d80fe3d0b7b55ec1f4b1a9b3ccd683c857faf06e103b972b9b59d63bda6fdc3e984f410720eeae17922176d518561
+  metadata.gz: c142553b4316d8cf7cf541e41283f01c982fc2f0ece3ffb1f87c258130035e3894062831364284fdfaa6c97771029687232955f7a4e64cb24e8d876aee36f08d
+  data.tar.gz: 5d59f78bb651c955617b0a0fee01b02b9e5aa4907d46d15cc79acf559db8f44d1a2a96ecd76571d3431737bfa8b9fd8a24a9a2ad80c5c8c0cc9754c42d1b75af

data/.github/stale.yml

@@ -0,0 +1,16 @@
+# Number of days of inactivity before an issue becomes stale
+daysUntilStale: 14
+# Number of days of inactivity before a stale issue is closed
+daysUntilClose: 7
+# Issues with these labels will never be considered stale
+exemptLabels:
+  - security
+# Label to use when marking an issue as stale
+staleLabel: inactive
+# Comment to post when marking an issue as stale. Set to `false` to disable
+markComment: >
+  This issue has been automatically marked as stale because it has not had
+  recent activity. It will be closed if no further activity occurs. Thank you
+  for your contributions.
+# Comment to post when closing a stale issue. Set to `false` to disable
+closeComment: false

data/README.md

@@ -46,6 +46,8 @@ end
 ![puppeteer-ruby](https://user-images.githubusercontent.com/11763113/78505735-6e7f3000-77b0-11ea-9c82-9016828dd2a9.gif)
 
 
+More usage examples can be found [here](https://github.com/YusukeIwaki/puppeteer-ruby-example)
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/YusukeIwaki/puppeteer-ruby.

data/lib/puppeteer/cdp_session.rb

@@ -44,8 +44,8 @@ class Puppeteer::CDPSession
           callback.reject(
             Puppeteer::Connection::ProtocolError.new(
               method: callback.method,
-              error_message: response['error']['message'],
-              error_data: response['error']['data']))
+              error_message: message['error']['message'],
+              error_data: message['error']['data']))
         else
           callback.resolve(message['result'])
         end

data/lib/puppeteer/dom_world.rb

@@ -12,6 +12,7 @@ class Puppeteer::DOMWorld
     @frame = frame
     @timeout_settings = timeout_settings
     @context_promise = resolvable_future
+    @pending_destroy = []
     @wait_tasks = Set.new
     @detached = false
   end
@@ -29,20 +30,24 @@ class Puppeteer::DOMWorld
 
     if context
       if @context_promise.fulfilled?
+        @pending_destroy << context._context_id
         @document = nil
         @context_promise = resolvable_future
-        @pending_destroy_exists = true
       end
       @context_promise.fulfill(context)
     #   for (const waitTask of this._waitTasks)
     #     waitTask.rerun();
     else
-      if @pending_destroy_exists
-        @pending_destroy_exists = false
-      else
-        @document = nil
-        @context_promise = resolvable_future
-      end
+      raise ArgumentError.new("context should now be nil. Use #delete_context for clearing document.")
+    end
+  end
+
+  def delete_context(execution_context_id)
+    if @pending_destroy.include?(execution_context_id)
+      @pending_destroy.delete(execution_context_id)
+    else
+      @document = nil
+      @context_promise = resolvable_future
     end
   end
 
@@ -303,16 +308,15 @@ class Puppeteer::DOMWorld
   #   }
   # }
 
-  # /**
-  #  * @param {string} selector
-  #  * @param {!{delay?: number, button?: "left"|"right"|"middle", clickCount?: number}=} options
-  #  */
-  # async click(selector, options) {
-  #   const handle = await this.$(selector);
-  #   assert(handle, 'No node found for selector: ' + selector);
-  #   await handle.click(options);
-  #   await handle.dispose();
-  # }
+  # @param selector [String]
+  # @param delay [Number]
+  # @param button [String] "left"|"right"|"middle"
+  # @param click_count [Number]
+  def click(selector, delay: nil, button: nil, click_count: nil)
+    handle = S(selector)
+    handle.click(delay: delay, button: button, click_count: click_count)
+    handle.dispose
+  end
 
   # /**
   #  * @param {string} selector

data/lib/puppeteer/element_handle.rb

@@ -28,62 +28,89 @@ class Puppeteer::ElementHandle < Puppeteer::JSHandle
     end
   end
 
-  #  async _scrollIntoViewIfNeeded() {
-  #    const error = await this.evaluate(async(element, pageJavascriptEnabled) => {
-  #      if (!element.isConnected)
-  #        return 'Node is detached from document';
-  #      if (element.nodeType !== Node.ELEMENT_NODE)
-  #        return 'Node is not of type HTMLElement';
-  #      // force-scroll if page's javascript is disabled.
-  #      if (!pageJavascriptEnabled) {
-  #        element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
-  #        return false;
-  #      }
-  #      const visibleRatio = await new Promise(resolve => {
-  #        const observer = new IntersectionObserver(entries => {
-  #          resolve(entries[0].intersectionRatio);
-  #          observer.disconnect();
-  #        });
-  #        observer.observe(element);
-  #      });
-  #      if (visibleRatio !== 1.0)
-  #        element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
-  #      return false;
-  #    }, this._page._javascriptEnabled);
-  #    if (error)
-  #      throw new Error(error);
-  #  }
+  class ScrollIntoViewError < StandardError; end
+
+  def scroll_into_view_if_needed
+    js = <<~JAVASCRIPT
+      async(element, pageJavascriptEnabled) => {
+        if (!element.isConnected)
+          return 'Node is detached from document';
+        if (element.nodeType !== Node.ELEMENT_NODE)
+          return 'Node is not of type HTMLElement';
+        // force-scroll if page's javascript is disabled.
+        if (!pageJavascriptEnabled) {
+          element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
+          return false;
+        }
+        const visibleRatio = await new Promise(resolve => {
+          const observer = new IntersectionObserver(entries => {
+            resolve(entries[0].intersectionRatio);
+            observer.disconnect();
+          });
+          observer.observe(element);
+        });
+        if (visibleRatio !== 1.0)
+          element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
+        return false;
+      }
+    JAVASCRIPT
+    error = evaluate(js, @page.javascript_enabled) # returns String or false
+    if error
+      raise ScrollIntoViewError.new(error)
+    end
+  end
 
-  #  /**
-  #   * @return {!Promise<!{x: number, y: number}>}
-  #   */
-  #  async _clickablePoint() {
-  #    const [result, layoutMetrics] = await Promise.all([
-  #      this._client.send('DOM.getContentQuads', {
-  #        objectId: this._remoteObject.objectId
-  #      }).catch(debugError),
-  #      this._client.send('Page.getLayoutMetrics'),
-  #    ]);
-  #    if (!result || !result.quads.length)
-  #      throw new Error('Node is either not visible or not an HTMLElement');
-  #    // Filter out quads that have too small area to click into.
-  #    const {clientWidth, clientHeight} = layoutMetrics.layoutViewport;
-  #    const quads = result.quads.map(quad => this._fromProtocolQuad(quad)).map(quad => this._intersectQuadWithViewport(quad, clientWidth, clientHeight)).filter(quad => computeQuadArea(quad) > 1);
-  #    if (!quads.length)
-  #      throw new Error('Node is either not visible or not an HTMLElement');
-  #    // Return the middle point of the first quad.
-  #    const quad = quads[0];
-  #    let x = 0;
-  #    let y = 0;
-  #    for (const point of quad) {
-  #      x += point.x;
-  #      y += point.y;
-  #    }
-  #    return {
-  #      x: x / 4,
-  #      y: y / 4
-  #    };
-  #  }
+  class Point
+    def initialize(x:, y:)
+      @x = x
+      @y = y
+    end
+
+    def +(other)
+      Point.new(
+        x: @x + other.x,
+        y: @y + other.y,
+      )
+    end
+
+    def /(num)
+      Point.new(
+        x: @x / num,
+        y: @y / num,
+      )
+    end
+
+    attr_reader :x, :y
+  end
+
+  class ElementNotVisibleError < StandardError
+    def initialize
+      super("Node is either not visible or not an HTMLElement")
+    end
+  end
+
+  def clickable_point
+    result = @remote_object.content_quads(@client)
+    if !result || result["quads"].empty?
+      raise ElementNotVisibleError.new
+    end
+
+    # Filter out quads that have too small area to click into.
+    layout_metrics = @client.send_message('Page.getLayoutMetrics')
+    client_width = layout_metrics["layoutViewport"]["clientWidth"]
+    client_height = layout_metrics["layoutViewport"]["clientHeight"]
+
+    quads = result["quads"].
+              map { |quad| from_protocol_quad(quad) }.
+              map { |quad| intersect_quad_with_viewport(quad, client_width, client_height) }.
+              select { |quad| compute_quad_area(quad) > 1 }
+    if quads.empty?
+      raise ElementNotVisibleError.new
+    end
+
+    # Return the middle point of the first quad.
+    quads.first.reduce(:+) / 4
+  end
 
   #  /**
   #   * @return {!Promise<void|Protocol.DOM.getBoxModelReturnValue>}
@@ -94,31 +121,26 @@ class Puppeteer::ElementHandle < Puppeteer::JSHandle
   #    }).catch(error => debugError(error));
   #  }
 
-  #  /**
-  #   * @param {!Array<number>} quad
-  #   * @return {!Array<{x: number, y: number}>}
-  #   */
-  #  _fromProtocolQuad(quad) {
-  #    return [
-  #      {x: quad[0], y: quad[1]},
-  #      {x: quad[2], y: quad[3]},
-  #      {x: quad[4], y: quad[5]},
-  #      {x: quad[6], y: quad[7]}
-  #    ];
-  #  }
+  # @param quad [Array<number>]
+  # @return [Array<Point>]
+  private def from_protocol_quad(quad)
+    quad.each_slice(2).map do |x, y|
+      Point.new(x: x, y: y)
+    end
+  end
 
-  #  /**
-  #   * @param {!Array<{x: number, y: number}>} quad
-  #   * @param {number} width
-  #   * @param {number} height
-  #   * @return {!Array<{x: number, y: number}>}
-  #   */
-  #  _intersectQuadWithViewport(quad, width, height) {
-  #    return quad.map(point => ({
-  #      x: Math.min(Math.max(point.x, 0), width),
-  #      y: Math.min(Math.max(point.y, 0), height),
-  #    }));
-  #  }
+  # @param quad [Array<Point>]
+  # @param width [number]
+  # @param height [number]
+  # @return [Array<Point>]
+  private def intersect_quad_with_viewport(quad, width, height)
+    quad.map do |point|
+      Point.new(
+        x: [[point.x, 0].max, width].min,
+        y: [[point.y, 0].max, height].min,
+      )
+    end
+  end
 
   #  async hover() {
   #    await this._scrollIntoViewIfNeeded();
@@ -126,6 +148,15 @@ class Puppeteer::ElementHandle < Puppeteer::JSHandle
   #    await this._page.mouse.move(x, y);
   #  }
 
+  # @param delay [Number]
+  # @param button [String] "left"|"right"|"middle"
+  # @param click_count [Number]
+  def click(delay: nil, button: nil, click_count: nil)
+    scroll_into_view_if_needed
+    point = clickable_point
+    @page.mouse.click(point.x, point.y, delay: delay, button: button, click_count: click_count)
+  end
+
   #  /**
   #   * @param {!{delay?: number, button?: "left"|"right"|"middle", clickCount?: number}=} options
   #   */
@@ -430,4 +461,11 @@ class Puppeteer::ElementHandle < Puppeteer::JSHandle
   #      return visibleRatio > 0;
   #    });
   #  }
+
+  # @param quad [Array<Point>]
+  private def compute_quad_area(quad)
+    # Compute sum of all directed areas of adjacent triangles
+    # https://en.wikipedia.org/wiki/Polygon#Simple_polygons
+    quad.zip(quad.rotate).map { |p1, p2| (p1.x * p2.y - p2.x * p1.y) / 2 }.reduce(:+).abs
+  end
 end

data/lib/puppeteer/execution_context.rb

@@ -16,6 +16,11 @@ class Puppeteer::ExecutionContext
 
   attr_reader :client, :world
 
+  # only used in DomWorld#delete_context
+  def _context_id
+    @context_id
+  end
+
   # @return [Puppeteer::Frame]
   def frame
     if_present(@world) do |world|

data/lib/puppeteer/frame.rb

@@ -143,8 +143,10 @@ class Puppeteer::Frame
     @main_world.add_style_tag(style_tag)
   end
 
-  # @param {string} selector
-  # @param {!{delay?: number, button?: "left"|"right"|"middle", clickCount?: number}=} options
+  # @param selector [String]
+  # @param delay [Number]
+  # @param button [String] "left"|"right"|"middle"
+  # @param click_count [Number]
   def click(selector, delay: nil, button: nil, click_count: nil)
     @secondary_world.click(selector, delay: delay, button: button, click_count: click_count)
   end
@@ -268,8 +270,8 @@ class Puppeteer::Frame
 
   def detach
     @detached = true
-    #   this._mainWorld._detach();
-    #   this._secondaryWorld._detach();
+    @main_world.detach
+    @secondary_world.detach
     if @parent_frame
       @parent_frame._child_frames.delete(self)
     end

data/lib/puppeteer/frame_manager.rb

@@ -206,12 +206,12 @@ class Puppeteer::FrameManager
   # @param {string} frameId
   # @param {?string} parentFrameId
   def handle_frame_attached(frame_id, parent_frame_id)
-    return if @frames.has_key?[frame_id]
+    return if @frames.has_key?(frame_id)
     if !parent_frame_id
       raise ArgymentError.new('parent_frame_id must not be nil')
     end
     parent_frame = @frames[parent_frame_id]
-    frame = Frame.new(self, @client, parent_frame, frame_id)
+    frame = Puppeteer::Frame.new(self, @client, parent_frame, frame_id)
     @frames[frame_id] = frame
 
     emit_event 'Events.FrameManager.FrameAttached', frame
@@ -332,12 +332,12 @@ class Puppeteer::FrameManager
     @context_id_to_context.delete(execution_context_id)
     @context_id_created.delete(execution_context_id)
     if context.world
-      context.world.context = nil
+      context.world.delete_context(execution_context_id)
     end
   end
 
   def handle_execution_contexts_cleared
-    # executionContextCleared is often notified after executionContextCreated.
+    # executionContextsCleared is often notified after executionContextCreated.
     #   D, [2020-04-06T01:47:03.101227 #13823] DEBUG -- : RECV << {"method"=>"Runtime.executionContextCreated", "params"=>{"context"=>{"id"=>5, "origin"=>"https://github.com", "name"=>"", "auxData"=>{"isDefault"=>true, "type"=>"default", "frameId"=>"71C347B70848B89DDDEFAA8AB5B0BC92"}}}, "sessionId"=>"53F088EED260C28001D26A019F95D9E3"}
     #   D, [2020-04-06T01:47:03.101439 #13823] DEBUG -- : RECV << {"method"=>"Page.frameNavigated", "params"=>{"frame"=>{"id"=>"71C347B70848B89DDDEFAA8AB5B0BC92", "loaderId"=>"80338225D035AC96BAE8F6D4E81C7D51", "url"=>"https://github.com/search?q=puppeteer", "securityOrigin"=>"https://github.com", "mimeType"=>"text/html"}}, "sessionId"=>"53F088EED260C28001D26A019F95D9E3"}
     #   D, [2020-04-06T01:47:03.101325 #13823] DEBUG -- : RECV << {"method"=>"Target.targetInfoChanged", "params"=>{"targetInfo"=>{"targetId"=>"71C347B70848B89DDDEFAA8AB5B0BC92", "type"=>"page", "title"=>"https://github.com/search?q=puppeteer", "url"=>"https://github.com/search?q=puppeteer", "attached"=>true, "browserContextId"=>"AF37BC660284CE1552B4ECB147BE9305"}}}
@@ -346,9 +346,9 @@ class Puppeteer::FrameManager
     # To avoid the problem, just skip recent created ids.
     now = Time.now
     context_ids_to_skip = @context_id_created.select { |k, v| now - v < 1 }.keys
-    @context_id_to_context.reject { |k, v| context_ids_to_skip.include?(k) }.each_value do |context|
+    @context_id_to_context.reject { |k, v| context_ids_to_skip.include?(k) }.each do |execution_context_id, context|
       if context.world
-        context.world.context = nil
+        context.world.delete_context(execution_context_id)
       end
     end
     @context_id_to_context.select! { |k, v| context_ids_to_skip.include?(k) }

data/lib/puppeteer/js_handle.rb

@@ -116,7 +116,6 @@ class Puppeteer::JSHandle
     nil
   end
 
-  # @return [Future]
   def dispose
     return if @disposed
 

data/lib/puppeteer/keyboard.rb

@@ -178,6 +178,6 @@ class Puppeteer::Keyboard
   # @param key [String]
   # @return [Future]
   async def async_press(key, delay: nil)
-    press(key, delay)
+    press(key, delay: delay)
   end
 end

data/lib/puppeteer/keyboard/us_keyboard_layout.rb

@@ -41,10 +41,10 @@ class Puppeteer::Keyboard
     'Backspace': KeyDefinition.new({ 'keyCode': 8, 'code': 'Backspace', 'key': 'Backspace' }),
     'Tab': KeyDefinition.new({ 'keyCode': 9, 'code': 'Tab', 'key': 'Tab' }),
     'Numpad5': KeyDefinition.new({ 'keyCode': 12, 'shiftKeyCode': 101, 'key': 'Clear', 'code': 'Numpad5', 'shiftKey': '5', 'location': 3 }),
-    'NumpadEnter': KeyDefinition.new({ 'keyCode': 13, 'code': 'NumpadEnter', 'key': 'Enter', 'text': '\r', 'location': 3 }),
-    'Enter': KeyDefinition.new({ 'keyCode': 13, 'code': 'Enter', 'key': 'Enter', 'text': '\r' }),
-    '\r': KeyDefinition.new({ 'keyCode': 13, 'code': 'Enter', 'key': 'Enter', 'text': '\r' }),
-    '\n': KeyDefinition.new({ 'keyCode': 13, 'code': 'Enter', 'key': 'Enter', 'text': '\r' }),
+    'NumpadEnter': KeyDefinition.new({ 'keyCode': 13, 'code': 'NumpadEnter', 'key': 'Enter', 'text': "\r", 'location': 3 }),
+    'Enter': KeyDefinition.new({ 'keyCode': 13, 'code': 'Enter', 'key': 'Enter', 'text': "\r" }),
+    "\r": KeyDefinition.new({ 'keyCode': 13, 'code': 'Enter', 'key': 'Enter', 'text': "\r" }),
+    "\n": KeyDefinition.new({ 'keyCode': 13, 'code': 'Enter', 'key': 'Enter', 'text': "\r" }),
     'ShiftLeft': KeyDefinition.new({ 'keyCode': 16, 'code': 'ShiftLeft', 'key': 'Shift', 'location': 1 }),
     'ShiftRight': KeyDefinition.new({ 'keyCode': 16, 'code': 'ShiftRight', 'key': 'Shift', 'location': 2 }),
     'ControlLeft': KeyDefinition.new({ 'keyCode': 17, 'code': 'ControlLeft', 'key': 'Control', 'location': 1 }),

data/lib/puppeteer/lifecycle_watcher.rb

@@ -50,6 +50,11 @@ class Puppeteer::LifecycleWatcher
     end
   end
 
+  class FrameDetachedError < StandardError
+    def initialize
+      super('Navigating frame was detached')
+    end
+  end
   class TerminatedError < StandardError; end
 
   #  * @param {!Puppeteer.FrameManager} frameManager
@@ -92,7 +97,7 @@ class Puppeteer::LifecycleWatcher
   # @param frame [Puppeteer::Frame]
   def handle_frame_detached(frame)
     if @frame == frame
-      # this._terminationCallback.call(null, new Error('Navigating frame was detached'));
+      @termination_promise.reject(FrameDetachedError.new)
       return
     end
     check_lifecycle_complete

data/lib/puppeteer/mouse.rb

@@ -37,8 +37,8 @@ class Puppeteer::Mouse
       @client.send_message('Input.dispatchMouseEvent',
         type: 'mouseMoved',
         button: @button,
-        x: from_x + (@x - from_x) * n / steps,
-        y: from_y + (@y - from_y) * n / steps,
+        x: from_x + (@x - from_x) * n / move_steps,
+        y: from_y + (@y - from_y) * n / move_steps,
         modifiers: @keyboard.modifiers,
       )
     end
@@ -56,16 +56,19 @@ class Puppeteer::Mouse
   # @param y [number]
   # @param {!{delay?: number, button?: "left"|"right"|"middle", clickCount?: number}=} options
   def click(x, y, delay: nil, button: nil, click_count: nil)
+    # await_all(async_move, async_down, async_up) often breaks the order of CDP commands.
+    # D, [2020-04-15T17:09:47.895895 #88683] DEBUG -- : RECV << {"id"=>23, "result"=>{"layoutViewport"=>{"pageX"=>0, "pageY"=>1, "clientWidth"=>375, "clientHeight"=>667}, "visualViewport"=>{"offsetX"=>0, "offsetY"=>0, "pageX"=>0, "pageY"=>1, "clientWidth"=>375, "clientHeight"=>667, "scale"=>1, "zoom"=>1}, "contentSize"=>{"x"=>0, "y"=>0, "width"=>375, "height"=>2007}}, "sessionId"=>"0B09EA5E18DEE403E525B3E7FCD7E225"}
+    # D, [2020-04-15T17:09:47.898422 #88683] DEBUG -- : SEND >> {"sessionId":"0B09EA5E18DEE403E525B3E7FCD7E225","method":"Input.dispatchMouseEvent","params":{"type":"mouseReleased","button":"left","x":0,"y":0,"modifiers":0,"clickCount":1},"id":24}
+    # D, [2020-04-15T17:09:47.899711 #88683] DEBUG -- : SEND >> {"sessionId":"0B09EA5E18DEE403E525B3E7FCD7E225","method":"Input.dispatchMouseEvent","params":{"type":"mousePressed","button":"left","x":0,"y":0,"modifiers":0,"clickCount":1},"id":25}
+    # D, [2020-04-15T17:09:47.900237 #88683] DEBUG -- : SEND >> {"sessionId":"0B09EA5E18DEE403E525B3E7FCD7E225","method":"Input.dispatchMouseEvent","params":{"type":"mouseMoved","button":"left","x":187,"y":283,"modifiers":0},"id":26}
+    # So we execute move in advance.
+    move(x, y)
     if delay
-      await_all(
-        async_move(x, y),
-        async_down(button: button, click_count: click_count),
-      )
+      down(button: button, click_count: click_count)
       sleep(delay / 1000.0)
       up(button: button, click_count: click_count)
     else
       await_all(
-        async_move(x, y),
         async_down(button: button, click_count: click_count),
         async_up(button: button, click_count: click_count),
       )

data/lib/puppeteer/page.rb

@@ -173,7 +173,7 @@ class Puppeteer::Page
   #   await this._client.send('Emulation.setGeolocationOverride', {longitude, latitude, accuracy});
   # }
 
-  attr_reader :target
+  attr_reader :javascript_enabled, :target
 
   def browser
     @target.browser
@@ -932,12 +932,23 @@ class Puppeteer::Page
 
   attr_reader :mouse
 
-  # @param {string} selector
-  # @param {!{delay?: number, button?: "left"|"right"|"middle", clickCount?: number}=} options
+  # @param selector [String]
+  # @param delay [Number]
+  # @param button [String] "left"|"right"|"middle"
+  # @param click_count [Number]
   def click(selector, delay: nil, button: nil, click_count: nil)
     main_frame.click(selector, delay: delay, button: button, click_count: click_count)
   end
 
+  # @param selector [String]
+  # @param delay [Number]
+  # @param button [String] "left"|"right"|"middle"
+  # @param click_count [Number]
+  # @return [Future]
+  async def async_click(selector, delay: nil, button: nil, click_count: nil)
+    click(selector, delay: delay, button: button, click_count: click_count)
+  end
+
   # @param {string} selector
   def focus(selector)
     main_frame.focus(selector)

data/lib/puppeteer/remote_object.rb

@@ -57,6 +57,11 @@ class Puppeteer::RemoteObject
     client.send_message('DOM.describeNode', objectId: @object_id)
   end
 
+  # used in ElementHandle#clickable_point
+  def content_quads(client)
+    client.send_message('DOM.getContentQuads', objectId: @object_id)
+  end
+
   # helper#valueFromRemoteObject
   def value
     if @unserializable_value

data/lib/puppeteer/version.rb

@@ -1,3 +1,3 @@
 class Puppeteer
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppeteer-ruby
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - YusukeIwaki
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-12 00:00:00.000000000 Z
+date: 2020-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -130,6 +130,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
+- ".github/stale.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"