puppeteer-ruby 0.0.2 → 0.0.3

data/lib/puppeteer/launcher.rb

@@ -14,7 +14,7 @@ module Puppeteer::Launcher
   # @return {!Puppeteer.ProductLauncher}
   module_function def new(project_root:, preferred_revision:, is_puppeteer_core:, product:)
     if product == 'firefox'
-      raise NotImplementedError.new("FirefoxLauncher is not implemented yet.")
+      raise NotImplementedError.new('FirefoxLauncher is not implemented yet.')
     end
 
     Chrome.new(

data/lib/puppeteer/launcher/base.rb

@@ -8,7 +8,7 @@ module Puppeteer::Launcher
       @is_puppeteer_core = is_puppeteer_core
     end
 
-    class ExecutablePathNotFound < StandardError ; end
+    class ExecutablePathNotFound < StandardError; end
 
     # @returns [String] Chrome Executable file path.
     # @raise [ExecutablePathNotFound]
@@ -25,7 +25,7 @@ module Puppeteer::Launcher
       end
 
       # temporal logic.
-      if RUBY_PLATFORM.include?("darwin") # MacOS
+      if RUBY_PLATFORM.include?('darwin') # MacOS
         '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome'
       else
         '/usr/bin/google-chrome'

data/lib/puppeteer/launcher/chrome.rb

@@ -24,7 +24,7 @@ module Puppeteer::Launcher
       #
       # let temporaryUserDataDir = null;
 
-      if chrome_arguments.none?{ |arg| arg.start_with?('--remote-debugging-') }
+      if chrome_arguments.none? { |arg| arg.start_with?('--remote-debugging-') }
         if @launch_options.pipe?
           chrome_arguments << '--remote-debugging-pipe'
         else
@@ -33,7 +33,7 @@ module Puppeteer::Launcher
       end
 
       temporary_user_data_dir = nil
-      if chrome_arguments.none?{ |arg| arg.start_with?('--user-data-dir') }
+      if chrome_arguments.none? { |arg| arg.start_with?('--user-data-dir') }
         temporary_user_data_dir = Dir.mktmpdir('puppeteer_dev_profile-')
         chrome_arguments << "--user-data-dir=#{temporary_user_data_dir}"
       end
@@ -48,7 +48,7 @@ module Puppeteer::Launcher
         dumpio: @launch_options.dumpio?,
         env: @launch_options.env,
         pipe: use_pipe,
-      );
+      )
 
       begin
         connection = runner.setup_connection(
@@ -64,7 +64,7 @@ module Puppeteer::Launcher
           ignore_https_errors: @browser_options.ignore_https_errors?,
           default_viewport: @browser_options.default_viewport,
           process: runner.proc,
-          close_callback: ->{ runner.close },
+          close_callback: -> { runner.close },
         )
 
         browser.wait_for_target(predicate: ->(target) { target.type == 'page' })
@@ -115,7 +115,7 @@ module Puppeteer::Launcher
           chrome_arguments << '--auto-open-devtools-for-tabs'
         end
 
-        if (chrome_arg_options.headless?)
+        if chrome_arg_options.headless?
           chrome_arguments.concat([
             '--headless',
             '--hide-scrollbars',
@@ -123,7 +123,7 @@ module Puppeteer::Launcher
           ])
         end
 
-        if chrome_arg_options.args.all?{ |arg| arg.start_with?('-') }
+        if chrome_arg_options.args.all? { |arg| arg.start_with?('-') }
           chrome_arguments << 'about:blank'
         end
 

data/lib/puppeteer/lifecycle_watcher.rb

@@ -50,7 +50,7 @@ class Puppeteer::LifecycleWatcher
     end
   end
 
-  class TerminatedError < StandardError ; end
+  class TerminatedError < StandardError; end
 
   #  * @param {!Puppeteer.FrameManager} frameManager
   #  * @param {!Puppeteer.Frame} frame
@@ -118,15 +118,13 @@ class Puppeteer::LifecycleWatcher
 
   def timeout_or_termination_promise
     if @timeout > 0
-      future {
-        begin
-          Timeout.timeout(@timeout / 1000.0) do
-            @termination_promise.value!
-          end
-        rescue Timeout::Error
-          raise Puppeteer::FrameManager::NavigationError.new("Navigation timeout of #{@timeout}ms exceeded")
+      future do
+        Timeout.timeout(@timeout / 1000.0) do
+          @termination_promise.value!
         end
-      }
+      rescue Timeout::Error
+        raise Puppeteer::FrameManager::NavigationError.new("Navigation timeout of #{@timeout}ms exceeded")
+      end
     else
       @termination_promise
     end

data/lib/puppeteer/network_manager.rb

@@ -107,7 +107,7 @@ class Puppeteer::NetworkManager
       update_protocol_cache_disabled
       @client.send_message('Fetch.enable',
         handleAuthRequests: true,
-        patterns: [{urlPattern: '*'}],
+        patterns: [{ urlPattern: '*' }],
       )
     else
       update_protocol_cache_disabled

data/lib/puppeteer/page.rb

@@ -34,12 +34,12 @@ class Puppeteer::Page
     @mouse = Puppeteer::Mouse.new(client, @keyboard)
     @timeout_settings = Puppeteer::TimeoutSettings.new
     @touchscreen = Puppeteer::TouchScreen.new(client, @keyboard)
-    #@accessibility = Accessibility.new(client)
+    # @accessibility = Accessibility.new(client)
     @frame_manager = Puppeteer::FrameManager.new(client, self, ignore_https_errors, @timeout_settings)
     @emulation_manager = Puppeteer::EmulationManager.new(client)
-    #@tracing = Tracing.new(client)
+    # @tracing = Tracing.new(client)
     @page_bindings = {}
-    #@coverage = Coverage.new(client)
+    # @coverage = Coverage.new(client)
     @javascript_enabled = true
     @screenshot_task_queue = screenshot_task_queue
 
@@ -183,21 +183,21 @@ class Puppeteer::Page
     @target.browser_context
   end
 
-  class TargetCrashedError < StandardError ; end
+  class TargetCrashedError < StandardError; end
 
   private def handle_target_crashed
     emit_event 'error', TargetCrashedError.new('Page crashed!')
   end
 
   private def handle_log_entry_added(event)
-    entry = event["entry"]
-    level = entry["level"]
-    text = entry["text"]
-    source = entry["source"]
-    url = entry["url"]
-    line_number = entry["lineNumber"]
-
-    if_present(entry["args"]) do |args|
+    entry = event['entry']
+    level = entry['level']
+    text = entry['text']
+    source = entry['source']
+    url = entry['url']
+    line_number = entry['lineNumber']
+
+    if_present(entry['args']) do |args|
       args.map do |arg|
         Puppeteer::RemoteObject.new(arg).async_release(@client)
       end
@@ -205,7 +205,7 @@ class Puppeteer::Page
     if source != 'worker'
       console_message_location = Puppeteer::ConsoleMessage::Location.new(
                                     url: url, line_number: line_number)
-      emit_event("Events.Page.Console",
+      emit_event('Events.Page.Console',
         Puppeteer::ConsoleMessage.new(level, text, [], console_message_location))
     end
   end
@@ -686,7 +686,7 @@ class Puppeteer::Page
     if_present(entries[index]) do |entry|
       await_all(
         async_wait_for_navigation(timeout: timeout, wait_until: wait_until),
-        @client.async_send_message('Page.navigateToHistoryEntry', entryId: entry['id'])
+        @client.async_send_message('Page.navigateToHistoryEntry', entryId: entry['id']),
       )
     end
   end
@@ -699,9 +699,9 @@ class Puppeteer::Page
 
   # @param {boolean} enabled
   def javascript_enabled=(enabled)
-    return if (@javascript_enabled == enabled)
+    return if @javascript_enabled == enabled
     @javascript_enabled = enabled
-    @client.send_message('Emulation.setScriptExecutionDisabled', value: !enabled);
+    @client.send_message('Emulation.setScriptExecutionDisabled', value: !enabled)
   end
 
   # /**
@@ -788,7 +788,7 @@ class Puppeteer::Page
   def screenshot(options = {})
     screenshot_options = ScreenshotOptions.new(options)
 
-    #@screenshot_task_queue.post_task(-> { screenshot_task(screenshot_options.type, screenshot_options) })
+    # @screenshot_task_queue.post_task(-> { screenshot_task(screenshot_options.type, screenshot_options) })
     screenshot_task(screenshot_options.type, screenshot_options)
   end
 
@@ -796,7 +796,7 @@ class Puppeteer::Page
   # @param {!ScreenshotOptions=} options
   # @return {!Promise<!Buffer|!String>}
   private def screenshot_task(format, screenshot_options)
-    @client.send_message('Target.activateTarget', targetId: @target.target_id);
+    @client.send_message('Target.activateTarget', targetId: @target.target_id)
 
     clip = if_present(screenshot_options.clip) do |rect|
       x = rect[:x].round

data/lib/puppeteer/remote_object.rb

@@ -5,10 +5,10 @@ class Puppeteer::RemoteObject
 
   # @param payload [Hash]
   def initialize(payload)
-    @object_id = payload["objectId"]
-    @sub_type = payload["subtype"]
-    @unserializable_value = payload["unserializableValue"]
-    @value = payload["value"]
+    @object_id = payload['objectId']
+    @sub_type = payload['subtype']
+    @unserializable_value = payload['unserializableValue']
+    @value = payload['value']
   end
 
   attr_reader :sub_type
@@ -35,8 +35,8 @@ class Puppeteer::RemoteObject
         'returnByValue': true,
         'awaitPromise': true,
       }
-      response = client.send_message("Runtime.callFunctionOn", params)
-      Puppeteer::RemoteObject.new(response["result"])
+      response = client.send_message('Runtime.callFunctionOn', params)
+      Puppeteer::RemoteObject.new(response['result'])
     else
       nil
     end
@@ -54,7 +54,7 @@ class Puppeteer::RemoteObject
 
   # used in ElementHandle#content_frame
   def node_info(client)
-    client.send_message("DOM.describeNode", objectId: @object_id)
+    client.send_message('DOM.describeNode', objectId: @object_id)
   end
 
   # helper#valueFromRemoteObject
@@ -74,7 +74,7 @@ class Puppeteer::RemoteObject
       #   default:
       #     throw new Error('Unsupported unserializable value: ' + remoteObject.unserializableValue);
       # }
-      raise NotImplementedError.new("unserializable_value is not implemented yet")
+      raise NotImplementedError.new('unserializable_value is not implemented yet')
     else
       @value
     end

data/lib/puppeteer/target.rb

@@ -45,11 +45,11 @@ class Puppeteer::Target
 
   attr_reader :target_id, :initialized_promise
 
-  class InitializeFailure < StandardError ; end
+  class InitializeFailure < StandardError; end
 
   def handle_initialized(success)
     unless success
-      @initialized_promise.reject(InitializeFailure.new("Failed to create target for page"))
+      @initialized_promise.reject(InitializeFailure.new('Failed to create target for page'))
     end
     @on_initialize_succeeded&.call
     @initialized_promise.fulfill(true)

data/lib/puppeteer/version.rb

@@ -1,3 +1,3 @@
 class Puppeteer
-  VERSION = "0.0.2"
+  VERSION = '0.0.3'
 end

data/lib/puppeteer/wait_task.rb

@@ -1,5 +1,5 @@
 class Puppeteer::WaitTask
-  class TerminatedError < StandardError ; end
+  class TerminatedError < StandardError; end
 
   def initialize
   end

data/lib/puppeteer/web_socket.rb

@@ -37,6 +37,9 @@ class Puppeteer::WebSocket
 
     Thread.new do
       wait_for_data until @ready_state >= STATE_CLOSING
+    rescue EOFError
+      # Google Chrome was gone.
+      # We have nothing todo. Just finish polling.
     end
   end
 

data/puppeteer-ruby.gemspec

@@ -18,11 +18,11 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'concurrent-ruby', "~> 1.1.0"
+  spec.add_dependency 'concurrent-ruby', '~> 1.1.0'
   spec.add_dependency 'websocket-driver', '>= 0.6.0'
   spec.add_dependency 'mime-types', '>= 3.0'
   spec.add_development_dependency 'bundler', '~> 1.17'
-  spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'pry-byebug'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rubocop', '~> 0.80.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppeteer-ruby
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - YusukeIwaki
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-04-05 00:00:00.000000000 Z
+date: 2020-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1.17'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -129,6 +129,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -140,7 +141,6 @@ files:
 - bin/console
 - bin/setup
 - docker-compose.yml
-- example.rb
 - lib/puppeteer.rb
 - lib/puppeteer/async_await_behavior.rb
 - lib/puppeteer/browser.rb

data/example.rb

@@ -1,7 +0,0 @@
-require 'puppeteer';
-
-Puppeteer.launch(headless: false) do |browser|
-  page = browser.pages.first || browser.new_page
-  page.goto("https://github.com/YusukeIwaki")
-  page.screenshot(path: "YusukeIwaki.png")
-end