puppeteer-ruby 0.0.18 → 0.0.23

data/lib/puppeteer/dialog.rb

@@ -0,0 +1,34 @@
+class Puppeteer::Dialog
+  def initialize(client, type:, message:, default_value:)
+    @client = client
+    @type = type
+    @message = message
+    @default_value = default_value || ''
+  end
+
+  attr_reader :type, :message, :default_value
+
+  # @param prompt_text - optional text that will be entered in the dialog
+  # prompt. Has no effect if the dialog's type is not `prompt`.
+  #
+  # @returns A promise that resolves when the dialog has been accepted.
+  def accept(prompt_text = nil)
+    if @handled
+      raise 'Cannot accept dialog which is already handled!'
+    end
+    @handled = true
+    @client.send_message('Page.handleJavaScriptDialog', {
+      accept: true,
+      promptText: prompt_text,
+    }.compact)
+  end
+
+  # @returns A promise which will resolve once the dialog has been dismissed
+  def dismiss
+    if @handled
+      raise 'Cannot accept dialog which is already handled!'
+    end
+    @handled = true
+    @client.send_message('Page.handleJavaScriptDialog', accept: false)
+  end
+end

data/lib/puppeteer/dom_world.rb

@@ -134,7 +134,7 @@ class Puppeteer::DOMWorld
 
   # @return [String]
   def content
-    evaluate <<-JAVASCRIPT
+    evaluate(<<-JAVASCRIPT)
     () => {
       let retVal = '';
       if (document.doctype)
@@ -151,7 +151,7 @@ class Puppeteer::DOMWorld
   # @param wait_until [String|Array<String>]
   def set_content(html, timeout: nil, wait_until: nil)
     option_wait_until = [wait_until || 'load'].flatten
-    option_timeout = @timeout_settings.navigation_timeout
+    option_timeout = timeout || @timeout_settings.navigation_timeout
 
     # We rely upon the fact that document.open() will reset frame lifecycle with "init"
     # lifecycle event. @see https://crrev.com/608658

data/lib/puppeteer/element_handle.rb

@@ -43,7 +43,24 @@ class Puppeteer::ElementHandle < Puppeteer::JSHandle
         if (element.nodeType !== Node.ELEMENT_NODE)
           return 'Node is not of type HTMLElement';
 
-        element.scrollIntoViewIfNeeded({block: 'center', inline: 'center', behavior: 'instant'});
+        if (element.scrollIntoViewIfNeeded) {
+          element.scrollIntoViewIfNeeded({block: 'center', inline: 'center', behavior: 'instant'});
+        } else {
+          // force-scroll if page's javascript is disabled.
+          if (!pageJavascriptEnabled) {
+            element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
+            return false;
+          }
+          const visibleRatio = await new Promise(resolve => {
+            const observer = new IntersectionObserver(entries => {
+              resolve(entries[0].intersectionRatio);
+              observer.disconnect();
+            });
+            observer.observe(element);
+          });
+          if (visibleRatio !== 1.0)
+            element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
+        }
         return false;
       }
     JAVASCRIPT

data/lib/puppeteer/env.rb

@@ -9,6 +9,11 @@ class Puppeteer::Env
   def ci?
     ['1', 'true'].include?(ENV['CI'].to_s)
   end
+
+  # check if running on macOS
+  def darwin?
+    RUBY_PLATFORM.include?('darwin')
+  end
 end
 
 class Puppeteer

data/lib/puppeteer/event_callbackable.rb

@@ -31,6 +31,8 @@ module Puppeteer::EventCallbackable
     (@event_listeners[event_name] ||= EventListeners.new).add(&block)
   end
 
+  alias_method :on, :add_event_listener
+
   def remove_event_listener(*id_args)
     (@event_listeners ||= {}).each do |event_name, listeners|
       id_args.each do |id|
@@ -50,6 +52,8 @@ module Puppeteer::EventCallbackable
     end
   end
 
+  alias_method :once, :observe_first
+
   def on_event(event_name, &block)
     @event_callbackable_handlers ||= {}
     @event_callbackable_handlers[event_name] = block

data/lib/puppeteer/events.rb

@@ -0,0 +1,184 @@
+require 'digest/md5'
+
+module EventsDefinitionUtils
+  refine Kernel do
+    # Symbol is used to prevent external parties listening to these events
+    def Symbol(str)
+      Digest::MD5.hexdigest(str)
+    end
+  end
+
+  refine Hash do
+    def define_const_into(target_module)
+      each do |key, value|
+        target_module.const_set(key, value)
+        target_module.define_singleton_method(key) { value }
+      end
+      keyset = Set.new(keys)
+      valueset = Set.new(values)
+      target_module.define_singleton_method(:keys) { keyset }
+      target_module.define_singleton_method(:values) { valueset }
+    end
+  end
+end
+
+using EventsDefinitionUtils
+
+# Internal events that the Connection class emits.
+module ConnectionEmittedEvents ; end
+
+{
+  Disconnected: Symbol('Connection.Disconnected'),
+}.define_const_into(ConnectionEmittedEvents)
+
+# Internal events that the CDPSession class emits.
+module CDPSessionEmittedEvents ; end
+
+{
+  Disconnected: Symbol('CDPSession.Disconnected'),
+}.define_const_into(CDPSessionEmittedEvents)
+
+# All the events a Browser may emit.
+module BrowserEmittedEvents ; end
+
+{
+  # Emitted when Puppeteer gets disconnected from the Chromium instance. This might happen because of one of the following:
+  # - Chromium is closed or crashed
+  # - The Browser#disconnect method was called.
+  Disconnected: 'disconnected',
+
+  # Emitted when the url of a target changes. Contains a {@link Target} instance.
+  TargetChanged: 'targetchanged',
+
+  # Emitted when a target is created, for example when a new page is opened by
+  # window.open or by Browser#newPage
+  # Contains a Target instance.
+  TargetCreated: 'targetcreated',
+
+  # Emitted when a target is destroyed, for example when a page is closed.
+  # Contains a Target instance.
+  TargetDestroyed: 'targetdestroyed',
+}.define_const_into(BrowserEmittedEvents)
+
+module BrowserContextEmittedEvents ; end
+
+{
+  # Emitted when the url of a target inside the browser context changes.
+  # Contains a Target instance.
+  TargetChanged: 'targetchanged',
+
+  # Emitted when a target is created, for example when a new page is opened by
+  # window.open or by BrowserContext#newPage
+  # Contains a Target instance.
+  TargetCreated: 'targetcreated',
+
+  # Emitted when a target is destroyed within the browser context, for example when a page is closed.
+  # Contains a Target instance.
+  TargetDestroyed: 'targetdestroyed',
+}.define_const_into(BrowserContextEmittedEvents)
+
+# We use symbols to prevent any external parties listening to these events.
+# They are internal to Puppeteer.
+module NetworkManagerEmittedEvents ; end
+
+{
+  Request: Symbol('NetworkManager.Request'),
+  Response: Symbol('NetworkManager.Response'),
+  RequestFailed: Symbol('NetworkManager.RequestFailed'),
+  RequestFinished: Symbol('NetworkManager.RequestFinished'),
+}.define_const_into(NetworkManagerEmittedEvents)
+
+
+# We use symbols to prevent external parties listening to these events.
+# They are internal to Puppeteer.
+module FrameManagerEmittedEvents ; end
+
+{
+  FrameAttached: Symbol('FrameManager.FrameAttached'),
+  FrameNavigated: Symbol('FrameManager.FrameNavigated'),
+  FrameDetached: Symbol('FrameManager.FrameDetached'),
+  LifecycleEvent: Symbol('FrameManager.LifecycleEvent'),
+  FrameNavigatedWithinDocument: Symbol('FrameManager.FrameNavigatedWithinDocument'),
+  ExecutionContextCreated: Symbol('FrameManager.ExecutionContextCreated'),
+  ExecutionContextDestroyed: Symbol('FrameManager.ExecutionContextDestroyed'),
+}.define_const_into(FrameManagerEmittedEvents)
+
+# All the events that a page instance may emit.
+module PageEmittedEvents ; end
+
+{
+  # Emitted when the page closes.
+  Close: 'close',
+
+  # Emitted when JavaScript within the page calls one of console API methods,
+  # e.g. `console.log` or `console.dir`. Also emitted if the page throws an
+  # error or a warning.
+  Console: 'console',
+
+  # Emitted when a JavaScript dialog appears, such as `alert`, `prompt`,
+  # `confirm` or `beforeunload`. Puppeteer can respond to the dialog via
+  # Dialog#accept or Dialog#dismiss.
+  Dialog: 'dialog',
+
+  # Emitted when the JavaScript
+  # {https://developer.mozilla.org/en-US/docs/Web/Events/DOMContentLoaded DOMContentLoaded} event is dispatched.
+  DOMContentLoaded: 'domcontentloaded',
+
+  # Emitted when the page crashes. Will contain an `Error`.
+  Error: 'error',
+
+  # Emitted when a frame is attached. Will contain a Frame.
+  FrameAttached: 'frameattached',
+  # Emitted when a frame is detached. Will contain a Frame.
+  FrameDetached: 'framedetached',
+  # Emitted when a frame is navigated to a new URL. Will contain a {@link Frame}.
+  FrameNavigated: 'framenavigated',
+
+  # Emitted when the JavaScript
+  # {https://developer.mozilla.org/en-US/docs/Web/Events/load | load} event is dispatched.
+  Load: 'load',
+
+  # Emitted when the JavaScript code makes a call to `console.timeStamp`. For
+  # the list of metrics see {@link Page.metrics | page.metrics}.
+  #
+  # Contains an object with two properties:
+  # - `title`: the title passed to `console.timeStamp`
+  # - `metrics`: objec containing metrics as key/value pairs. The values will be `number`s.
+  Metrics: 'metrics',
+
+  # Emitted when an uncaught exception happens within the page.
+  # Contains an `Error`.
+  PageError: 'pageerror',
+
+  # Emitted when the page opens a new tab or window.
+  # Contains a Page corresponding to the popup window.
+  Popup: 'popup',
+
+  # Emitted when a page issues a request and contains a HTTPRequest.
+  #
+  # The object is readonly. See Page#setRequestInterception for intercepting and mutating requests.
+  Request: 'request',
+
+  # Emitted when a request fails, for example by timing out.
+  #
+  # Contains a HTTPRequest.
+  #
+  # NOTE: HTTP Error responses, such as 404 or 503, are still successful
+  # responses from HTTP standpoint, so request will complete with
+  # `requestfinished` event and not with `requestfailed`.
+  RequestFailed: 'requestfailed',
+
+  # Emitted when a request finishes successfully. Contains a HTTPRequest.
+  RequestFinished: 'requestfinished',
+
+  # Emitted when a response is received. Contains a HTTPResponse.
+  Response: 'response',
+
+  # Emitted when a dedicated
+  # {https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API WebWorker} is spawned by the page.
+  WorkerCreated: 'workercreated',
+
+  # Emitted when a dedicated
+  # {https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API WebWorker} is destroyed by the page.
+  WorkerDestroyed: 'workerdestroyed',
+}.define_const_into(PageEmittedEvents)

data/lib/puppeteer/exception_details.rb

@@ -0,0 +1,38 @@
+# Original implementation, helpers.getExceptionMessage
+class Puppeteer::ExceptionDetails
+  # @param exception_details [Hash]
+  def initialize(exception_details)
+    @exception_details = exception_details
+  end
+
+  def message
+    # "exceptionDetails"=>{"exceptionId"=>1, "text"=>"Uncaught", "lineNumber"=>12, "columnNumber"=>10, "url"=>"http://127.0.0.1:4567/error.html",
+    #  "stackTrace"=>{"callFrames"=>[
+    #   {"functionName"=>"c", "scriptId"=>"6", "url"=>"http://127.0.0.1:4567/error.html", "lineNumber"=>12, "columnNumber"=>10},
+    #   {"functionName"=>"b", "scriptId"=>"6", "url"=>"http://127.0.0.1:4567/error.html", "lineNumber"=>8, "columnNumber"=>4},
+    #   {"functionName"=>"a", "scriptId"=>"6", "url"=>"http://127.0.0.1:4567/error.html", "lineNumber"=>4, "columnNumber"=>4},
+    #   {"functionName"=>"", "scriptId"=>"6", "url"=>"http://127.0.0.1:4567/error.html", "lineNumber"=>1, "columnNumber"=>0}
+    #  ]},
+    #  "exception"=>{"type"=>"object", "subtype"=>"error", "className"=>"Error", "description"=>"Error: Fancy error!\n    at c (http://127.0.0.1:4567/error.html:13:11)\n    at b (http://127.0.0.1:4567/error.html:9:5)\n    at a (http://127.0.0.1:4567/error.html:5:5)\n    at http://127.0.0.1:4567/error.html:2:1", "objectId"=>"{\"injectedScriptId\":3,\"id\":1}", "preview"=>{"type"=>"object", "subtype"=>"error", "description"=>"Error: Fancy error!\n    at c (http://127.0.0.1:4567/error.html:13:11)\n    at b (http://127.0.0.1:4567/error.html:9:5)\n    at a (http://127.0.0.1:4567/error.html:5:5)\n    at http://127.0.0.1:4567/error.html:2:1", "overflow"=>false, "properties"=>[{"name"=>"stack", "type"=>"string", "value"=>"Error: Fancy error!\n    at c (http://127.0.0.1:456…:5:5)\n    at http://127.0.0.1:4567/error.html:2:1"}, {"name"=>"message", "type"=>"string", "value"=>"Fancy error!"}]}}
+    if @exception_details['exception']
+      return exception_description_or_value(@exception_details['exception'])
+    end
+
+    messages = []
+    messages << @exception_details['text']
+
+    if @exception_details['stackTrace']
+      @exception_details['stackTrace']['callFrames'].each do |call_frame|
+        location = "#{call_frame['url']}:#{call_frame['lineNumber']}:#{call_frame['columnNumber']}"
+        function_name = call_frame['functionName'] || '<anonymous>'
+        messages << "at #{function_name} (#{location})"
+      end
+    end
+
+    messages.join("\n    ")
+  end
+
+  private def exception_description_or_value(exception)
+    exception['description'] || exception['value']
+  end
+end

data/lib/puppeteer/frame.rb

@@ -266,9 +266,7 @@ class Puppeteer::Frame
   # @param frame_payload [Hash]
   def navigated(frame_payload)
     @name = frame_payload['name']
-    # TODO(lushnikov): remove this once requestInterception has loaderId exposed.
-    @navigation_url = frame_payload['url']
-    @url = frame_payload['url']
+    @url = "#{frame_payload['url']}#{frame_payload['urlFragment']}"
 
     # Ensure loaderId updated.
     # The order of [Page.lifecycleEvent name="init"] and [Page.frameNavigated] is random... for some reason...

data/lib/puppeteer/frame_manager.rb

@@ -27,31 +27,31 @@ class Puppeteer::FrameManager
     # @type {!Set<string>}
     @isolated_worlds = Set.new
 
-    @client.on_event 'Page.frameAttached' do |event|
+    @client.on_event('Page.frameAttached') do |event|
       handle_frame_attached(event['frameId'], event['parentFrameId'])
     end
-    @client.on_event 'Page.frameNavigated' do |event|
+    @client.on_event('Page.frameNavigated') do |event|
       handle_frame_navigated(event['frame'])
     end
-    @client.on_event 'Page.navigatedWithinDocument' do |event|
+    @client.on_event('Page.navigatedWithinDocument') do |event|
       handle_frame_navigated_within_document(event['frameId'], event['url'])
     end
-    @client.on_event 'Page.frameDetached' do |event|
+    @client.on_event('Page.frameDetached') do |event|
       handle_frame_detached(event['frameId'])
     end
-    @client.on_event 'Page.frameStoppedLoading' do |event|
+    @client.on_event('Page.frameStoppedLoading') do |event|
       handle_frame_stopped_loading(event['frameId'])
     end
-    @client.on_event 'Runtime.executionContextCreated' do |event|
+    @client.on_event('Runtime.executionContextCreated') do |event|
       handle_execution_context_created(event['context'])
     end
-    @client.on_event 'Runtime.executionContextDestroyed' do |event|
+    @client.on_event('Runtime.executionContextDestroyed') do |event|
       handle_execution_context_destroyed(event['executionContextId'])
     end
-    @client.on_event 'Runtime.executionContextsCleared' do |event|
+    @client.on_event('Runtime.executionContextsCleared') do |event|
       handle_execution_contexts_cleared
     end
-    @client.on_event 'Page.lifecycleEvent' do |event|
+    @client.on_event('Page.lifecycleEvent') do |event|
       handle_lifecycle_event(event)
     end
   end
@@ -121,6 +121,8 @@ class Puppeteer::FrameManager
         document_navigation_promise,
         watcher.timeout_or_termination_promise,
       )
+    rescue Puppeteer::TimeoutError => err
+      raise NavigationError.new(err)
     ensure
       watcher.dispose
     end
@@ -143,6 +145,8 @@ class Puppeteer::FrameManager
         watcher.same_document_navigation_promise,
         watcher.new_document_navigation_promise,
       )
+    rescue Puppeteer::TimeoutError => err
+      raise NavigationError.new(err)
     ensure
       watcher.dispose
     end
@@ -155,7 +159,7 @@ class Puppeteer::FrameManager
     frame = @frames[event['frameId']]
     return if !frame
     frame.handle_lifecycle_event(event['loaderId'], event['name'])
-    emit_event 'Events.FrameManager.LifecycleEvent', frame
+    emit_event(FrameManagerEmittedEvents::LifecycleEvent, frame)
   end
 
   # @param {string} frameId
@@ -163,7 +167,7 @@ class Puppeteer::FrameManager
     frame = @frames[frame_id]
     return if !frame
     frame.handle_loading_stopped
-    emit_event 'Events.FrameManager.LifecycleEvent', frame
+    emit_event(FrameManagerEmittedEvents::LifecycleEvent, frame)
   end
 
   # @param frame_tree [Hash]
@@ -211,7 +215,7 @@ class Puppeteer::FrameManager
     frame = Puppeteer::Frame.new(self, @client, parent_frame, frame_id)
     @frames[frame_id] = frame
 
-    emit_event 'Events.FrameManager.FrameAttached', frame
+    emit_event(FrameManagerEmittedEvents::FrameAttached, frame)
   end
 
   # @param frame_payload [Hash]
@@ -252,7 +256,7 @@ class Puppeteer::FrameManager
     # Update frame payload.
     frame.navigated(frame_payload)
 
-    emit_event 'Events.FrameManager.FrameNavigated', frame
+    emit_event(FrameManagerEmittedEvents::FrameNavigated, frame)
   end
 
   # @param name [String]
@@ -280,8 +284,8 @@ class Puppeteer::FrameManager
     frame = @frames[frame_id]
     return unless frame
     frame.navigated_within_document(url)
-    emit_event 'Events.FrameManager.FrameNavigatedWithinDocument', frame
-    emit_event 'Events.FrameManager.FrameNavigated', frame
+    emit_event(FrameManagerEmittedEvents::FrameNavigatedWithinDocument, frame)
+    emit_event(FrameManagerEmittedEvents::FrameNavigated, frame)
   end
 
   # @param frame_id [String]
@@ -349,7 +353,7 @@ class Puppeteer::FrameManager
     end
     frame.detach
     @frames.delete(frame.id)
-    emit_event 'Events.FrameManager.FrameDetached', frame
+    emit_event(FrameManagerEmittedEvents::FrameDetached, frame)
   end
 
   private def assert_no_legacy_navigation_options(wait_until:)