puppeteer-ruby 0.0.18 → 0.0.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 63cde4d139f1dc95710efb059310822219b905ef4b44ec8a1347b4bdc97a6b2e
-  data.tar.gz: '0989de5d246bb1c2bcb5ab625eb0702f608ec6ec667db9bbcf4282cf419314fa'
+  metadata.gz: 6e6a29713aa4dd143bdd6c4fd1cc84df1bd7037aa920b0d660a62267f6321515
+  data.tar.gz: 46a433d484dfabd019cc0874b8dd6c17182e374fb53d6f6905fde7c1d120d5e6
 SHA512:
-  metadata.gz: 96aaf3dc540e160dd983660f2ea4fa10a8c3a2126e9c56f57f9c7a11c31c956376f556473c2d6c591b4cf4253c92e91055cc564e1910fe6dbaf3eb8244d2e852
-  data.tar.gz: c2195746ce0ed09fb2be8e66cb842cc2fb9487c51cb2232e51f3970df0234aec97fce173627bbedd1c4d113cd82154c134a69d0f9eb02c23826ab0bc0ad7ee18
+  metadata.gz: 9c5796c2331a9218c1191e1c2869aa5b02c6affdd19f5af23324ee1b257e93d3f328688b19ac14b4060f050c3649a82f6074f0a2b5d66c4bb71f34f46d51557a
+  data.tar.gz: 70bfa15d8c788ab11dbf8cf240a3967a906a15777294b1f8be2be22a64d5f2123a3c4bf44226c35c58bed0614a9b7703d6db498ce283309aa36bb30c5587cea6

data/.circleci/config.yml

@@ -5,7 +5,7 @@ orbs:
 jobs:
   rspec:
     docker:
-      - image: circleci/ruby:2.6.3-stretch-node-browsers
+      - image: circleci/ruby:2.6.6-buster-node-browsers
     executor: ruby/default
     steps:
       - checkout
@@ -18,6 +18,28 @@ jobs:
               --out test_results/rspec.xml \
               --format documentation
 
+  rspec_firefox:
+    docker:
+      - image: circleci/ruby:2.6.6-buster-node-browsers
+    executor: ruby/default
+    steps:
+      - checkout
+      - ruby/bundle-install
+      - run:
+          name: install firefox-nightly
+          command: |
+            wget -O nightly.tar.bz2 "https://download.mozilla.org/?product=firefox-nightly-latest-ssl&os=linux64&lang=en-US"
+            tar xf nightly.tar.bz2
+      - run:
+          name: rspec
+          command: |
+            DEBUG=1 PUPPETEER_PRODUCT_RSPEC=firefox \
+            PUPPETEER_EXECUTABLE_PATH_RSPEC=${CIRCLE_WORKING_DIRECTORY/#\~/$HOME}/firefox/firefox \
+            bundle exec rspec --profile 10 \
+              --format RspecJunitFormatter \
+              --out test_results/rspec.xml \
+              --format documentation spec/integration/
+
   deploy:
     docker:
       - image: circleci/ruby:2.6.3-stretch-node
@@ -49,6 +71,7 @@ workflows:
   ci:
     jobs:
       - rspec
+      - rspec_firefox
   rubygems-deploy:
     jobs:
       - deploy:

data/.github/workflows/reviewdog.yml

@@ -12,4 +12,4 @@ jobs:
         with:
           github_token: ${{ secrets.github_token }}
           reporter: github-pr-review
-          rubocop_version: 0.86.0
+          rubocop_version: 0.90.0

data/.rubocop.yml

@@ -35,6 +35,9 @@ Layout/EndAlignment:
 Layout/EmptyLineAfterMagicComment:
   Enabled: true
 
+Layout/EmptyLineAfterMultilineCondition:
+  Enabled: true
+
 Layout/EmptyLinesAroundAccessModifier:
   Enabled: true
   EnforcedStyle: only_before
@@ -102,6 +105,10 @@ Layout/SpaceBeforeComment:
 Layout/SpaceBeforeFirstArg:
   Enabled: true
 
+Style/ClassMethodsDefinitions:
+  Enabled: true
+  EnforcedStyle: def_self
+
 Style/DefWithParentheses:
   Enabled: true
 
@@ -112,6 +119,12 @@ Style/MethodDefParentheses:
 Style/RedundantFreeze:
   Enabled: true
 
+Style/RedundantSelf:
+  Enabled: true
+
+Style/RedundantSelfAssignment:
+  Enabled: true
+
 # Use `foo {}` not `foo{}`.
 Layout/SpaceBeforeBlockBraces:
   Enabled: true
@@ -164,9 +177,6 @@ Lint/EmptyConditionalBody:
 Lint/FloatComparison:
   Enabled: true
 
-Lint/MissingSuper:
-  Enabled: true
-
 Lint/OutOfRangeRegexpRef:
   Enabled: true
 

data/Dockerfile

@@ -0,0 +1,9 @@
+FROM circleci/ruby:2.6.6-buster-node-browsers
+
+USER root
+
+RUN wget -O nightly.tar.bz2 "https://download.mozilla.org/?product=firefox-nightly-latest-ssl&os=linux64&lang=en-US" \
+    && tar xf nightly.tar.bz2 \
+    && ln -s $(pwd)/firefox/firefox /usr/bin/firefox
+
+USER circleci

data/docker-compose.yml

@@ -0,0 +1,34 @@
+version: "3"
+services:
+  chrome:
+    tty: true
+    stdin_open: true
+    build: .
+    environment:
+      BUNDLE_PATH: /usr/local/bundle
+      DEBUG: 1
+      CI: 1
+    volumes:
+      - .:/puppeteer-ruby
+      - bundle-data:/usr/local/bundle
+    working_dir: /puppeteer-ruby
+    command: bundle exec rspec
+
+  firefox:
+    tty: true
+    stdin_open: true
+    build: .
+    environment:
+      BUNDLE_PATH: /usr/local/bundle
+      PUPPETEER_PRODUCT_RSPEC: firefox
+      DEBUG: 1
+      CI: 1
+    volumes:
+      - .:/puppeteer-ruby
+      - bundle-data:/usr/local/bundle
+    working_dir: /puppeteer-ruby
+    command: bundle exec rspec spec/integration/
+
+volumes:
+  bundle-data:
+    driver: local

data/lib/puppeteer.rb

@@ -53,18 +53,14 @@ require 'puppeteer/element_handle'
 
 # ref: https://github.com/puppeteer/puppeteer/blob/master/lib/Puppeteer.js
 class Puppeteer
-  class << self
-    def method_missing(method, *args, **kwargs, &block)
-      instance.send(method, *args, **kwargs, &block)
-    end
+  def self.method_missing(method, *args, **kwargs, &block)
+    @puppeteer ||= Puppeteer.new(
+      project_root: __dir__,
+      preferred_revision: '706915',
+      is_puppeteer_core: true,
+    )
 
-    def instance
-      @instance ||= Puppeteer.new(
-        project_root: __dir__,
-        preferred_revision: '706915',
-        is_puppeteer_core: true,
-      )
-    end
+    @puppeteer.send(method, *args, **kwargs, &block)
   end
 
   # @param project_root [String]

data/lib/puppeteer/browser_runner.rb

@@ -156,6 +156,6 @@ class Puppeteer::BrowserRunner
       end
     end
   rescue Timeout::Error
-    raise Puppeteer::TimeoutError.new("Timed out after #{timeout} ms while trying to connect to the browser! Only Chrome at revision r#{preferredRevision} is guaranteed to work.")
+    raise Puppeteer::TimeoutError.new("Timed out after #{timeout} ms while trying to connect to the browser! Only Chrome at revision r#{preferred_revision} is guaranteed to work.")
   end
 end

data/lib/puppeteer/debug_print.rb

@@ -3,7 +3,7 @@ require 'logger'
 module Puppeteer::DebugPrint
   if Puppeteer.env.debug?
     def debug_puts(*args, **kwargs)
-      @__debug_logger ||= Logger.new(STDOUT)
+      @__debug_logger ||= Logger.new($stdout)
       @__debug_logger.debug(*args, **kwargs)
     end
 

data/lib/puppeteer/define_async_method.rb

@@ -14,7 +14,7 @@ module Puppeteer::DefineAsyncMethod
         Concurrent::Promises.future do
           original_method.bind(self).call(*args)
         rescue => err
-          Logger.new(STDERR).warn(err)
+          Logger.new($stderr).warn(err)
           raise err
         end
       end

data/lib/puppeteer/element_handle.rb

@@ -43,7 +43,24 @@ class Puppeteer::ElementHandle < Puppeteer::JSHandle
         if (element.nodeType !== Node.ELEMENT_NODE)
           return 'Node is not of type HTMLElement';
 
-        element.scrollIntoViewIfNeeded({block: 'center', inline: 'center', behavior: 'instant'});
+        if (element.scrollIntoViewIfNeeded) {
+          element.scrollIntoViewIfNeeded({block: 'center', inline: 'center', behavior: 'instant'});
+        } else {
+          // force-scroll if page's javascript is disabled.
+          if (!pageJavascriptEnabled) {
+            element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
+            return false;
+          }
+          const visibleRatio = await new Promise(resolve => {
+            const observer = new IntersectionObserver(entries => {
+              resolve(entries[0].intersectionRatio);
+              observer.disconnect();
+            });
+            observer.observe(element);
+          });
+          if (visibleRatio !== 1.0)
+            element.scrollIntoView({block: 'center', inline: 'center', behavior: 'instant'});
+        }
         return false;
       }
     JAVASCRIPT

data/lib/puppeteer/env.rb

@@ -9,6 +9,11 @@ class Puppeteer::Env
   def ci?
     ['1', 'true'].include?(ENV['CI'].to_s)
   end
+
+  # check if running on macOS
+  def darwin?
+    RUBY_PLATFORM.include?('darwin')
+  end
 end
 
 class Puppeteer

data/lib/puppeteer/launcher.rb

@@ -2,6 +2,7 @@ require_relative './launcher/base'
 require_relative './launcher/browser_options'
 require_relative './launcher/chrome'
 require_relative './launcher/chrome_arg_options'
+require_relative './launcher/firefox'
 require_relative './launcher/launch_options'
 
 # https://github.com/puppeteer/puppeteer/blob/main/src/node/Launcher.ts
@@ -9,10 +10,19 @@ module Puppeteer::Launcher
   # @param project_root [String]
   # @param prefereed_revision [String]
   # @param is_puppeteer_core [String]
-  # @param product [String] 'chrome' or 'firefox' (not implemented yet)
+  # @param product [String] 'chrome' or 'firefox'
   # @return [Puppeteer::Launcher::Chrome]
   module_function def new(project_root:, preferred_revision:, is_puppeteer_core:, product:)
+    unless is_puppeteer_core
+      product ||= ENV['PUPPETEER_PRODUCT']
+    end
+
     if product == 'firefox'
+      return Firefox.new(
+        project_root: project_root,
+        preferred_revision: preferred_revision,
+        is_puppeteer_core: is_puppeteer_core,
+      )
       raise NotImplementedError.new('FirefoxLauncher is not implemented yet.')
     end
 

data/lib/puppeteer/launcher/base.rb

@@ -20,15 +20,25 @@ module Puppeteer::Launcher
           return executable_path
         end
         raise ExecutablePathNotFound.new(
-          "Tried to use PUPPETEER_EXECUTABLE_PATH env variable to launch browser but did not find any executable at: #{executablePath}",
+          "Tried to use PUPPETEER_EXECUTABLE_PATH env variable to launch browser but did not find any executable at: #{executable_path}",
         )
       end
 
       # temporal logic.
-      if RUBY_PLATFORM.include?('darwin') # MacOS
-        '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome'
+      if Puppeteer.env.darwin?
+        case self
+        when Chrome
+          '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome'
+        when Firefox
+          '/Applications/Firefox Nightly.app/Contents/MacOS/firefox'
+        end
       else
-        '/usr/bin/google-chrome'
+        case self
+        when Chrome
+          '/usr/bin/google-chrome'
+        when Firefox
+          '/usr/bin/firefox'
+        end
       end
 
       # const browserFetcher = new BrowserFetcher(launcher._projectRoot);

data/lib/puppeteer/launcher/chrome.rb

@@ -34,7 +34,7 @@ module Puppeteer::Launcher
 
       temporary_user_data_dir = nil
       if chrome_arguments.none? { |arg| arg.start_with?('--user-data-dir') }
-        temporary_user_data_dir = Dir.mktmpdir('puppeteer_dev_profile-')
+        temporary_user_data_dir = Dir.mktmpdir('puppeteer_dev_chrome_profile-')
         chrome_arguments << "--user-data-dir=#{temporary_user_data_dir}"
       end
 

data/lib/puppeteer/launcher/firefox.rb

@@ -0,0 +1,392 @@
+require 'tmpdir'
+
+# https://github.com/puppeteer/puppeteer/blob/main/src/node/Launcher.ts
+module Puppeteer::Launcher
+  class Firefox < Base
+    # @param {!(Launcher.LaunchOptions & Launcher.ChromeArgOptions & Launcher.BrowserOptions)=} options
+    # @return {!Promise<!Browser>}
+    def launch(options = {})
+      @chrome_arg_options = ChromeArgOptions.new(options)
+      @launch_options = LaunchOptions.new(options)
+      @browser_options = BrowserOptions.new(options)
+
+      firefox_arguments =
+        if !@launch_options.ignore_default_args
+          default_args.to_a
+        elsif @launch_options.ignore_default_args.is_a?(Enumerable)
+          default_args.reject do |arg|
+            @launch_options.ignore_default_args.include?(arg)
+          end.to_a
+        else
+          @chrome_arg_options.args.dup
+        end
+
+      if firefox_arguments.none? { |arg| arg.start_with?('--remote-debugging-') }
+        firefox_arguments << '--remote-debugging-port=0'
+      end
+
+      temporary_user_data_dir = nil
+      if firefox_arguments.none? { |arg| arg.start_with?('--profile') || arg.start_with?('-profile') }
+        temporary_user_data_dir = create_profile
+        firefox_arguments << "--profile"
+        firefox_arguments << temporary_user_data_dir
+      end
+
+      firefox_executable = @launch_options.executable_path || resolve_executable_path
+      runner = Puppeteer::BrowserRunner.new(firefox_executable, firefox_arguments, temporary_user_data_dir)
+      runner.start(
+        handle_SIGHUP: @launch_options.handle_SIGHUP?,
+        handle_SIGTERM: @launch_options.handle_SIGTERM?,
+        handle_SIGINT: @launch_options.handle_SIGINT?,
+        dumpio: @launch_options.dumpio?,
+        env: @launch_options.env,
+        pipe: @launch_options.pipe?,
+      )
+
+      begin
+        connection = runner.setup_connection(
+          use_pipe: @launch_options.pipe?,
+          timeout: @launch_options.timeout,
+          slow_mo: @browser_options.slow_mo,
+          preferred_revision: @preferred_revision,
+        )
+
+        browser = Puppeteer::Browser.create(
+          connection: connection,
+          context_ids: [],
+          ignore_https_errors: @browser_options.ignore_https_errors?,
+          default_viewport: @browser_options.default_viewport,
+          process: runner.proc,
+          close_callback: -> { runner.close },
+        )
+
+        browser.wait_for_target(predicate: ->(target) { target.type == 'page' })
+
+        browser
+      rescue
+        runner.kill
+        raise
+      end
+    end
+
+    # @return [Puppeteer::Browser]
+    def connect(options = {})
+      @browser_options = BrowserOptions.new(options)
+      browser_ws_endpoint = options[:browser_ws_endpoint]
+      browser_url = options[:browser_url]
+      transport = options[:transport]
+
+      connection =
+        if browser_ws_endpoint && browser_url.nil? && transport.nil?
+          connect_with_browser_ws_endpoint(browser_ws_endpoint)
+        elsif browser_ws_endpoint.nil? && browser_url && transport.nil?
+          connect_with_browser_url(browser_url)
+        elsif browser_ws_endpoint.nil? && browser_url.nil? && transport
+          connect_with_transport(transport)
+        else
+          raise ArgumentError.new("Exactly one of browserWSEndpoint, browserURL or transport must be passed to puppeteer.connect")
+        end
+
+      result = connection.send_message('Target.getBrowserContexts')
+      browser_context_ids = result['browserContextIds']
+
+      Puppeteer::Browser.create(
+        connection: connection,
+        context_ids: browser_context_ids,
+        ignore_https_errors: @browser_options.ignore_https_errors?,
+        default_viewport: @browser_options.default_viewport,
+        process: nil,
+        close_callback: -> { connection.send_message('Browser.close') },
+      )
+    end
+
+    # @return [Puppeteer::Connection]
+    private def connect_with_browser_ws_endpoint(browser_ws_endpoint)
+      transport = Puppeteer::WebSocketTransport.create(browser_ws_endpoint)
+      Puppeteer::Connection.new(browser_ws_endpoint, transport, @browser_options.slow_mo)
+    end
+
+    # @return [Puppeteer::Connection]
+    private def connect_with_browser_url(browser_url)
+      require 'net/http'
+      uri = URI(browser_url)
+      uri.path = '/json/version'
+      response_body = Net::HTTP.get(uri)
+      json = JSON.parse(response_body)
+      connection_url = json['webSocketDebuggerUrl']
+      connect_with_browser_ws_endpoint(connection_url)
+    end
+
+    # @return [Puppeteer::Connection]
+    private def connect_with_transport(transport)
+      Puppeteer::Connection.new('', transport, @browser_options.slow_mo)
+    end
+
+    # @return {string}
+    def executable_path
+      resolve_executable_path
+    end
+
+    private def product
+      'firefox'
+    end
+
+    class DefaultArgs
+      include Enumerable
+
+      # @param options [Launcher::ChromeArgOptions]
+      def initialize(chrome_arg_options)
+        firefox_arguments = ['--no-remote', '--foreground']
+
+        # if (os.platform().startsWith('win')) {
+        #   firefoxArguments.push('--wait-for-browser');
+        # }
+
+        if chrome_arg_options.user_data_dir
+          firefox_arguments << "--profile"
+          firefox_arguments << chrome_arg_options.user_data_dir
+        end
+
+        if chrome_arg_options.headless?
+          firefox_arguments << '--headless'
+        end
+
+        if chrome_arg_options.devtools?
+          firefox_arguments << '--devtools'
+        end
+
+        if chrome_arg_options.args.all? { |arg| arg.start_with?('-') }
+          firefox_arguments << 'about:blank'
+        end
+
+        firefox_arguments.concat(chrome_arg_options.args)
+
+        @firefox_arguments = firefox_arguments
+      end
+
+      def each(&block)
+        @firefox_arguments.each do |opt|
+          block.call(opt)
+        end
+      end
+    end
+
+    # @return [DefaultArgs]
+    def default_args(options = nil)
+      if options.nil?
+        @default_args ||= DefaultArgs.new(@chrome_arg_options)
+      else
+        DefaultArgs.new(ChromeArgOptions.new(options))
+      end
+    end
+
+    private def create_profile(extra_prefs = {})
+      Dir.mktmpdir('puppeteer_dev_firefox_profile-').tap do |profile_path|
+        server = 'dummy.test'
+        default_preferences = {
+          # Make sure Shield doesn't hit the network.
+          'app.normandy.api_url': '',
+          # Disable Firefox old build background check
+          'app.update.checkInstallTime': false,
+          # Disable automatically upgrading Firefox
+          'app.update.disabledForTesting': true,
+
+          # Increase the APZ content response timeout to 1 minute
+          'apz.content_response_timeout': 60000,
+
+          # Prevent various error message on the console
+          # jest-puppeteer asserts that no error message is emitted by the console
+          'browser.contentblocking.features.standard': '-tp,tpPrivate,cookieBehavior0,-cm,-fp',
+
+          # Enable the dump function: which sends messages to the system
+          # console
+          # https://bugzilla.mozilla.org/show_bug.cgi?id=1543115
+          'browser.dom.window.dump.enabled': true,
+          # Disable topstories
+          'browser.newtabpage.activity-stream.feeds.section.topstories': false,
+          # Always display a blank page
+          'browser.newtabpage.enabled': false,
+          # Background thumbnails in particular cause grief: and disabling
+          # thumbnails in general cannot hurt
+          'browser.pagethumbnails.capturing_disabled': true,
+
+          # Disable safebrowsing components.
+          'browser.safebrowsing.blockedURIs.enabled': false,
+          'browser.safebrowsing.downloads.enabled': false,
+          'browser.safebrowsing.malware.enabled': false,
+          'browser.safebrowsing.passwords.enabled': false,
+          'browser.safebrowsing.phishing.enabled': false,
+
+          # Disable updates to search engines.
+          'browser.search.update': false,
+          # Do not restore the last open set of tabs if the browser has crashed
+          'browser.sessionstore.resume_from_crash': false,
+          # Skip check for default browser on startup
+          'browser.shell.checkDefaultBrowser': false,
+
+          # Disable newtabpage
+          'browser.startup.homepage': 'about:blank',
+          # Do not redirect user when a milstone upgrade of Firefox is detected
+          'browser.startup.homepage_override.mstone': 'ignore',
+          # Start with a blank page about:blank
+          'browser.startup.page': 0,
+
+          # Do not allow background tabs to be zombified on Android: otherwise for
+          # tests that open additional tabs: the test harness tab itself might get
+          # unloaded
+          'browser.tabs.disableBackgroundZombification': false,
+          # Do not warn when closing all other open tabs
+          'browser.tabs.warnOnCloseOtherTabs': false,
+          # Do not warn when multiple tabs will be opened
+          'browser.tabs.warnOnOpen': false,
+
+          # Disable the UI tour.
+          'browser.uitour.enabled': false,
+          # Turn off search suggestions in the location bar so as not to trigger
+          # network connections.
+          'browser.urlbar.suggest.searches': false,
+          # Disable first run splash page on Windows 10
+          'browser.usedOnWindows10.introURL': '',
+          # Do not warn on quitting Firefox
+          'browser.warnOnQuit': false,
+
+          # Do not show datareporting policy notifications which can
+          # interfere with tests
+          'datareporting.healthreport.about.reportUrl': "http://#{server}/dummy/abouthealthreport/",
+          'datareporting.healthreport.documentServerURI': "http://#{server}/dummy/healthreport/",
+          'datareporting.healthreport.logging.consoleEnabled': false,
+          'datareporting.healthreport.service.enabled': false,
+          'datareporting.healthreport.service.firstRun': false,
+          'datareporting.healthreport.uploadEnabled': false,
+          'datareporting.policy.dataSubmissionEnabled': false,
+          'datareporting.policy.dataSubmissionPolicyAccepted': false,
+          'datareporting.policy.dataSubmissionPolicyBypassNotification': true,
+
+          # DevTools JSONViewer sometimes fails to load dependencies with its require.js.
+          # This doesn't affect Puppeteer but spams console (Bug 1424372)
+          'devtools.jsonview.enabled': false,
+
+          # Disable popup-blocker
+          'dom.disable_open_during_load': false,
+
+          # Enable the support for File object creation in the content process
+          # Required for |Page.setFileInputFiles| protocol method.
+          'dom.file.createInChild': true,
+
+          # Disable the ProcessHangMonitor
+          'dom.ipc.reportProcessHangs': false,
+
+          # Disable slow script dialogues
+          'dom.max_chrome_script_run_time': 0,
+          'dom.max_script_run_time': 0,
+
+          # Only load extensions from the application and user profile
+          # AddonManager.SCOPE_PROFILE + AddonManager.SCOPE_APPLICATION
+          'extensions.autoDisableScopes': 0,
+          'extensions.enabledScopes': 5,
+
+          # Disable metadata caching for installed add-ons by default
+          'extensions.getAddons.cache.enabled': false,
+
+          # Disable installing any distribution extensions or add-ons.
+          'extensions.installDistroAddons': false,
+
+          # Disabled screenshots extension
+          'extensions.screenshots.disabled': true,
+
+          # Turn off extension updates so they do not bother tests
+          'extensions.update.enabled': false,
+
+          # Turn off extension updates so they do not bother tests
+          'extensions.update.notifyUser': false,
+
+          # Make sure opening about:addons will not hit the network
+          'extensions.webservice.discoverURL': "http://#{server}/dummy/discoveryURL",
+
+          # Allow the application to have focus even it runs in the background
+          'focusmanager.testmode': true,
+          # Disable useragent updates
+          'general.useragent.updates.enabled': false,
+          # Always use network provider for geolocation tests so we bypass the
+          # macOS dialog raised by the corelocation provider
+          'geo.provider.testing': true,
+          # Do not scan Wifi
+          'geo.wifi.scan': false,
+          # No hang monitor
+          'hangmonitor.timeout': 0,
+          # Show chrome errors and warnings in the error console
+          'javascript.options.showInConsole': true,
+
+          # Disable download and usage of OpenH264: and Widevine plugins
+          'media.gmp-manager.updateEnabled': false,
+          # Prevent various error message on the console
+          # jest-puppeteer asserts that no error message is emitted by the console
+          'network.cookie.cookieBehavior': 0,
+
+          # Do not prompt for temporary redirects
+          'network.http.prompt-temp-redirect': false,
+
+          # Disable speculative connections so they are not reported as leaking
+          # when they are hanging around
+          'network.http.speculative-parallel-limit': 0,
+
+          # Do not automatically switch between offline and online
+          'network.manage-offline-status': false,
+
+          # Make sure SNTP requests do not hit the network
+          'network.sntp.pools': server,
+
+          # Disable Flash.
+          'plugin.state.flash': 0,
+
+          'privacy.trackingprotection.enabled': false,
+
+          # Enable Remote Agent
+          # https://bugzilla.mozilla.org/show_bug.cgi?id=1544393
+          'remote.enabled': true,
+
+          # Don't do network connections for mitm priming
+          'security.certerrors.mitm.priming.enabled': false,
+          # Local documents have access to all other local documents,
+          # including directory listings
+          'security.fileuri.strict_origin_policy': false,
+          # Do not wait for the notification button security delay
+          'security.notification_enable_delay': 0,
+
+          # Ensure blocklist updates do not hit the network
+          'services.settings.server': "http://#{server}/dummy/blocklist/",
+
+          # Do not automatically fill sign-in forms with known usernames and
+          # passwords
+          'signon.autofillForms': false,
+          # Disable password capture, so that tests that include forms are not
+          # influenced by the presence of the persistent doorhanger notification
+          'signon.rememberSignons': false,
+
+          # Disable first-run welcome page
+          'startup.homepage_welcome_url': 'about:blank',
+
+          # Disable first-run welcome page
+          'startup.homepage_welcome_url.additional': '',
+
+          # Disable browser animations (tabs, fullscreen, sliding alerts)
+          'toolkit.cosmeticAnimations.enabled': false,
+
+          # We want to collect telemetry, but we don't want to send in the results
+          'toolkit.telemetry.server': "https://#{server}/dummy/telemetry/",
+          # Prevent starting into safe mode after application crashes
+          'toolkit.startup.max_resumed_crashes': -1,
+        }
+
+        preferences = default_preferences.merge(extra_prefs)
+
+        File.open(File.join(profile_path, 'user.js'), 'w') do |f|
+          preferences.each do |key, value|
+            f.write("user_pref(#{JSON.generate(key)}, #{JSON.generate(value)});\n")
+          end
+        end
+        IO.write(File.join(profile_path, 'prefs.js'), "")
+      end
+    end
+  end
+end

data/lib/puppeteer/page.rb

@@ -266,7 +266,13 @@ class Puppeteer::Page
     @frame_manager.main_frame
   end
 
-  attr_reader :keyboard, :touch_screen, :coverage, :accessibility
+  attr_reader :touch_screen, :coverage, :accessibility
+
+  def keyboard(&block)
+    @keyboard.instance_eval(&block) unless block.nil?
+
+    @keyboard
+  end
 
   def frames
     @frame_manager.frames

data/lib/puppeteer/remote_object.rb

@@ -80,7 +80,18 @@ class Puppeteer::RemoteObject
 
   # used in ElementHandle#_box_model
   def box_model(client)
-    client.send_message('DOM.getBoxModel', objectId: @object_id)
+    result = client.send_message('DOM.getBoxModel', objectId: @object_id)
+
+    # Firefox returns width/height = 0, content/padding/border/margin = [nil, nil, nil, nil, nil, nil, nil, nil]
+    # while Chrome throws Error(Could not compute box model)
+    model = result['model']
+    if model['width'] == 0 && model['height'] == 0 &&
+      %w(content padding border margin).all? { |key| model[key].all?(&:nil?) }
+
+      debug_puts('Could not compute box model in Firefox.')
+      return nil
+    end
+    result
   rescue => err
     debug_puts(err)
     nil

data/lib/puppeteer/version.rb

@@ -1,3 +1,3 @@
 class Puppeteer
-  VERSION = '0.0.18'
+  VERSION = '0.0.19'
 end

data/puppeteer-ruby.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec_junit_formatter' # for CircleCI.
-  spec.add_development_dependency 'rubocop', '~> 0.89.0'
+  spec.add_development_dependency 'rubocop', '~> 0.90.0'
   spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency 'sinatra'
   spec.add_development_dependency 'yard'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: puppeteer-ruby
 version: !ruby/object:Gem::Version
-  version: 0.0.18
+  version: 0.0.19
 platform: ruby
 authors:
 - YusukeIwaki
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-08-23 00:00:00.000000000 Z
+date: 2020-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -128,14 +128,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.89.0
+        version: 0.90.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.89.0
+        version: 0.90.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -193,11 +193,13 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
+- Dockerfile
 - Gemfile
 - README.md
 - Rakefile
 - bin/console
 - bin/setup
+- docker-compose.yml
 - lib/puppeteer.rb
 - lib/puppeteer/browser.rb
 - lib/puppeteer/browser_context.rb
@@ -234,6 +236,7 @@ files:
 - lib/puppeteer/launcher/browser_options.rb
 - lib/puppeteer/launcher/chrome.rb
 - lib/puppeteer/launcher/chrome_arg_options.rb
+- lib/puppeteer/launcher/firefox.rb
 - lib/puppeteer/launcher/launch_options.rb
 - lib/puppeteer/lifecycle_watcher.rb
 - lib/puppeteer/mouse.rb