puppeteer-bidi 0.0.3.beta3 → 0.0.3.beta4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb435eba199162f3270ff09d0efeaf728935717f0c690a0549f176f1be06e072
-  data.tar.gz: 7a39e4c65471997c4d37f4558459121a9370769dbf341b7f45b6d2441175b60e
+  metadata.gz: b794392cacbce5b48461723974e67a0e22502bad38c1aa80a49474b1a68d0839
+  data.tar.gz: cfb0d15e44f66ed1ae5b2bc4bdb3d3d51cef2a58fedd589595ec12da0d7b7493
 SHA512:
-  metadata.gz: 1d9b44c59dda746bae25de8ad9e37c9576867fd5f39b434e39e0ea2cb1ce30d05e943496d787e9cc254d5747af1ce8514818dce67c5778861345617788c2b6af
-  data.tar.gz: 5d80cc021677292638eb0103cf7aca8f9c87309fcb858425360b1ac6f937f2d5d1e5386c5b30e738589fc787ab7f609a271af18d682ac9452b95ae5fec25d765
+  metadata.gz: 9c0aad71fa66ac6e9a8d04db539d58eabcf68c405816e2692a6c228c42f6a03608fb37bd254b11bf87e87984253c87641c7d6b51d1a2f85c4b921c0fee69bfa3
+  data.tar.gz: 42eb5accee635501e56df09026fa506cf1772f188ac7d2f6b595e8b70d6428380cb4a4d97023436d284a0fae8db056a00ef41d5c69fad4f67326c2a0d67ee108

data/lib/puppeteer/bidi/reactor_runner.rb

@@ -3,7 +3,6 @@
 
 require "async"
 require "async/promise"
-require "async/queue"
 require "delegate"
 require "thread"
 
@@ -11,6 +10,18 @@ module Puppeteer
   module Bidi
     # Runs a dedicated Async reactor in a background thread and proxies calls into it.
     class ReactorRunner
+      class Finalizer
+        def initialize(queue, thread)
+          @queue = queue
+          @thread = thread
+        end
+
+        def call(_id)
+          @queue.close
+          @thread.join unless ::Thread.current == @thread
+        end
+      end
+
       class Proxy < SimpleDelegator
         # @rbs runner: ReactorRunner -- Reactor runner
         # @rbs target: untyped -- Target object to proxy
@@ -78,20 +89,27 @@ module Puppeteer
 
       # @rbs return: void
       def initialize
-        @queue = Async::Queue.new
+        @queue = Thread::Queue.new
         @ready = Queue.new
         @closed = false
         @thread = Thread.new do
-          Sync do |task|
-            @ready << true
-            @queue.async(parent: task) do |_async_task, job|
-              job.call
+          begin
+            Sync do |task|
+              @ready << true
+              while (job = @queue.pop)
+                task.async do
+                  job.call
+                end
+              end
             end
+          rescue ClosedQueueError
+            # Queue closed; exit the reactor loop.
           ensure
             @closed = true
           end
         end
 
+        ObjectSpace.define_finalizer(self, Finalizer.new(@queue, @thread))
         @ready.pop
       end
 
@@ -103,16 +121,12 @@ module Puppeteer
 
         promise = Async::Promise.new
         job = lambda do
-          begin
-            promise.resolve(block.call)
-          rescue => e
-            promise.reject(e)
-          end
+          Async::Promise.fulfill(promise, &block)
         end
 
         begin
           @queue << job
-        rescue Async::Queue::ClosedError
+        rescue ClosedQueueError
           raise Error, "ReactorRunner is closed"
         end
 

data/lib/puppeteer/bidi/transport.rb

@@ -101,7 +101,7 @@ module Puppeteer
           next if message.nil?
 
           Async do
-            data = JSON.parse(message)
+            data = JSON.parse(message.to_str)
             debug_print_receive(data)
             @on_message&.call(data)
           rescue JSON::ParserError => e

data/lib/puppeteer/bidi/version.rb

@@ -2,6 +2,6 @@
 
 module Puppeteer
   module Bidi
-    VERSION = "0.0.3.beta3"
+    VERSION = "0.0.3.beta4"
   end
 end

data/sig/_external.rbs

@@ -34,6 +34,7 @@ module Async
     def reject: (Exception) -> void
     def resolved?: () -> bool
     def value: () -> T?
+    def self.fulfill: [U] (Promise[U]) { () -> U } -> U
   end
 
   class TimeoutError < StandardError

data/sig/puppeteer/bidi/reactor_runner.rbs

@@ -4,6 +4,12 @@ module Puppeteer
   module Bidi
     # Runs a dedicated Async reactor in a background thread and proxies calls into it.
     class ReactorRunner
+      class Finalizer
+        def initialize: (untyped queue, untyped thread) -> untyped
+
+        def call: (untyped _id) -> untyped
+      end
+
       class Proxy < SimpleDelegator
         # @rbs runner: ReactorRunner -- Reactor runner
         # @rbs target: untyped -- Target object to proxy

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppeteer-bidi
 version: !ruby/object:Gem::Version
-  version: 0.0.3.beta3
+  version: 0.0.3.beta4
 platform: ruby
 authors:
 - YusukeIwaki