puppeteer-bidi 0.0.3.beta3 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb435eba199162f3270ff09d0efeaf728935717f0c690a0549f176f1be06e072
-  data.tar.gz: 7a39e4c65471997c4d37f4558459121a9370769dbf341b7f45b6d2441175b60e
+  metadata.gz: 6258f257557d7e7ad54126303faab369f6cf1fc356346f9606de321516f60ef6
+  data.tar.gz: a857af87cb9ed377eb5c266e64eab95dd7183f3c7174d9948ceb1eea08718c71
 SHA512:
-  metadata.gz: 1d9b44c59dda746bae25de8ad9e37c9576867fd5f39b434e39e0ea2cb1ce30d05e943496d787e9cc254d5747af1ce8514818dce67c5778861345617788c2b6af
-  data.tar.gz: 5d80cc021677292638eb0103cf7aca8f9c87309fcb858425360b1ac6f937f2d5d1e5386c5b30e738589fc787ab7f609a271af18d682ac9452b95ae5fec25d765
+  metadata.gz: dd7ed38b4927219f89f37ba2f4c6c76af4696c6892900281d337bcd166e1e616257304ffdf6b575960eaa271ae23b31b6db3ccecad3087cbc69ed5297fbbf617
+  data.tar.gz: df98ee653d7543e3c26fa31420e8983185f1a5f5f8e50bcb4d7595435b1014ca6ea8dbe29a7f7983de2874c882431a77c45c29cce0106088a46e1203116bd360

data/Dockerfile.ci-test

@@ -0,0 +1,39 @@
+# Dockerfile for reproducing CI failures locally
+FROM ruby:4.0-slim-bookworm
+
+ENV DEBIAN_FRONTEND=noninteractive
+
+# Install system dependencies
+RUN apt-get update && apt-get install -y \
+    wget \
+    gnupg \
+    git \
+    xvfb \
+    build-essential \
+    && rm -rf /var/lib/apt/lists/*
+
+# Add Mozilla APT repository for Firefox Nightly
+RUN install -d -m 0755 /etc/apt/keyrings && \
+    wget -q https://packages.mozilla.org/apt/repo-signing-key.gpg -O- | tee /etc/apt/keyrings/packages.mozilla.org.asc > /dev/null && \
+    echo "deb [signed-by=/etc/apt/keyrings/packages.mozilla.org.asc] https://packages.mozilla.org/apt mozilla main" | tee /etc/apt/sources.list.d/mozilla.list > /dev/null && \
+    echo 'Package: *\nPin: origin packages.mozilla.org\nPin-Priority: 1000' | tee /etc/apt/preferences.d/mozilla
+
+# Install Firefox Nightly
+RUN apt-get update && apt-get install -y firefox-nightly && rm -rf /var/lib/apt/lists/*
+
+# Verify installations
+RUN ruby --version && firefox-nightly --version
+
+WORKDIR /app
+
+# Copy Gemfile first for caching
+COPY Gemfile Gemfile.lock* puppeteer-bidi.gemspec ./
+COPY lib/puppeteer/bidi/version.rb ./lib/puppeteer/bidi/
+
+RUN bundle install
+
+# Copy the rest of the application
+COPY . .
+
+ENV HEADLESS=true
+ENV FIREFOX_PATH=/usr/bin/firefox-nightly

data/lib/puppeteer/bidi/reactor_runner.rb

@@ -3,7 +3,6 @@
 
 require "async"
 require "async/promise"
-require "async/queue"
 require "delegate"
 require "thread"
 
@@ -11,6 +10,18 @@ module Puppeteer
   module Bidi
     # Runs a dedicated Async reactor in a background thread and proxies calls into it.
     class ReactorRunner
+      class Finalizer
+        def initialize(queue, thread)
+          @queue = queue
+          @thread = thread
+        end
+
+        def call(_id)
+          @queue.close
+          @thread.join unless ::Thread.current == @thread
+        end
+      end
+
       class Proxy < SimpleDelegator
         # @rbs runner: ReactorRunner -- Reactor runner
         # @rbs target: untyped -- Target object to proxy
@@ -78,20 +89,27 @@ module Puppeteer
 
       # @rbs return: void
       def initialize
-        @queue = Async::Queue.new
+        @queue = Thread::Queue.new
         @ready = Queue.new
         @closed = false
         @thread = Thread.new do
-          Sync do |task|
-            @ready << true
-            @queue.async(parent: task) do |_async_task, job|
-              job.call
+          begin
+            Sync do |task|
+              @ready << true
+              while (job = @queue.pop)
+                task.async do
+                  job.call
+                end
+              end
             end
+          rescue ClosedQueueError
+            # Queue closed; exit the reactor loop.
           ensure
             @closed = true
           end
         end
 
+        ObjectSpace.define_finalizer(self, Finalizer.new(@queue, @thread))
         @ready.pop
       end
 
@@ -103,31 +121,16 @@ module Puppeteer
 
         promise = Async::Promise.new
         job = lambda do
-          begin
-            promise.resolve(block.call)
-          rescue => e
-            promise.reject(e)
-          end
+          Async::Promise.fulfill(promise, &block)
         end
 
         begin
           @queue << job
-        rescue Async::Queue::ClosedError
+        rescue ClosedQueueError
           raise Error, "ReactorRunner is closed"
         end
 
-        # Ruby 4.0: Async::Promise#wait can wake spuriously; retry until resolved.
-        loop do
-          begin
-            return promise.wait
-          rescue TypeError => e
-            raise unless e.message == "exception class/object expected"
-            next unless promise.resolved?
-            value = promise.value
-            raise value if value.is_a?(Exception)
-            return value
-          end
-        end
+        promise.wait
       end
 
       # @rbs return: void

data/lib/puppeteer/bidi/transport.rb

@@ -101,7 +101,7 @@ module Puppeteer
           next if message.nil?
 
           Async do
-            data = JSON.parse(message)
+            data = JSON.parse(message.to_str)
             debug_print_receive(data)
             @on_message&.call(data)
           rescue JSON::ParserError => e

data/lib/puppeteer/bidi/version.rb

@@ -2,6 +2,6 @@
 
 module Puppeteer
   module Bidi
-    VERSION = "0.0.3.beta3"
+    VERSION = "0.0.3"
   end
 end

data/sig/_external.rbs

@@ -34,6 +34,7 @@ module Async
     def reject: (Exception) -> void
     def resolved?: () -> bool
     def value: () -> T?
+    def self.fulfill: [U] (Promise[U]) { () -> U } -> U
   end
 
   class TimeoutError < StandardError

data/sig/puppeteer/bidi/reactor_runner.rbs

@@ -4,6 +4,12 @@ module Puppeteer
   module Bidi
     # Runs a dedicated Async reactor in a background thread and proxies calls into it.
     class ReactorRunner
+      class Finalizer
+        def initialize: (untyped queue, untyped thread) -> untyped
+
+        def call: (untyped _id) -> untyped
+      end
+
       class Proxy < SimpleDelegator
         # @rbs runner: ReactorRunner -- Reactor runner
         # @rbs target: untyped -- Target object to proxy

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppeteer-bidi
 version: !ruby/object:Gem::Version
-  version: 0.0.3.beta3
+  version: 0.0.3
 platform: ruby
 authors:
 - YusukeIwaki
@@ -13,16 +13,16 @@ dependencies:
   name: async
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: 2.35.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: 2.35.1
 - !ruby/object:Gem::Dependency
   name: async-websocket
   requirement: !ruby/object:Gem::Requirement
@@ -79,6 +79,7 @@ files:
 - ".rubocop.yml"
 - API_COVERAGE.md
 - DEVELOPMENT.md
+- Dockerfile.ci-test
 - LICENSE.txt
 - README.md
 - Rakefile