puppeteer-bidi 0.0.1.beta3 → 0.0.1.beta5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a297f926102da482b6ffaecf8f894cb95dffb910f6743ebc75d0414f1aae00f
-  data.tar.gz: 81c8b08b57b53ca739af7e864723686965278d60bd5d0d1197aff31dd37b299f
+  metadata.gz: 552201477c25d25546b8336a6b38d49eb26d57158ab848deed7ad01223484a17
+  data.tar.gz: abf59f3c09e19997883e8c6867268741225cdea474bb6aff8c4547593758f760
 SHA512:
-  metadata.gz: 519a8a8e1dccfc046de5c8bea356a59d3b5e40e79e8040f85fbbe370f1530170ccbd555b32a242841d132130ef4da85eeedc58bac3f554ab34159faa0b807826
-  data.tar.gz: d60e4cb2eb5caf33a055d394861814f4ecd3f8b561796ff5cb69cce17a5efe59ae3e07cc98e9e5c46b90a68944f20090cfccb6726849cf774f0f0f015fbffaf1
+  metadata.gz: e5cd4ab729b1bde62808ac953baa64d8ea46b2a5d5b3bc64c758cc0a2f20602aa9bb0be707124bcefcd888201290f8de516ee24411292441b78f6e98d92e03ff
+  data.tar.gz: f582a4541d667b1456a0543bab37fc066f556da6a9630b41cf77383d1bd9d18401494efda0089f214f4680f733ccc47e232fd90d027c7ee2c836eccb352ac272

data/CLAUDE.md

@@ -108,6 +108,10 @@ end
 - Public methods should have type annotations
 - **Do NOT use `@rbs!` blocks** - RubyMine IDE doesn't recognize them
 - **Use direct union types** instead of type aliases: `BrowserTarget | PageTarget | FrameTarget` not `target`
+- **Do NOT use `**options` in public APIs** - RubyMine shows as `untyped`. Use explicit keyword arguments:
+  - Optional params: `param: nil`
+  - Boolean params with default: `headless: true` or `enabled: false`
+  - Internal/Core layer methods may still use `**options` for flexibility
 
 **Generate RBS files:**
 ```bash

data/lib/puppeteer/bidi/browser.rb

@@ -69,18 +69,18 @@ module Puppeteer
       end
 
       # Launch a new Firefox browser instance
-      # @rbs executable_path: String
-      # @rbs user_data_dir: String
-      # @rbs headless: bool
-      # @rbs args: Array[String]
-      # @rbs timeout: Numeric
+      # @rbs executable_path: String? -- Path to browser executable
+      # @rbs user_data_dir: String? -- Path to user data directory
+      # @rbs headless: bool -- Run browser in headless mode
+      # @rbs args: Array[String]? -- Additional browser arguments
+      # @rbs timeout: Numeric? -- Launch timeout in seconds
       # @rbs return: Browser -- Browser instance
-      def self.launch(**options)
+      def self.launch(executable_path: nil, user_data_dir: nil, headless: true, args: nil, timeout: nil)
         launcher = BrowserLauncher.new(
-          executable_path: options[:executable_path],
-          user_data_dir: options[:user_data_dir],
-          headless: options.fetch(:headless, true),
-          args: options.fetch(:args, [])
+          executable_path: executable_path,
+          user_data_dir: user_data_dir,
+          headless: headless,
+          args: args || []
         )
 
         ws_endpoint = launcher.launch
@@ -90,7 +90,7 @@ module Puppeteer
 
         # Start transport connection in background thread with Sync reactor
         # Sync is the preferred way to run async code at the top level
-        AsyncUtils.async_timeout(options.fetch(:timeout, 30) * 1000, transport.connect).wait
+        AsyncUtils.async_timeout((timeout || 30) * 1000, transport.connect).wait
 
         connection = Connection.new(transport)
 

data/lib/puppeteer/bidi/version.rb

@@ -2,6 +2,6 @@
 
 module Puppeteer
   module Bidi
-    VERSION = "0.0.1.beta3"
+    VERSION = "0.0.1.beta5"
   end
 end

data/lib/puppeteer/bidi.rb

@@ -33,14 +33,38 @@ require "puppeteer/bidi/browser"
 module Puppeteer
   module Bidi
     # Launch a new browser instance
-    # @rbs executable_path: String
-    # @rbs user_data_dir: String
-    # @rbs headless: bool
-    # @rbs args: Array[String]
-    # @rbs timeout: Numeric
-    # @rbs return: Browser -- Browser instance
-    def self.launch(**options)
-      Browser.launch(**options)
+    # @rbs executable_path: String? -- Path to browser executable
+    # @rbs user_data_dir: String? -- Path to user data directory
+    # @rbs headless: bool -- Run browser in headless mode
+    # @rbs args: Array[String]? -- Additional browser arguments
+    # @rbs timeout: Numeric? -- Launch timeout in seconds
+    # @rbs block: (Browser -> void)? -- Optional block to execute with the browser instance
+    # @rbs return: Browser? -- Browser instance (if no block given)
+    def self.launch(executable_path: nil, user_data_dir: nil, headless: true, args: nil, timeout: nil, &block)
+      if block
+        Sync do
+          begin
+            browser = Browser.launch(
+              executable_path: executable_path,
+              user_data_dir: user_data_dir,
+              headless: headless,
+              args: args,
+              timeout: timeout
+            )
+            block.call(browser)
+          ensure
+            browser&.close
+          end
+        end
+      else
+        Browser.launch(
+          executable_path: executable_path,
+          user_data_dir: user_data_dir,
+          headless: headless,
+          args: args,
+          timeout: timeout
+        )
+      end
     end
 
     # Connect to an existing browser instance

data/sig/puppeteer/bidi/browser.rbs

@@ -23,13 +23,13 @@ module Puppeteer
       def initialize: (connection: Connection, launcher: BrowserLauncher?, core_browser: Core::Browser, session: Core::Session) -> void
 
       # Launch a new Firefox browser instance
-      # @rbs executable_path: String
-      # @rbs user_data_dir: String
-      # @rbs headless: bool
-      # @rbs args: Array[String]
-      # @rbs timeout: Numeric
+      # @rbs executable_path: String? -- Path to browser executable
+      # @rbs user_data_dir: String? -- Path to user data directory
+      # @rbs headless: bool -- Run browser in headless mode
+      # @rbs args: Array[String]? -- Additional browser arguments
+      # @rbs timeout: Numeric? -- Launch timeout in seconds
       # @rbs return: Browser -- Browser instance
-      def self.launch: (**untyped options) -> Browser
+      def self.launch: (?executable_path: String?, ?user_data_dir: String?, ?headless: bool, ?args: Array[String]?, ?timeout: Numeric?) -> Browser
 
       # Connect to an existing Firefox browser instance
       # @rbs ws_endpoint: String -- WebSocket endpoint URL

data/sig/puppeteer/bidi.rbs

@@ -3,13 +3,14 @@
 module Puppeteer
   module Bidi
     # Launch a new browser instance
-    # @rbs executable_path: String
-    # @rbs user_data_dir: String
-    # @rbs headless: bool
-    # @rbs args: Array[String]
-    # @rbs timeout: Numeric
-    # @rbs return: Browser -- Browser instance
-    def self.launch: (**untyped options) -> Browser
+    # @rbs executable_path: String? -- Path to browser executable
+    # @rbs user_data_dir: String? -- Path to user data directory
+    # @rbs headless: bool -- Run browser in headless mode
+    # @rbs args: Array[String]? -- Additional browser arguments
+    # @rbs timeout: Numeric? -- Launch timeout in seconds
+    # @rbs block: (Browser -> void)? -- Optional block to execute with the browser instance
+    # @rbs return: Browser? -- Browser instance (if no block given)
+    def self.launch: (?executable_path: String?, ?user_data_dir: String?, ?headless: bool, ?args: Array[String]?, ?timeout: Numeric?) ?{ (?) -> untyped } -> Browser?
 
     # Connect to an existing browser instance
     # @rbs ws_endpoint: String -- WebSocket endpoint URL

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: puppeteer-bidi
 version: !ruby/object:Gem::Version
-  version: 0.0.1.beta3
+  version: 0.0.1.beta5
 platform: ruby
 authors:
 - YusukeIwaki