puppet_litmus 0.7.3 → 0.8.0

data/spec/data/inventory.yaml

@@ -1,16 +1,16 @@
----
-groups:
-- name: ssh_nodes
-  nodes:
-  - name: test.delivery.puppetlabs.net
-    config:
-      transport: ssh
-      ssh:
-        user: root
-        password: Qu@lity!
-        host-key-check: false
-    facts:
-      provisioner: vmpooler
-      platform: centos-5-x86_64
-- name: winrm_nodes
-  nodes: []
+---
+groups:
+- name: ssh_nodes
+  nodes:
+  - name: test.delivery.puppetlabs.net
+    config:
+      transport: ssh
+      ssh:
+        user: root
+        password: Qu@lity!
+        host-key-check: false
+    facts:
+      provisioner: vmpooler
+      platform: centos-5-x86_64
+- name: winrm_nodes
+  nodes: []

data/spec/lib/puppet_litmus/inventory_manipulation_spec.rb

@@ -1,102 +1,138 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe PuppetLitmus::InventoryManipulation do
-  class DummyClass
-  end
-  let(:dummy_class) do
-    dummy_class = DummyClass.new
-    dummy_class.extend(described_class)
-    dummy_class
-  end
-
-  context 'with config_from_node' do
-    let(:no_config_hash) do
-      { 'groups' =>
-  [{ 'name' => 'ssh_nodes',
-     'nodes' =>
-     [{ 'name' => 'test.delivery.puppetlabs.net',
-        'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' } }] },
-   { 'name' => 'winrm_nodes', 'nodes' => [] }] }
-    end
-
-    let(:config_hash) do
-      { 'groups' =>
-  [{ 'name' => 'ssh_nodes',
-     'nodes' =>
-     [{ 'name' => 'test.delivery.puppetlabs.net',
-        'config' => { 'transport' => 'ssh', 'ssh' => { 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false } },
-        'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' } }] },
-   { 'name' => 'winrm_nodes', 'nodes' => [] }] }
-    end
-
-    let(:inventory_full_path) { 'spec/data/inventory.yaml' }
-
-    let(:no_feature_hash) do
-      { 'groups' =>
-  [{ 'name' => 'ssh_nodes',
-     'nodes' =>
-     [{ 'name' => 'test.delivery.puppetlabs.net',
-        'config' => { 'transport' => 'ssh', 'ssh' => { 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false } },
-        'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' } }] },
-   { 'name' => 'winrm_nodes', 'nodes' => [] }] }
-    end
-
-    let(:feature_hash) do
-      { 'groups' =>
-  [{ 'name' => 'ssh_nodes',
-     'nodes' =>
-     [{ 'name' => 'test.delivery.puppetlabs.net',
-        'config' => { 'transport' => 'ssh', 'ssh' => { 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false } },
-        'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' } }],
-     'features' => ['puppet-agent'] },
-   { 'name' => 'winrm_nodes', 'nodes' => [] }] }
-    end
-
-    let(:empty_feature_hash) do
-      { 'groups' =>
-  [{ 'name' => 'ssh_nodes',
-     'nodes' =>
-     [{ 'name' => 'test.delivery.puppetlabs.net',
-        'config' => { 'transport' => 'ssh', 'ssh' => { 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false } },
-        'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' } }],
-     'features' => [] },
-   { 'name' => 'winrm_nodes', 'nodes' => [] }] }
-    end
-
-    it 'no matching node, raises' do
-      expect { dummy_class.config_from_node(config_hash, 'not.here') }.to raise_error('No config was found for not.here')
-    end
-
-    it 'no config section, returns nil' do
-      expect(dummy_class.config_from_node(no_config_hash, 'test.delivery.puppetlabs.net')).to eq(nil)
-    end
-
-    it 'config exists, and returns' do
-      expect(dummy_class.config_from_node(config_hash, 'test.delivery.puppetlabs.net')).to eq('transport' => 'ssh', 'ssh' =>
-{ 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false })
-    end
-
-    it 'no feature exists, and returns hash with feature added' do
-      expect(dummy_class.add_feature_to_group(no_feature_hash, 'puppet-agent', 'ssh_nodes')).to eq('groups' => [{ 'features' => ['puppet-agent'], 'name' => 'ssh_nodes', 'nodes' => [{ 'config' => { 'ssh' => { 'host-key-check' => false, 'password' => 'Qu@lity!', 'user' => 'root' }, 'transport' => 'ssh' }, 'facts' => { 'platform' => 'centos-5-x86_64', 'provisioner' => 'vmpooler' }, 'name' => 'test.delivery.puppetlabs.net' }] }, { 'name' => 'winrm_nodes', 'nodes' => [] }]) # rubocop:disable Metrics/LineLength: Line is too long
-    end
-
-    it 'feature exists, and returns hash with feature removed' do
-      expect(dummy_class.remove_feature_from_group(feature_hash, 'puppet-agent', 'ssh_nodes')).to eq('groups' => [{ 'features' => [], 'name' => 'ssh_nodes', 'nodes' => [{ 'config' => { 'ssh' => { 'host-key-check' => false, 'password' => 'Qu@lity!', 'user' => 'root' }, 'transport' => 'ssh' }, 'facts' => { 'platform' => 'centos-5-x86_64', 'provisioner' => 'vmpooler' }, 'name' => 'test.delivery.puppetlabs.net' }] }, { 'name' => 'winrm_nodes', 'nodes' => [] }]) # rubocop:disable Metrics/LineLength: Line is too long
-    end
-
-    it 'write from inventory_hash to inventory_yaml file feature_hash' do
-      expect { dummy_class.write_to_inventory_file(feature_hash, inventory_full_path) }.not_to raise_error
-    end
-
-    it 'empty feature exists, and returns hash with feature added' do
-      expect(dummy_class.add_feature_to_group(empty_feature_hash, 'puppet-agent', 'ssh_nodes')).to eq('groups' => [{ 'features' => ['puppet-agent'], 'name' => 'ssh_nodes', 'nodes' => [{ 'config' => { 'ssh' => { 'host-key-check' => false, 'password' => 'Qu@lity!', 'user' => 'root' }, 'transport' => 'ssh' }, 'facts' => { 'platform' => 'centos-5-x86_64', 'provisioner' => 'vmpooler' }, 'name' => 'test.delivery.puppetlabs.net' }] }, { 'name' => 'winrm_nodes', 'nodes' => [] }]) # rubocop:disable Metrics/LineLength: Line is too long
-    end
-
-    it 'write from inventory_hash to inventory_yaml file no feature_hash' do
-      expect(File).to exist(inventory_full_path)
-      expect { dummy_class.write_to_inventory_file(no_feature_hash, inventory_full_path) }.not_to raise_error
-    end
-  end
-end
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe PuppetLitmus::InventoryManipulation do
+  let(:dummy_class) do
+    dummy = Class.new
+    dummy.extend(described_class)
+    dummy
+  end
+
+  context 'with config_from_node' do
+    let(:no_config_hash) do
+      { 'groups' =>
+  [{ 'name' => 'ssh_nodes',
+     'nodes' =>
+     [{ 'name' => 'test.delivery.puppetlabs.net',
+        'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' } }] },
+   { 'name' => 'winrm_nodes', 'nodes' => [] }] }
+    end
+
+    let(:config_hash) do
+      { 'groups' =>
+  [{ 'name' => 'ssh_nodes',
+     'nodes' =>
+     [{ 'name' => 'test.delivery.puppetlabs.net',
+        'config' => { 'transport' => 'ssh', 'ssh' => { 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false } },
+        'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' } }] },
+   { 'name' => 'winrm_nodes', 'nodes' => [] }] }
+    end
+
+    let(:inventory_full_path) { 'spec/data/inventory.yaml' }
+
+    let(:no_feature_hash) do
+      { 'groups' =>
+  [{ 'name' => 'ssh_nodes',
+     'nodes' =>
+     [{ 'name' => 'test.delivery.puppetlabs.net',
+        'config' => { 'transport' => 'ssh', 'ssh' => { 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false } },
+        'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' } }] },
+   { 'name' => 'winrm_nodes', 'nodes' => [] }] }
+    end
+
+    let(:feature_hash_group) do
+      { 'groups' =>
+  [{ 'name' => 'ssh_nodes',
+     'nodes' =>
+     [{ 'name' => 'test.delivery.puppetlabs.net',
+        'config' => { 'transport' => 'ssh', 'ssh' => { 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false } },
+        'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' } }],
+     'features' => ['puppet-agent'] },
+   { 'name' => 'winrm_nodes', 'nodes' => [] }] }
+    end
+
+    let(:empty_feature_hash_group) do
+      { 'groups' =>
+  [{ 'name' => 'ssh_nodes',
+     'nodes' =>
+     [{ 'name' => 'test.delivery.puppetlabs.net',
+        'config' => { 'transport' => 'ssh', 'ssh' => { 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false } },
+        'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' } }],
+     'features' => [] },
+   { 'name' => 'winrm_nodes', 'nodes' => [] }] }
+    end
+
+    let(:feature_hash_node) do
+      { 'groups' =>
+  [{ 'name' => 'ssh_nodes',
+     'nodes' =>
+     [{ 'name' => 'test.delivery.puppetlabs.net',
+        'config' => { 'transport' => 'ssh', 'ssh' => { 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false } },
+        'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' },
+        'features' => ['puppet-agent'] }] },
+   { 'name' => 'winrm_nodes', 'nodes' => [] }] }
+    end
+
+    let(:empty_feature_hash_node) do
+      { 'groups' =>
+  [{ 'name' => 'ssh_nodes',
+     'nodes' =>
+     [{ 'name' => 'test.delivery.puppetlabs.net',
+        'config' => { 'transport' => 'ssh', 'ssh' => { 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false } },
+        'facts' => { 'provisioner' => 'vmpooler', 'platform' => 'centos-5-x86_64' },
+        'features' => [] }] },
+   { 'name' => 'winrm_nodes', 'nodes' => [] }] }
+    end
+
+    it 'no matching node, raises' do
+      expect { dummy_class.config_from_node(config_hash, 'not.here') }.to raise_error('No config was found for not.here')
+    end
+
+    it 'no config section, returns nil' do
+      expect(dummy_class.config_from_node(no_config_hash, 'test.delivery.puppetlabs.net')).to eq(nil)
+    end
+
+    it 'config exists, and returns' do
+      expect(dummy_class.config_from_node(config_hash, 'test.delivery.puppetlabs.net')).to eq('transport' => 'ssh', 'ssh' =>
+{ 'user' => 'root', 'password' => 'Qu@lity!', 'host-key-check' => false })
+    end
+
+    it 'no feature exists for the group, and returns hash with feature added' do
+      expect(dummy_class.add_feature_to_group(no_feature_hash, 'puppet-agent', 'ssh_nodes')).to eq('groups' => [{ 'features' => ['puppet-agent'], 'name' => 'ssh_nodes', 'nodes' => [{ 'config' => { 'ssh' => { 'host-key-check' => false, 'password' => 'Qu@lity!', 'user' => 'root' }, 'transport' => 'ssh' }, 'facts' => { 'platform' => 'centos-5-x86_64', 'provisioner' => 'vmpooler' }, 'name' => 'test.delivery.puppetlabs.net' }] }, { 'name' => 'winrm_nodes', 'nodes' => [] }]) # rubocop:disable Metrics/LineLength: Line is too long
+    end
+
+    it 'feature exists for the group, and returns hash with feature removed' do
+      expect(dummy_class.remove_feature_from_group(feature_hash_group, 'puppet-agent', 'ssh_nodes')).to eq('groups' => [{ 'features' => [], 'name' => 'ssh_nodes', 'nodes' => [{ 'config' => { 'ssh' => { 'host-key-check' => false, 'password' => 'Qu@lity!', 'user' => 'root' }, 'transport' => 'ssh' }, 'facts' => { 'platform' => 'centos-5-x86_64', 'provisioner' => 'vmpooler' }, 'name' => 'test.delivery.puppetlabs.net' }] }, { 'name' => 'winrm_nodes', 'nodes' => [] }]) # rubocop:disable Metrics/LineLength: Line is too long
+    end
+
+    it 'write from inventory_hash to inventory_yaml file feature_hash_group' do
+      expect { dummy_class.write_to_inventory_file(feature_hash_group, inventory_full_path) }.not_to raise_error
+    end
+
+    it 'empty feature exists for the group, and returns hash with feature added' do
+      expect(dummy_class.add_feature_to_group(empty_feature_hash_group, 'puppet-agent', 'ssh_nodes')).to eq('groups' => [{ 'features' => ['puppet-agent'], 'name' => 'ssh_nodes', 'nodes' => [{ 'config' => { 'ssh' => { 'host-key-check' => false, 'password' => 'Qu@lity!', 'user' => 'root' }, 'transport' => 'ssh' }, 'facts' => { 'platform' => 'centos-5-x86_64', 'provisioner' => 'vmpooler' }, 'name' => 'test.delivery.puppetlabs.net' }] }, { 'name' => 'winrm_nodes', 'nodes' => [] }]) # rubocop:disable Metrics/LineLength: Line is too long
+    end
+
+    it 'no feature exists for the node, and returns hash with feature added' do
+      expect(dummy_class.add_feature_to_node(no_feature_hash, 'puppet-agent', 'test.delivery.puppetlabs.net')).to eq('groups' => [{ 'name' => 'ssh_nodes', 'nodes' => [{ 'config' => { 'ssh' => { 'host-key-check' => false, 'password' => 'Qu@lity!', 'user' => 'root' }, 'transport' => 'ssh' }, 'facts' => { 'platform' => 'centos-5-x86_64', 'provisioner' => 'vmpooler' }, 'name' => 'test.delivery.puppetlabs.net', 'features' => ['puppet-agent'] }] }, { 'name' => 'winrm_nodes', 'nodes' => [] }]) # rubocop:disable Metrics/LineLength: Line is too long
+    end
+
+    it 'feature exists for the node, and returns hash with feature removed' do
+      expect(dummy_class.remove_feature_from_node(feature_hash_node, 'puppet-agent', 'test.delivery.puppetlabs.net')).to eq('groups' => [{ 'name' => 'ssh_nodes', 'nodes' => [{ 'config' => { 'ssh' => { 'host-key-check' => false, 'password' => 'Qu@lity!', 'user' => 'root' }, 'transport' => 'ssh' }, 'facts' => { 'platform' => 'centos-5-x86_64', 'provisioner' => 'vmpooler' }, 'name' => 'test.delivery.puppetlabs.net', 'features' => [] }] }, { 'name' => 'winrm_nodes', 'nodes' => [] }]) # rubocop:disable Metrics/LineLength: Line is too long
+    end
+
+    it 'write from inventory_hash to inventory_yaml file feature_hash_node' do
+      expect { dummy_class.write_to_inventory_file(feature_hash_node, inventory_full_path) }.not_to raise_error
+    end
+
+    it 'empty feature exists for the node, and returns hash with feature added' do
+      expect(dummy_class.add_feature_to_node(empty_feature_hash_node, 'puppet-agent', 'test.delivery.puppetlabs.net')).to eq('groups' => [{ 'name' => 'ssh_nodes', 'nodes' => [{ 'config' => { 'ssh' => { 'host-key-check' => false, 'password' => 'Qu@lity!', 'user' => 'root' }, 'transport' => 'ssh' }, 'facts' => { 'platform' => 'centos-5-x86_64', 'provisioner' => 'vmpooler' }, 'name' => 'test.delivery.puppetlabs.net', 'features' => ['puppet-agent'] }] }, { 'name' => 'winrm_nodes', 'nodes' => [] }]) # rubocop:disable Metrics/LineLength: Line is too long
+    end
+
+    it 'write from inventory_hash to inventory_yaml file no feature_hash' do
+      expect(File).to exist(inventory_full_path)
+      expect { dummy_class.write_to_inventory_file(no_feature_hash, inventory_full_path) }.not_to raise_error
+    end
+  end
+end

data/spec/lib/puppet_litmus/rake_tasks_spec.rb

@@ -1,55 +1,55 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-require 'rake'
-
-describe 'litmus rake tasks' do
-  before(:all) do # rubocop:disable RSpec/BeforeAfterAll
-    load File.expand_path('../../../lib/puppet_litmus/rake_tasks.rb', __dir__)
-    # the spec_prep task is stubbed, rather than load from another gem.
-    Rake::Task.define_task(:spec_prep)
-  end
-
-  context 'with litmus:metadata task' do
-    it 'happy path' do
-      metadata = { 'name' => 'puppetlabs-postgresql',
-                   'version' => '6.0.0',
-                   'operatingsystem_support' =>
-  [{ 'operatingsystem' => 'RedHat', 'operatingsystemrelease' => ['5'] },
-   { 'operatingsystem' => 'Ubuntu', 'operatingsystemrelease' => ['14.04', '18.04'] }],
-                   'template-ref' => 'heads/master-0-g7827fc2' }
-      expect(File).to receive(:read).with(any_args).once
-      expect(JSON).to receive(:parse).with(any_args).and_return(metadata)
-      expect(STDOUT).to receive(:puts).with('redhat-5-x86_64')
-      expect(STDOUT).to receive(:puts).with('ubuntu-1404-x86_64')
-      expect(STDOUT).to receive(:puts).with('ubuntu-1804-x86_64')
-      Rake::Task['litmus:metadata'].invoke
-    end
-  end
-
-  context 'with litmus:provision_install task' do
-    it 'happy path' do
-      expect(Rake::Task['spec_prep']).to receive(:invoke).and_return('').once
-      expect(Rake::Task['litmus:provision_list']).to receive(:invoke).with('default').once
-      expect(Rake::Task['litmus:install_agent']).to receive(:invoke).with('puppet6').once
-      expect(Rake::Task['litmus:install_module']).to receive(:invoke).once
-      Rake::Task['litmus:provision_install'].invoke('default', 'puppet6')
-    end
-  end
-
-  context 'with litmus:provision task' do
-    it 'provisions' do
-      results = [{ 'node' => 'localhost',
-                   'target' => 'localhost',
-                   'action' => 'task',
-                   'object' => 'provision::docker',
-                   'status' => 'success',
-                   'result' => { 'status' => 'ok', 'node_name' => 'localhost:2222' } }]
-
-      allow(File).to receive(:directory?).with(any_args).and_return(true)
-      allow_any_instance_of(BoltSpec::Run).to receive(:run_task).with(any_args).and_return(results) # rubocop:disable RSpec/AnyInstance
-      expect(STDOUT).to receive(:puts).with('localhost:2222, centos:7')
-      Rake::Task['litmus:provision'].invoke('docker', 'centos:7')
-    end
-  end
-end
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'rake'
+
+describe 'litmus rake tasks' do
+  before(:all) do # rubocop:disable RSpec/BeforeAfterAll
+    load File.expand_path('../../../lib/puppet_litmus/rake_tasks.rb', __dir__)
+    # the spec_prep task is stubbed, rather than load from another gem.
+    Rake::Task.define_task(:spec_prep)
+  end
+
+  context 'with litmus:metadata task' do
+    it 'happy path' do
+      metadata = { 'name' => 'puppetlabs-postgresql',
+                   'version' => '6.0.0',
+                   'operatingsystem_support' =>
+  [{ 'operatingsystem' => 'RedHat', 'operatingsystemrelease' => ['5'] },
+   { 'operatingsystem' => 'Ubuntu', 'operatingsystemrelease' => ['14.04', '18.04'] }],
+                   'template-ref' => 'heads/master-0-g7827fc2' }
+      expect(File).to receive(:read).with(any_args).once
+      expect(JSON).to receive(:parse).with(any_args).and_return(metadata)
+      expect(STDOUT).to receive(:puts).with('redhat-5-x86_64')
+      expect(STDOUT).to receive(:puts).with('ubuntu-1404-x86_64')
+      expect(STDOUT).to receive(:puts).with('ubuntu-1804-x86_64')
+      Rake::Task['litmus:metadata'].invoke
+    end
+  end
+
+  context 'with litmus:provision_install task' do
+    it 'happy path' do
+      expect(Rake::Task['spec_prep']).to receive(:invoke).and_return('').once
+      expect(Rake::Task['litmus:provision_list']).to receive(:invoke).with('default').once
+      expect(Rake::Task['litmus:install_agent']).to receive(:invoke).with('puppet6').once
+      expect(Rake::Task['litmus:install_module']).to receive(:invoke).once
+      Rake::Task['litmus:provision_install'].invoke('default', 'puppet6')
+    end
+  end
+
+  context 'with litmus:provision task' do
+    it 'provisions' do
+      results = [{ 'node' => 'localhost',
+                   'target' => 'localhost',
+                   'action' => 'task',
+                   'object' => 'provision::docker',
+                   'status' => 'success',
+                   'result' => { 'status' => 'ok', 'node_name' => 'localhost:2222' } }]
+
+      allow(File).to receive(:directory?).with(any_args).and_return(true)
+      allow_any_instance_of(BoltSpec::Run).to receive(:run_task).with(any_args).and_return(results) # rubocop:disable RSpec/AnyInstance
+      expect(STDOUT).to receive(:puts).with('localhost:2222, centos:7')
+      Rake::Task['litmus:provision'].invoke('docker', 'centos:7')
+    end
+  end
+end

data/spec/lib/puppet_litmus/serverspec_spec.rb

@@ -1,196 +1,194 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe PuppetLitmus::Serverspec do
-  class DummyClass
-  end
-  let(:dummy_class) do
-    dummy_class = DummyClass.new
-    dummy_class.extend(described_class)
-    dummy_class
-  end
-
-  context 'with idempotent_apply' do
-    let(:manifest) do
-      "include '::doot'"
-    end
-
-    it 'calls all functions' do
-      expect(dummy_class).to receive(:create_manifest_file).with(manifest).and_return('/bla.pp')
-      expect(dummy_class).to receive(:apply_manifest).with(nil, catch_failures: true, manifest_file_location: '/bla.pp')
-      expect(dummy_class).to receive(:apply_manifest).with(nil, catch_changes: true, manifest_file_location: '/bla.pp')
-      dummy_class.idempotent_apply(manifest)
-    end
-  end
-
-  describe '.run_shell' do
-    let(:command_to_run) { "puts 'doot'" }
-    let(:result) { ['result' => { 'exit_code' => 0, 'stdout' => nil, 'stderr' => nil }] }
-    let(:inventory_hash) { Hash.new(0) }
-
-    it 'responds to run_shell' do
-      expect(dummy_class).to respond_to(:run_shell).with(1..2).arguments
-    end
-
-    context 'when running against localhost and no inventory.yaml file' do
-      it 'does run_shell against localhost without error' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'localhost'))
-        expect(dummy_class).to receive(:run_command).with(command_to_run, 'localhost', config: nil, inventory: nil).and_return(result)
-        expect { dummy_class.run_shell(command_to_run) }.not_to raise_error
-      end
-    end
-
-    context 'when running against remote host' do
-      it 'does run_shell against remote host without error' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
-        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
-        expect(dummy_class).to receive(:run_command).with(command_to_run, 'some.host', config: nil, inventory: inventory_hash).and_return(result)
-        expect { dummy_class.run_shell(command_to_run) }.not_to raise_error
-      end
-    end
-  end
-
-  describe '.bolt_upload_file' do
-    let(:local) { '/tmp' }
-    let(:remote) { '/remote_tmp' }
-    # Ignore rubocop because these hashes are representative of output from an external method and editing them leads to test failures.
-    # rubocop:disable SpaceInsideHashLiteralBraces, SpaceInsideBlockBraces, SpaceAroundOperators, LineLength, SpaceAfterComma
-    let(:result_success) {[{'node'=>'some.host','target'=>'some.host','action'=>'upload','object'=>'C:\foo\bar.ps1','status'=>'success','result'=>{'_output'=>'Uploaded \'C:\foo\bar.ps1\' to \'some.host:C:\bar\''}}]}
-    let(:result_failure) {[{'node'=>'some.host','target'=>'some.host','action'=>nil,'object'=>nil,'status'=>'failure','result'=>{'_error'=>{'kind'=>'puppetlabs.tasks/task_file_error','msg'=>'No such file or directory @ rb_sysopen - /nonexistant/file/path','details'=>{},'issue_code'=>'WRITE_ERROR'}}}]}
-    # rubocop:enable SpaceInsideHashLiteralBraces, SpaceInsideBlockBraces, SpaceAroundOperators, LineLength, SpaceAfterComma
-    let(:inventory_hash) { Hash.new(0) }
-
-    it 'responds to run_shell' do
-      expect(dummy_class).to respond_to(:bolt_upload_file).with(2..3).arguments
-    end
-
-    context 'when upload returns success' do
-      it 'does upload_file against remote host without error' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
-        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
-        expect(dummy_class).to receive(:upload_file).with(local, remote, 'some.host', options: {}, config: nil, inventory: inventory_hash).and_return(result_success)
-        expect { dummy_class.bolt_upload_file(local, remote) }.not_to raise_error
-      end
-      it 'does upload_file against localhost without error' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'localhost'))
-        expect(dummy_class).not_to receive(:inventory_hash_from_inventory_file)
-        expect(dummy_class).to receive(:upload_file).with(local, remote, 'localhost', options: {}, config: nil, inventory: nil).and_return(result_success)
-        expect { dummy_class.bolt_upload_file(local, remote) }.not_to raise_error
-      end
-    end
-
-    context 'when upload returns failure' do
-      it 'does upload_file gives runtime error for failure' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
-        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
-        expect(dummy_class).to receive(:upload_file).with(local, remote, 'some.host', options: {}, config: nil, inventory: inventory_hash).and_return(result_failure)
-        expect { dummy_class.bolt_upload_file(local, remote) }.to raise_error(RuntimeError, %r{upload file failed})
-      end
-      it 'returns the exit code and error message when expecting failure' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
-        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
-        expect(dummy_class).to receive(:upload_file).with(local, remote, 'some.host', options: {}, config: nil, inventory: inventory_hash).and_return(result_failure)
-        method_result = dummy_class.bolt_upload_file(local, remote, expect_failures: true)
-        expect(method_result.exit_code).to be(255)
-        expect(method_result.stderr).to be('No such file or directory @ rb_sysopen - /nonexistant/file/path')
-      end
-    end
-  end
-
-  describe '.bolt_run_script' do
-    let(:script) { '/tmp/script.sh' }
-    let(:result) { ['result' => { 'exit_code' => 0, 'stdout' => nil, 'stderr' => nil }] }
-    let(:inventory_hash) { Hash.new(0) }
-
-    it 'responds to bolt_run_script' do
-      expect(dummy_class).to respond_to(:bolt_run_script).with(1..2).arguments
-    end
-
-    context 'when running against localhost and no inventory.yaml file' do
-      it 'does bolt_run_script against localhost without error' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'localhost'))
-        expect(dummy_class).not_to receive(:inventory_hash_from_inventory_file)
-        expect(dummy_class).to receive(:run_script).with(script, 'localhost', [], options: {}, config: nil, inventory: nil).and_return(result)
-        expect { dummy_class.bolt_run_script(script) }.not_to raise_error
-      end
-    end
-
-    context 'when running against remote host' do
-      it 'does bolt_run_script against remote host without error' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
-        expect(dummy_class).to receive(:inventory_hash_from_inventory_file)
-        expect(dummy_class).to receive(:run_script).with(script, 'some.host', [], options: {}, config: nil, inventory: nil).and_return(result)
-        expect { dummy_class.bolt_run_script(script) }.not_to raise_error
-      end
-    end
-
-    context 'when running with arguments' do
-      it 'does bolt_run_script with arguments without error' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'localhost'))
-        expect(dummy_class).not_to receive(:inventory_hash_from_inventory_file)
-        expect(dummy_class).to receive(:run_script).with(script, 'localhost', ['doot'], options: {}, config: nil, inventory: nil).and_return(result)
-        expect { dummy_class.bolt_run_script(script, arguments: ['doot']) }.not_to raise_error
-      end
-    end
-  end
-
-  describe '.run_bolt_task' do
-    let(:task_name) { 'testtask' }
-    let(:params) { { 'action' => 'install', 'name' => 'foo' } }
-    let(:config_data) { { 'modulepath' => File.join(Dir.pwd, 'spec', 'fixtures', 'modules') } }
-    # Ignore rubocop because these hashes are representative of output from an external method and editing them leads to test failures.
-    # rubocop:disable SpaceInsideHashLiteralBraces, SpaceBeforeBlockBraces, SpaceInsideBlockBraces, SpaceAroundOperators, LineLength, SpaceAfterComma
-    let(:result_unstructured_task_success){ [{'node'=>'some.host','target'=>'some.host','action'=>'task','object'=>'testtask::unstructured','status'=>'success','result'=>{'_output'=>'SUCCESS!'}}]}
-    let(:result_structured_task_success){ [{'node'=>'some.host','target'=>'some.host','action'=>'task','object'=>'testtask::structured','status'=>'success','result'=>{'key1'=>'foo','key2'=>'bar'}}]}
-    let(:result_failure) {[{'node'=>'some.host','target'=>'some.host','action'=>'task','object'=>'testtask::unstructured','status'=>'failure','result'=>{'_error'=>{'msg'=>'FAILURE!','kind'=>'puppetlabs.tasks/task-error','details'=>{'exitcode'=>123}}}}]}
-    # rubocop:enable SpaceInsideHashLiteralBraces, SpaceBeforeBlockBraces, SpaceInsideBlockBraces, SpaceAroundOperators, LineLength, SpaceAfterComma
-    let(:inventory_hash) { Hash.new(0) }
-
-    it 'responds to bolt_run_task' do
-      expect(dummy_class).to respond_to(:run_bolt_task).with(2..3).arguments
-    end
-
-    context 'when bolt returns success' do
-      it 'does bolt_task_run gives no runtime error for success' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
-        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
-        expect(dummy_class).to receive(:run_task).with(task_name, 'some.host', params, config: config_data, inventory: inventory_hash).and_return(result_unstructured_task_success)
-        expect { dummy_class.run_bolt_task(task_name, params, opts: {}) }.not_to raise_error
-      end
-      it 'returns stdout for unstructured-data tasks' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
-        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
-        expect(dummy_class).to receive(:run_task).with(task_name, 'some.host', params, config: config_data, inventory: inventory_hash).and_return(result_unstructured_task_success)
-        method_result = dummy_class.run_bolt_task(task_name, params, opts: {})
-        expect(method_result.stdout).to eq('SUCCESS!')
-      end
-      it 'returns structured output for structured-data tasks' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
-        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
-        expect(dummy_class).to receive(:run_task).with(task_name, 'some.host', params, config: config_data, inventory: inventory_hash).and_return(result_structured_task_success)
-        method_result = dummy_class.run_bolt_task(task_name, params, opts: {})
-        expect(method_result.stdout).to eq('{"key1"=>"foo", "key2"=>"bar"}')
-        expect(method_result.result['key1']).to eq('foo')
-        expect(method_result.result['key2']).to eq('bar')
-      end
-    end
-
-    context 'when bolt returns failure' do
-      it 'does bolt_task_run gives runtime error for failure' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
-        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
-        expect(dummy_class).to receive(:run_task).with(task_name, 'some.host', params, config: config_data, inventory: inventory_hash).and_return(result_failure)
-        expect { dummy_class.run_bolt_task(task_name, params, opts: {}) }.to raise_error(RuntimeError, %r{task failed})
-      end
-      it 'returns the exit code and error message when expecting failure' do
-        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
-        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
-        expect(dummy_class).to receive(:run_task).with(task_name, 'some.host', params, config: config_data, inventory: inventory_hash).and_return(result_failure)
-        method_result = dummy_class.run_bolt_task(task_name, params, expect_failures: true)
-        expect(method_result.exit_code).to be(123)
-        expect(method_result.stderr).to be('FAILURE!')
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe PuppetLitmus::Serverspec do
+  let(:dummy_class) do
+    dummy = Class.new
+    dummy.extend(described_class)
+    dummy
+  end
+
+  context 'with idempotent_apply' do
+    let(:manifest) do
+      "include '::doot'"
+    end
+
+    it 'calls all functions' do
+      expect(dummy_class).to receive(:create_manifest_file).with(manifest).and_return('/bla.pp')
+      expect(dummy_class).to receive(:apply_manifest).with(nil, catch_failures: true, manifest_file_location: '/bla.pp')
+      expect(dummy_class).to receive(:apply_manifest).with(nil, catch_changes: true, manifest_file_location: '/bla.pp')
+      dummy_class.idempotent_apply(manifest)
+    end
+  end
+
+  describe '.run_shell' do
+    let(:command_to_run) { "puts 'doot'" }
+    let(:result) { ['result' => { 'exit_code' => 0, 'stdout' => nil, 'stderr' => nil }] }
+    let(:inventory_hash) { Hash.new(0) }
+
+    it 'responds to run_shell' do
+      expect(dummy_class).to respond_to(:run_shell).with(1..2).arguments
+    end
+
+    context 'when running against localhost and no inventory.yaml file' do
+      it 'does run_shell against localhost without error' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'localhost'))
+        expect(dummy_class).to receive(:run_command).with(command_to_run, 'localhost', config: nil, inventory: nil).and_return(result)
+        expect { dummy_class.run_shell(command_to_run) }.not_to raise_error
+      end
+    end
+
+    context 'when running against remote host' do
+      it 'does run_shell against remote host without error' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
+        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
+        expect(dummy_class).to receive(:run_command).with(command_to_run, 'some.host', config: nil, inventory: inventory_hash).and_return(result)
+        expect { dummy_class.run_shell(command_to_run) }.not_to raise_error
+      end
+    end
+  end
+
+  describe '.bolt_upload_file' do
+    let(:local) { '/tmp' }
+    let(:remote) { '/remote_tmp' }
+    # Ignore rubocop because these hashes are representative of output from an external method and editing them leads to test failures.
+    # rubocop:disable SpaceInsideHashLiteralBraces, SpaceInsideBlockBraces, SpaceAroundOperators, LineLength, SpaceAfterComma
+    let(:result_success) {[{'node'=>'some.host','target'=>'some.host','action'=>'upload','object'=>'C:\foo\bar.ps1','status'=>'success','result'=>{'_output'=>'Uploaded \'C:\foo\bar.ps1\' to \'some.host:C:\bar\''}}]}
+    let(:result_failure) {[{'node'=>'some.host','target'=>'some.host','action'=>nil,'object'=>nil,'status'=>'failure','result'=>{'_error'=>{'kind'=>'puppetlabs.tasks/task_file_error','msg'=>'No such file or directory @ rb_sysopen - /nonexistant/file/path','details'=>{},'issue_code'=>'WRITE_ERROR'}}}]}
+    # rubocop:enable SpaceInsideHashLiteralBraces, SpaceInsideBlockBraces, SpaceAroundOperators, LineLength, SpaceAfterComma
+    let(:inventory_hash) { Hash.new(0) }
+
+    it 'responds to run_shell' do
+      expect(dummy_class).to respond_to(:bolt_upload_file).with(2..3).arguments
+    end
+
+    context 'when upload returns success' do
+      it 'does upload_file against remote host without error' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
+        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
+        expect(dummy_class).to receive(:upload_file).with(local, remote, 'some.host', options: {}, config: nil, inventory: inventory_hash).and_return(result_success)
+        expect { dummy_class.bolt_upload_file(local, remote) }.not_to raise_error
+      end
+      it 'does upload_file against localhost without error' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'localhost'))
+        expect(dummy_class).not_to receive(:inventory_hash_from_inventory_file)
+        expect(dummy_class).to receive(:upload_file).with(local, remote, 'localhost', options: {}, config: nil, inventory: nil).and_return(result_success)
+        expect { dummy_class.bolt_upload_file(local, remote) }.not_to raise_error
+      end
+    end
+
+    context 'when upload returns failure' do
+      it 'does upload_file gives runtime error for failure' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
+        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
+        expect(dummy_class).to receive(:upload_file).with(local, remote, 'some.host', options: {}, config: nil, inventory: inventory_hash).and_return(result_failure)
+        expect { dummy_class.bolt_upload_file(local, remote) }.to raise_error(RuntimeError, %r{upload file failed})
+      end
+      it 'returns the exit code and error message when expecting failure' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
+        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
+        expect(dummy_class).to receive(:upload_file).with(local, remote, 'some.host', options: {}, config: nil, inventory: inventory_hash).and_return(result_failure)
+        method_result = dummy_class.bolt_upload_file(local, remote, expect_failures: true)
+        expect(method_result.exit_code).to be(255)
+        expect(method_result.stderr).to be('No such file or directory @ rb_sysopen - /nonexistant/file/path')
+      end
+    end
+  end
+
+  describe '.bolt_run_script' do
+    let(:script) { '/tmp/script.sh' }
+    let(:result) { ['result' => { 'exit_code' => 0, 'stdout' => nil, 'stderr' => nil }] }
+    let(:inventory_hash) { Hash.new(0) }
+
+    it 'responds to bolt_run_script' do
+      expect(dummy_class).to respond_to(:bolt_run_script).with(1..2).arguments
+    end
+
+    context 'when running against localhost and no inventory.yaml file' do
+      it 'does bolt_run_script against localhost without error' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'localhost'))
+        expect(dummy_class).not_to receive(:inventory_hash_from_inventory_file)
+        expect(dummy_class).to receive(:run_script).with(script, 'localhost', [], options: {}, config: nil, inventory: nil).and_return(result)
+        expect { dummy_class.bolt_run_script(script) }.not_to raise_error
+      end
+    end
+
+    context 'when running against remote host' do
+      it 'does bolt_run_script against remote host without error' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
+        expect(dummy_class).to receive(:inventory_hash_from_inventory_file)
+        expect(dummy_class).to receive(:run_script).with(script, 'some.host', [], options: {}, config: nil, inventory: nil).and_return(result)
+        expect { dummy_class.bolt_run_script(script) }.not_to raise_error
+      end
+    end
+
+    context 'when running with arguments' do
+      it 'does bolt_run_script with arguments without error' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'localhost'))
+        expect(dummy_class).not_to receive(:inventory_hash_from_inventory_file)
+        expect(dummy_class).to receive(:run_script).with(script, 'localhost', ['doot'], options: {}, config: nil, inventory: nil).and_return(result)
+        expect { dummy_class.bolt_run_script(script, arguments: ['doot']) }.not_to raise_error
+      end
+    end
+  end
+
+  describe '.run_bolt_task' do
+    let(:task_name) { 'testtask' }
+    let(:params) { { 'action' => 'install', 'name' => 'foo' } }
+    let(:config_data) { { 'modulepath' => File.join(Dir.pwd, 'spec', 'fixtures', 'modules') } }
+    # Ignore rubocop because these hashes are representative of output from an external method and editing them leads to test failures.
+    # rubocop:disable SpaceInsideHashLiteralBraces, SpaceBeforeBlockBraces, SpaceInsideBlockBraces, SpaceAroundOperators, LineLength, SpaceAfterComma
+    let(:result_unstructured_task_success){ [{'node'=>'some.host','target'=>'some.host','action'=>'task','object'=>'testtask::unstructured','status'=>'success','result'=>{'_output'=>'SUCCESS!'}}]}
+    let(:result_structured_task_success){ [{'node'=>'some.host','target'=>'some.host','action'=>'task','object'=>'testtask::structured','status'=>'success','result'=>{'key1'=>'foo','key2'=>'bar'}}]}
+    let(:result_failure) {[{'node'=>'some.host','target'=>'some.host','action'=>'task','object'=>'testtask::unstructured','status'=>'failure','result'=>{'_error'=>{'msg'=>'FAILURE!','kind'=>'puppetlabs.tasks/task-error','details'=>{'exitcode'=>123}}}}]}
+    # rubocop:enable SpaceInsideHashLiteralBraces, SpaceBeforeBlockBraces, SpaceInsideBlockBraces, SpaceAroundOperators, LineLength, SpaceAfterComma
+    let(:inventory_hash) { Hash.new(0) }
+
+    it 'responds to bolt_run_task' do
+      expect(dummy_class).to respond_to(:run_bolt_task).with(2..3).arguments
+    end
+
+    context 'when bolt returns success' do
+      it 'does bolt_task_run gives no runtime error for success' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
+        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
+        expect(dummy_class).to receive(:run_task).with(task_name, 'some.host', params, config: config_data, inventory: inventory_hash).and_return(result_unstructured_task_success)
+        expect { dummy_class.run_bolt_task(task_name, params, opts: {}) }.not_to raise_error
+      end
+      it 'returns stdout for unstructured-data tasks' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
+        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
+        expect(dummy_class).to receive(:run_task).with(task_name, 'some.host', params, config: config_data, inventory: inventory_hash).and_return(result_unstructured_task_success)
+        method_result = dummy_class.run_bolt_task(task_name, params, opts: {})
+        expect(method_result.stdout).to eq('SUCCESS!')
+      end
+      it 'returns structured output for structured-data tasks' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
+        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
+        expect(dummy_class).to receive(:run_task).with(task_name, 'some.host', params, config: config_data, inventory: inventory_hash).and_return(result_structured_task_success)
+        method_result = dummy_class.run_bolt_task(task_name, params, opts: {})
+        expect(method_result.stdout).to eq('{"key1"=>"foo", "key2"=>"bar"}')
+        expect(method_result.result['key1']).to eq('foo')
+        expect(method_result.result['key2']).to eq('bar')
+      end
+    end
+
+    context 'when bolt returns failure' do
+      it 'does bolt_task_run gives runtime error for failure' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
+        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
+        expect(dummy_class).to receive(:run_task).with(task_name, 'some.host', params, config: config_data, inventory: inventory_hash).and_return(result_failure)
+        expect { dummy_class.run_bolt_task(task_name, params, opts: {}) }.to raise_error(RuntimeError, %r{task failed})
+      end
+      it 'returns the exit code and error message when expecting failure' do
+        stub_const('ENV', ENV.to_hash.merge('TARGET_HOST' => 'some.host'))
+        expect(dummy_class).to receive(:inventory_hash_from_inventory_file).and_return(inventory_hash)
+        expect(dummy_class).to receive(:run_task).with(task_name, 'some.host', params, config: config_data, inventory: inventory_hash).and_return(result_failure)
+        method_result = dummy_class.run_bolt_task(task_name, params, expect_failures: true)
+        expect(method_result.exit_code).to be(123)
+        expect(method_result.stderr).to be('FAILURE!')
+      end
+    end
+  end
+end